paybox_direct 0.1.2 → 0.1.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 96b8102e2e2bbdeaa9e7b0f135dd830d72731f2e
-  data.tar.gz: c4af4de994a7a25cb624f6ef00f7b006121f9f2e
+  metadata.gz: d6998f735f27720f3c35bc55f6723eb342664d86
+  data.tar.gz: bd26cf6c73b72f96b1748664d2fa60e13aaa1157
 SHA512:
-  metadata.gz: 2689575f1327dad65fb2e34cda320545c41ed23d1d3cc92bc36d4518191189dddc333038ec7f49ab4ef3b45964cba066478d8c154454b30a9536365040f58778
-  data.tar.gz: 28fe97e750b3a71d2c43c5ee854d66f69d289bcf39ab6e8c1010bcd7f48401f2f8331e1d973953f6b8614f1fa1b32a604d3eaf73c0dd4b166d82077498217060
+  metadata.gz: 4e0ef292152cb66d1da4b74d6c4227dd13c8635a1e287e84ccf9c36ea06d3e4ab72c8943ef17109b4208b828283e8876e224ba9f916c8ce8a3931c75b73303cc
+  data.tar.gz: c9ad2b64d51e8c5aeb08a8674fe97a6dbc1bd9a65369ec91525b95bb13eff29e30fa12d24d4f384ea2b4ef012f597cb7f7701320332688f7bedecded9e11f65e

data/lib/paybox_direct/exceptions.rb

@@ -3,14 +3,20 @@
 # This library is licensed under the new BSD license. Checkout the license text
 # in the LICENSE file or online at <http://opensource.org/licenses/BSD-3-Clause>.
 
-class PayboxDirect
+module PayboxDirect
   class PayboxRequestError < StandardError
-    attr_reader :code, :comment
+    attr_reader :request, :request_id, :code, :comment
 
-    def initialize(code, comment)
-      super("#{code.to_s.rjust(5, "0")}: #{comment}")
-      @code    = code
-      @comment = comment
+    def initialize(request)
+      @request    = request
+      @request_id = request.request_id
+      @code       = request.error_code
+      @comment    = request.error_comment
+      super("#{@code.to_s.rjust(5, "0")}: #{@comment} (req. ##{@request_id})")
+    end
+
+    def may_retry?
+      return [105, 151, 157].include? @code
     end
   end
 

data/lib/paybox_direct/request.rb

@@ -63,6 +63,11 @@ class PayboxDirect::Request
     return @fields["CODEREPONSE"] != "00000"
   end
 
+  def request_id
+    raise "Not executed yet" if @fields.nil?
+    return @fields["NUMAPPEL"].to_i
+  end
+
   def error_code
     raise "Not executed yet" if @fields.nil?
     return @fields["CODEREPONSE"].to_i

data/lib/paybox_direct.rb

@@ -6,7 +6,7 @@
 require 'ostruct'
 require 'net/http'
 
-class PayboxDirect
+module PayboxDirect
   DEV_URL           = 'https://preprod-ppps.paybox.com/PPPS.php'
   PROD_URL          = 'https://ppps.paybox.com/PPPS.php'
   PROD_FALLBACK_URL = 'https://ppps1.paybox.com/PPPS.php'
@@ -59,7 +59,6 @@ class PayboxDirect
   #
   # == Returns: (PayboxDirect::Request)
   # The Paybox request with these response variables:
-  # * request_id:     The Paybox request ID (NUMAPPEL)
   # * transaction_id: The Paybox transaction ID (NUMTRANS)
   # * wallet:         (if new subscription) The created wallet code (PORTEUR)
   #
@@ -108,10 +107,9 @@ class PayboxDirect
     req.execute!
 
     if req.failed?
-      raise AuthorizationError.new(req.error_code, req.error_comment)
+      raise AuthorizationError.new(req)
     end
     req.response = {
-      request_id:     req.fields["NUMAPPEL"].to_i,
       transaction_id: req.fields["NUMTRANS"].to_i,
       authorization:  req.fields["AUTORISATION"] == "XXXXXX" ? nil : req.fields["AUTORISATION"].to_i
     }
@@ -124,7 +122,7 @@ class PayboxDirect
         debit_authorization(
           amount:         opts[:amount],
           currency:       opts[:currency],
-          request_id:     req.response[:request_id],
+          request_id:     req.request_id,
           transaction_id: req.response[:transaction_id]
         )
       end
@@ -177,7 +175,7 @@ class PayboxDirect
     req.execute!
 
     if req.failed?
-      raise DebitError.new(req.error_code, req.error_comment)
+      raise DebitError.new(req)
     end
     return req
   end
@@ -245,7 +243,7 @@ class PayboxDirect
     req.execute!
 
     if req.failed?
-      raise CancelError.new(req.error_code, req.error_comment)
+      raise CancelError.new(req)
     end
     return req
   end
@@ -287,7 +285,7 @@ class PayboxDirect
     req.execute!
 
     if req.failed?
-      raise RefundError.new(req.error_code, req.error_comment)
+      raise RefundError.new(req)
     end
     return req
   end
@@ -350,8 +348,10 @@ class PayboxDirect
     req.execute!
 
     if req.failed?
-      raise CreditError.new(req.error_code, req.error_comment)
+      raise CreditError.new(req)
     end
+
+    req.response[:transaction_id] = req.fields["NUMTRANS"].to_i
     return req
   end
 
@@ -377,7 +377,7 @@ class PayboxDirect
     })
     req.execute!
     if req.failed?
-      raise DeleteSubscriberError.new(req.error_code, req.error_comment)
+      raise DeleteSubscriberError.new(req)
     end
     return req
   end

data/spec/paybox_direct_spec.rb

@@ -42,11 +42,11 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
       end
@@ -77,12 +77,12 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
         expect(req.response[:wallet]).to eq "CMDLpStLLLs"
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
         expect(req.response[:wallet]).to eq "my_wallet_code"
@@ -129,11 +129,11 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
       end
@@ -162,11 +162,11 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
       end
@@ -218,12 +218,12 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
         expect(req.response[:wallet]).to eq "CMDLpStLLLs"
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
         expect(req.response[:wallet]).to eq "my_wallet_code"
@@ -270,11 +270,11 @@ RSpec.describe PayboxDirect do
       })
 
       if DO_CALLS
-        expect(req.response[:request_id]).to be_a Fixnum
+        expect(req.request_id).to be_a Fixnum
         expect(req.response[:transaction_id]).to be_a Fixnum
         expect(req.response[:authorization]).to be_nil
       else
-        expect(req.response[:request_id]).to eq 111111
+        expect(req.request_id).to eq 111111
         expect(req.response[:transaction_id]).to eq 2222222
         expect(req.response[:authorization]).to eq 444444
       end
@@ -292,7 +292,7 @@ RSpec.describe PayboxDirect do
           cc_expire:  CC_EXPIRE,
           cc_cvv:     CC_CVV
         )
-        req_id = req.response[:request_id]
+        req_id = req.request_id
         trans_id = req.response[:transaction_id]
       else
         req_id = 111111
@@ -316,6 +316,66 @@ RSpec.describe PayboxDirect do
     end
   end
 
+  context "exceptions" do
+    it "raises exception on auth-only failure" do
+      stub_response "CODEREPONSE=00008&COMMENTAIRE=&NUMAPPEL=0000111111"
+
+      expect {
+        PayboxDirect.authorize(
+          ref:       "auth_only_failure",
+          amount:    14.29,
+          currency:  :EUR,
+          cc_number: CC_NUMBER,
+          cc_expire: CC_EXPIRE,
+          cc_cvv:    CC_CVV
+        )
+      }.to raise_error(PayboxDirect::AuthorizationError) do |e|
+        expect(e.request_id).to eq 111111
+        expect(e.code).to eq 8
+        expect(e.comment).to be_a String
+        expect(e.request).to be_a PayboxDirect::Request
+      end
+    end
+
+    it "raises exception on debit failure" do
+      stub_response "CODEREPONSE=00008&COMMENTAIRE=&NUMAPPEL=0000111111"
+
+      expect {
+        PayboxDirect.debit(
+          ref:       "debit_failure",
+          amount:    50.3,
+          currency:  :EUR,
+          cc_number: CC_NUMBER,
+          cc_expire: CC_EXPIRE,
+          cc_cvv:    CC_CVV
+        )
+      }.to raise_error(PayboxDirect::AuthorizationError) do |e|
+        expect(e.request_id).to eq 111111
+        expect(e.code).to eq 8
+        expect(e.comment).to be_a String
+        expect(e.request).to be_a PayboxDirect::Request
+      end
+    end
+
+    it "raises exception on debit failure on prior auth-only" do
+      stub_response "CODEREPONSE=00008&COMMENTAIRE=&NUMAPPEL=0000111111"
+
+      expect {
+        PayboxDirect.debit_authorization(
+          amount:         18.20,
+          currency:       :EUR,
+          request_id:     111111,
+          transaction_id: 2222222
+        )
+      }.to raise_error(PayboxDirect::DebitError) do |e|
+        expect(e.request_id).to eq 111111
+        expect(e.code).to eq 8
+        expect(e.comment).to be_a String
+        expect(e.request).to be_a PayboxDirect::Request
+      end
+    end
+  end
+
   it "should cancel an operation" do
     stub_response "CODEREPONSE=00000&COMMENTAIRE=" if !DO_CALLS
 
@@ -328,7 +388,7 @@ RSpec.describe PayboxDirect do
         cc_expire:  CC_EXPIRE,
         cc_cvv:     CC_CVV
       )
-      req_id = req.response[:request_id]
+      req_id = req.request_id
       trans_id = req.response[:transaction_id]
     else
       req_id = 111111
@@ -375,4 +435,83 @@ RSpec.describe PayboxDirect do
       "NUMTRANS"  => "0002222222"
     })
   end
+
+  it "credits a card without subscription" do
+    stub_response "CODEREPONSE=00000&COMMENTAIRE=&NUMAPPEL=0000111111&NUMTRANS=0002222222" if !DO_CALLS
+
+    req = PayboxDirect.credit(
+      ref:       "credit",
+      amount:    38.4,
+      currency:  :EUR,
+      cc_number: CC_NUMBER,
+      cc_expire: CC_EXPIRE,
+      cc_cvv:    CC_CVV
+    )
+
+    expect(req.vars).to include({
+      "TYPE"      => "00004",
+      "REFERENCE" => REF_PREFIX + "credit",
+      "MONTANT"   => "0000003840",
+      "DEVISE"    => "978",
+      "PORTEUR"   => CC_NUMBER.gsub("-", ""),
+      "DATEVAL"   => CC_EXPIRE.strftime("%m%y"),
+      "CVV"       => CC_CVV
+    })
+
+    if DO_CALLS
+      expect(req.request_id).to be_a Fixnum
+      expect(req.response[:transaction_id]).to be_a Fixnum
+    else
+      expect(req.request_id).to eq 111111
+      expect(req.response[:transaction_id]).to eq 2222222
+    end
+  end
+
+  it "credits a subscriber" do
+    stub_response "CODEREPONSE=00000&COMMENTAIRE=&NUMAPPEL=0000111111&NUMTRANS=0002222222" if !DO_CALLS
+
+    if DO_CALLS
+      req = PayboxDirect.debit(
+        ref:        "credit_subscriber_create",
+        amount:     1,
+        currency:   :EUR,
+        cc_number:  CC_NUMBER,
+        cc_expire:  CC_EXPIRE,
+        cc_cvv:     CC_CVV,
+        subscriber: "my_sub_id6"
+      )
+      wallet = req.response[:wallet]
+    else
+      wallet = "my_wallet_code"
+    end
+
+    req = PayboxDirect.credit(
+      ref:        "credit_subscriber",
+      amount:     29,
+      currency:   :EUR,
+      wallet:     wallet,
+      cc_expire:  CC_EXPIRE,
+      cc_cvv:     CC_CVV,
+      subscriber: "my_sub_id6"
+    )
+
+    expect(req.vars).to include({
+      "TYPE"      => "00054",
+      "REFERENCE" => REF_PREFIX + "credit_subscriber",
+      "MONTANT"   => "0000002900",
+      "DEVISE"    => "978",
+      "PORTEUR"   => wallet,
+      "DATEVAL"   => CC_EXPIRE.strftime("%m%y"),
+      "CVV"       => CC_CVV,
+      "REFABONNE" => REF_PREFIX + "my_sub_id6"
+    })
+
+    if DO_CALLS
+      expect(req.request_id).to be_a Fixnum
+      expect(req.response[:transaction_id]).to be_a Fixnum
+    else
+      expect(req.request_id).to eq 111111
+      expect(req.response[:transaction_id]).to eq 2222222
+    end
+  end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paybox_direct
 version: !ruby/object:Gem::Version
-  version: 0.1.2
+  version: 0.1.3
 platform: ruby
 authors:
 - Kévin Lesénéchal
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-09-13 00:00:00.000000000 Z
+date: 2015-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake