pavlov 0.1.5 → 0.1.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 31594240b64696361ea5deeb4a506ba17c5cd1c8
-  data.tar.gz: 1e8ccb1439a90046a11496bb6fa35c68209f5752
+  metadata.gz: 28147e53a9ec3060b50d87d0ffa15929c17f006c
+  data.tar.gz: 4f508eb3d010a7f276f68ff269d71ca86e200549
 SHA512:
-  metadata.gz: 6ddbe50610a56b8b4d0b52c4875cd3b3b2cd1652fe535fa179143316db2ed1254edce5fa3de0ab3b0c3c3f32f19869939e129d3c7206152ba85aadc032d46307
-  data.tar.gz: 83bd809253f41acaa8a3c11931950a4d6585ff99151b4919a7138c1d4c92884c5616cdaead48be9c91982c4e10966eb0eea8ec9e52df12545da93d5986490192
+  metadata.gz: c9c8cb195850d0e8deb4f8e70c08ba86a587104b66a8f78b920678d0bcf903ebfde8f51dea33e26ce22cd87dda1a7a6a41ad4da5db8090b87d1216ed27385b66
+  data.tar.gz: 8bb36fef06d09c8ef8c4a0e91bfb402dee5c95f863aac3aff77200619f69631c1ce371009e120d108556aa693b068a5461f9a1ffc294a09d57088a7e6e94ed77

data/lib/pavlov/command.rb

@@ -5,5 +5,9 @@ module Pavlov
   module Command
     extend Pavlov::Concern
     include Pavlov::Operation
+
+    def authorized?
+      true
+    end
   end
 end

data/lib/pavlov/helpers.rb

@@ -1,14 +1,14 @@
 module Pavlov
   module Helpers
-    def interactor name, hash
+    def interactor name, hash = {}
       Pavlov.interactor name, with_pavlov_options(hash)
     end
 
-    def query name, hash
+    def query name, hash = {}
       Pavlov.query name, with_pavlov_options(hash)
     end
 
-    def command name, hash
+    def command name, hash = {}
       Pavlov.command name, with_pavlov_options(hash)
     end
 

data/lib/pavlov/interactor.rb

@@ -16,9 +16,5 @@ module Pavlov
         @queue ||= :interactor_operations
       end
     end
-
-    def authorized?
-      raise NotImplementedError
-    end
   end
 end

data/lib/pavlov/operation.rb

@@ -4,18 +4,24 @@ require 'virtus'
 require_relative 'access_denied'
 
 module Pavlov
+  class ValidationError < StandardError
+  end
+
   module Operation
     extend Pavlov::Concern
     include Pavlov::Helpers
     include Virtus
 
     def validate
-      return false unless attributes_without_defaults_have_values
-      if respond_to? :valid?
-        raise Pavlov::ValidationError, 'an argument is invalid' unless valid?
-      else
-        true
-      end
+      return false if attributes_without_defaults_missing_values?
+
+      raise Pavlov::ValidationError, 'an argument is invalid' unless valid?
+
+      true
+    end
+
+    def valid?
+      true
     end
 
     def call(*args, &block)
@@ -31,14 +37,13 @@ module Pavlov
     end
 
     def check_authorization
-      raise_unauthorized if respond_to?(:authorized?, true) && !authorized?
+      raise_unauthorized unless authorized?
     end
 
-    def attributes_without_defaults_have_values
-      attributes_without_value = attribute_set.select do |attribute|
+    def attributes_without_defaults_missing_values?
+      attribute_set.find_index do |attribute|
         !attribute.options.has_key?(:default) && send(attribute.name).nil?
       end
-      attributes_without_value.empty?
     end
 
     module ClassMethods

data/lib/pavlov/query.rb

@@ -5,5 +5,9 @@ module Pavlov
   module Query
     extend Pavlov::Concern
     include Pavlov::Operation
+
+    def authorized?
+      true
+    end
   end
 end

data/lib/pavlov/version.rb

@@ -2,5 +2,5 @@ module Pavlov
   # We're doing this because we might write tests that deal
   # with other versions of bundler and we are unsure how to
   # handle this better.
-  VERSION = '0.1.5'
+  VERSION = '0.1.6'
 end

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification
 name: pavlov
 version: !ruby/object:Gem::Version
-  version: 0.1.5
+  version: 0.1.6
 platform: ruby
 authors:
-- marten@veldthuis.com
+- Marten Veldthuis
 - Mark IJbema
 - Tom de Vries
 - Jan Paul Posma
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-08-07 00:00:00.000000000 Z
+date: 2013-08-13 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: virtus
@@ -85,6 +85,20 @@ dependencies:
     - - '>='
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: guard-rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: terminal-notifier-guard
   requirement: !ruby/object:Gem::Requirement
@@ -164,9 +178,6 @@ extra_rdoc_files: []
 files:
 - lib/generators/pavlov/install_generator.rb
 - lib/generators/pavlov/templates/backend/backend.rb
-- lib/generators/pavlov/templates/backend/command.rb
-- lib/generators/pavlov/templates/backend/interactor.rb
-- lib/generators/pavlov/templates/backend/query.rb
 - lib/pavlov.rb
 - lib/pavlov/access_denied.rb
 - lib/pavlov/alpha_compatibility.rb

data/lib/generators/pavlov/templates/backend/command.rb

@@ -1,3 +0,0 @@
-class Command
-  include Pavlov::Operation
-end

data/lib/generators/pavlov/templates/backend/interactor.rb

@@ -1,16 +0,0 @@
-class Interactor
-  include Pavlov::Operation
-
-  # If you want your interactors to be compatible with a backgrounding
-  # daemon, you can use this base class to add support.
-  #
-  # Example for Resque:
-  #
-  # def self.perform(*args)
-  #   new(*args).call
-  # end
-
-  def authorized?
-    raise NotImplementedError
-  end
-end

data/lib/generators/pavlov/templates/backend/query.rb

@@ -1,3 +0,0 @@
-class Query
-  include Pavlov::Operation
-end