patient_http 1.1.0 → 1.1.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf333a4e860c7ec2acbabd0b2d99b050a2574fd3fe97e7d9cb10b5ba08868fed
-  data.tar.gz: ea8fdac974792444d4f82ded653beeb644d39a58a88b2c1d7796029266dd0e39
+  metadata.gz: ba06f7676b7d33f9c53adea879761a89d31593f51c3f33b999400d7305fcbf06
+  data.tar.gz: ede7b685bbfbdd5049695316f73da55bf0abe203b0a9e1e28eb0bc1da6739f79
 SHA512:
-  metadata.gz: 1ca730c46c12d7be338959fbb45b4c0863e7b81fc2c09ec43aa5e27f073cf4e6023df63441ffc7fa4b244e7fe560a26041872fc4013ed8dfaf8dfdd5b9390fb4
-  data.tar.gz: 4073af1b84aac90f73e41efaded611eff0c46d2521221eedcdbb3dd640269d4fcf2865cb881e88134897825adc0899b022cf9ca041d0ec3a4818c93fade351f3
+  metadata.gz: 9271aecb38a8adac4634d6e02f7797472347e1d4d20a154cf52c39daa450789a1ea1511f464d0551172361f4815ab26eeac535d2d72fb483e169be58bd5900df
+  data.tar.gz: 379ff51d8e0a3e90f49577c9922c6f58a2caa6ed6e4d36a651f9f0071ea5d4999cf25df926cdaf1165e27a495db1d1e65d208d8c58cb41e3513f5c8210829332

data/CHANGELOG.md

@@ -4,6 +4,22 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.1.2
+
+### Added
+
+- Added `protocol` configuration option to force the HTTP protocol to `:http1` or `:http2` instead of negotiating with the server. Forcing `:http1` also limits the TLS ALPN advertisement to `http/1.1`, which can work around SSL-intercepting proxies that mishandle HTTP/2 negotiation.
+
+### Fixed
+
+- `Errno::ECONNABORTED` ("Software caused connection abort") is now treated as a connection error: the pooled client for the host is evicted so the aborted connection is not reused, and `RequestError` classifies it as `:connection` instead of `:unknown`. This error is commonly raised when an SSL-intercepting proxy kills a connection.
+
+## 1.1.1
+
+### Fixed
+
+- Connection pools are now closed gracefully inside the reactor during shutdown. Previously the reactor stopped with open pools, causing async-pool to force-cancel each connection pool's background gardener task mid-wait and emit a noisy (but harmless) `ThreadError: Attempt to unlock a mutex which is not locked` warning when the process was killed.
+
 ## 1.1.0
 
 ### Added

data/README.md

@@ -555,6 +555,12 @@ config = PatientHttp::Configuration.new(
   # Retries for failed requests (default: 3)
   retries: 3,
 
+  # Force the HTTP protocol to :http1 or :http2 (default: nil, negotiates with
+  # the server, preferring HTTP/2 for HTTPS). Forcing :http1 also limits the TLS
+  # ALPN advertisement to http/1.1, which can work around SSL-intercepting
+  # proxies that mishandle HTTP/2.
+  protocol: nil,
+
   # Logger instance (default: Logger to STDERR at ERROR level)
   logger: Logger.new($stdout)
 )

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.1.2

data/lib/patient_http/client.rb

@@ -8,7 +8,8 @@ module PatientHttp
         max_size: config.connection_pool_size,
         connection_timeout: config.connection_timeout,
         proxy_url: config.proxy_url,
-        retries: config.retries
+        retries: config.retries,
+        protocol: config.protocol
       )
       @response_reader = ResponseReader.new(@processor)
     end
@@ -64,8 +65,8 @@ module PatientHttp
 
     def connection_error?(exception)
       case exception
-      when Async::TimeoutError, Errno::ECONNRESET, Errno::EPIPE, Errno::ECONNREFUSED,
-           Errno::EHOSTUNREACH, SocketError, IOError
+      when Async::TimeoutError, Errno::ECONNRESET, Errno::ECONNABORTED, Errno::EPIPE,
+           Errno::ECONNREFUSED, Errno::EHOSTUNREACH, SocketError, IOError
         true
       else
         false

data/lib/patient_http/client_pool.rb

@@ -7,17 +7,30 @@ module PatientHttp
   # is capped with an LRU algorithm - when a new client is needed and the
   # pool is at capacity, the least recently used client is closed and removed.
   class ClientPool
-    def initialize(max_size:, connection_timeout: nil, proxy_url: nil, retries: 3)
+    # Supported protocol names mapped to their async-http implementations. Forcing
+    # :http1 also limits the TLS ALPN advertisement to http/1.1, which avoids
+    # HTTP/2 negotiation with servers and middleboxes that mishandle it.
+    PROTOCOLS = {
+      http1: Async::HTTP::Protocol::HTTP11,
+      http2: Async::HTTP::Protocol::HTTP2
+    }.freeze
+
+    def initialize(max_size:, connection_timeout: nil, proxy_url: nil, retries: 3, protocol: nil)
+      if protocol && !PROTOCOLS.include?(protocol)
+        raise ArgumentError.new("protocol must be one of #{PROTOCOLS.keys.inspect}, got: #{protocol.inspect}")
+      end
+
       @clients = {}
       @max_size = max_size
       @connection_timeout = connection_timeout
       @proxy_url = proxy_url
       @retries = retries
+      @protocol = protocol
       @mutex = Mutex.new
       @proxy_client = nil
     end
 
-    attr_reader :max_size, :connection_timeout, :proxy_url, :retries
+    attr_reader :max_size, :connection_timeout, :proxy_url, :retries, :protocol
 
     # Get or create a client for the given endpoint.
     #
@@ -162,17 +175,19 @@ module PatientHttp
 
     def create_proxy_client
       proxy_endpoint = Async::HTTP::Endpoint.parse(@proxy_url)
-      proxy_endpoint = configure_endpoint(proxy_endpoint) if @connection_timeout
+      if @connection_timeout
+        proxy_endpoint = Async::HTTP::Endpoint.new(proxy_endpoint.url, timeout: @connection_timeout)
+      end
       Async::HTTP::Client.new(proxy_endpoint)
     end
 
     def configure_endpoint(endpoint)
-      return endpoint unless @connection_timeout
+      options = {}
+      options[:timeout] = @connection_timeout if @connection_timeout
+      options[:protocol] = PROTOCOLS.fetch(@protocol) if @protocol
+      return endpoint if options.empty?
 
-      Async::HTTP::Endpoint.new(
-        endpoint.url,
-        timeout: @connection_timeout
-      )
+      Async::HTTP::Endpoint.new(endpoint.url, **options)
     end
   end
 end

data/lib/patient_http/configuration.rb

@@ -46,6 +46,10 @@ module PatientHttp
     # @return [Integer] Number of retries for failed requests
     attr_reader :retries
 
+    # @return [Symbol, nil] HTTP protocol to use (:http1 or :http2). When nil, the
+    #   protocol is negotiated with the server (HTTP/2 preferred for HTTPS).
+    attr_reader :protocol
+
     # @return [SecretManager] the secret manager instance
     attr_reader :secret_manager
 
@@ -63,6 +67,7 @@ module PatientHttp
     # @param connection_timeout [Numeric, nil] Connection timeout in seconds
     # @param proxy_url [String, nil] HTTP/HTTPS proxy URL (supports authentication)
     # @param retries [Integer] Number of retries for failed requests
+    # @param protocol [Symbol, nil] HTTP protocol to use (:http1 or :http2); nil to negotiate
     def initialize(
       max_connections: 256,
       request_timeout: 60,
@@ -76,6 +81,7 @@ module PatientHttp
       connection_timeout: nil,
       proxy_url: nil,
       retries: 3,
+      protocol: nil,
       encryption_key: nil
     )
       @mutex = Mutex.new
@@ -102,6 +108,7 @@ module PatientHttp
       self.connection_timeout = connection_timeout
       self.proxy_url = proxy_url
       self.retries = retries
+      self.protocol = protocol
       self.encryption_key = encryption_key
     end
 
@@ -164,6 +171,20 @@ module PatientHttp
       @retries = value
     end
 
+    def protocol=(value)
+      if value.nil?
+        @protocol = nil
+        return
+      end
+
+      value = value.to_sym if value.is_a?(String)
+      unless ClientPool::PROTOCOLS.key?(value)
+        raise ArgumentError.new("protocol must be one of #{ClientPool::PROTOCOLS.keys.inspect}, got: #{value.inspect}")
+      end
+
+      @protocol = value
+    end
+
     # Set the encryption callable for encrypting payloads before serialization.
     #
     # @param callable [#call, nil] An object that responds to #call, taking data and returning encrypted data
@@ -326,6 +347,7 @@ module PatientHttp
         "connection_timeout" => connection_timeout,
         "proxy_url" => proxy_url,
         "retries" => retries,
+        "protocol" => protocol,
         "payload_stores" => payload_stores.keys,
         "default_payload_store" => default_payload_store_name,
         "secrets" => @mutex.synchronize { @secrets.keys }

data/lib/patient_http/processor.rb

@@ -328,6 +328,17 @@ module PatientHttp
         @config.logger&.info("[PatientHttp] Reactor received stop signal")
       rescue => e
         @config.logger&.error("[PatientHttp] Reactor loop error: #{e.inspect}\n#{e.backtrace.join("\n")}")
+      ensure
+        # Close the HTTP connection pools while still inside the reactor so the
+        # pools' background gardener tasks shut down gracefully. Otherwise the
+        # reactor stops with open pools and async-pool force-cancels each
+        # gardener mid-wait, emitting a noisy (but harmless) ThreadError:
+        # "Attempt to unlock a mutex which is not locked".
+        begin
+          @http_client.close
+        rescue => e
+          @config.logger&.error("[PatientHttp] Error closing HTTP client: #{e.inspect}")
+        end
       end
     end
 

data/lib/patient_http/request_error.rb

@@ -80,7 +80,7 @@ module PatientHttp
           :timeout
         in OpenSSL::SSL::SSLError
           :ssl
-        in Errno::ECONNREFUSED | Errno::ECONNRESET | Errno::EHOSTUNREACH | Errno::EPIPE | SocketError | IOError
+        in Errno::ECONNREFUSED | Errno::ECONNRESET | Errno::ECONNABORTED | Errno::EHOSTUNREACH | Errno::EPIPE | SocketError | IOError
           :connection
         else
           if exception.is_a?(PatientHttp::ResponseTooLargeError)

data/lib/patient_http.rb

@@ -307,8 +307,8 @@ module PatientHttp
       if missing_keywords.any?
         raise ArgumentError.new(
           "Handler must accept keyword arguments: " \
-          "#{required_keywords.map(&:to_s).join(", ")}. " \
-          "Missing: #{missing_keywords.map(&:to_s).join(", ")}"
+          "#{required_keywords.join(", ")}. " \
+          "Missing: #{missing_keywords.join(", ")}"
         )
       end
 
@@ -321,7 +321,7 @@ module PatientHttp
 
       raise ArgumentError.new(
         "Handler must not have extra required keyword parameters. " \
-        "Found: #{extra_required_keywords.map(&:to_s).join(", ")}"
+        "Found: #{extra_required_keywords.join(", ")}"
       )
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: patient_http
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.2
 platform: ruby
 authors:
 - Brian Durand
@@ -156,7 +156,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.3
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Generic async HTTP connection pool for Ruby applications using Fiber-based
   concurrency