patient_http 1.1.0 → 1.1.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bf333a4e860c7ec2acbabd0b2d99b050a2574fd3fe97e7d9cb10b5ba08868fed
-  data.tar.gz: ea8fdac974792444d4f82ded653beeb644d39a58a88b2c1d7796029266dd0e39
+  metadata.gz: dbb8a32f746745abcfd6728c31f6460793440abc3b5bf42f4e0702b7cdd2987e
+  data.tar.gz: 482823627d13df33a1a262341c2dd2f8512d466f595edbb2414c573d96d7cd8d
 SHA512:
-  metadata.gz: 1ca730c46c12d7be338959fbb45b4c0863e7b81fc2c09ec43aa5e27f073cf4e6023df63441ffc7fa4b244e7fe560a26041872fc4013ed8dfaf8dfdd5b9390fb4
-  data.tar.gz: 4073af1b84aac90f73e41efaded611eff0c46d2521221eedcdbb3dd640269d4fcf2865cb881e88134897825adc0899b022cf9ca041d0ec3a4818c93fade351f3
+  metadata.gz: 1e31bfe3ec727df7c534a93b74c4bb66ee36e45b5ba587fb11751198f360d82d9d0ca01ac43c186244bf5b125f73cfb7588e1e438508124f0c25000bdb7b3e42
+  data.tar.gz: 573b8de414ef3ca0251b7cbb946c33f7e9a4a24eeefa1f54823f8c86454243998a3517935f8dc9612c4f61bcc4a1d7d778d7df5ab74c33cbaad47614d26cf96a

data/CHANGELOG.md

@@ -4,6 +4,12 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## 1.1.1
+
+### Fixed
+
+- Connection pools are now closed gracefully inside the reactor during shutdown. Previously the reactor stopped with open pools, causing async-pool to force-cancel each connection pool's background gardener task mid-wait and emit a noisy (but harmless) `ThreadError: Attempt to unlock a mutex which is not locked` warning when the process was killed.
+
 ## 1.1.0
 
 ### Added

data/VERSION

@@ -1 +1 @@
-1.1.0
+1.1.1

data/lib/patient_http/processor.rb

@@ -328,6 +328,17 @@ module PatientHttp
         @config.logger&.info("[PatientHttp] Reactor received stop signal")
       rescue => e
         @config.logger&.error("[PatientHttp] Reactor loop error: #{e.inspect}\n#{e.backtrace.join("\n")}")
+      ensure
+        # Close the HTTP connection pools while still inside the reactor so the
+        # pools' background gardener tasks shut down gracefully. Otherwise the
+        # reactor stops with open pools and async-pool force-cancels each
+        # gardener mid-wait, emitting a noisy (but harmless) ThreadError:
+        # "Attempt to unlock a mutex which is not locked".
+        begin
+          @http_client.close
+        rescue => e
+          @config.logger&.error("[PatientHttp] Error closing HTTP client: #{e.inspect}")
+        end
       end
     end
 

data/lib/patient_http.rb

@@ -307,8 +307,8 @@ module PatientHttp
       if missing_keywords.any?
         raise ArgumentError.new(
           "Handler must accept keyword arguments: " \
-          "#{required_keywords.map(&:to_s).join(", ")}. " \
-          "Missing: #{missing_keywords.map(&:to_s).join(", ")}"
+          "#{required_keywords.join(", ")}. " \
+          "Missing: #{missing_keywords.join(", ")}"
         )
       end
 
@@ -321,7 +321,7 @@ module PatientHttp
 
       raise ArgumentError.new(
         "Handler must not have extra required keyword parameters. " \
-        "Found: #{extra_required_keywords.map(&:to_s).join(", ")}"
+        "Found: #{extra_required_keywords.join(", ")}"
       )
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: patient_http
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.1.1
 platform: ruby
 authors:
 - Brian Durand