pathway 1.2.0 → 1.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a13868cae6ff80203b023cdb1444609565f0004f0a2cab229997c01cbaa3aaa5
-  data.tar.gz: c22500510ef22c61cf9e11beba23455287b38539f35c21a3e9c082f498e7ba0b
+  metadata.gz: d647d15611dc847cac56d22ff0b7dd34236ee8d67b62ffd84b7a252925f4c84a
+  data.tar.gz: 94ef8ed2ebd848e222e180b91e2c8969768cde5fcb1a65644c41f9adb4ee45ab
 SHA512:
-  metadata.gz: 00012d3079c7487ca627bebcb24b5164dd08012082f40d7765bb0bb23a2e0210a9583ea18fa71fdd5f2c69be93d171459fe9ad5f159250bc46c67425fe7b4dd3
-  data.tar.gz: 2c9557ffc6243159ff110a2e91d6017646020e05f990a1b3158ee46ccb1b2948993c085b06051a5eb9ea1eaa36ef3fb86b4858725fbb4966a9a2797bf0abf58e
+  metadata.gz: 60fac55bfa9c5105883209c9f44ea151a21e0720efd8e237bd66a06c46addf5c40c5c54ee24a69197aa9fd742c7a68edc4594c97365392f1e55711673ed4a80e
+  data.tar.gz: 03bb1724a76ea42a3bc079c7a349c740f55e82c13c4510308326465429c855cc6f949cb5ede7235fdb1f7c0e5f4a5e842c81ebf794423a011a07a07553763edf

data/.github/workflows/tests.yml

@@ -11,19 +11,42 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        ruby-version: [3.2, 3.3, 3.4]
+        ruby-version: [3.3, 3.4, 4.0]
     steps:
     - uses: actions/checkout@v3
     - name: Set up Ruby
       uses: ruby/setup-ruby@v1
       with:
         ruby-version: ${{ matrix.ruby-version }}
-        bundler: '2.4.22'
+        bundler: '2.5.6'
         bundler-cache: true
     - name: Run tests
       run: bundle exec rake
+  coveralls:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '4.0'
+        bundler: '2.5.6'
+        bundler-cache: true
+    - name: Run tests for coverage
+      run: bundle exec rake
     - name: Coveralls GitHub Action
-      if: matrix.ruby-version == '3.4'
       uses: coverallsapp/github-action@v2
       with:
         github-token: ${{ secrets.GITHUB_TOKEN }}
+  rubocop:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - name: Set up Ruby
+      uses: ruby/setup-ruby@v1
+      with:
+        ruby-version: '4.0'
+        bundler: '2.5.6'
+        bundler-cache: true
+    - name: Run RuboCop
+      run: bundle exec rubocop --force-exclusion

data/.rubocop.yml

@@ -0,0 +1,137 @@
+# The behavior of RuboCop can be controlled via the .rubocop.yml
+# configuration file. It makes it possible to enable/disable
+# certain cops (checks) and to alter their behavior if they accept
+# any parameters. The file can be placed either in your home
+# directory or in some project directory.
+#
+# RuboCop will start looking for the configuration file in the directory
+# where the inspected file is and continue its way up to the root directory.
+#
+# See https://docs.rubocop.org/rubocop/configuration
+
+plugins:
+  - rubocop-performance
+  - rubocop-rake
+
+AllCops:
+  NewCops: enable
+  SuggestExtensions: false
+  Exclude:
+    - 'bin/*'
+    - 'vendor/**/*'
+
+Style/Alias:
+  EnforcedStyle: prefer_alias_method
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/HashSyntax:
+  Exclude:
+    - Rakefile
+
+Metrics/BlockLength:
+  Exclude:
+    - 'spec/**/*.rb'
+    - 'lib/pathway/rspec/matchers/*.rb'
+    - 'pathway.gemspec'
+
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+    - 'spec/**/*.rb'
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented_relative_to_receiver
+
+Naming/MethodParameterName:
+  MinNameLength: 2
+
+Lint/MissingSuper:
+  AllowedParentClasses: [Result]
+
+Style/AccessModifierDeclarations:
+  AllowModifiersOnAliasMethod: true
+
+Gemspec/DevelopmentDependencies:
+  Enabled: true
+  EnforcedStyle: gemspec
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table
+
+Metrics/CyclomaticComplexity:
+  Max: 8
+
+Metrics/AbcSize:
+  Max: 23
+
+Metrics/MethodLength:
+  Max: 15
+
+Metrics/PerceivedComplexity:
+  Max: 10
+
+# Permanently Disabled
+Style/GuardClause:
+  Enabled: false
+
+Style/LambdaCall:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/Lambda:
+  Enabled: false
+
+Style/Documentation:
+  Enabled: false
+
+Layout/EmptyLinesAroundAccessModifier:
+  Enabled: false
+
+Gemspec/OrderedDependencies:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: False
+
+Style/TrailingCommaInHashLiteral:
+  Enabled: False
+
+Style/RedundantSelf:
+  Enabled: False
+
+Style/IfUnlessModifier:
+  Enabled: False
+
+Lint/EmptyClass:
+  Enabled: False
+
+# TODO: Temporally Disabled
+Style/SafeNavigation:
+  Enabled: False
+
+Layout/LeadingCommentSpace:
+  Enabled: False
+
+Style/NumericLiterals:
+  Enabled: False
+
+Style/CaseEquality:
+  Enabled: False
+
+Performance/RedundantBlockCall:
+  Enabled: False
+
+Lint/ConstantDefinitionInBlock:
+  Enabled: false
+
+Layout/LineLength:
+  Enabled: false
+
+Layout/SpaceInsideHashLiteralBraces:
+  Enabled: false
+
+Metrics/ModuleLength:
+  Enabled: false

data/CHANGELOG.md

@@ -1,7 +1,15 @@
+## [1.3.0] - 2026-03-25
+### Changed
+- Removed support for `Ruby` versions older than 3.3
+### Removed
+- Remove support for passing a block to the step method through `DSLMethods#step`
+- Remove support for passing a block to the step method through `DSLMethods#set`
+- Remove support for `DSLMethods#map`
+
 ## [1.2.0] - 2025-11-16
 ### Deprecated
-- Deprecate passing a block to the step method using `DSLMethods#step`
-- Deprecate passing a block to the step method using `DSLMethods#set`
+- Deprecate passing a block to the step method through `DSLMethods#step`
+- Deprecate passing a block to the step method through `DSLMethods#set`
 - Deprecate `DSLMethods#map`
 ### Changed
 - Removed deprecated `:auto_wire_options` option from `:dry_validation` plugin

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source "https://rubygems.org"
 
 # Specify your gem's dependencies in pathway.gemspec

data/Rakefile

@@ -3,10 +3,6 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
 
-RSpec::Core::RakeTask.new(:spec) do |t|
-  unless RUBY_VERSION =~ /^2\.7|^3\./
-    t.exclude_pattern = 'spec/operation_call_pattern_matching_spec.rb,spec/state_pattern_matching_spec.rb'
-  end
-end
+RSpec::Core::RakeTask.new(:spec)
 
 task :default => :spec

data/bin/racc

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'racc' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("racc", "racc")

data/bin/rubocop

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'rubocop' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("rubocop", "rubocop")

data/bin/ruby-parse

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'ruby-parse' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("parser", "ruby-parse")

data/bin/ruby-rewrite

@@ -0,0 +1,27 @@
+#!/usr/bin/env ruby
+# frozen_string_literal: true
+
+#
+# This file was generated by Bundler.
+#
+# The application 'ruby-rewrite' is installed as part of a gem, and
+# this file is here to facilitate running it.
+#
+
+ENV["BUNDLE_GEMFILE"] ||= File.expand_path("../Gemfile", __dir__)
+
+bundle_binstub = File.expand_path("bundle", __dir__)
+
+if File.file?(bundle_binstub)
+  if File.read(bundle_binstub, 300).include?("This file was generated by Bundler")
+    load(bundle_binstub)
+  else
+    abort("Your `bin/bundle` was not generated by Bundler, so this binstub cannot run.
+Replace `bin/bundle` by running `bundle binstubs bundler --force`, then run this command again.")
+  end
+end
+
+require "rubygems"
+require "bundler/setup"
+
+load Gem.bin_path("parser", "ruby-rewrite")

data/lib/pathway/plugins/auto_deconstruct_state.rb

@@ -8,10 +8,10 @@ module Pathway
 
         def _callable(callable)
           if callable.is_a?(Symbol) && @operation.respond_to?(callable, true) &&
-            @operation.method(callable).arity != 0 &&
-            @operation.method(callable).parameters.all? { _1 in [:key|:keyreq|:keyrest|:block,*] }
+             @operation.method(callable).arity != 0 &&
+             @operation.method(callable).parameters.all? { _1 in [:key | :keyreq | :keyrest | :block, *] }
 
-            -> state { @operation.send(callable, **state) }
+            ->(state) { @operation.send(callable, **state) }
           else
             super
           end

data/lib/pathway/plugins/dry_validation.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'dry/validation'
+require "dry/validation"
 
 module Pathway
   module Plugins
@@ -16,7 +16,7 @@ module Pathway
           elsif base
             self.contract_class = base
           else
-            raise ArgumentError, 'Either a contract class or a block must be provided'
+            raise ArgumentError, "Either a contract class or a block must be provided"
           end
         end
 
@@ -24,7 +24,7 @@ module Pathway
           contract { params(...) }
         end
 
-        def contract_class= klass
+        def contract_class=(klass)
           @contract_class   = klass
           @contract_options = (klass.dry_initializer.options - Dry::Validation::Contract.dry_initializer.options).map(&:target)
           @builded_contract = @contract_options.empty? && klass.schema ? klass.new : nil
@@ -50,14 +50,14 @@ module Pathway
       module InstanceMethods
         extend Forwardable
 
-        delegate %i[build_contract contract_options auto_wire] => 'self.class'
+        delegate %i[build_contract contract_options auto_wire] => "self.class"
         alias_method :contract, :build_contract
 
         def validate(state, with: nil)
           if auto_wire && contract_options.any?
             with ||= contract_options.zip(contract_options).to_h
           end
-          opts = Hash(with).map { |to, from| [to, state[from]] }.to_h
+          opts = Hash(with).transform_values { |from| state[from] }
           validate_with(state[:input], **opts)
             .then { |params| state.update(params:) }
         end

data/lib/pathway/plugins/responder.rb

@@ -4,9 +4,9 @@ module Pathway
   module Plugins
     module Responder
       module ClassMethods
-        def call(*args, **kwargs, &bl)
-          result = super(*args, **kwargs)
-          block_given? ? Responder.respond(result, &bl) : result
+        def call(*, **, &)
+          result = super(*, **)
+          block_given? ? Responder.respond(result, &) : result
         end
       end
 
@@ -34,7 +34,7 @@ module Pathway
         def respond
           if @result.success?
             @context.instance_exec(@result.value, &@ok)
-          elsif Error === @result.error && fail_block = @fails[@result.error.type]
+          elsif Error === @result.error && (fail_block = @fails[@result.error.type])
             @context.instance_exec(@result.error, &fail_block)
           else
             @context.instance_exec(@result.error, &@fail_default)

data/lib/pathway/plugins/sequel_models.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'sequel/model'
+require "sequel/model"
 
 module Pathway
   module Plugins
@@ -32,9 +32,10 @@ module Pathway
 
         def _opts_if_unless(bg) = %i[if unless].map { bg.local_variable_get(_1) }
 
-        def _with_db_steps(steps, step_name=nil, if_cond=nil, unless_cond=nil, &db_logic)
-          raise ArgumentError, 'options :if and :unless are mutually exclusive' if if_cond && unless_cond
-          raise ArgumentError, 'must provide either a step or a block but not both' if !!step_name == !!steps
+        def _with_db_steps(steps, step_name = nil, if_cond = nil, unless_cond = nil, &db_logic)
+          raise ArgumentError, "options :if and :unless are mutually exclusive" if if_cond && unless_cond
+          raise ArgumentError, "must provide either a step or a block but not both" if !step_name.nil? == !steps.nil?
+
           steps ||= proc { step step_name }
 
           if if_cond
@@ -69,15 +70,16 @@ module Pathway
 
       module InstanceMethods
         extend Forwardable
-        delegate %i[model_class search_field model_not_found] => 'self.class'
-        delegate :db => :model_class
 
-        def fetch_model(state, from: model_class, search_by: search_field, using: search_by, to: result_key, overwrite: false, error_message: nil)
-          error_message ||= if (from == model_class)
+        delegate %i[model_class search_field model_not_found] => "self.class"
+        delegate db: :model_class
+
+        def fetch_model(state, from: model_class, search_by: search_field, using: search_by, to: result_key, overwrite: false, error_message: nil) # rubocop:disable Metrics/ParameterLists
+          error_message ||= if from == model_class
                               model_not_found
                             elsif from.respond_to?(:name) || from.respond_to?(:model)
                               from_name = (from.respond_to?(:name) ? from : from.model).name
-                              Inflector.humanize(Inflector.underscore(Inflector.demodulize(from_name))) + ' not found'
+                              Inflector.humanize(Inflector.underscore(Inflector.demodulize(from_name))) + " not found"
                             end
 
           if state[to].nil? || overwrite
@@ -94,8 +96,8 @@ module Pathway
         end
       end
 
-      def self.apply(operation, model: nil, **kwargs)
-        operation.model(model, **kwargs) if model
+      def self.apply(operation, model: nil, **)
+        operation.model(model, **) if model
       end
     end
   end

data/lib/pathway/result.rb

@@ -3,14 +3,15 @@
 module Pathway
   class Result
     extend Forwardable
+
     attr_reader :value, :error
 
     class Success < Result
       def initialize(value) = @value = value
       def success? = true
 
-      def then(bl=nil)
-        result(block_given? ? yield(value): bl.call(value))
+      def then(bl = nil)
+        result(block_given? ? yield(value) : bl.call(value))
       end
 
       def tee(...)
@@ -18,20 +19,16 @@ module Pathway
         follow.failure? ? follow : self
       end
 
-      private
-
-      alias_method :value_for_deconstruct, :value
+      private alias_method :value_for_deconstruct, :value
     end
 
     class Failure < Result
       def initialize(error) = @error = error
       def success? = false
-      def then(_=nil) = self
-      def tee(_=nil) = self
-
-      private
+      def then(_ = nil) = self
+      def tee(_ = nil) = self
 
-      alias_method :value_for_deconstruct, :error
+      private alias_method :value_for_deconstruct, :error
     end
 
     module Mixin
@@ -57,6 +54,6 @@ module Pathway
       end
     end
 
-    delegate :result => 'self.class'
+    delegate result: "self.class"
   end
 end

data/lib/pathway/rspec/matchers/accept_optional_fields.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/form_schema_helpers'
+require "pathway/rspec/matchers/form_schema_helpers"
 
 RSpec::Matchers.define :accept_optional_fields do |*fields|
   match do |form|
@@ -13,7 +13,7 @@ RSpec::Matchers.define :accept_optional_fields do |*fields|
   end
 
   match_when_negated do |form|
-    raise NotImplementedError, 'expect().not_to accept_optional_fields.not_allowing_null_values is not supported.' if @allowing_null_values || @not_allowing_null_values
+    raise NotImplementedError, "expect().not_to accept_optional_fields.not_allowing_null_values is not supported." if @allowing_null_values || @not_allowing_null_values
 
     @form, @fields = form, fields
 
@@ -21,23 +21,23 @@ RSpec::Matchers.define :accept_optional_fields do |*fields|
   end
 
   description do
-    null_value_allowed = @allowing_null_values ? ' allowing null values' : ''
-    null_value_disallowed = @not_allowing_null_values ? ' not allowing null values' : ''
+    null_value_allowed = @allowing_null_values ? " allowing null values" : ""
+    null_value_disallowed = @not_allowing_null_values ? " not allowing null values" : ""
     "accept #{field_list} as optional #{pluralize_fields}#{null_value_allowed}#{null_value_disallowed}"
   end
 
   failure_message do
-    null_value_allowed = @allowing_null_values ? ' allowing null values' : ''
-    null_value_disallowed = @not_allowing_null_values ? ' not allowing null values' : ''
+    null_value_allowed = @allowing_null_values ? " allowing null values" : ""
+    null_value_disallowed = @not_allowing_null_values ? " not allowing null values" : ""
 
     "Expected to accept #{field_list} as optional #{pluralize_fields}#{null_value_allowed}#{null_value_disallowed} but " +
       as_sentence([not_optional_list, not_defined_list, accepting_null_list, not_accepting_null_list].compact,
-                  connector: '; ', last_connector: '; and ')
+                  connector: "; ", last_connector: "; and ")
   end
 
   failure_message_when_negated do
     "Did not expect to accept #{field_list} as optional #{pluralize_fields} but " +
-      [optional_list, not_defined_list].compact.join('; and ')
+      [optional_list, not_defined_list].compact.join("; and ")
   end
 
   include Pathway::Rspec::FormSchemaHelpers
@@ -51,13 +51,13 @@ RSpec::Matchers.define :accept_optional_fields do |*fields|
   end
 
   chain :allowing_null_values do
-    fail 'cannot use allowing_null_values and not_allowing_null_values at the same time' if @not_allowing_null_values
+    raise "cannot use allowing_null_values and not_allowing_null_values at the same time" if @not_allowing_null_values
 
     @allowing_null_values = true
   end
 
   chain :not_allowing_null_values do
-    fail 'cannot use allowing_null_values and not_allowing_null_values at the same time' if @allowing_null_values
+    raise "cannot use allowing_null_values and not_allowing_null_values at the same time" if @allowing_null_values
 
     @not_allowing_null_values = true
   end

data/lib/pathway/rspec/matchers/fail_on.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/list_helpers'
+require "pathway/rspec/matchers/list_helpers"
 
 RSpec::Matchers.define :fail_on do |input|
   match do |operation|
@@ -10,9 +10,10 @@ RSpec::Matchers.define :fail_on do |input|
   end
 
   match_when_negated do |operation|
-    raise NotImplementedError, '`expect().not_to fail_on(input).with_type()` is not supported.' if @type
-    raise NotImplementedError, '`expect().not_to fail_on(input).with_message()` is not supported.' if @message
-    raise NotImplementedError, '`expect().not_to fail_on(input).with_details()` is not supported.' if @details
+    raise NotImplementedError, "`expect().not_to fail_on(input).with_type()` is not supported." if @type
+    raise NotImplementedError, "`expect().not_to fail_on(input).with_message()` is not supported." if @message
+    raise NotImplementedError, "`expect().not_to fail_on(input).with_details()` is not supported." if @details
+
     @operation, @input = operation, input
 
     !failure?
@@ -40,20 +41,20 @@ RSpec::Matchers.define :fail_on do |input|
   alias_method :and_details, :details
 
   description do
-    'fail' + (@type ? " with :#@type error" : '')
+    "fail" + (@type ? " with :#{@type} error" : "")
   end
 
   failure_message do
-    if !failure?
-      "Expected operation to fail but it didn't"
+    if failure?
+      "Expected failed operation to " +
+        as_sentence(failure_descriptions, connector: "; ", last_connector: "; and ")
     else
-      'Expected failed operation to ' +
-        as_sentence(failure_descriptions, connector: '; ', last_connector: '; and ')
+      "Expected operation to fail but it didn't"
     end
   end
 
   failure_message_when_negated do
-    'Did not expected operation to fail but it did'
+    "Did not expected operation to fail but it did"
   end
 
   def failure?
@@ -85,7 +86,7 @@ RSpec::Matchers.define :fail_on do |input|
   end
 
   def type_failure_description
-    type_matches? ? nil : "have type :#@type but instead was :#{error.type}"
+    type_matches? ? nil : "have type :#{@type} but instead was :#{error.type}"
   end
 
   def message_failure_description

data/lib/pathway/rspec/matchers/field_list_helpers.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/list_helpers'
+require "pathway/rspec/matchers/list_helpers"
 
 module Pathway
   module Rspec
@@ -12,11 +12,11 @@ module Pathway
       end
 
       def were_was(list)
-        list.size > 1 ? 'were' : 'was'
+        list.size > 1 ? "were" : "was"
       end
 
       def pluralize_fields
-        @fields.size > 1 ? 'fields' : 'field'
+        @fields.size > 1 ? "fields" : "field"
       end
     end
   end

data/lib/pathway/rspec/matchers/form_schema_helpers.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/field_list_helpers'
+require "pathway/rspec/matchers/field_list_helpers"
 
 module Pathway
   module Rspec

data/lib/pathway/rspec/matchers/list_helpers.rb

@@ -3,14 +3,14 @@
 module Pathway
   module Rspec
     module ListHelpers
-      def as_list(items, **kwargs)
-        as_sentence(items.map(&:inspect), **kwargs)
+      def as_list(items, **)
+        as_sentence(items.map(&:inspect), **)
       end
 
-      def as_sentence(items, connector: ', ', last_connector: ' and ')
+      def as_sentence(items, connector: ", ", last_connector: " and ")
         *rest, last = items
 
-        result = String.new
+        result = +""
         result << rest.join(connector) << last_connector if rest.any?
         result << last
       end

data/lib/pathway/rspec/matchers/require_fields.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/form_schema_helpers'
+require "pathway/rspec/matchers/form_schema_helpers"
 
 RSpec::Matchers.define :require_fields do |*fields|
   match do |form|
@@ -13,7 +13,7 @@ RSpec::Matchers.define :require_fields do |*fields|
   end
 
   match_when_negated do |form|
-    raise NotImplementedError, 'expect().not_to require_fields.not_allowing_null_values is not supported.' if @allowing_null_values || @not_allowing_null_values
+    raise NotImplementedError, "expect().not_to require_fields.not_allowing_null_values is not supported." if @allowing_null_values || @not_allowing_null_values
 
     @form, @fields = form, fields
 
@@ -21,23 +21,23 @@ RSpec::Matchers.define :require_fields do |*fields|
   end
 
   description do
-    null_value_allowed = @allowing_null_values ? ' allowing null values' : ''
-    null_value_disallowed = @not_allowing_null_values ? ' not allowing null values' : ''
+    null_value_allowed = @allowing_null_values ? " allowing null values" : ""
+    null_value_disallowed = @not_allowing_null_values ? " not allowing null values" : ""
     "require #{field_list} as #{pluralize_fields}#{null_value_allowed}#{null_value_disallowed}"
   end
 
   failure_message do
-    null_value_allowed = @allowing_null_values ? ' allowing null values' : ''
-    null_value_disallowed = @not_allowing_null_values ? ' not allowing null values' : ''
+    null_value_allowed = @allowing_null_values ? " allowing null values" : ""
+    null_value_disallowed = @not_allowing_null_values ? " not allowing null values" : ""
 
     "Expected to require #{field_list} as #{pluralize_fields}#{null_value_allowed}#{null_value_disallowed} but " +
       as_sentence([not_required_list, not_defined_list, accepting_null_list, not_accepting_null_list].compact,
-                  connector: '; ', last_connector: '; and ')
+                  connector: "; ", last_connector: "; and ")
   end
 
   failure_message_when_negated do
     "Did not expect to require #{field_list} as #{pluralize_fields} but " +
-      [required_list, not_defined_list].compact.join('; and ')
+      [required_list, not_defined_list].compact.join("; and ")
   end
 
   include Pathway::Rspec::FormSchemaHelpers
@@ -51,13 +51,13 @@ RSpec::Matchers.define :require_fields do |*fields|
   end
 
   chain :allowing_null_values do
-    fail 'cannot use allowing_null_values and not_allowing_null_values at the same time' if @not_allowing_null_values
+    raise "cannot use allowing_null_values and not_allowing_null_values at the same time" if @not_allowing_null_values
 
     @allowing_null_values = true
   end
 
   chain :not_allowing_null_values do
-    fail 'cannot use allowing_null_values and not_allowing_null_values at the same time' if @allowing_null_values
+    raise "cannot use allowing_null_values and not_allowing_null_values at the same time" if @allowing_null_values
 
     @not_allowing_null_values = true
   end

data/lib/pathway/rspec/matchers/succeed_on.rb

@@ -8,7 +8,8 @@ RSpec::Matchers.define :succeed_on do |input|
   end
 
   match_when_negated do |operation|
-    raise NotImplementedError, '`expect().not_to succeed_on(input).returning()` is not supported.' if @value
+    raise NotImplementedError, "`expect().not_to succeed_on(input).returning()` is not supported." if @value
+
     @operation, @input = operation, input
 
     !success?
@@ -23,15 +24,15 @@ RSpec::Matchers.define :succeed_on do |input|
   end
 
   failure_message do
-    if !success?
-      "Expected operation to be successful but failed with :#{result.error.type} error"
-    else
+    if success?
       "Expected successful operation to return #{description_of(@value)} but instead got #{description_of(result.value)}"
+    else
+      "Expected operation to be successful but failed with :#{result.error.type} error"
     end
   end
 
   failure_message_when_negated do
-    'Did not to expected operation to be successful but it was'
+    "Did not to expected operation to be successful but it was"
   end
 
   def success?

data/lib/pathway/rspec/matchers.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers/succeed_on'
-require 'pathway/rspec/matchers/fail_on'
-require 'pathway/rspec/matchers/accept_optional_fields'
-require 'pathway/rspec/matchers/require_fields'
+require "pathway/rspec/matchers/succeed_on"
+require "pathway/rspec/matchers/fail_on"
+require "pathway/rspec/matchers/accept_optional_fields"
+require "pathway/rspec/matchers/require_fields"

data/lib/pathway/rspec.rb

@@ -1,3 +1,3 @@
 # frozen_string_literal: true
 
-require 'pathway/rspec/matchers'
+require "pathway/rspec/matchers"

data/lib/pathway/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Pathway
-  VERSION = '1.2.0'
+  VERSION = "1.3.0"
 end

data/lib/pathway.rb

@@ -1,16 +1,16 @@
 # frozen_string_literal: true
 
-require 'forwardable'
-require 'dry/inflector'
-require 'contextualizer'
-require 'pathway/version'
-require 'pathway/result'
+require "forwardable"
+require "dry/inflector"
+require "contextualizer"
+require "pathway/version"
+require "pathway/result"
 
 module Pathway
   Inflector = Dry::Inflector.new
   class Operation
     class << self
-      def plugin(name,...)
+      def plugin(name, ...)
         require "pathway/plugins/#{Inflector.underscore(name)}" if name.is_a?(Symbol)
 
         plugin = name.is_a?(Module) ? name : Plugins.const_get(Inflector.camelize(name))
@@ -19,7 +19,7 @@ module Pathway
         self.include plugin::InstanceMethods if plugin.const_defined? :InstanceMethods
         self::DSL.include plugin::DSLMethods if plugin.const_defined? :DSLMethods
 
-        plugin.apply(self,...) if plugin.respond_to?(:apply)
+        plugin.apply(self, ...) if plugin.respond_to?(:apply)
       end
 
       def inherited(subclass)
@@ -34,6 +34,7 @@ module Pathway
 
   class Error
     attr_reader :type, :message, :details
+
     singleton_class.send :attr_accessor, :default_messages
 
     @default_messages = {}
@@ -56,7 +57,8 @@ module Pathway
 
   class State
     extend Forwardable
-    delegate %i([] []= fetch store include? values_at deconstruct_keys) => :@hash
+
+    delegate %i[[] []= fetch store include? values_at deconstruct_keys] => :@hash
 
     def initialize(operation, values = {})
       @hash = operation.context.merge(values)
@@ -72,16 +74,16 @@ module Pathway
     def to_hash = @hash
 
     def use(&bl)
-      raise ArgumentError, 'a block must be provided' if !block_given?
-      if bl.parameters in [*, [:rest|:keyrest,], *]
-        raise ArgumentError, 'rest arguments are not supported'
+      raise ArgumentError, "a block must be provided" unless block_given?
+      if bl.parameters in [*, [:rest | :keyrest,], *]
+        raise ArgumentError, "rest arguments are not supported"
       end
 
-      keys = bl.parameters.select { _1 in :key|:keyreq, }.map(&:last)
-      names = bl.parameters.select { _1 in :req|:opt, }.map(&:last)
+      keys = bl.parameters.select { _1 in :key | :keyreq, }.map(&:last)
+      names = bl.parameters.select { _1 in :req | :opt, }.map(&:last)
 
       if keys.any? && names.any?
-        raise ArgumentError, 'cannot mix positional and keyword arguments'
+        raise ArgumentError, "cannot mix positional and keyword arguments"
       elsif keys.any?
         bl.call(**to_hash.slice(*keys))
       else
@@ -104,12 +106,12 @@ module Pathway
         def process(&steps)
           define_method(:call) do |input|
             _dsl_for(input:)
-               .run(&steps)
-               .then(&:result)
+              .run(&steps)
+              .then(&:result)
           end
         end
 
-        def call(ctx,...) = new(ctx).call(...)
+        def call(ctx, ...) = new(ctx).call(...)
 
         def inherited(subclass)
           super
@@ -120,12 +122,12 @@ module Pathway
       module InstanceMethods
         extend Forwardable
 
-        delegate :result_key => 'self.class'
+        delegate result_key: "self.class"
         delegate %i[result success failure] => Result
 
         alias_method :wrap, :result
 
-        def call(*) = raise 'must implement at subclass'
+        def call(*) = raise "must implement at subclass"
 
         def error(type, message: nil, details: nil)
           failure(Error.new(type:, message:, details:))
@@ -150,46 +152,27 @@ module Pathway
           @result, @operation = wrap(state), operation
         end
 
-        def run(&steps)
-          instance_eval(&steps)
+        def run(&)
+          instance_eval(&)
           @result
         end
 
         # Execute step and preserve the former state
-        def step(callable,...)
-          #:nocov:
-          if block_given?
-            warn "[DEPRECATION] Passing a block to the step method using `DSLMethods#step` is deprecated"
-          end
-          #:nocov:
+        def step(callable, *, **)
           bl = _callable(callable)
-          @result = @result.tee { |state| bl.call(state,...) }
+          @result = @result.tee { |state| bl.call(state, *, **) }
         end
 
         # Execute step and modify the former state setting the key
-        def set(callable, *args, to: @operation.result_key, **kwargs, &bl)
-          #:nocov:
-          if block_given?
-            warn "[DEPRECATION] Passing a block to the step method using `DSLMethods#set` is deprecated"
-          end
-          #:nocov:
+        def set(callable, *args, to: @operation.result_key, **kwargs)
           bl = _callable(callable)
 
           @result = @result.then do |state|
-            wrap(bl.call(state, *args, **kwargs, &bl))
+            wrap(bl.call(state, *args, **kwargs))
               .then { |value| state.update(to => value) }
           end
         end
 
-        # Execute step and replace the current state completely
-        def map(callable,...)
-          #:nocov:
-          warn "[DEPRECATION] `Pathway::DSLMethods#map` has been deprecated, use `step` instead"
-          #:nocov:
-          bl = _callable(callable)
-          @result = @result.then { |state| bl.call(state,...) }
-        end
-
         def around(execution_strategy, &steps)
           @result.then do |state|
             steps_runner = ->(dsl = self) { dsl.run(&steps) }
@@ -198,13 +181,13 @@ module Pathway
           end
         end
 
-        def if_true(cond, &steps)
+        def if_true(cond, &)
           cond = _callable(cond)
-          around(->(runner, state) { runner.call if cond.call(state) }, &steps)
+          around(->(runner, state) { runner.call if cond.call(state) }, &)
         end
 
-        def if_false(cond, &steps)
-          if_true(_callable(cond) >> :!.to_proc, &steps)
+        def if_false(cond, &)
+          if_true(_callable(cond) >> :!.to_proc, &)
         end
 
         alias_method :sequence, :around

data/pathway.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path("../lib", __FILE__)
+lib = File.expand_path("lib", __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require "pathway/version"
 
@@ -10,24 +10,23 @@ Gem::Specification.new do |spec|
   spec.authors       = ["Pablo Herrero"]
   spec.email         = ["pablodherrero@gmail.com"]
 
-  spec.summary       = %q{Define your business logic in simple steps.}
-  spec.description   = %q{Define your business logic in simple steps.}
+  spec.summary       = "Define your business logic in simple steps."
+  spec.description   = "Define your business logic in simple steps."
   spec.homepage      = "https://github.com/pabloh/pathway"
   spec.license       = "MIT"
 
   spec.metadata      = {
-    "bug_tracker_uri" => "https://github.com/pabloh/pathway/issues",
-    "source_code_uri" => "https://github.com/pabloh/pathway",
+    "rubygems_mfa_required" => "true",
+    "bug_tracker_uri"       => "https://github.com/pabloh/pathway/issues",
+    "source_code_uri"       => "https://github.com/pabloh/pathway",
   }
 
-  spec.files         = `git ls-files -z`.split("\x0").reject do |f|
-    f.match(%r{^(test|spec|features)/})
-  end
+  spec.files         = `git ls-files -z`.split("\x0").grep_v(%r{^(test|spec|features)/})
   spec.bindir        = "exe"
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ["lib"]
 
-  spec.required_ruby_version = ">= 3.2.0"
+  spec.required_ruby_version = ">= 3.3.0"
 
   spec.add_dependency "dry-inflector", ">= 0.1.0"
   spec.add_dependency "contextualizer", "~> 0.1.0"
@@ -37,7 +36,10 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "sequel", "~> 5.0"
   spec.add_development_dependency "rake", "~> 13.0"
   spec.add_development_dependency "rspec", "~> 3.11"
-  spec.add_development_dependency "simplecov-lcov", '~> 0.8.0'
+  spec.add_development_dependency "simplecov-lcov", "~> 0.8.0"
+  spec.add_development_dependency "rubocop", "~> 1.81.0"
+  spec.add_development_dependency "rubocop-performance"
+  spec.add_development_dependency "rubocop-rake"
   spec.add_development_dependency "simplecov"
   spec.add_development_dependency "pry"
   spec.add_development_dependency "reline"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: pathway
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.3.0
 platform: ruby
 authors:
 - Pablo Herrero
@@ -121,6 +121,48 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.8.0
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.81.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.81.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov
   requirement: !ruby/object:Gem::Requirement
@@ -215,6 +257,7 @@ files:
 - ".github/workflows/tests.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -229,16 +272,20 @@ files:
 - bin/irb
 - bin/ldiff
 - bin/pry
+- bin/racc
 - bin/rake
 - bin/rbs
 - bin/rdbg
 - bin/rdoc
 - bin/ri
 - bin/rspec
+- bin/rubocop
 - bin/ruby-lsp
 - bin/ruby-lsp-check
 - bin/ruby-lsp-launcher
 - bin/ruby-lsp-test-exec
+- bin/ruby-parse
+- bin/ruby-rewrite
 - bin/sequel
 - bin/setup
 - bin/yard
@@ -266,6 +313,7 @@ homepage: https://github.com/pabloh/pathway
 licenses:
 - MIT
 metadata:
+  rubygems_mfa_required: 'true'
   bug_tracker_uri: https://github.com/pabloh/pathway/issues
   source_code_uri: https://github.com/pabloh/pathway
 rdoc_options: []
@@ -275,14 +323,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 3.2.0
+      version: 3.3.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.3
 specification_version: 4
 summary: Define your business logic in simple steps.
 test_files: []