pathspec 0.1.2 → 0.2.1

data/lib/pathspec/regexspec.rb

@@ -1,17 +1,21 @@
 require 'pathspec/spec'
 
-class RegexSpec < Spec
-  def initialize(regex)
-    @regex = Regexp.compile regex
+class PathSpec
+  # Simple regex-based spec
+  class RegexSpec < Spec
+    def initialize(pattern)
+      @pattern = pattern.dup
+      @regex = Regexp.compile pattern
 
-    super
-  end
+      super
+    end
 
-  def inclusive?
-    true
-  end
+    def inclusive?
+      true
+    end
 
-  def match(path)
-    @regex.match(path) if @regex
+    def match(path)
+      @regex.match(path) if @regex
+    end
   end
 end

data/lib/pathspec/spec.rb

@@ -1,14 +1,21 @@
-class Spec
-  attr_reader :regex
+class PathSpec
+  # Abstract spec
+  class Spec
+    attr_reader :regex
+    attr_reader :pattern
 
-  def initialize(*_)
-  end
+    def initialize(*_); end
 
-  def match(files)
-    raise "Unimplemented"
-  end
+    def match(files)
+      raise 'Unimplemented'
+    end
+
+    def inclusive?
+      true
+    end
 
-  def inclusive?
-    true
+    def to_s
+      @pattern
+    end
   end
 end

data/spec/files/gitignore_readme

@@ -0,0 +1,2 @@
+!**/important.txt
+abc/**

data/spec/files/gitignore_ruby

@@ -0,0 +1,51 @@
+# Source: https://github.com/github/gitignore/blob/master/Ruby.gitignore
+*.gem
+*.rbc
+/.config
+/coverage/
+/InstalledFiles
+/pkg/
+/spec/reports/
+/spec/examples.txt
+/test/tmp/
+/test/version_tmp/
+/tmp/
+
+# Used by dotenv library to load environment variables.
+# .env
+
+## Specific to RubyMotion:
+.dat*
+.repl_history
+build/
+*.bridgesupport
+build-iPhoneOS/
+build-iPhoneSimulator/
+
+## Specific to RubyMotion (use of CocoaPods):
+#
+# We recommend against adding the Pods directory to your .gitignore. However
+# you should judge for yourself, the pros and cons are mentioned at:
+# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
+#
+# vendor/Pods/
+
+## Documentation cache and generated files:
+/.yardoc/
+/_yardoc/
+/doc/
+/rdoc/
+
+## Environment normalization:
+/.bundle/
+/vendor/bundle
+/lib/bundler/man/
+
+# for a library or gem, you might want to ignore these files since the code is
+# intended to run in multiple environments; otherwise, check them in:
+# Gemfile.lock
+# .ruby-version
+# .ruby-gemset
+
+# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
+.rvmrc

data/spec/files/gitignore_simple

@@ -0,0 +1 @@
+*.md

data/spec/files/regex_simple

@@ -0,0 +1 @@
+.*\.md

data/spec/spec_helper.rb

@@ -1,9 +1,6 @@
 begin
   require 'simplecov'
   SimpleCov.start
-
-  require 'codecov'
-  SimpleCov.formatter = SimpleCov::Formatter::Codecov
-rescue
+rescue StandardError
   puts 'SimpleCov failed to start, most likely this due to running Ruby 1.8.7'
 end

data/spec/unit/pathspec/gitignorespec_spec.rb

@@ -1,20 +1,20 @@
 require 'spec_helper'
 require 'pathspec/gitignorespec'
 
-describe GitIgnoreSpec do
+describe PathSpec::GitIgnoreSpec do
   # Original specification by http://git-scm.com/docs/gitignore
 
   # A blank line matches no files, so it can serve as a separator for
   # readability.
   describe 'does nothing for newlines' do
-    subject { GitIgnoreSpec.new "\n" }
+    subject { PathSpec::GitIgnoreSpec.new "\n" }
     it { is_expected.to_not match('foo.tmp') }
     it { is_expected.to_not match(' ') }
     it { is_expected.to_not be_inclusive }
   end
 
   describe 'does nothing for blank strings' do
-    subject { GitIgnoreSpec.new '' }
+    subject { PathSpec::GitIgnoreSpec.new '' }
     it { is_expected.to_not match 'foo.tmp' }
     it { is_expected.to_not match ' ' }
     it { is_expected.to_not be_inclusive }
@@ -23,21 +23,21 @@ describe GitIgnoreSpec do
   # A line starting with # serves as a comment. Put a backslash ("\") in front
   # of the first hash for patterns that begin with a hash.
   describe 'does nothing for comments' do
-    subject { GitIgnoreSpec.new '# this is a gitignore style comment' }
+    subject { PathSpec::GitIgnoreSpec.new '# this is a gitignore style comment' }
     it { is_expected.to_not match('foo.tmp') }
     it { is_expected.to_not match(' ') }
     it { is_expected.to_not be_inclusive }
   end
 
   describe 'ignores comment char with a slash' do
-    subject { GitIgnoreSpec.new '\#averystrangefile' }
+    subject { PathSpec::GitIgnoreSpec.new '\#averystrangefile' }
     it { is_expected.to match('#averystrangefile') }
     it { is_expected.to_not match('foobar') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'escapes characters with slashes' do
-    subject { GitIgnoreSpec.new 'twinkletwinkle\*' }
+    subject { PathSpec::GitIgnoreSpec.new 'twinkletwinkle\*' }
     it { is_expected.to match('twinkletwinkle*') }
     it { is_expected.to_not match('twinkletwinkletwinkle') }
     it { is_expected.to be_inclusive }
@@ -45,7 +45,7 @@ describe GitIgnoreSpec do
 
   # Trailing spaces are ignored unless they are quoted with backlash ("\").
   describe 'ignores trailing spaces' do
-    subject { GitIgnoreSpec.new 'foo        ' }
+    subject { PathSpec::GitIgnoreSpec.new 'foo        ' }
     it { is_expected.to match('foo') }
     it { is_expected.to_not match('foo        ') }
     it { is_expected.to be_inclusive }
@@ -62,7 +62,7 @@ describe GitIgnoreSpec do
   # backslash ("\") in front of the first "!" for patterns that begin with a
   # literal "!", for example, "\!important!.txt".
   describe 'is exclusive of !' do
-    subject { GitIgnoreSpec.new '!important.txt' }
+    subject { PathSpec::GitIgnoreSpec.new '!important.txt' }
     it { is_expected.to match('important.txt') }
     it { is_expected.to_not be_inclusive }
     it { is_expected.to_not match('!important.txt') }
@@ -74,7 +74,7 @@ describe GitIgnoreSpec do
   # will not match a regular file or a symbolic link foo (this is consistent
   # with the way how pathspec works in general in Git).
   describe 'trailing slashes match directories and their contents but not regular files or symlinks' do
-    subject { GitIgnoreSpec.new 'foo/' }
+    subject { PathSpec::GitIgnoreSpec.new 'foo/' }
     it { is_expected.to match('foo/') }
     it { is_expected.to match('foo/bar') }
     it { is_expected.to match('baz/foo/bar') }
@@ -87,7 +87,7 @@ describe GitIgnoreSpec do
   # of the .gitignore file (relative to the toplevel of the work tree if not
   # from a .gitignore file).
   describe 'handles basic globbing' do
-    subject { GitIgnoreSpec.new '*.tmp' }
+    subject { PathSpec::GitIgnoreSpec.new '*.tmp' }
     it { is_expected.to match('foo.tmp') }
     it { is_expected.to match('foo/bar.tmp') }
     it { is_expected.to match('foo/bar.tmp/baz') }
@@ -96,7 +96,7 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles inner globs' do
-    subject { GitIgnoreSpec.new 'foo-*-bar' }
+    subject { PathSpec::GitIgnoreSpec.new 'foo-*-bar' }
     it { is_expected.to match('foo--bar') }
     it { is_expected.to match('foo-hello-bar') }
     it { is_expected.to match('a/foo-hello-bar') }
@@ -106,7 +106,7 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles postfix globs' do
-    subject { GitIgnoreSpec.new '~temp-*' }
+    subject { PathSpec::GitIgnoreSpec.new '~temp-*' }
     it { is_expected.to match('~temp-') }
     it { is_expected.to match('~temp-foo') }
     it { is_expected.to match('foo/~temp-bar') }
@@ -115,14 +115,14 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles multiple globs' do
-    subject { GitIgnoreSpec.new '*.middle.*' }
+    subject { PathSpec::GitIgnoreSpec.new '*.middle.*' }
     it { is_expected.to match('hello.middle.rb') }
     it { is_expected.to_not match('foo.rb') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles dir globs' do
-    subject { GitIgnoreSpec.new 'dir/*' }
+    subject { PathSpec::GitIgnoreSpec.new 'dir/*' }
     it { is_expected.to match('dir/foo') }
     it { is_expected.to_not match('foo/') }
     it { is_expected.to be_inclusive }
@@ -134,14 +134,14 @@ describe GitIgnoreSpec do
   # "Documentation/git.html" but not "Documentation/ppc/ppc.html" or
   # "tools/perf/Documentation/perf.html".
   describe 'handles dir globs' do
-    subject { GitIgnoreSpec.new 'dir/*' }
+    subject { PathSpec::GitIgnoreSpec.new 'dir/*' }
     it { is_expected.to match('dir/foo') }
     it { is_expected.to_not match('foo/') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles globs inside of dirs' do
-    subject { GitIgnoreSpec.new 'Documentation/*.html' }
+    subject { PathSpec::GitIgnoreSpec.new 'Documentation/*.html' }
     it { is_expected.to match('Documentation/git.html') }
     it { is_expected.to_not match('Documentation/ppc/ppc.html') }
     it { is_expected.to_not match('tools/perf/Documentation/perf.html') } # TODO: Or is it? Git 2 weirdness?
@@ -149,14 +149,14 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles wildcards' do
-    subject { GitIgnoreSpec.new 'jokeris????' }
+    subject { PathSpec::GitIgnoreSpec.new 'jokeris????' }
     it { is_expected.to match('jokeriswild') }
     it { is_expected.to_not match('jokerisfat') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles brackets' do
-    subject { GitIgnoreSpec.new '*[eu][xl]*' }
+    subject { PathSpec::GitIgnoreSpec.new '*[eu][xl]*' }
     it { is_expected.to match('youknowregex') }
     it { is_expected.to match('youknowregularexpressions') }
     it { is_expected.to_not match('youknownothing') }
@@ -164,19 +164,19 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles unmatched brackets' do
-    subject { GitIgnoreSpec.new '*[*[*' }
+    subject { PathSpec::GitIgnoreSpec.new '*[*[*' }
     it { is_expected.to match('bracket[oh[wow') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles brackets with carats' do
-    subject { GitIgnoreSpec.new '*[^]' }
+    subject { PathSpec::GitIgnoreSpec.new '*[^]' }
     it { is_expected.to match('myfavorite^') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles brackets for brackets' do
-    subject { GitIgnoreSpec.new '*[]]' }
+    subject { PathSpec::GitIgnoreSpec.new '*[]]' }
     it { is_expected.to match('yodawg[]]') }
     it { is_expected.to be_inclusive }
   end
@@ -189,7 +189,7 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles negated brackets' do
-    subject { GitIgnoreSpec.new 'ab[!cd]ef' }
+    subject { PathSpec::GitIgnoreSpec.new 'ab[!cd]ef' }
     it { is_expected.to_not match('abcef') }
     it { is_expected.to match('abzef') }
     it { is_expected.to be_inclusive }
@@ -198,14 +198,14 @@ describe GitIgnoreSpec do
   # A leading slash matches the beginning of the pathname. For example, "/*.c"
   # matches "cat-file.c" but not "mozilla-sha1/sha1.c".
   describe 'handles leading / as relative to base directory' do
-    subject { GitIgnoreSpec.new '/*.c' }
+    subject { PathSpec::GitIgnoreSpec.new '/*.c' }
     it { is_expected.to match('cat-file.c') }
     it { is_expected.to_not match('mozilla-sha1/sha1.c') }
     it { is_expected.to be_inclusive }
   end
 
   describe 'handles simple single paths' do
-    subject { GitIgnoreSpec.new 'spam' }
+    subject { PathSpec::GitIgnoreSpec.new 'spam' }
     it { is_expected.to match('spam') }
     it { is_expected.to match('spam/') }
     it { is_expected.to match('foo/spam') }
@@ -222,7 +222,7 @@ describe GitIgnoreSpec do
   # pattern "foo". "**/foo/bar" matches file or directory "bar" anywhere that is
   # directly under directory "foo".
   describe 'handles prefixed ** as searching any location' do
-    subject { GitIgnoreSpec.new '**/foo' }
+    subject { PathSpec::GitIgnoreSpec.new '**/foo' }
     it { is_expected.to match('foo') }
     it { is_expected.to match('bar/foo') }
     it { is_expected.to match('baz/bar/foo') }
@@ -231,7 +231,7 @@ describe GitIgnoreSpec do
   end
 
   describe 'handles prefixed ** with a directory as searching a file under a directory in any location' do
-    subject { GitIgnoreSpec.new '**/foo/bar' }
+    subject { PathSpec::GitIgnoreSpec.new '**/foo/bar' }
     it { is_expected.to_not match('foo') }
     it { is_expected.to match('foo/bar') }
     it { is_expected.to match('baz/foo/bar') }
@@ -245,7 +245,7 @@ describe GitIgnoreSpec do
   # all files inside directory "abc", relative to the location of the .gitignore
   # file, with infinite depth.
   describe 'handles leading /** as all files inside a directory' do
-    subject { GitIgnoreSpec.new 'abc/**' }
+    subject { PathSpec::GitIgnoreSpec.new 'abc/**' }
     it { is_expected.to match('abc/') }
     it { is_expected.to match('abc/def') }
     it { is_expected.to_not match('123/abc/def') }
@@ -257,7 +257,7 @@ describe GitIgnoreSpec do
   # more directories. For example, "a/**/b" matches "a/b", "a/x/b", "a/x/y/b"
   # and so on.
   describe 'handles /** in the middle of a path' do
-    subject { GitIgnoreSpec.new 'a/**/b' }
+    subject { PathSpec::GitIgnoreSpec.new 'a/**/b' }
     it { is_expected.to match('a/b') }
     it { is_expected.to match('a/x/b') }
     it { is_expected.to match('a/x/y/b') }
@@ -267,7 +267,7 @@ describe GitIgnoreSpec do
   end
 
   describe 'matches all paths when given **' do
-    subject { GitIgnoreSpec.new '**' }
+    subject { PathSpec::GitIgnoreSpec.new '**' }
 
     it { is_expected.to match('a/b') }
     it { is_expected.to match('a/x/b') }
@@ -278,7 +278,7 @@ describe GitIgnoreSpec do
 
   # Other consecutive asterisks are considered invalid.
   describe 'considers other consecutive asterisks invalid' do
-    subject { GitIgnoreSpec.new 'a/***/b' }
+    subject { PathSpec::GitIgnoreSpec.new 'a/***/b' }
     it { is_expected.to_not match('a/b') }
     it { is_expected.to_not match('a/x/b') }
     it { is_expected.to_not match('a/x/y/b') }
@@ -288,18 +288,16 @@ describe GitIgnoreSpec do
   end
 
   describe 'does not match single absolute paths' do
-    subject { GitIgnoreSpec.new "/" }
+    subject { PathSpec::GitIgnoreSpec.new '/' }
     it { is_expected.to_not match('foo.tmp') }
     it { is_expected.to_not match(' ') }
     it { is_expected.to_not match('a/b') }
   end
 
   describe 'nested paths are relative to the file' do
-    subject { GitIgnoreSpec.new 'foo/spam' }
+    subject { PathSpec::GitIgnoreSpec.new 'foo/spam' }
     it { is_expected.to match('foo/spam') }
     it { is_expected.to match('foo/spam/bar') }
     it { is_expected.to_not match('bar/foo/spam') }
   end
-
-
 end

data/spec/unit/pathspec/spec_spec.rb

@@ -1,12 +1,12 @@
 require 'spec_helper'
 require 'pathspec/spec'
 
-describe Spec do
-  subject { Spec.new }
+describe PathSpec::Spec do
+  subject { PathSpec::Spec.new }
 
-  it "does not allow matching" do
-    expect { subject.match "anything" }.to raise_error
+  it 'does not allow matching' do
+    expect { subject.match 'anything' }.to raise_error(/Unimplemented/)
   end
 
-  it { is_expected.to be_inclusive  }
+  it { is_expected.to be_inclusive }
 end

data/spec/unit/pathspec_spec.rb

@@ -4,30 +4,47 @@ require 'pathspec'
 require 'fakefs/spec_helpers'
 
 describe PathSpec do
-  shared_examples "standard gitignore negation" do
-    it { is_expected.to_not match('important.txt') }
-    it { is_expected.to_not match('foo/important.txt') }
-    it { is_expected.to match('foo/bar/') }
+  shared_examples 'standard gitignore negation' do
+    it { is_expected.not_to match('important.txt') }
+    it { is_expected.not_to match('abc/important.txt') }
+    it { is_expected.to match('bar/baz/') }
+    it { is_expected.to match('foo/file') }
+    it { is_expected.not_to match('foo/important.txt') }
+    it { is_expected.to match('foo/subdir/file') }
   end
 
-  context "initialization" do
-    context "from multilines" do
-      context "#new" do
-        subject { PathSpec.new <<-IGNORELINES
+  # Specs that should be kept up to date with the README
+  context 'README.md' do
+    subject { PathSpec.from_filename 'spec/files/gitignore_readme' }
+
+    it { is_expected.to match('abc/def.rb') }
+    it { is_expected.not_to match('abc/important.txt') }
+    it do
+       expect(subject.match_paths(['/abc/123', '/abc/important.txt', '/abc/'])).to contain_exactly(
+         '/abc/123',
+         '/abc/')
+    end
+  end
+
+  context 'initialization' do
+    context 'from multilines' do
+      context '#new' do
+        subject {
+          PathSpec.new <<-IGNORELINES
 !important.txt
 foo/**
 /bar/baz
 IGNORELINES
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
     end
 
-    context "from a string with no newlines" do
-      let(:str) { "foo/**" }
+    context 'from a string with no newlines' do
+      let(:str) { 'foo/**' }
 
-      context "#new" do
+      context '#new' do
         subject { PathSpec.new str }
 
         it { is_expected.to match('foo/important.txt') }
@@ -35,67 +52,67 @@ IGNORELINES
       end
     end
 
-    context "from a non-string/non-enumerable" do
-      it "throws an exception" do
-        expect { PathSpec.new Object.new }.to raise_error
+    context 'from a non-string/non-enumerable' do
+      it 'throws an exception' do
+        expect { PathSpec.new Object.new }.to raise_error(/Cannot make Pathspec/)
       end
     end
 
-    context "from array of gitignore strings" do
-      let(:arr) { ["!important.txt", "foo/**", "/bar/baz"] }
+    context 'from array of gitignore strings' do
+      let(:arr) { ['!important.txt', 'foo/**', '/bar/baz'] }
 
-      context "#new" do
+      context '#new' do
         subject { PathSpec.new arr }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
 
-      context "#from_lines" do
+      context '#from_lines' do
         subject {
           PathSpec.from_lines(arr)
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
 
-      context "#add array" do
+      context '#add array' do
         subject {
           ps = PathSpec.new []
           ps.add arr
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
     end
 
-    context "from linedelimited gitignore string" do
+    context 'from linedelimited gitignore string' do
       let(:line) { "!important.txt\nfoo/**\n/bar/baz\n" }
 
-      context "#new" do
+      context '#new' do
         subject { PathSpec.new line }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
 
-      context "#from_lines" do
+      context '#from_lines' do
         subject {
           PathSpec.from_lines(line)
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
 
-      context "#add" do
+      context '#add' do
         subject {
           ps = PathSpec.new
           ps.add line
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
     end
 
-    context "from a gitignore file" do
+    context 'from a gitignore file' do
       include FakeFS::SpecHelpers
 
       let(:filename) { '.gitignore' }
@@ -107,24 +124,24 @@ IGNORELINES
         }
       end
 
-      context "#new" do
+      context '#new' do
         subject {
           PathSpec.new File.open(filename, 'r')
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
 
-      context "#from_filename" do
+      context '#from_filename' do
         subject {
           PathSpec.from_filename(filename)
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
       end
     end
 
-    context "from multiple gitignore files" do
+    context 'from multiple gitignore files' do
       include FakeFS::SpecHelpers
 
       let(:filenames) { ['.gitignore', '.otherignore'] }
@@ -141,26 +158,26 @@ IGNORELINES
         }
       end
 
-      context "#new" do
+      context '#new' do
         subject {
           arr = filenames.collect { |f| File.open(f, 'r') }
           PathSpec.new arr
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
 
         it { is_expected.to_not match('banana') }
         it { is_expected.to match('banananananana') }
       end
 
-      context "#add" do
+      context '#add' do
         subject {
           arr = filenames.collect { |f| File.open(f, 'r') }
           ps = PathSpec.new
           ps.add arr
         }
 
-        it_behaves_like "standard gitignore negation"
+        it_behaves_like 'standard gitignore negation'
 
         it { is_expected.to_not match('banana') }
         it { is_expected.to match('banananananana') }
@@ -168,12 +185,13 @@ IGNORELINES
     end
   end
 
-  context "#match_tree" do
+  context '#match_tree' do
     include FakeFS::SpecHelpers
 
-    context "unix" do
+    context 'unix' do
       let(:root) {'/tmp/project'}
-      let(:gitignore) { <<-GITIGNORE
+      let(:gitignore) {
+        <<-GITIGNORE
   !**/important.txt
   abc/**
   GITIGNORE
@@ -194,12 +212,13 @@ IGNORELINES
       it { is_expected.to include "#{root}/abc".to_s }
       it { is_expected.to include "#{root}/abc/1".to_s }
       it { is_expected.not_to include "#{root}/abc/important.txt".to_s }
-      it { is_expected.not_to include "#{root}".to_s }
+      it { is_expected.not_to include root.to_s.to_s }
     end
 
-    context "windows" do
+    context 'windows' do
       let(:root) {'C:/project'}
-      let(:gitignore) { <<-GITIGNORE
+      let(:gitignore) {
+        <<-GITIGNORE
   !**/important.txt
   abc/**
   GITIGNORE
@@ -220,53 +239,59 @@ IGNORELINES
       it { is_expected.to include "#{root}/abc".to_s }
       it { is_expected.to include "#{root}/abc/1".to_s }
       it { is_expected.not_to include "#{root}/abc/important.txt".to_s }
-      it { is_expected.not_to include "#{root}".to_s }
+      it { is_expected.not_to include root.to_s.to_s }
     end
   end
 
-  context "#match_paths" do
-    let(:gitignore) { <<-GITIGNORE
+  context '#match_paths' do
+    let(:gitignore) {
+      <<-GITIGNORE
 !**/important.txt
 /abc/**
 GITIGNORE
     }
 
-    context "with no root arg" do
+    context 'with no root arg' do
       subject { PathSpec.new(gitignore).match_paths(['/abc/important.txt', '/abc/', '/abc/1']) }
 
-      it { is_expected.to include "/abc/" }
-      it { is_expected.to include "/abc/1" }
-      it { is_expected.not_to include "/abc/important.txt" }
+      it { is_expected.to include '/abc/' }
+      it { is_expected.to include '/abc/1' }
+      it { is_expected.not_to include '/abc/important.txt' }
     end
 
     context 'relative to non-root dir' do
-      subject { PathSpec.new(gitignore).match_paths([
-        '/def/abc/important.txt',
-        '/def/abc/',
-        '/def/abc/1'], '/def') }
-
-      it { is_expected.to include "/def/abc/" }
-      it { is_expected.to include "/def/abc/1" }
-      it { is_expected.not_to include "/def/abc/important.txt" }
+      subject {
+        PathSpec.new(gitignore).match_paths([
+                                              '/def/abc/important.txt',
+                                              '/def/abc/',
+                                              '/def/abc/1'
+                                            ], '/def') }
+
+      it { is_expected.to include '/def/abc/' }
+      it { is_expected.to include '/def/abc/1' }
+      it { is_expected.not_to include '/def/abc/important.txt' }
     end
 
     context 'relative to windows drive letter' do
-      subject { PathSpec.new(gitignore).match_paths([
-        'C:/def/abc/important.txt',
-        'C:/def/abc/',
-        'C:/def/abc/1'], 'C:/def/') }
-
-      it { is_expected.to include "C:/def/abc/" }
-      it { is_expected.to include "C:/def/abc/1" }
-      it { is_expected.not_to include "C:/def/abc/important.txt" }
+      subject {
+        PathSpec.new(gitignore).match_paths([
+                                              'C:/def/abc/important.txt',
+                                              'C:/def/abc/',
+                                              'C:/def/abc/1'
+                                            ], 'C:/def/') }
+
+      it { is_expected.to include 'C:/def/abc/' }
+      it { is_expected.to include 'C:/def/abc/1' }
+      it { is_expected.not_to include 'C:/def/abc/important.txt' }
     end
   end
 
   # Example to exclude everything except a specific directory foo/bar (note
   # the /* - without the slash, the wildcard would also exclude everything
   # within foo/bar): (from git-scm.com)
-  context "very specific gitignore" do
-    let(:gitignore) { <<-GITIGNORE
+  context 'very specific gitignore' do
+    let(:gitignore) {
+      <<-GITIGNORE
 # exclude everything except directory foo/bar
 /*
 !/foo
@@ -277,13 +302,14 @@ GITIGNORE
 
     subject { PathSpec.new(gitignore) }
 
-    it { is_expected.not_to match("foo/bar") }
-    it { is_expected.to match("anything") }
-    it { is_expected.to match("foo/otherthing") }
+    it { is_expected.not_to match('foo/bar') }
+    it { is_expected.to match('anything') }
+    it { is_expected.to match('foo/otherthing') }
   end
 
-  context "#empty" do
-    let(:gitignore) { <<-GITIGNORE
+  context '#empty' do
+    let(:gitignore) {
+      <<-GITIGNORE
 # A comment
 GITIGNORE
     }
@@ -295,39 +321,65 @@ GITIGNORE
     end
   end
 
-  context "regex file" do
-    let(:regexfile) { <<-REGEX
+  context 'regex file' do
+    let(:regexfile) {
+      <<-REGEX
 ab*a
 REGEX
     }
 
     subject { PathSpec.new regexfile, :regex}
 
-    it "matches the regex" do
+    it 'matches the regex' do
       expect(subject.match('anna')).to be false
       expect(subject.match('abba')).to be true
     end
 
-    context "#from_filename" do
-      it "forwards the type argument" do
+    context '#from_filename' do
+      it 'forwards the type argument' do
         io = double
 
         expect(File).to receive(:open).and_yield(io)
         expect(PathSpec).to receive(:from_lines).with(io, :regex)
 
-        PathSpec.from_filename "/some/file", :regex
+        PathSpec.from_filename '/some/file', :regex
+      end
+
+      it 'reads a simple regex file' do
+        spec = PathSpec.from_filename 'spec/files/regex_simple', :regex
+
+        expect(spec.match('artifact.md')).to be true
+        expect(spec.match('code.rb')).to be false
+      end
+
+      it 'reads a simple gitignore file' do
+        spec = PathSpec.from_filename 'spec/files/gitignore_simple', :git
+
+        expect(spec.match('artifact.md')).to be true
+        expect(spec.match('code.rb')).to be false
+      end
+
+      it 'reads an example ruby gitignore file' do
+        spec = PathSpec.from_filename 'spec/files/gitignore_ruby', :git
+
+        expect(spec.match('coverage/')).to be true
+        expect(spec.match('coverage/index.html')).to be true
+        expect(spec.match('pathspec-0.0.1.gem')).to be true
+        expect(spec.match('lib/pathspec')).to be false
+        expect(spec.match('Gemfile')).to be false
       end
     end
   end
 
-  context "unsuppored spec type" do
-    let(:file) { <<-REGEX
+  context 'unsuppored spec type' do
+    let(:file) {
+      <<-REGEX
 This is some kind of nonsense.
 REGEX
     }
 
-    it "does not allow an unknown spec type" do
-      expect { PathSpec.new file, :foo}.to raise_error
+    it 'does not allow an unknown spec type' do
+      expect { PathSpec.new file, :foo}.to raise_error(/Unknown/)
     end
   end
 end