passwordsafe 0.0.4 → 0.0.5

data/Gemfile.lock

@@ -1,7 +1,8 @@
 PATH
   remote: .
   specs:
-    passwordsafe (0.0.3)
+    passwordsafe (0.0.4)
+      clipboard
       highline
       thor
 
@@ -13,6 +14,7 @@ GEM
       cucumber (~> 0.10.0)
     background_process (1.2)
     builder (3.0.0)
+    clipboard (0.9.7)
     cucumber (0.10.0)
       builder (>= 2.1.2)
       diff-lcs (~> 1.1.2)
@@ -34,7 +36,7 @@ GEM
       diff-lcs (~> 1.1.2)
     rspec-mocks (2.3.0)
     term-ansicolor (1.0.5)
-    thor (0.14.3)
+    thor (0.14.6)
 
 PLATFORMS
   ruby
@@ -43,7 +45,5 @@ DEPENDENCIES
   aruba
   bundler
   cucumber
-  highline
   passwordsafe!
   rspec
-  thor

data/History.md

@@ -1,3 +1,6 @@
+== 0.0.4
+* New feature: `password list`
+
 == 0.0.3
 * New feature: `password get name`
 

data/README.md

@@ -9,17 +9,26 @@ Based on 'Tutorial: Build your own password safe with Ruby!' at http://rbjl.net/
     password add name password
 Use passwordsafe to add a password with NAME to the safe.  The utility will prompt for a master password to use to encrypt the file. *Do NOT loose your master password, it is unrecoverable!*
 
+    password change name password
+Change an existing named password to this new password.
+
+    password generate name [--length]
+Generate a new password with name, accepts an optional length argument.
+
     password get name
 Use passwordsafe to retrive an existing password out of your safe.  The utility will prompt for a master password.
 
     password list
 List all the existing password names in the safe.
 
+    password remove name
+Remove an existing password from your safe.
 
 ## Not Implemented yet
 
-    password remove name
-    password help
+# Contributers
+
+* polarblau https://github.com/polarblau
 
 # Note on Patches/Pull Requests
 

data/features/add.feature

@@ -3,7 +3,6 @@ Feature: Add
     As a user
     I want to be able to add my passwords to the passwordsafe
 
-
     Scenario: Add a new password
         When I run "password add name pa$$word" interactively
         And I type "masterpa$$"

data/features/change.feature

@@ -0,0 +1,16 @@
+Feature: Add
+    In order to not having to remove and re-add my passwords
+    As a user
+    I want to be able to change a password
+
+    Scenario: Change password
+        Given A safe exists with masterpassword "masterpa$$" and a "name" key
+        When I run "password change name newpa$$word" interactively
+        And I type "masterpa$$"
+        Then the output should contain "password for name has been updated"
+
+    Scenario: Change a password for a key that doesn't exist
+        Given A safe exists with masterpassword "masterpa$$" and a "name" key
+        When I run "password change name2 newpa$$word" interactively
+        And I type "masterpa$$"
+        Then the output should contain "name2 does not exist in this safe."

data/features/generate.feature

@@ -0,0 +1,27 @@
+Feature: Add
+    In order to store a safe password
+    As a user
+    I want to be able to generate a safe password and store it
+
+    Scenario: Generate and add new password
+        Given A safe exists with masterpassword "masterpa$$"
+        When I run "password generate name" interactively
+        And I type "masterpa$$"
+        Then the output should contain "generated and added to safe"
+        And the clipboard should contain the password for the "name" key
+ 
+    Scenario: Generate a password with a certain length
+      Given A safe exists with masterpassword "masterpa$$"
+        When I run "password generate name --length 12" interactively
+        And I type "masterpa$$"
+        Then the output should contain "generated and added to safe"
+        And the clipboard should contain the password for the "name" key
+       
+    Scenario: Generate a password with a name that exists
+        Given A safe exists with masterpassword "masterpa$$" and a "name" key
+        When I run "password generate name" interactively
+        And I type "masterpa$$"
+        Then the output should contain "Key already exists in keyring"
+        And the output should not contain "generated and added to safe"
+        
+      

data/features/get.feature

@@ -8,10 +8,10 @@ Feature: Get
         When I run "password get name" interactively
         And I type "masterpa$$"
         Then the output should contain "name: "
-
+        And the clipboard should contain the password for the "name" key
+  
     Scenario: Get a password with a name that does not exist
         Given A safe exists with masterpassword "masterpa$$" and a "name" key
         When I run "password get name2" interactively
         And I type "masterpa$$"
-        Then the output should contain "name2 does not exist in this safe."
-
+        Then the output should contain "name2 does not exist in this safe."

data/features/remove.feature

@@ -0,0 +1,16 @@
+Feature: Remove
+    In order to keep my password list up-to-date
+    As a user
+    I want to be able to remove a password
+
+    Scenario: Remove a password
+        Given A safe exists with masterpassword "masterpa$$" and a "name" key
+        When I run "password remove name" interactively
+        And I type "masterpa$$"
+        Then the output should contain "entry has been removed"
+        
+    Scenario: Remove a password for a key that doesn't exist
+        Given A safe exists with masterpassword "masterpa$$" and a "name" key
+        When I run "password remove name2" interactively
+        And I type "masterpa$$"
+        Then the output should contain "name2 does not exist in this safe." 

data/features/step_definitions/safe_steps.rb

@@ -1,21 +1,33 @@
 require 'passwordsafe/safe'
 require 'passwordsafe/keyring'
 require 'passwordsafe/cli'
+require 'clipboard'
+
+Given /^A safe exists with masterpassword "([^"]*)"$/ do |masterpass|
+  in_current_dir do
+    @safe = PasswordSafe::Safe.new(PasswordSafe::CLI::DEFAULTSAFE, masterpass)
+  end
+end
 
 Given /^A safe exists with masterpassword "([^"]*)" and a "([^"]*)" key$/ do |masterpass, key_name|
   in_current_dir do
-    safe = PasswordSafe::Safe.new(PasswordSafe::CLI::DEFAULTSAFE, masterpass)
-    PasswordSafe::Keyring.new(safe).add key_name, "dummypass"
+    @safe = PasswordSafe::Safe.new(PasswordSafe::CLI::DEFAULTSAFE, masterpass)
+    PasswordSafe::Keyring.new(@safe).add key_name, "dummypass"
   end
 end
 
 Given /^A safe exists with masterpassword "([^"]*)" and "([^"]*)" keys$/ do |masterpass, keys|
   in_current_dir do
-    safe = PasswordSafe::Safe.new(PasswordSafe::CLI::DEFAULTSAFE, masterpass)
+    @safe = PasswordSafe::Safe.new(PasswordSafe::CLI::DEFAULTSAFE, masterpass)
 
     keys.to_i.times do |i|
-      PasswordSafe::Keyring.new(safe).add "pass#{i}", "dummypass"
+      PasswordSafe::Keyring.new(@safe).add "pass#{i}", "dummypass"
     end
   end
 end
 
+Then /^the clipboard should contain the password for the "([^"]*)" key$/ do |key_name|
+  password = PasswordSafe::Keyring.new(@safe).get key_name
+  password.should eq(Clipboard.paste)
+end
+

data/features/support/env.rb

@@ -3,5 +3,6 @@ require 'aruba/cucumber'
 
 After do |s|
   remove_file(PasswordSafe::CLI::DEFAULTSAFE)
+  Clipboard.clear
 end
 

data/lib/passwordsafe/cli.rb

@@ -17,6 +17,19 @@ module PasswordSafe
         puts "password #{name} added to safe"
       end
     end
+    
+    desc "generate NAME", "Generate a new PASSWORD and add it to the keyring with NAME"
+    method_options :length => 8
+    def generate name
+      safe = make_safe
+      begin
+        password = PasswordSafe::Keyring.new(safe).generate(name, options[:length])
+      rescue PasswordSafe::Keyring::KeyExistsException => msg
+        puts "#{msg}"
+      else
+        puts "password #{password} generated and added to safe"
+      end
+    end
 
     desc "get NAME", "Get an existing password with name NAME from keyring"
     def get name
@@ -28,6 +41,30 @@ module PasswordSafe
         puts "#{name}: #{password}"
       end
     end
+    
+    desc "remove NAME", "Remove an existing passoword with name NAME from keyring"
+    def remove name
+      safe = make_safe
+      begin
+       PasswordSafe::Keyring.new(safe).remove(name)
+      rescue PasswordSafe::Keyring::KeyMissingException => msg
+        puts "#{msg}"
+      else
+        puts "entry has been removed"
+      end
+    end
+    
+    desc "change NAME PASSWORD", "Change the password for an existing name NAME to password PASSWORD"
+    def change name, password
+      safe = make_safe
+      begin
+       PasswordSafe::Keyring.new(safe).change(name, password)
+      rescue PasswordSafe::Keyring::KeyMissingException => msg
+        puts "#{msg}"
+      else
+        puts "password for #{name} has been updated"
+      end
+    end
 
     desc "list", "List the names of all the existing passwords in the safe"
     def list

data/lib/passwordsafe/keyring.rb

@@ -1,8 +1,10 @@
 require 'passwordsafe/safe'
+require 'clipboard'
 
 module PasswordSafe
   class Keyring
     class KeyExistsException < StandardError; end
+    class KeyMissingException < StandardError; end
 
     def initialize safe = nil
       @safe = safe
@@ -22,24 +24,47 @@ module PasswordSafe
       @ring.store(name, password)
       @safe.write_safe @ring
     end
+    
+    def change name, password
+      raise KeyMissingException, "#{name} does not exist in this safe.", caller unless @ring.has_key?(name)
+      @ring[name] = password
+      @safe.write_safe @ring
+    end
 
-    def get name
-      @ring[name]
+    def generate name, length = 8
+      raise KeyExistsException, "Key already exists in keyring, if you'd like to add it remove the existing key", caller if @ring.has_key?(name)
+      password = generate_password(length)
+      @ring.store(name, password)
+      @safe.write_safe @ring
+      Clipboard.copy(password)
+      password
     end
 
-    def list
-      @ring.keys
+    def get name
+      raise KeyMissingException, "#{name} does not exist in this safe.", caller unless @ring.has_key?(name)
+      password = @ring[name]
+      Clipboard.copy(password)
+      password
     end
 
     def remove name
+      raise KeyMissingException, "#{name} does not exist in this safe.", caller unless @ring.has_key?(name)
       @ring.delete(name)
       @safe.write_safe @ring
     end
 
+    def list
+      @ring.keys
+    end
+
     private
       def load_from_safe
         @safe.read_safe
       end
+      
+      def generate_password(len)
+        Array.new(len/2) { rand(256) }.pack('C*').unpack('H*').first
+      end
   end
 end
 

data/lib/passwordsafe/version.rb

@@ -1,4 +1,4 @@
 module Passwordsafe
-  VERSION = "0.0.4"
+  VERSION = "0.0.5"
 end
 

data/passwordsafe.gemspec

@@ -26,5 +26,6 @@ Gem::Specification.new do |s|
 
   s.add_dependency "thor"
   s.add_dependency "highline"
+  s.add_dependency "clipboard"
 end
 

data/spec/keyring_spec.rb

@@ -1,9 +1,14 @@
 require 'spec_helper'
 require 'passwordsafe/keyring'
+require 'clipboard'
 
 describe PasswordSafe::Keyring do
   let(:safe) { mock PasswordSafe::Safe, :read_safe => {}, :write_safe => nil }
   let(:keyring) { PasswordSafe::Keyring.new(safe) }
+  
+  after (:each) do
+    Clipboard.clear
+  end
 
   it "expects to get a Safe to read/write" do
     safe.should_receive(:is_a?).and_return(true)
@@ -13,7 +18,6 @@ describe PasswordSafe::Keyring do
   end
 
   describe "length" do
-
     it "returns the number of keys in the keyring" do
       keyring.should respond_to(:length)
       keyring.length.should be_a(Integer)
@@ -21,7 +25,6 @@ describe PasswordSafe::Keyring do
   end
 
   describe "add" do
-
     it "adds a key to the keyring" do
       keyring.should respond_to(:add).with(2).arguments
       keyring.add("name", "password")
@@ -37,19 +40,49 @@ describe PasswordSafe::Keyring do
     end
   end
 
+  describe "generate" do
+    it "adds a generated password to the keyring" do
+      keyring.should respond_to(:generate).with(1).arguments
+      keyring.generate("name")
+      keyring.length.should eq(1)
+    end
+    it "generates a password" do
+      keyring.should respond_to(:generate).with(1).arguments
+      password = keyring.generate("name")
+      keyring.get("name").should eq(password)
+    end
+    it "generates a password of default length '8'" do
+      keyring.generate("name").length.should eq(8)
+    end
+    it "generates a password of a specified length" do
+      keyring.generate("name", 12).length.should eq(12)
+    end
+    it "throws an error when generating passord for a duplicate key name" do
+      keyring.generate("name")
+      expect{keyring.generate("name")}.to raise_error()
+    end
+    it "should copy the generated password to the clipboard" do
+      password = keyring.generate("name")
+      Clipboard.paste.should eq(password)
+    end
+  end
+  
   describe "get" do
-
     it "gets a key from the keyring" do
       safe.stub(:read_safe).and_return({"name" => "password"})
       keyring.get("name").should eq("password")
     end
-    it "returns nil if the key does not exist" do
-      keyring.get("name").should be_nil
+    it "throws an error if a key does not exist" do
+      expect{keyring.get("name")}.to raise_error()
+    end
+    it "should copy the retrieved password to the clipboard" do
+      safe.stub(:read_safe).and_return({"name" => "password"})
+      password = keyring.get("name")
+      Clipboard.paste.should eq(password)
     end
   end
 
   describe "list" do
-
     it "returns a list of existing key names" do
       safe.should_receive(:read_safe).and_return({"first" => "password", "second" => "password"})
       keyring.list.should eq(["first", "second"])
@@ -58,19 +91,46 @@ describe PasswordSafe::Keyring do
       keyring.list.should eq([])
     end
   end
+  
+  describe "change" do
+     it "responds to 'change'" do
+        safe.stub(:read_safe).and_return({"name" => "password"})
+        keyring.should respond_to(:change).with(2).arguments
+      end
+      it "throws an error if a key does not exist" do
+        expect{keyring.change("name", "password")}.to raise_error()
+      end
+      it "updates the password" do
+        safe.stub(:read_safe).and_return({"name" => "password"})
+        keyring.get("name").should eq("password")
+        keyring.change("name", "newpassword")
+        keyring.get("name").should eq("newpassword")
+      end
+      it "updates the modified keyring to the safe" do
+        safe.stub(:read_safe).and_return({"name" => "password"})
+        safe.should_receive(:write_safe).with({"name" => "newpassword"})
+        keyring.change("name", "newpassword")
+      end
+  end
 
   describe "remove" do
-
+    it "responds to 'remove'" do
+      safe.stub(:read_safe).and_return({"name" => "password"})
+      keyring.should respond_to(:remove).with(1).arguments
+    end
     it "removes an existing key" do
       safe.should_receive(:read_safe).and_return({"first" => "password", "second" => "password"})
       keyring.remove("first")
-      keyring.get("first").should eq(nil)
+      expect{keyring.get("first")}.to raise_error()
     end
     it "saves the modified keyring to the safe" do
       safe.should_receive(:read_safe).and_return({"first" => "password", "second" => "password"})
       safe.should_receive(:write_safe).with({"second" => "password"})
       keyring.remove("first")
     end
+    it "throws an error if a key does not exist" do
+      expect{keyring.remove("name")}.to raise_error()
+    end
   end
 end
 

metadata

@@ -1,12 +1,8 @@
 --- !ruby/object:Gem::Specification 
 name: passwordsafe
 version: !ruby/object:Gem::Version 
-  prerelease: false
-  segments: 
-  - 0
-  - 0
-  - 4
-  version: 0.0.4
+  prerelease: 
+  version: 0.0.5
 platform: ruby
 authors: 
 - thecatwasnot
@@ -14,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-04 00:00:00 -06:00
+date: 2011-03-07 00:00:00 -06:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -25,8 +21,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id001
@@ -38,8 +32,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id002
@@ -51,8 +43,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id003
@@ -64,8 +54,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :development
   version_requirements: *id004
@@ -77,8 +65,6 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :runtime
   version_requirements: *id005
@@ -90,11 +76,20 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        segments: 
-        - 0
         version: "0"
   type: :runtime
   version_requirements: *id006
+- !ruby/object:Gem::Dependency 
+  name: clipboard
+  prerelease: false
+  requirement: &id007 !ruby/object:Gem::Requirement 
+    none: false
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: "0"
+  type: :runtime
+  version_requirements: *id007
 description: Small command line app for storing passwords
 email: 
 - thecatwasnot@gmail.com
@@ -115,8 +110,11 @@ files:
 - Rakefile
 - bin/password
 - features/add.feature
+- features/change.feature
+- features/generate.feature
 - features/get.feature
 - features/list.feature
+- features/remove.feature
 - features/step_definitions/safe_steps.rb
 - features/support/env.rb
 - lib/passwordsafe.rb
@@ -145,21 +143,17 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 required_rubygems_version: !ruby/object:Gem::Requirement 
   none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
-      segments: 
-      - 0
       version: "0"
 requirements: []
 
 rubyforge_project: passwordsafe
-rubygems_version: 1.3.7
+rubygems_version: 1.5.0
 signing_key: 
 specification_version: 3
 summary: Small command line app for storing passwords