password_strength 0.1.4 → 0.1.5

data/lib/password_strength.js

@@ -22,6 +22,7 @@ var PasswordStrength = function() {
 		this.score += this.scoreFor("only_numbers");
 		this.score += this.scoreFor("username");
 		this.score += this.scoreFor("sequences");
+		this.score += this.scoreFor("repetitions");
 
 		if (this.score < 0) {
 			this.score = 0;
@@ -115,9 +116,15 @@ var PasswordStrength = function() {
 				break;
 
 			case "sequences":
-				score += -15 * this.detectSequences(this.password);
-				score += -15 * this.detectSequences(this.reversed(this.password));
-				break
+				score += -15 * this.sequences(this.password);
+				score += -15 * this.sequences(this.reversed(this.password));
+				break;
+
+			case "repetitions":
+				score += -(this.repetitions(this.password, 2) * 4);
+        		score += -(this.repetitions(this.password, 3) * 3);
+        		score += -(this.repetitions(this.password, 4) * 2);
+				break;
 		};
 
 		return score;
@@ -145,7 +152,7 @@ var PasswordStrength = function() {
 		}
 	};
 
-	this.detectSequences = function(text) {
+	this.sequences = function(text) {
 		var matches = 0;
 		var sequenceSize = 0;
 		var codes = [];
@@ -173,6 +180,38 @@ var PasswordStrength = function() {
 		return matches;
 	};
 
+	this.repetitions = function(text, size) {
+		var count = 0;
+  		var matches = {};
+		var len = text.length;
+		var substring;
+		var occurrences;
+		var tmpText;
+
+		for (var i = 0; i < len; i++) {
+			substring = text.substr(i, size);
+			occurrences = 0;
+			tmpText = text;
+
+			if (matches[substring] || substring.length < size) {
+				continue;
+			}
+
+			matches[substring] = true;
+
+			while ((i = tmpText.indexOf(substring)) != -1) {
+				occurrences += 1;
+				tmpText = tmpText.substr(i + 1);
+			};
+
+			if (occurrences > 1) {
+				count += 1;
+			}
+		}
+
+		return count;
+	};
+
 	this.reversed = function(text) {
 		var newText = "";
 		var len = text.length;

data/lib/password_strength.rb

@@ -1,3 +1,4 @@
+require "active_support"
 require "password_strength/base"
 require "password_strength/active_record"
 

data/lib/password_strength/base.rb

@@ -135,6 +135,7 @@ module PasswordStrength
     end
 
     def repetitions(text, size) # :nodoc:
+      text = text.mb_chars
       count = 0
       matches = []
 
@@ -144,8 +145,7 @@ module PasswordStrength
         next if matches.include?(substring) || substring.size < size
 
         matches << substring
-        occurrences = text.scan(substring).length
-
+        occurrences = text.scan(/#{Regexp.escape(substring)}/).length
         count += 1 if occurrences > 1
       end
 

data/lib/password_strength/version.rb

@@ -2,7 +2,7 @@ module PasswordStrength
   module Version # :nodoc: all
     MAJOR = 0
     MINOR = 1
-    PATCH = 4
+    PATCH = 5
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/test/password_strength_test.js

@@ -179,6 +179,12 @@ new Test.Unit.Runner({
     	assertEqual(-100, strength.scoreFor("password_size"));
 	}},
 
+	// Penalize repetitions
+	testPenalizeRepetitions: function() { with(this) {
+	    strength.password = "abcdabcdabcd";
+	    assertEqual(-36, strength.scoreFor("repetitions"));
+	}},
+
 	// Password length
 	testPasswordLength: function() { with(this) {
 		strength.password = "12345";
@@ -221,5 +227,18 @@ new Test.Unit.Runner({
     	assertEqual(15, strength.scoreFor("symbols_chars"));
 	}},
 
+	// Two char repetition
+	testTwoCharRepetition: function() { with(this) {
+		assertEqual(3, strength.repetitions("11221122", 2));
+	}},
+
+	// Three char repetition
+	testThreeCharRepetition: function() { with(this) {
+		assertEqual(3, strength.repetitions("123123123", 3));
+	}},
 
+	// Four char repetition
+	testFourCharRepetition: function() { with(this) {
+		assertEqual(4, strength.repetitions("abcdabcdabcd", 4));
+	}}
 });

data/test/password_strength_test.rb

@@ -212,4 +212,15 @@ class TestPasswordStrength < Test::Unit::TestCase
     # expected: abcd, bcda, cdab, dabc
     assert_equal 4, @strength.repetitions("abcdabcdabcd", 4)
   end
+
+  def test_special_chars_repetition
+    # expected: §§, ££, §£
+    assert_equal 3, @strength.repetitions("§§££§§££", 2)
+
+    # expected: §£€, £€§, €§£
+    assert_equal 3, @strength.repetitions("§£€§£€§£€", 3)
+
+    # expected: §£€à, £€à§, €à§£, ৣ€
+    assert_equal 4, @strength.repetitions("§£€à§£€à§£€à", 4)
+  end
 end

data/test/test_helper.rb

@@ -1,4 +1,5 @@
 $LOAD_PATH.unshift File.dirname(__FILE__) + "/../lib"
+$KCODE = "utf8" if RUBY_VERSION < "1.9"
 
 require "rubygems"
 require "test/unit"

metadata

@@ -1,7 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: password_strength
 version: !ruby/object:Gem::Version 
-  version: 0.1.4
+  prerelease: false
+  segments: 
+  - 0
+  - 1
+  - 5
+  version: 0.1.5
 platform: ruby
 authors: 
 - Nando Vieira
@@ -9,10 +14,21 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-08 00:00:00 -03:00
+date: 2010-03-23 00:00:00 -03:00
 default_executable: 
-dependencies: []
-
+dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: activesupport
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        segments: 
+        - 0
+        version: "0"
+  type: :runtime
+  version_requirements: *id001
 description: |
   Validates the strength of a password according to several rules:
   
@@ -69,18 +85,20 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.3.5
+rubygems_version: 1.3.6
 signing_key: 
 specification_version: 3
 summary: Check password strength against several rules. Includes ActiveRecord support.