password_strength 0.1.3 → 0.1.4

data/CHANGELOG.rdoc

@@ -1,5 +1,22 @@
 = Changelog
 
-== March 5 2010
+== 0.1.0 - March 5 2010
 
-* Released 0.1.0 version
+* First release
+
+== 0.1.1 - March 5 2010
+
+* Added JavaScript implementation
+
+== 0.1.2 - March 5 2010
+
+* Added jQuery plugin
+
+== 0.1.3 - March 5 2010
+
+* Added localized error messages for +pt+ and +en+
+
+== 0.1.4 - March 8 2010
+
+* jQuery function can accept string instead of selectors
+* Added repetition penalization

data/README.rdoc

@@ -9,6 +9,7 @@ Validates the strength of a password according to several rules:
 * combination of numbers, letters and symbols
 * password contains username
 * sequences (123, abc, aaa)
+* repetitions
 
 Some results:
 
@@ -105,7 +106,6 @@ Get the files:
 
 = TO-DO
 
-* Detect repetitions
 * Rake task to get the latest JavaScript file
 
 = License

data/lib/jquery.strength.js

@@ -1,19 +1,32 @@
 (function($){
 	$.strength = function(username, password, callback) {
-		username = $(username);
-		password = $(password);
+		var usernameField = $(username);
+		var passwordField = $(password);
 		var strength = new PasswordStrength();
 		callback = callback || $.strength.callback;
 
 		var handler = function(){
-			strength.username = $(username).val();
-			strength.password = $(this).val();
+			strength.username = $(usernameField).val();
+
+			if ($(usernameField).length == 0) {
+				strength.username = username;
+			}
+
+			strength.password = $(passwordField).val();
+
+			if ($(passwordField).length == 0) {
+				strength.password = password;
+			}
+
 			strength.test();
-			callback(username, password, strength);
+			callback(usernameField, passwordField, strength);
 		};
 
-		$(username).keydown(handler);
-		$(password).keydown(handler);
+		$(usernameField).keydown(handler);
+		$(usernameField).keyup(handler);
+
+		$(passwordField).keydown(handler);
+		$(passwordField).keyup(handler);
 	};
 
 	$.extend($.strength, {
@@ -31,8 +44,6 @@
 				.removeClass("strong")
 				.addClass(strength.status)
 				.attr("src", $.strength[strength.status + "Image"]);
-
-			console.debug($.strength[strength.status + "Image"])
 		},
 		weakImage: "/images/weak.png",
 		goodImage: "/images/good.png",

data/lib/password_strength/base.rb

@@ -98,8 +98,12 @@ module PasswordStrength
           score = -15 if password =~ /#{Regexp.escape(username)}/
         end
       when :sequences then
-        score = -15 * detect_sequences(password)
-        score += -15 * detect_sequences(password.to_s.reverse)
+        score = -15 * sequences(password)
+        score += -15 * sequences(password.to_s.reverse)
+      when :repetitions then
+        score += -(repetitions(password, 2) * 4)
+        score += -(repetitions(password, 3) * 3)
+        score += -(repetitions(password, 4) * 2)
       end
 
       score
@@ -118,6 +122,7 @@ module PasswordStrength
       @score += score_for(:only_numbers)
       @score += score_for(:username)
       @score += score_for(:sequences)
+      @score += score_for(:repetitions)
 
       @score = 0 if score < 0
       @score = 100 if score > 100
@@ -129,7 +134,25 @@ module PasswordStrength
       score
     end
 
-    def detect_sequences(text) # :nodoc:
+    def repetitions(text, size) # :nodoc:
+      count = 0
+      matches = []
+
+      0.upto(text.size - 1) do |i|
+        substring = text[i, size]
+
+        next if matches.include?(substring) || substring.size < size
+
+        matches << substring
+        occurrences = text.scan(substring).length
+
+        count += 1 if occurrences > 1
+      end
+
+      count
+    end
+
+    def sequences(text) # :nodoc:
       matches = 0
       sequence_size = 0
       bytes = []

data/lib/password_strength/version.rb

@@ -2,7 +2,7 @@ module PasswordStrength
   module Version # :nodoc: all
     MAJOR = 0
     MINOR = 1
-    PATCH = 3
+    PATCH = 4
     STRING = "#{MAJOR}.#{MINOR}.#{PATCH}"
   end
 end

data/test/jquery_strength_test.js

@@ -71,4 +71,25 @@ new Test.Unit.Runner({
 		assertEqual(1, $("img.strong").length);
 		assertEqual("/images/strong.png", $("img.strength").attr("src"));
 	}},
+
+	// Missing username element: use selector as text
+	testMissingUsernameElementUseSelectorAsText: function() { with(this) {
+		$("#password").val("^P4ssw0rd$");
+		$.strength("root", "#password", function(username, password, strength){
+			assertEqual("root", strength.username);
+			assertEqual("^P4ssw0rd$", strength.password);
+		});
+
+		$("#password").trigger("keydown");
+	}},
+
+	// Missing password element: use selector as text
+	testMissingPasswordElementUseSelectorAsText: function() { with(this) {
+		$.strength("#username", "mypass", function(username, password, strength){
+			assertEqual("johndoe", strength.username);
+			assertEqual("mypass", strength.password);
+		});
+
+		$("#username").trigger("keydown");
+	}}
 });

data/test/password_strength_test.rb

@@ -155,6 +155,14 @@ class TestPasswordStrength < Test::Unit::TestCase
     assert_equal -100, @strength.score_for(:password_size)
   end
 
+  def test_penalize_repetitions
+    # 2-chars: ab, bc, cd, da           (4 * 4 = 16)
+    # 3-chars: abc, bcd, cda, dab       (4 * 3 = 12)
+    # 4-chars: abcd, bcda, cdab, dabc   (4 * 2 =  8)
+    @strength.password = "abcdabcdabcd"
+    assert_equal -36, @strength.score_for(:repetitions)
+  end
+
   def test_password_length
     @strength.password = "12345"
     assert_equal 20, @strength.score_for(:password_size)
@@ -189,4 +197,19 @@ class TestPasswordStrength < Test::Unit::TestCase
     @strength.password = "a$"
     assert_equal 15, @strength.score_for(:symbols_chars)
   end
+
+  def test_two_chars_repetition
+    # expected: 11, 22, 12
+    assert_equal 3, @strength.repetitions("11221122", 2)
+  end
+
+  def test_three_chars_repetition
+    # expected: 123, 231, 312
+    assert_equal 3, @strength.repetitions("123123123", 3)
+  end
+
+  def test_four_chars_repetition
+    # expected: abcd, bcda, cdab, dabc
+    assert_equal 4, @strength.repetitions("abcdabcdabcd", 4)
+  end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: password_strength
 version: !ruby/object:Gem::Version 
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors: 
 - Nando Vieira
@@ -9,7 +9,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-03-05 00:00:00 -03:00
+date: 2010-03-08 00:00:00 -03:00
 default_executable: 
 dependencies: []