passwd 0.0.5 → 0.0.6

data/.coveralls.yml

@@ -0,0 +1 @@
+repo_token: juJNf3K7FF93l6tzdF8cv1V2NFgGdCaWv

data/Gemfile

@@ -2,3 +2,7 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in passwd.gemspec
 gemspec
+
+group :test do
+  gem 'coveralls', require: false
+end

data/README.md

@@ -1,6 +1,9 @@
 # Passwd
 
+[![Gem Version](https://badge.fury.io/rb/passwd.png)](http://badge.fury.io/rb/passwd)
 [![Build Status](https://travis-ci.org/i2bskn/passwd.png?branch=master)](https://travis-ci.org/i2bskn/passwd)
+[![Code Climate](https://codeclimate.com/github/i2bskn/passwd.png)](https://codeclimate.com/github/i2bskn/passwd)
+[![Coverage Status](https://coveralls.io/repos/i2bskn/passwd/badge.png?branch=master)](https://coveralls.io/r/i2bskn/passwd?branch=master)
 
 Password utilities.
 
@@ -60,31 +63,6 @@ Options that can be specified:
 * :letters_upper => Define an array of upper case. default is ("A".."Z").to_a
 * :letters_number => Define an array of numbers. default is ("0".."9").to_a
 
-### Password policy check
-
-```ruby
-Passwd.policy_check(password)
-```
-
-### Policy settings
-
-Default policy is stored in the class variable. (@@policy)
-Changing the default policy are as follows:
-
-```ruby
-Passwd.policy => Get policy hash.
-Passwd.policy(min_length: 10) => Change to the default min_length.
-```
-
-Options that can be specified:
-
-* :min_length => Minimum length of password. default is 8.
-* :min_type => Minimum types of password. default is 2.(types is lower/upper/number)
-* :specify_type => Check of each types. default is false.
-* :require_lower => Require lower case if set true. specify_type enabled when true.
-* :require_upper => Require upper case if set true. specify_type enabled when true.
-* :require_number => Require number case if set true. specify_type enabled when true.
-
 ### Password object
 
 Default password is randomly generated.

data/lib/passwd.rb

@@ -17,55 +17,22 @@ module Passwd
     letters_number: ('0'..'9').to_a
   }
 
-  @@policy = {
-    min_length: 8,
-    min_type: 2,
-    specify_type: false,
-    require_lower: true,
-    require_upper: true,
-    require_number: true
-  }
-
   class << self
     def create(options={})
       config = @@config.merge(options)
+      letters = get_retters(config)
 
+      # Create random password
+      Array.new(config[:length]){letters[rand(letters.size)]}.join
+    end
+
+    def get_retters(config)
       # Create letters
       letters = Array.new
       letters += config[:letters_lower] if config[:lower]
       letters += config[:letters_upper] if config[:upper]
       letters += config[:letters_number] if config[:number]
-
-      # Create random password
-      Array.new(config[:length]){letters[rand(letters.size)]}.join
-    end
-
-    def policy_check(passwd, options={})
-      policy = @@policy.merge(options)
-
-      # Check number of characters
-      return false if passwd.size < policy[:min_length]
-
-      # Check number of types of characters
-      ctype = Array.new
-      passwd.each_char.with_index do |char, i|
-        case
-        when @@config[:letters_lower].include?(char) then ctype << 0
-        when @@config[:letters_upper].include?(char) then ctype << 1
-        when @@config[:letters_number].include?(char) then ctype << 2
-        end
-      end
-      ctype.uniq!
-      return false if ctype.size < policy[:min_type]
-
-      # Check of each character type
-      if policy[:specify_type]
-        return false if policy[:require_lower] && !ctype.include?(0)
-        return false if policy[:require_upper] && !ctype.include?(1)
-        return false if policy[:require_number] && !ctype.include?(2)
-      end
-
-      true
+      letters
     end
 
     def auth(password_text, salt_hash, password_hash)
@@ -80,9 +47,5 @@ module Passwd
     def config(options={})
       @@config.merge!(options)
     end
-
-    def policy(options={})
-      @@policy.merge!(options)
-    end
   end
 end

data/lib/passwd/password.rb

@@ -33,10 +33,6 @@ module Passwd
       @salt_hash = salt_hash
     end
 
-    def policy_check
-      Passwd.policy_check @text
-    end
-
     def ==(password)
       enc_pass = Passwd.hashing("#{@salt_hash}#{password}")
       @hash == enc_pass

data/lib/passwd/version.rb

@@ -1,3 +1,3 @@
 module Passwd
-  VERSION = "0.0.5"
+  VERSION = "0.0.6"
 end

data/spec/passwd/password_spec.rb

@@ -122,15 +122,6 @@ describe Passwd::Password do
     end
   end
 
-  context "#policy_check" do
-    it "Passwd.policy_check is called with pass_text" do
-      pass_text = Passwd.create
-      Passwd.should_receive(:policy_check).with(pass_text)
-      password = Passwd::Password.new(password: pass_text)
-      password.policy_check
-    end
-  end
-
   context "#==" do
     before(:each) do
       @password = Passwd::Password.new

data/spec/passwd_spec.rb

@@ -33,41 +33,6 @@ describe Passwd do
       end
     end
 
-    context "#policy_check" do
-      it "return true with valid password" do
-        expect(Passwd.policy_check("09aVCud5")).to eq(true)
-      end
-
-      it "return false with less number of characters" do
-        expect(Passwd.policy_check("Secret")).to eq(false)
-      end
-
-      it "return false with less number of types" do
-        expect(Passwd.policy_check("password")).to eq(false)
-      end
-
-      it "require lower case if require_lower is true" do
-        password = Passwd.create(lower: false)
-        expect(
-          Passwd.policy_check(password, min_type: 1, specify_type: true, require_lower: true)
-        ).to eq(false)
-      end
-
-      it "require upper case if require_upper is true" do
-        password = Passwd.create(upper: false)
-        expect(
-          Passwd.policy_check(password, min_type: 1, specify_type: true, require_upper: true)
-        ).to eq(false)
-      end
-
-      it "require number case if require_number is true" do
-        password = Passwd.create(number: false)
-        expect(
-          Passwd.policy_check(password, min_type: 1, specify_type: true, require_number: true)
-        ).to eq(false)
-      end
-    end
-
     context "#auth" do
       it "return true with valid password" do
         password = Passwd.create
@@ -115,25 +80,5 @@ describe Passwd do
         expect(Passwd.config[:length]).not_to eq(old_value)
       end
     end
-
-    context "#policy" do
-      before(:all) do
-        @default_value = Passwd.policy.clone
-      end
-
-      after(:all) do
-        Passwd.policy(@default_value)
-      end
-
-      it "return policy hash" do
-        expect(Passwd.policy.class).to eq(Hash)
-      end
-
-      it "set config value" do
-        old_value = Passwd.policy[:min_length]
-        Passwd.policy(min_length: 10)
-        expect(Passwd.policy[:min_length]).not_to eq(old_value)
-      end
-    end
   end
 end

data/spec/spec_helper.rb

@@ -1 +1,4 @@
 require "passwd"
+
+require "coveralls"
+Coveralls.wear!

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: passwd
 version: !ruby/object:Gem::Version
-  version: 0.0.5
+  version: 0.0.6
   prerelease: 
 platform: ruby
 authors:
@@ -66,6 +66,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .coveralls.yml
 - .gitignore
 - .travis.yml
 - Gemfile
@@ -96,7 +97,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 109903666620076134
+      hash: -540825171026277875
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -105,10 +106,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 109903666620076134
+      hash: -540825171026277875
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.25
+rubygems_version: 1.8.23
 signing_key: 
 specification_version: 3
 summary: Password utility