passpartu 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: f9a34533883b1c070612ecd73c34299a9c05f899e31256b8f51f0b9edf50c6e4
-  data.tar.gz: 625c359af9f1d4560f28d63fe47b426351f1cf7f5e0f68da3e7aaafb2bfec08f
+  metadata.gz: 1a282e26dea8142a8ad36151367612a9bfbc3ad0e4c116d87343e93f7e8301a9
+  data.tar.gz: 0dc7b495c6b574a3ca83328e1014e948cbf2993b9fe97cbed192cfb0756b91a6
 SHA512:
-  metadata.gz: bb08f025f855506ea084cf9010dddb38d6f9f499d12e837fb015bf061163b48b86312da2e20e3a223559ebf1800b1fd332adfecb7769e52e6fcd3cbbd503f717
-  data.tar.gz: b10e9806c7eb0dee1e0332b5f651a4ab82da93a52cf1c955681f3d3c5be9cb32fd4346dd18da26f5d7af78c0a6876b289ce075a01a1ba2049a5becd0f5d25afe
+  metadata.gz: 73f3c5177366551d7101dd0873e17c6f13dd76b5fb682c0b6b55f07514c9329c728f4e1c5f83c136c7875f5b59968278ad86707010a8b5874b5f4ffdcc386071
+  data.tar.gz: 43ac9dcdc2d90c3db00e781277abdd544a748cab17a2548de57a6d206d1605302cf93e7a9ab90ddb390f90a2bd8878d92663fd363c99017f4bbe3bc4444f90c8

data/README.md

@@ -1,4 +1,6 @@
-# Passpartu v1.1.0 - [changelog](https://github.com/coaxsoft/passpartu/blob/master/CHANGELOG.md)
+# Passpartu - [changelog](https://github.com/coaxsoft/passpartu/blob/master/CHANGELOG.md)
+
+[![Gem Version](https://badge.fury.io/rb/passpartu.png)](https://badge.fury.io/rb/passpartu)
 
 Passpartu makes policies great again (works awesome with [Pundit](https://rubygems.org/gems/pundit)).
 
@@ -85,7 +87,6 @@ It's possible to use `crud` key to set values for `create`, `read`, `update`, `d
 
 In case `crud: true` and `delete: false` - result `false` 
 
-
 ### Only
 
 It's possible to include specific roles to checks
@@ -158,6 +159,25 @@ Check user roles AND policy rule
   user_agent.agent_can?(:orders, :edit, except: [:admin, :manager]) { user_agent.orders.include?(order) }
 ```
 
+### 'Maybe' option
+
+Option 'maybe' means that user can do something if the block returns true. In this case block is required
+and error is raised when option is maybe and no block given.
+
+```yml
+manager:
+  products:
+    create: true
+    delete: false
+  bookings:
+    update: maybe
+```
+
+```ruby
+manager.can?(:bookings, :update) # raises error
+manager.can?(:bookings, :update) { user.bookings.include?(booking) } # returns true or false
+```
+
 ### Waterfall check
 
 Allow or restrict absolutely everything for particular role or/and particular domain.

data/lib/passpartu/block_verify.rb

@@ -2,11 +2,21 @@
 
 module Passpartu
   class BlockVerify < ::Passpartu::Verify
+    class BlockMissedError < StandardError; end
+    MAYBE_VALUE = 'maybe'
+
     def call
       policy_result = super
+      raise BlockMissedError, "Block is required for 'maybe' allowed resource" if maybe? && block.nil?
       return policy_result if block.nil?
 
       policy_result && block.call
     end
+
+    private
+
+    def maybe?
+      result == MAYBE_VALUE
+    end
   end
 end

data/lib/passpartu/validate_result.rb

@@ -3,6 +3,7 @@
 module Passpartu
   class ValidateResult
     class PolicyMissedError < StandardError; end
+    class InvalidResultError < StandardError; end
 
     attr_reader :result
 
@@ -15,20 +16,20 @@ module Passpartu
     end
 
     def call
-      raise PolicyMissedError if raise_error?
-      return false unless boolean?
+      raise PolicyMissedError if raise_policy_missed_error?
+      return false if result_not_defined?
 
       result
     end
 
     private
 
-    def boolean?
-      [true, false].include?(result)
+    def raise_policy_missed_error?
+      result_not_defined? && Passpartu.config.raise_policy_missed_error
     end
 
-    def raise_error?
-      !boolean? && Passpartu.config.raise_policy_missed_error
+    def result_not_defined?
+      result.nil? || result.is_a?(Hash)
     end
   end
 end

data/lib/passpartu/verify.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
-require 'byebug'
+
 module Passpartu
   class Verify
     CRUD_KEY = 'crud'
@@ -31,12 +31,10 @@ module Passpartu
 
       validate_result
     rescue StandardError => e
-      if ['TrueClass does not have #dig method', 'FalseClass does not have #dig method'].include?(e.message)
-        raise WaterfallError,
-              "Looks like you want to use check_waterfall feature, but it's set to 'false'. Otherwise check your #{Passpartu.config.policy_file} for validness"
-      else
-        raise e
-      end
+      raise e unless ['TrueClass does not have #dig method', 'FalseClass does not have #dig method'].include?(e.message)
+
+      raise WaterfallError,
+            "Looks like you want to use check_waterfall feature, but it's set to 'false'. Otherwise check your #{Passpartu.config.policy_file} for validness"
     end
 
     private

data/lib/passpartu/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Passpartu
-  VERSION = '1.1.0'
+  VERSION = '1.2.0'
 end

data/lib/passpartu.rb

@@ -83,6 +83,8 @@ module Passpartu
           value.define_singleton_method(:dig) { |*_keys| true }
         when false
           value.define_singleton_method(:dig) { |*_keys| false }
+        when 'maybe'
+          value.define_singleton_method(:dig) { |*_keys| 'maybe' }
         else
           patch_policy_booleans_if(value)
         end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passpartu
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - OrestF
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2022-04-28 00:00:00.000000000 Z
+date: 2023-05-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -145,7 +145,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.3.7
+rubygems_version: 3.4.6
 signing_key:
 specification_version: 4
 summary: Passpartu makes policies great again