passkit 0.8.1 → 0.8.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 113677b120a24b0f9b64e2ca133a9a668bb30d042d3939c9b0ba65fef38b8407
-  data.tar.gz: e070e3b7fd30e589772bc3c1e850cdfbe5f9ecbe2a56237f6fd163e69c4ddcee
+  metadata.gz: 0ba766112a286c8570851338476fee913b5eff4575cfc2fc6eeb91fb2617e5b0
+  data.tar.gz: 7b28c2c662b071529705a5fa409da39d42442eb702547a25ad960369d0c8500d
 SHA512:
-  metadata.gz: a0bdbaaff31652f167dd8d9db7f122f21035bc3b0076192bd208fcb62e8b03824fb3057e15a51b0ab3c5208a746cb715e9fd77b243f74a8113994d2f8dc2aa82
-  data.tar.gz: 97f160e5f66ce8cc780049044ede60887cc616f337550c3b252fd42bf55cb3d30fd0355d2a7d0460869ebbcf4306ebff947bf7ccb275d2a227dd1c83d0c54753
+  metadata.gz: 53782d8dd386090a3fda13fa70ebf39a82d06afe3f00fd83cc54845cdeb59b5f0d0a414fe4e151e773451b4d18a3331720acfbd0ebd2e7eb6238effb1b8ab719
+  data.tar.gz: f37f52f4b3f105e1a5dde4c2613ffa35372d2c5734b8da28e3551f84bf978742c4d1a257ee380c46fa950fbba04e9f22fc37c67dfa05de7149c0c902735d91f7

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.8.3]
+- Exclude development and test files from the packaged gem.
+
+## [0.8.2]
+- Set up the Semaphore CI pipeline with a manual promotion to release the gem.
+- Self-signed certificates for the test suite, so it runs without an Apple Developer certificate.
+- Code formatting cleanup (standardrb).
+- Relax the `sqlite3` development dependency to `>= 1.4`.
+
 ## [0.8.1]
 - [#45](https://github.com/coorasse/passkit/pull/45): Fix broken build.
 

data/README.md

@@ -188,9 +188,15 @@ or the certificate trust chain could not be verified." the certificate (p12) mig
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies and to generate the self-signed certificates
+used to sign the passes in the test suite. Then, run `rake test` to run the tests and `rake test:system` to run the
+system tests (they require Chrome). You can also run `bin/console` for an interactive prompt that will allow you to
+experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+The test suite reads its configuration from `.env.test`, so no Apple Developer certificate is needed to run it.
+Values defined in your own `.env` take precedence, in case you want to run the dummy app with real certificates.
+
+To install this gem onto your local machine, run `bundle exec rake install`.
 
 ## Contributing
 

data/app/controllers/passkit/api/v1/passes_controller.rb

@@ -12,10 +12,10 @@ module Passkit
               Passkit::Factory.create_pass(@payload[:pass_class], collection_item)
             end
             file = Passkit::Generator.compress_passes_files(files)
-            send_file(file, type: 'application/vnd.apple.pkpasses', disposition: 'attachment')
+            send_file(file, type: "application/vnd.apple.pkpasses", disposition: "attachment")
           else
             file = Passkit::Factory.create_pass(@payload[:pass_class], @generator)
-            send_file(file, type: 'application/vnd.apple.pkpass', disposition: 'attachment')
+            send_file(file, type: "application/vnd.apple.pkpass", disposition: "attachment")
           end
         end
 

data/app/models/passkit/pass.rb

@@ -39,7 +39,7 @@ module Passkit
       :secondary_fields,
       :semantics,
       :sharing_prohibited,
-      :strip_color
+      :strip_color,
       :suppress_strip_shine,
       :user_info,
       :voided,

data/lib/passkit/base_pass.rb

@@ -189,10 +189,10 @@ module Passkit
 
     # QRCode by default
     def barcode
-      { messageEncoding: "iso-8859-1",
-        format: "PKBarcodeFormatQR",
-        message: "https://github.com/coorasse/passkit",
-        altText: "https://github.com/coorasse/passkit" }
+      {messageEncoding: "iso-8859-1",
+       format: "PKBarcodeFormatQR",
+       message: "https://github.com/coorasse/passkit",
+       altText: "https://github.com/coorasse/passkit"}
     end
 
     # Barcode example
@@ -231,7 +231,7 @@ module Passkit
       false
     end
 
-  private
+    private
 
     def folder_name
       self.class.name.demodulize.underscore

data/lib/passkit/example_store_card.rb

@@ -39,10 +39,10 @@ module Passkit
     # QRCode by default
     def barcodes
       [
-        { messageEncoding: "iso-8859-1",
-          format: "PKBarcodeFormatQR",
-          message: "https://github.com/coorasse/passkit",
-          altText: "https://github.com/coorasse/passkit" }
+        {messageEncoding: "iso-8859-1",
+         format: "PKBarcodeFormatQR",
+         message: "https://github.com/coorasse/passkit",
+         altText: "https://github.com/coorasse/passkit"}
       ]
     end
 
@@ -59,12 +59,12 @@ module Passkit
     end
 
     def relevant_date
-      Time.current.strftime('%Y-%m-%dT%H:%M:%S%:z')
+      Time.current.strftime("%Y-%m-%dT%H:%M:%S%:z")
     end
 
     def expiration_date
       # Expire the pass tomorrow
-      (Time.current + 1.day).strftime('%Y-%m-%dT%H:%M:%S%:z')
+      (Time.current + 1.day).strftime("%Y-%m-%dT%H:%M:%S%:z")
     end
 
     def semantics
@@ -121,7 +121,7 @@ module Passkit
         }]
     end
 
-  private
+    private
 
     def folder_name
       self.class.name.demodulize.underscore

data/lib/passkit/generator.rb

@@ -36,7 +36,7 @@ module Passkit
       zip_path
     end
 
-  private
+    private
 
     def check_necessary_files
       raise "icon.png is not present in #{@pass.pass_path}" unless File.exist?(File.join(@pass.pass_path, "icon.png"))

data/lib/passkit/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Passkit
-  VERSION = "0.8.1"
+  VERSION = "0.8.3"
 end

data/lib/passkit.rb

@@ -22,7 +22,7 @@ module Passkit
   end
 
   def self.configured?
-    self.configuration&.configured?
+    configuration&.configured?
   end
 
   class Configuration
@@ -68,7 +68,7 @@ module Passkit
       # Optional
       @skip_verification = false
       @web_service_host = ENV["PASSKIT_WEB_SERVICE_HOST"] || "https://localhost:3000"
-      @available_passes = { "Passkit::ExampleStoreCard" => -> {} }
+      @available_passes = {"Passkit::ExampleStoreCard" => -> {}}
       @format_version = ENV["PASSKIT_FORMAT_VERSION"] || 1
       @dashboard_username = ENV["PASSKIT_DASHBOARD_USERNAME"]
       @dashboard_password = ENV["PASSKIT_DASHBOARD_PASSWORD"]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: passkit
 version: !ruby/object:Gem::Version
-  version: 0.8.1
+  version: 0.8.3
 platform: ruby
 authors:
 - Alessandro Rodi
@@ -41,14 +41,14 @@ dependencies:
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.4'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '1.4'
 - !ruby/object:Gem::Dependency
@@ -143,14 +143,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- ".example.env"
-- ".standard.yml"
 - CHANGELOG.md
 - CODE_OF_CONDUCT.md
-- Gemfile
 - LICENSE.txt
 - README.md
-- Rakefile
 - app/assets/config/passkit_manifest.js
 - app/assets/images/passkit/add_to_apple_wallet_de.png
 - app/assets/images/passkit/add_to_apple_wallet_en.png
@@ -178,17 +174,7 @@ files:
 - app/views/passkit/dashboard/previews/index.html.erb
 - app/views/passkit/example_mailer/example_email.html.erb
 - app/views/shared/passkit/_navigation.html.erb
-- bin/console
-- bin/setup
 - config/routes.rb
-- docs/membership.png
-- docs/passkit_environment_variables.md
-- docs/step1.png
-- docs/step2.png
-- docs/step3.png
-- docs/step4.png
-- docs/step5.png
-- docs/wallet.png
 - lib/generators/passkit/install_generator.rb
 - lib/generators/templates/create_passkit_tables.rb.tt
 - lib/generators/templates/passkit.rb
@@ -235,7 +221,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.9
 specification_version: 4
 summary: Serve Wallet Passes for iOS and Android directly from your Rails app
 test_files: []

data/.example.env

@@ -1,8 +0,0 @@
-PASSKIT_WEB_SERVICE_HOST=https://localhost:3000
-PASSKIT_CERTIFICATE_KEY=theCertPassword
-PASSKIT_PRIVATE_P12_CERTIFICATE=path/to/certificate.p12
-PASSKIT_APPLE_INTERMEDIATE_CERTIFICATE=path/to/AppleWWDRCA.cer
-PASSKIT_APPLE_TEAM_IDENTIFIER=XXXXXXXXXX
-PASSKIT_PASS_TYPE_IDENTIFIER=pass.com.example.pass
-PASSKIT_DASHBOARD_USERNAME=admin
-PASSKIT_DASHBOARD_PASSWORD=admin

data/.standard.yml

@@ -1,2 +0,0 @@
-# For available configuration options, see:
-#   https://github.com/testdouble/standard

data/Gemfile

@@ -1,12 +0,0 @@
-# frozen_string_literal: true
-
-source "https://rubygems.org"
-
-# Specify your gem's dependencies in passkit.gemspec
-gemspec
-
-gem "rake", "~> 13.0"
-
-gem "minitest", "~> 5.0"
-
-gem "standard", "~> 1.3"

data/Rakefile

@@ -1,14 +0,0 @@
-# frozen_string_literal: true
-
-require "bundler/gem_tasks"
-require "rake/testtask"
-
-Rake::TestTask.new(:test) do |t|
-  t.libs << "test"
-  t.libs << "lib"
-  t.test_files = FileList["test/**/test_*.rb"]
-end
-
-require "standard/rake"
-
-task default: %i[test standard]

data/bin/console

@@ -1,15 +0,0 @@
-#!/usr/bin/env ruby
-# frozen_string_literal: true
-
-require "bundler/setup"
-require "passkit"
-
-# You can add fixtures and/or initialization code here to make experimenting
-# with your gem easier. You can also use a different console, if you like.
-
-# (If you use this, don't forget to add pry to your Gemfile!)
-# require "pry"
-# Pry.start
-
-require "irb"
-IRB.start(__FILE__)

data/bin/setup

@@ -1,8 +0,0 @@
-#!/usr/bin/env bash
-set -euo pipefail
-IFS=$'\n\t'
-set -vx
-
-bundle install
-
-# Do any other automated setup that you need to do here

data/docs/passkit_environment_variables.md

@@ -1,53 +0,0 @@
-# Setup Passkit Environment variables
-
-### `PASSKIT_WEB_SERVICE_HOST`
-
-This is the host where your Rails app is running. It is used to generate the URLs for the passes. 
-When the device wants to update the Pass, it will invoke services on this host.
-In production, it will simply be your domain name, but in development you can use [ngrok](https://ngrok.com/) to expose your local server to the internet.
-
-**Remember that it must always start with `https://`.**
-
-### `PASSKIT_APPLE_INTERMEDIATE_CERTIFICATE`
-
-This is the easy one.
-Head to https://www.apple.com/certificateauthority/ and download the latest Apple Intermediate Certificate Worldwide Developer Relations.
-You might want to choose the one with the longest expiration date. PASSKIT_APPLE_INTERMEDIATE_CERTIFICATE is the path to the certificate.
-
-### `PASSKIT_APPLE_TEAM_IDENTIFIER`
-
-You find this in your Apple Developer dashboard, under Membership.
-
-![Membership](membership.png)
-
-### `PASSKIT_PASS_TYPE_IDENTIFIER`, `PASSKIT_PRIVATE_P12_CERTIFICATE` and `PASSKIT_CERTIFICATE_KEY`
-
-Head to your Apple Developers console and generate a new certificate.
-
-![Step 1](step1.png)
-
-![Step 2](step2.png)
-
-![Step 3](step3.png)
-
-The identifier is the `PASSKIT_PASS_TYPE_IDENTIFIER` variable.
-
-**Note**: When renewing your certificate, make sure that this identifier stays the same as before. Changing this identifier will
-require existing passes to be regenerated, as they will otherwise no longer be updateable via the web service URL.
-
-Now, create a certificate signing request: https://developer.apple.com/help/account/create-certificates/create-a-certificate-signing-request/
-
-And create the certificate:
-
-![Step 4](step4.png)
-
-At the end, you'll have a `pass.cer` file.
-
-Open it in the Keychain Access tool and export it (you must be in the My Certificates tab):
-
-![Step 5](step5.png)
-
-Set a password and get your p12 file. The path to this file is the `PASSKIT_PRIVATE_P12_CERTIFICATE` variable.
-Save the password. This is the `PASSKIT_CERTIFICATE_KEY` variable.
-
-`PKCS12_parse: unsupported`: you might encounter this issue: https://help.heroku.com/88GYDTB2/how-do-i-configure-openssl-to-allow-the-use-of-legacy-cryptographic-algorithms