passfort 0.2.2 → 0.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a294b6d08bf000b4e3c3b76a7509bf5f55da3d0aa6f22e8108dd4f281105f6f4
-  data.tar.gz: '0197567a2dae8961d1cf6bed577d17753148b17f5dee37036740acc4885365f1'
+  metadata.gz: 5832d8b7e35914667cd070932413409c72ba907a9a0f66c4f371a38ad830dfe5
+  data.tar.gz: 5a78b3c88b98268f33eac8d6992b170338334f80397145ad895a21d35d0ff042
 SHA512:
-  metadata.gz: ef101eaec36d8f92d3702999aca16f1a20b1bd6286b3dcc5c75247a48f10a1d746fa3454e137dd22a9ecf3673b4150d0f5bb18c790b817b9f2400ffe9c615bf3
-  data.tar.gz: f36f1c38db985538ea6d97c378dca856c2c864d92de9eefbb41892869dab8518ff4422da02f9b3a3260d47073bd8d3357fa593775ffcdf392773d43dbb35131c
+  metadata.gz: ad1b56c1c2b447e2f43d307477677892e0c711974611b023d88c089c7e4d27bf5e468750c930173d4d7e1bb8b32a4a85763bb34923a3358277cb1f6fa9f1e87f
+  data.tar.gz: 301c2f12b9e4d148604d3b90d8642f7a05f17979641a9d9837f97e9dfb50bcce98776342e2f15924f14b8b54046d35905854644629d3d587ddb122d2f9735ea6

data/.rubocop.yml

@@ -1,2 +1,5 @@
 inherit_gem:
   gc_ruboconfig: rubocop.yml
+
+Metrics/MethodLength:
+  Max: 15

data/CHANGELOG.md

@@ -6,6 +6,11 @@ Unreleased
 
 No changes.
 
+0.2.3
+-----
+
+- Raise `Passfort::Errors::TimeoutError` when a request times out.
+
 0.2.2
 ----------
 

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    passfort (0.2.2)
+    passfort (0.2.3)
       activesupport (~> 5.0)
       excon (~> 0.60)
 
@@ -21,7 +21,7 @@ GEM
     crack (0.4.3)
       safe_yaml (~> 1.0.0)
     diff-lcs (1.3)
-    excon (0.60.0)
+    excon (0.62.0)
     gc_ruboconfig (2.3.5)
       rubocop (~> 0.54.0)
       rubocop-rspec (~> 1.24)
@@ -31,13 +31,13 @@ GEM
     method_source (0.9.0)
     minitest (5.11.3)
     parallel (1.12.1)
-    parser (2.5.0.4)
+    parser (2.5.0.5)
       ast (~> 2.4.0)
     powerpack (0.1.1)
     pry (0.11.3)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
-    public_suffix (3.0.1)
+    public_suffix (3.0.2)
     rainbow (3.0.0)
     rspec (3.7.0)
       rspec-core (~> 3.7.0)

data/lib/passfort/errors.rb

@@ -7,6 +7,7 @@ require "passfort/errors/invalid_api_key_error"
 require "passfort/errors/invalid_input_data_error"
 require "passfort/errors/request_error"
 require "passfort/errors/unparseable_response_error"
+require "passfort/errors/timeout_error"
 
 module Passfort
   module Errors

data/lib/passfort/errors/timeout_error.rb

@@ -0,0 +1,12 @@
+# frozen_string_literal: true
+
+module Passfort
+  module Errors
+    # Specific error class for when an HTTP request has timed out
+    class TimeoutError < APIError
+      def initialize
+        super("Request timed out")
+      end
+    end
+  end
+end

data/lib/passfort/http.rb

@@ -20,6 +20,8 @@ module Passfort
       body
     rescue JSON::ParserError
       raise Passfort::Errors::UnparseableResponseError.new([], response)
+    rescue Excon::Errors::Timeout
+      raise Passfort::Errors::TimeoutError
     end
 
     def post(path, body:)
@@ -33,6 +35,8 @@ module Passfort
       body
     rescue JSON::ParserError
       raise Passfort::Errors::UnparseableResponseError.new([], response)
+    rescue Excon::Errors::Timeout
+      raise Passfort::Errors::TimeoutError
     end
 
     private

data/lib/passfort/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Passfort
-  VERSION = "0.2.2"
+  VERSION = "0.2.3"
 end

data/spec/passfort/http_spec.rb

@@ -12,7 +12,7 @@ RSpec.describe Passfort::Http do
     let(:error_code) { 0 }
     let(:body) { { errors: { code: error_code } }.to_json }
 
-    before { stub_request(method, api_path). to_return(status: status, body: body) }
+    before { stub_request(method, api_path).to_return(status: status, body: body) }
 
     context "when returning a request error" do
       let(:status) { 404 }
@@ -68,6 +68,13 @@ RSpec.describe Passfort::Http do
         expect(result).to include("id" => "6c1d594a-496e-11e7-911e-acbc32b67d7b")
       end
     end
+
+    context "when the request times out" do
+      before { stub_request(method, api_path).to_raise(Excon::Errors::Timeout) }
+      let(:error_class) { Passfort::Errors::TimeoutError }
+
+      it { is_expected.to raise_error(error_class) }
+    end
   end
 
   describe "#get" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: passfort
 version: !ruby/object:Gem::Version
-  version: 0.2.2
+  version: 0.2.3
 platform: ruby
 authors:
 - GoCardless
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-03-23 00:00:00.000000000 Z
+date: 2018-03-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -135,6 +135,7 @@ files:
 - lib/passfort/errors/invalid_api_key_error.rb
 - lib/passfort/errors/invalid_input_data_error.rb
 - lib/passfort/errors/request_error.rb
+- lib/passfort/errors/timeout_error.rb
 - lib/passfort/errors/unknown_api_error.rb
 - lib/passfort/errors/unparseable_response_error.rb
 - lib/passfort/http.rb