partisan 0.4.1 → 0.4.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 698e3eb571bbe3198a67365ef8be7beb1b37acf2
-  data.tar.gz: 40db91f5461e512580f03d9afcc93391fffcd66d
+  metadata.gz: d936bacfb75a4439cfa641e0dc3f021f4eeefd0d
+  data.tar.gz: ceba8e18ebb77675bd10d141165a31321f552c8d
 SHA512:
-  metadata.gz: 9c02a2514eeb7b5b4249370c57aff22f4a587aa30e628868858b08234dd6b4df2c85eadba4cf4c9afebe1645ab3bc3dbe07f89c1a9e596e303f62be79a280ad4
-  data.tar.gz: 8eeb187a25dcdf319342860348b41408abc85e8baeb5b292cf932d699cf9e7a855b895bd48b1732ed4158391b2e507c7ca77763fc1f49e41e2ea60797eb71d9c
+  metadata.gz: 91469d38973cada18bb4ce7827e33b012b9fc55580b93cfafc24d8fad8be2a26e1b5c4cee53111704063a0afc7390fb313efbf41c7c6620c6e23cf510922d293
+  data.tar.gz: a3952e8a4e978691f966fc144bcfcb9a2c37f5056fe9e1e737b00d8893612499be3abae243fbf0399424b8c34e53a188b244660e8106e2947ca5b0809beaee40

data/.travis.yml

@@ -1,21 +1,14 @@
+sudo: false
+
 language: ruby
 
 rvm:
-  - 2.0.0
-  - 1.9.3
+  - 2.2
+  - 2.1
+  - 2.0
 
 gemfile:
+  - gemfiles/Gemfile.activerecord-4.2
   - gemfiles/Gemfile.activerecord-4.1
-  - gemfiles/Gemfile.activerecord-4.0
-  - gemfiles/Gemfile.activerecord-3.2.x
 
 script: "echo 'DO IT' && bundle exec rake spec"
-
-notifications:
-  hipchat:
-    rooms:
-      secure: "DUZC6Q2b18pEp7W7qNnGRYDgqtZGeWh44ED+hF27OIxjdM6JRx/nOmpvY46/lR6KjiH7DDM+TGPbxAzXo3rECxUZqkMPjMkqfZyfyN4JhccI/dJf1EL0GDUMogPfFUOuLWTqA49Y9GvvXTghK/irlLBhInWcrPJcTIsDG2t4nN4="
-    template:
-      - '%{repository}#%{build_number} (%{branch} - %{commit} : %{author}): %{message} (<a href="%{build_url}">Build</a>/<a href="%{compare_url}">Changes</a>)'
-    format: 'html'
-

data/LICENSE.md

@@ -1,4 +1,4 @@
-Copyright (c) 2013, Mirego
+Copyright (c) 2013-2016, Mirego
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

data/README.md

@@ -56,6 +56,10 @@ end
 class Band < ActiveRecord::Base
   acts_as_followable
 end
+
+class Follow < ActiveRecord::Base
+  acts_as_follow
+end
 ```
 
 And follow/unfollow other records!
@@ -140,9 +144,15 @@ The available callbacks are:
 | `before_being_unfollowed` | `self.about_to_by_unfollowed_by` |
 | `after_being_unfollowed`  | `self.just_unfollowed_by`        |
 
+## Contributors
+
+* [@simonprev](https://github.com/simonprev)
+* [@remiprev](https://github.com/remiprev)
+* [@jdurand](https://github.com/jdurand)
+
 ## License
 
-`Partisan` is © 2013 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/partisan/blob/master/LICENSE.md) file.
+`Partisan` is © 2013-2016 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/partisan/blob/master/LICENSE.md) file.
 
 ## About Mirego
 

data/gemfiles/{Gemfile.activerecord-3.2.x → Gemfile.activerecord-4.2}

@@ -2,4 +2,4 @@ source 'https://rubygems.org'
 
 gemspec path: '../'
 
-gem 'activerecord', '~> 3.2.0'
+gem 'activerecord', '~> 4.2.0'

data/lib/generators/partisan/templates/migration.rb

@@ -4,11 +4,12 @@ class AddFollowsMigration < ActiveRecord::Migration
       t.references :followable, polymorphic: true
       t.references :follower, polymorphic: true
 
-      t.timestamps
+      t.timestamps null: false
     end
 
-    add_index :follows, ['follower_id', 'follower_type'],     name: 'index_partisan_followers'
+    add_index :follows, ['follower_id', 'follower_type'], name: 'index_partisan_followers'
     add_index :follows, ['followable_id', 'followable_type'], name: 'index_partisan_followables'
+    add_index :follows, ['follower_id', 'follower_type', 'followable_id', 'follower_type'], name: 'index_partisan_unique_follow', unique: true
   end
 
   def down

data/lib/partisan/follow.rb

@@ -30,8 +30,8 @@ module Partisan
   protected
 
     def update_follow_counter
-      follower.update_follower_counter
-      followable.update_followable_counter
+      follower.update_followings_counter
+      followable.update_followers_counter
     end
 
     def around_create_follower(&blk)

data/lib/partisan/followable.rb

@@ -52,7 +52,7 @@ module Partisan
 
     # Update cache counter
     # Called in after_create and after_destroy
-    def update_followable_counter
+    def update_followers_counter
       self.update_attribute('followers_count', self.followings.count) if self.respond_to?(:followers_count)
     end
 

data/lib/partisan/follower.rb

@@ -96,7 +96,7 @@ module Partisan
 
     # Update cache counter
     # Called in after_create and after_destroy
-    def update_follower_counter
+    def update_followings_counter
       self.update_attribute('followings_count', self.follows.count) if self.respond_to?(:followings_count)
     end
 

data/lib/partisan/version.rb

@@ -1,3 +1,3 @@
 module Partisan
-  VERSION = '0.4.1'
+  VERSION = '0.4.2'
 end

data/spec/partisan/followable_spec.rb

@@ -4,7 +4,10 @@ describe Partisan::Followable do
   before do
     run_migration do
       create_table(:fans, force: true)
-      create_table(:users, force: true)
+      create_table(:users, force: true) do |t|
+        t.integer :followings_count, default: 0
+        t.integer :followers_count, default: 0
+      end
       create_table(:concerts, force: true)
 
       create_table(:bands, force: true) do |t|
@@ -13,13 +16,14 @@ describe Partisan::Followable do
     end
 
     follower 'Fan'
-    follower 'User'
+    followable_and_follower 'User'
     followable 'Band'
     followable 'Concert'
   end
 
   let(:band) { Band.create }
   let(:user) { User.create }
+  let(:user2) { User.create }
   let(:concert) { Concert.create }
   let(:fan) { Fan.create }
 
@@ -127,5 +131,14 @@ describe Partisan::Followable do
 
       it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(user) }
     end
+
+    describe :update_followings_counter do
+      before do
+        user.follow user2
+        user.reload
+      end
+
+      it { expect(user.followings_count).to eq 1 }
+    end
   end
 end

data/spec/partisan/follower_spec.rb

@@ -21,18 +21,6 @@ describe Partisan::Follower do
   let(:user2) { User.create }
   let(:concert) { Concert.create }
 
-  describe :UserToUser do
-    before do
-      user.follow user2
-
-      user.reload
-      user2.reload
-    end
-
-    it { expect(user.followings_count).to eq 1 }
-    it { expect(user2.followers_count).to eq 1 }
-  end
-
   describe :InstanceMethods do
     before do
       user.follow band
@@ -150,6 +138,15 @@ describe Partisan::Follower do
 
       it { expect{ user.unfollow(band) }.to change{ Buffer.tmp_value }.to(band) }
     end
+
+    describe :update_followers_counter do
+      before do
+        user.follow user2
+        user2.reload
+      end
+
+      it { expect(user2.followers_count).to eq 1 }
+    end
   end
 
   describe :AliasMethods do

data/spec/spec_helper.rb

@@ -2,6 +2,7 @@ $:.unshift File.expand_path('../lib', __FILE__)
 
 require 'rspec'
 require 'sqlite3'
+require 'delegate'
 
 require 'partisan'
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: partisan
 version: !ruby/object:Gem::Version
-  version: 0.4.1
+  version: 0.4.2
 platform: ruby
 authors:
 - Simon Prévost
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-12-10 00:00:00.000000000 Z
+date: 2016-01-04 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -98,9 +98,8 @@ files:
 - LICENSE.md
 - README.md
 - Rakefile
-- gemfiles/Gemfile.activerecord-3.2.x
-- gemfiles/Gemfile.activerecord-4.0
 - gemfiles/Gemfile.activerecord-4.1
+- gemfiles/Gemfile.activerecord-4.2
 - lib/generators/partisan/USAGE
 - lib/generators/partisan/install_generator.rb
 - lib/generators/partisan/templates/migration.rb
@@ -139,7 +138,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.2.2
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Partisan is a Ruby library that allows ActiveRecord records to be follower

data/gemfiles/Gemfile.activerecord-4.0

@@ -1,5 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '../'
-
-gem 'activerecord', '~> 4.0.0'