partigi-partigirb 0.2.1 → 0.2.2

data/VERSION

@@ -1 +1 @@
-0.2.1
+0.2.2

data/lib/partigirb/client.rb

@@ -4,9 +4,8 @@ module Partigirb
     attr_accessor :id 
   end
   
-  #Raised by methods which call the API if a non-200 response status is received 
+  # Raised by methods which call the API if a non-200 response status is received 
   class PartigiError < StandardError
-    attr_accessor :response_object
   end
   
   class Client
@@ -129,7 +128,7 @@ module Partigirb
       
       begin
         if res.code.to_i != 200
-          handle_error_response(res, Partigirb::Handlers::XMLHandler)
+          handle_error_response(res, Partigirb::Handlers::XMLHandler.new)
         else
           fmt_handler.decode_response(res.body)
         end
@@ -138,9 +137,10 @@ module Partigirb
     
     # TODO: Test for errors
     def handle_error_response(res, handler)
-      err = Partigirb::PartigiError.new
-      err.response_object = handler.decode_response(res.body)
-      raise err        
+      # Response for errors is an XML document containing an error tag as a root,
+      # having a text node with error name. As XMLHandler starts building the Struct
+      # on root node the returned value from the handler will always be the error name text.
+      raise PartigiError.new(handler.decode_response(res.body))
     end
     
     def format_invocation?(name)

data/partigirb.gemspec

@@ -2,11 +2,11 @@
 
 Gem::Specification.new do |s|
   s.name = %q{partigirb}
-  s.version = "0.2.1"
+  s.version = "0.2.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Alvaro Bautista", "Fernando Blat"]
-  s.date = %q{2009-07-24}
+  s.date = %q{2009-07-27}
   s.email = ["alvarobp@gmail.com", "ferblape@gmail.com"]
   s.extra_rdoc_files = [
     "LICENSE",

data/test/client_test.rb

@@ -174,6 +174,17 @@ class ClientTest < Test::Unit::TestCase
     @client.items.json
   end  
   
+  should "raise a PartigiError with response error text as the message when http response codes are other than 200" do
+   client = new_client(400, "<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n<error>Partigi::BadAPIRequestRequiredParams</error>\n")
+   
+   begin
+     client.items.show.xml :id => 'madeup'
+   rescue Exception => e
+     assert e.is_a?(Partigirb::PartigiError)
+     assert_equal 'Partigi::BadAPIRequestRequiredParams', e.message
+   end
+  end
+  
   # Copied from Grackle
   should "clear the request path on clear" do
     client = new_client(200,'[{"id":1,"text":"test 1"}]')

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification 
 name: partigi-partigirb
 version: !ruby/object:Gem::Version 
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors: 
 - Alvaro Bautista
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2009-07-24 00:00:00 -07:00
+date: 2009-07-27 00:00:00 -07:00
 default_executable: 
 dependencies: []
 
@@ -53,6 +53,7 @@ files:
 - test/xml_handler_test.rb
 has_rdoc: true
 homepage: http://github.com/partigi/partigirb
+licenses: 
 post_install_message: 
 rdoc_options: 
 - --charset=UTF-8
@@ -73,7 +74,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.2.0
+rubygems_version: 1.3.5
 signing_key: 
 specification_version: 2
 summary: TODO