partially_useful 0.0.3 → 0.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: db0acb9e7170ecf76a2213e54eefd5cfed8757d4
-  data.tar.gz: 875aa5b5f1697f7b724437cf2b533109cd4bdccc
+  metadata.gz: c946ba0664ecb0b799fa878beb56ae454aac2840
+  data.tar.gz: 376bba8c028629234928b5283a5094d233b4b23b
 SHA512:
-  metadata.gz: a6304798312b259f8cb05c8af760c54d29dde1c7c457e97850e784f28d6d4218931ee003b8bd0b6bd6acf4cfb3f725a4742aa6a9c0e246094a1855432b7b26df
-  data.tar.gz: 544a40ae37f3b85d031c1bcf3540ec5e62342c9d5ce1f7df88242574f9fa65836a69edcfe155f93c40d55ed3c6c76de272bd2f5589a40fced7e4dbf6b8924e04
+  metadata.gz: 8edaaa45a616ee17fc2921a1778bfdd852efc9827cda85a130fc716cbfdb6e075acfcc0896340903b42740b0a41270ee59a16f9bff4ee376b663b0ba7303e724
+  data.tar.gz: 8b4d25a75fc210cfa8903c9a1673cff20170a2c5070a5f78da2042a13cb931c5e90de872ce8b881c729d0ca3ea1313dbe433cb8bb50d2d21d758df4a2c4097b4

data/.travis.yml

@@ -1,5 +1,7 @@
 script: "bundle exec rake"
 rvm:
+  - jruby-19mode
+  - 1.9.3
   - 2.0.0
   - 2.1.0
   - 2.1.1

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+# 0.1.0
+
+* support for 1.9.3 and jruby (no more Module#prepend)
+
 # 0.0.3
 
 * clarification for ruby version

data/Gemfile.lock

@@ -1,22 +1,22 @@
 PATH
   remote: .
   specs:
-    partially_useful (0.0.2)
+    partially_useful (0.0.3)
       railties (~> 4.0)
 
 GEM
   remote: https://rubygems.org/
   specs:
-    actionpack (4.1.0)
-      actionview (= 4.1.0)
-      activesupport (= 4.1.0)
+    actionpack (4.1.1)
+      actionview (= 4.1.1)
+      activesupport (= 4.1.1)
       rack (~> 1.5.2)
       rack-test (~> 0.6.2)
-    actionview (4.1.0)
-      activesupport (= 4.1.0)
+    actionview (4.1.1)
+      activesupport (= 4.1.1)
       builder (~> 3.1)
       erubis (~> 2.7.0)
-    activesupport (4.1.0)
+    activesupport (4.1.1)
       i18n (~> 0.6, >= 0.6.9)
       json (~> 1.7, >= 1.7.7)
       minitest (~> 5.1)
@@ -26,22 +26,25 @@ GEM
     erubis (2.7.0)
     i18n (0.6.9)
     json (1.8.1)
+    json (1.8.1-java)
     minitest (5.3.3)
     rack (1.5.2)
     rack-test (0.6.2)
       rack (>= 1.0)
-    railties (4.1.0)
-      actionpack (= 4.1.0)
-      activesupport (= 4.1.0)
+    railties (4.1.1)
+      actionpack (= 4.1.1)
+      activesupport (= 4.1.1)
       rake (>= 0.8.7)
       thor (>= 0.18.1, < 2.0)
     rake (10.3.1)
     thor (0.19.1)
     thread_safe (0.3.3)
+    thread_safe (0.3.3-java)
     tzinfo (1.1.0)
       thread_safe (~> 0.1)
 
 PLATFORMS
+  java
   ruby
 
 DEPENDENCIES

data/README.md

@@ -1,10 +1,12 @@
 # PartiallyUseful
 
-[![Build Status](https://img.shields.io/travis/phoet/partially_useful/master.svg)](https://travis-ci.org/phoet/asin)
+[![Build Status](https://img.shields.io/travis/phoet/partially_useful/master.svg)](https://travis-ci.org/phoet/partially_useful)
 
-When looking at a rendered html page, it's often hard to tell where the code of a partial lives inside the views directory.
+HTML source code is very verbose and can be a pain in the ass to find a specific part on big pages.
 
-Surrounds rendered partials with html-comments in order to simplify the process of finding the proper file.
+Finding the origin of a piece of HTML in the Rails `app/views` directory can be tedious and error prone.
+
+Adding this gem to your Rails application adds HTML comments at development time, so it's easy to find the right partials.
 
 ```html
 <!-- start rendering 'some_partial' with locals '[:all, :assigned, :locals]'-->
@@ -26,13 +28,19 @@ gem 'partially_useful', group: 'development'
 
 ## Usage
 
-The plugin is enabled by default, buy you can disable it in your rails configuration:
+The plugin is enabled by default, but you can disable it in your Rails configuration:
 
 ```ruby
 # config/environments/development.rb
 config.partially_useful = false
 ```
 
+## Caveats
+
+HTML comments might subtly break your application when partials are used out of the usual HTML rendering context (JS, CSS etc).
+
+If you run into any problems, make sure to disable the gem and restart your Rails server.
+
 ## Supported Ruby versions
 
 See .travis.yml

data/lib/partially_useful/partial_renderer.rb

@@ -1,8 +1,13 @@
 module PartiallyUseful
   module PartialRenderer
+    def self.included(klass)
+      klass.send :alias_method, :original_rails_render, :render
+      klass.send :remove_method, :render
+    end
+
     def render(context, options, block)
       msg = "rendering '#{options[:partial]}' with locals '#{(options[:locals] || {}).keys}'"
-      "<!-- start #{msg}-->\n#{super(context, options, block)}\n<!-- end #{msg}-->\n".html_safe
+      "<!-- start #{msg}-->\n#{original_rails_render(context, options, block)}\n<!-- end #{msg}-->\n".html_safe
     end
   end
 end

data/lib/partially_useful/railtie.rb

@@ -4,7 +4,7 @@ module PartiallyUseful
 
     initializer :partially_useful do |app|
       if app.config.partially_useful
-        ActionView::PartialRenderer.send(:prepend, PartiallyUseful::PartialRenderer)
+        ActionView::PartialRenderer.send(:include, PartiallyUseful::PartialRenderer)
       end
     end
   end

data/lib/partially_useful/version.rb

@@ -1,3 +1,3 @@
 module PartiallyUseful
-  VERSION = "0.0.3"
+  VERSION = "0.1.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: partially_useful
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.1.0
 platform: ruby
 authors:
 - phoet
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-05-16 00:00:00.000000000 Z
+date: 2014-05-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: railties
@@ -146,4 +146,3 @@ test_files:
 - test/dummy/public/favicon.ico
 - test/partially_useful_test.rb
 - test/test_helper.rb
-has_rdoc: