partial_ks 0.3.0 → 0.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 06691f65e761fb70acf6be46198ceb5a9a9a4e6e
-  data.tar.gz: 955603f6c2ab9d7ab18a43162fc0bd0713ac9f2a
+  metadata.gz: 27cf67a4ac72c019e9ce39c13be6949746d319cb
+  data.tar.gz: c8aaa05cf43a2c2a3bbc0d5076147ee2593f1d35
 SHA512:
-  metadata.gz: 8b8788884ee10d5ba69e64415322fda35bf6420bb98e80e1c7b379ef6afe739fea7d26b7b114b6570c6fb96c854ef222123163d2ed1ddfcbe2366f1a33b03715
-  data.tar.gz: 48674b2d662fe3aab19c35aec9c25d5ce371e1bfa430bcd08150bf8e5783d96e2fb01df73a66e4d1c459a77687fc4a13c12d8dfda22aceca5aa336f094e8f064
+  metadata.gz: 41c5e26c8792bc97720b97aae22da1f4f0ca39014fc7e99b3eb20529557ffeb1dedd2015b164174acca8bf66a683ea0f2cd167b425bff7b04c237ab0c8f55873
+  data.tar.gz: 4cbdfbb74cfb845bba856ff2db9bfead21222f42cb61df535404cb3b9b959ad44f8f56880615e9cf7c41770030ca6d15bf221828428e36fffd4b9e59d035bf6d

data/CHANGES.md

@@ -1,5 +1,9 @@
 # Changelog
 
+# 0.4.0
+
+Allow lambdas to be used as a custom filter
+
 # 0.3.0
 
 No functionality changes but specify restrictions already observed in gemspec

data/CONTRIBUTING.md

@@ -1,10 +1,25 @@
-Tested with activerecord 4.2.7.1, 4.2.8 and 5.0.1 (on Ruby 2.2.3)
+This document should tell all you need to know for contributing to this project.
+
+# Testing
+
+Tested with activerecord 4.2.7.1, 4.2.8 and 5.0.1 (on Ruby 2.3.3)
 
 
 To install and run tests :
 
 ```
 rm Gemfile.lock
-ACTIVERECORD_VERSION="~4.2.8" bundle
+ACTIVERECORD_VERSION="~> 4.2.8" bundle
 bundle exec rake
 ```
+
+# Design
+
+Partial KS is meant to run on *two* databases : the source DB and the target DB.
+
+The building of the filter is done on the target DB.
+  - Hence, instructions for a table *cannot* be run until all data for its parent
+    table is fully downloaded onto the target DB.
+
+Filters are run on the source DB.
+  - Note that a SQL statement from the target DB will behave differently on the source DB.

data/README.md

@@ -20,7 +20,7 @@ You can specify manual configurations if needed.
 
 ```
 manual_configuration = [
-  [User, nil, User.where(:id => [1])],     # specify a subset of users. as users have no parent, specify `nil`
+  [User, nil, -> { User.where(:id => [1]) }],     # specify a subset of users. as users have no parent, specify `nil`
   [BlogPost, User]                         # filter blog_posts by User
 ]
 ```

data/lib/partial_ks/filtered_table.rb

@@ -25,10 +25,12 @@ module PartialKs
     end
 
     def filter_based_on_custom_filter_relation
-      if custom_filter_relation.is_a?(ActiveRecord::Relation) || custom_filter_relation.respond_to?(:where_sql)
-        custom_filter_relation.where_sql.to_s.sub(where_regexp, "")
-      elsif custom_filter_relation.is_a?(String)
-        custom_filter_relation.sub(where_regexp, "")
+      relation = custom_filter_relation.respond_to?(:call) ? custom_filter_relation.call : custom_filter_relation
+
+      if relation.is_a?(ActiveRecord::Relation) || relation.respond_to?(:where_sql)
+        relation.where_sql.to_s.sub(where_regexp, "")
+      elsif relation.is_a?(String)
+        relation.sub(where_regexp, "")
       end
     end
 

data/lib/partial_ks/version.rb

@@ -1,3 +1,3 @@
 module PartialKs
-  VERSION = '0.3.0'
+  VERSION = '0.4.0'
 end

data/test/filtered_table_test.rb

@@ -21,6 +21,12 @@ describe "kitchen sync filter" do
     filtered_table.kitchen_sync_filter.must_equal({"only" => '"post_tags"."id" IN (1, 2)'})
   end
 
+  it "uses the filter inside a lambda" do
+    filter = -> { PostTag.where(:id => [1, 2]) }
+    filtered_table = PartialKs::FilteredTable.new(table, nil, custom_filter_relation: filter)
+    filtered_table.kitchen_sync_filter.must_equal({"only" => '"post_tags"."id" IN (1, 2)'})
+  end
+
   it "uses a SQL where fragment as a filter if provided" do
     string_filter = "1=0"
     filtered_table = PartialKs::FilteredTable.new(table, nil, custom_filter_relation: string_filter)

data/test/runner_test.rb

@@ -35,7 +35,7 @@ describe 'running based on output from generator' do
   end
 
   it "yields all table names" do
-    expected_table_names = generator_output.map(&:table_name)
+    expected_table_names = [User, Tag, BlogPost].map(&:table_name)
     actual_table_names   = []
     runner.run! do |tables_to_filter, table_names|
       actual_table_names += table_names
@@ -45,7 +45,7 @@ describe 'running based on output from generator' do
   end
 
   it "yields all non-null filters" do
-    expected_filters     = generator_output.each_with_object({}) {|ft, hash| hash[ft.table_name] = ft.kitchen_sync_filter if ft.kitchen_sync_filter}
+    expected_filters     = [User, BlogPost].map(&:table_name)
     actual_filters       = {}
 
     runner.run! do |tables_to_filter, table_names|
@@ -53,8 +53,8 @@ describe 'running based on output from generator' do
     end
 
     actual_filters.size.must_equal expected_filters.size
-    actual_filters.keys.must_equal expected_filters.keys
-    expected_filters.each do |table_name, filter_condition|
+    actual_filters.keys.must_equal expected_filters
+    expected_filters.each do |table_name|
       actual_filters[table_name]["only"].must_be_kind_of String
     end
   end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: partial_ks
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.4.0
 platform: ruby
 authors:
 - Thong Kuah
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-25 00:00:00.000000000 Z
+date: 2017-03-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -52,8 +52,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-description: |
-  A library to use kitchen-sync to sync a subset of your database
+description: 'A library to use kitchen-sync to sync a subset of your database
+
+'
 email: kuahyeow@gmail.com
 executables: []
 extensions: []
@@ -104,7 +105,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.2
 signing_key: 
 specification_version: 4
 summary: Partial KS