parse_packwerk 0.18.2 → 0.19.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 674c8a13d849b72a052c6624b6a700a902579c917d2670da62a965c4944801dd
-  data.tar.gz: 91ae13980be718d98c96c77a8b1caf5cc3c9a5c05a700522f6189c57d61bdc0e
+  metadata.gz: 4ccc04b5202c680f618fb55fa776cd19898dc5e126ec20ae1a0457366637f302
+  data.tar.gz: 1332bbf45c911be1795602b20d2b6642682b3a2c46adc57d7602da1eea4b2599
 SHA512:
-  metadata.gz: d854c12addbf7826864bec2cf9d7bbb990030c9c0d852f76b4efe33eab36ec5d8d139b44430bed86236e8d7e31ff24c6ae933817995cf8712f82a867f7e2567a
-  data.tar.gz: c01c719aba0bb2a1cc4e49931436882a442fbd4d0f1b2ed64cea7a08cb4caa370c7aa93a55590cab96e716d76df158f7b53b41732af21e51f8e6eefdae7a79d1
+  metadata.gz: e917cbf8dc1e687eb3478cccfa16818adfed51676a4c64d17552c795518349906fdf93fcd1bf20dd7afc24db11596db6874fb3073c76f5ff23d83d6ad37174e1
+  data.tar.gz: d4ae625347c3dce180b658c1b2e36dddcd816db1ca7110d5e474145dcf4b936b2755a95b013eb44da06650e1f8660fd7810882419235f147596130d4ae3f97fa

data/lib/parse_packwerk/configuration.rb

@@ -6,6 +6,7 @@ module ParsePackwerk
 
     const :exclude, T::Array[String]
     const :package_paths, T::Array[String]
+    const :requires, T::Array[String]
 
     sig { returns(Configuration) }
     def self.fetch
@@ -21,6 +22,7 @@ module ParsePackwerk
       Configuration.new(
         exclude: excludes(raw_packwerk_config),
         package_paths: package_paths(raw_packwerk_config),
+        requires: raw_packwerk_config['require'] || []
       )
     end
 

data/lib/parse_packwerk/extensions.rb

@@ -0,0 +1,19 @@
+# typed: strict
+
+module ParsePackwerk
+  module Extensions
+    extend T::Sig
+
+    sig { returns(T::Boolean) }
+    def self.all_extensions_installed?
+      ParsePackwerk.yml.requires.include?('packwerk-extensions')
+    end
+
+    sig { returns(T::Boolean) }
+    def self.privacy_extension_installed?
+      all_extensions_installed? || ParsePackwerk.yml.requires.include?('packwerk/privacy/checker')
+    end
+  end
+
+  private_constant :Extensions
+end

data/lib/parse_packwerk/package.rb

@@ -6,7 +6,7 @@ module ParsePackwerk
 
     const :name, String
     const :enforce_dependencies, T.any(T::Boolean, String)
-    const :enforce_privacy, T.any(T::Boolean, String)
+    const :enforce_privacy, T.any(T::Boolean, String), default: false
     const :public_path, String, default: DEFAULT_PUBLIC_PATH
     const :metadata, MetadataYmlType
     const :dependencies, T::Array[String]
@@ -15,12 +15,16 @@ module ParsePackwerk
     sig { params(pathname: Pathname).returns(Package) }
     def self.from(pathname)
       package_loaded_yml = YAML.load_file(pathname)
+      if package_loaded_yml.nil? || package_loaded_yml == false
+        message = "Failed to parse `#{pathname}`. Please fix any issues with this package.yml OR add its containing folder to packwerk.yml `exclude`"
+        raise PackageParseError.new(message)
+      end
       package_name = pathname.dirname.cleanpath.to_s
 
       new(
         name: package_name,
         enforce_dependencies: package_loaded_yml[ENFORCE_DEPENDENCIES],
-        enforce_privacy: package_loaded_yml[ENFORCE_PRIVACY],
+        enforce_privacy: package_loaded_yml[ENFORCE_PRIVACY] || false,
         public_path: package_loaded_yml[PUBLIC_PATH] || DEFAULT_PUBLIC_PATH,
         metadata: package_loaded_yml[METADATA] || {},
         dependencies: package_loaded_yml[DEPENDENCIES] || [],

data/lib/parse_packwerk.rb

@@ -9,8 +9,12 @@ require 'parse_packwerk/package_todo'
 require 'parse_packwerk/package'
 require 'parse_packwerk/configuration'
 require 'parse_packwerk/package_set'
+require 'parse_packwerk/extensions'
 
 module ParsePackwerk
+  class PackageParseError < StandardError
+  end
+
   class MissingConfiguration < StandardError
     extend T::Sig
 
@@ -57,10 +61,11 @@ module ParsePackwerk
     File.open(package.yml, 'w') do |file|
       merged_config = package.config
 
-      merged_config.merge!(
-        'enforce_dependencies' => package.enforce_dependencies,
-        'enforce_privacy' => package.enforce_privacy
-      )
+      merged_config.merge!('enforce_dependencies' => package.enforce_dependencies,)
+
+      if Extensions.privacy_extension_installed?
+        merged_config.merge!('enforce_privacy' => package.enforce_privacy)
+      end
 
       # We want checkers of the form `enforce_xyz` to be at the top
       merged_config_arr = merged_config.sort_by do |k, v|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parse_packwerk
 version: !ruby/object:Gem::Version
-  version: 0.18.2
+  version: 0.19.1
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-03-13 00:00:00.000000000 Z
+date: 2023-05-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
@@ -133,6 +133,7 @@ files:
 - lib/parse_packwerk.rb
 - lib/parse_packwerk/configuration.rb
 - lib/parse_packwerk/constants.rb
+- lib/parse_packwerk/extensions.rb
 - lib/parse_packwerk/package.rb
 - lib/parse_packwerk/package_set.rb
 - lib/parse_packwerk/package_todo.rb