parse_packwerk 0.17.0 → 0.18.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 15bfbc3e8c8f9231a7e0c82ede3394bb05386abc71daa19febb3c86250597476
-  data.tar.gz: 2a976526390b78391b76130958e41729c6a8e0122be5f97c8322ae9642a2a753
+  metadata.gz: f712a4dfa471ea4f8652058277e83355306f809c224d3dde98ec68a960b4b89b
+  data.tar.gz: e0f7148f0cdb4a8d8a39dc07eb5ff7c27c45ababd49a46b6067f09751f2bbf91
 SHA512:
-  metadata.gz: d697a84ba9180443e4dd19a0bdfb7ff30970434fb4754a0648bbdaa3e7fa0c54a244e4bd16d13b43f437855e2f439ca1d7b1a072514f3fcb0882c64e85aabf7a
-  data.tar.gz: 56dad6bdaab9066b5bc9b0d8396212ab6befc66438ce5aec5d7475c271b3e86fe0f911efba815980afd3c5ea6d5187ad0712b6e36cbdfe0a033c940db38481f8
+  metadata.gz: 0f6e92205d265558bd11cfd5cff0739ce467d86ad896279be9718f032de0271f158943c03205d73c133f47295133feb9b32c2a1ffb4927521c1f772d5a433a8b
+  data.tar.gz: 133974d86d034cfcea559f60892a2b5183f0885309b23e05176ef29fb4f91a43e287054145b7044df6837bf88423ec8c11466f594f5e9e30400fe21b006901ad

data/lib/parse_packwerk/package.rb

@@ -10,6 +10,7 @@ module ParsePackwerk
     const :public_path, String, default: DEFAULT_PUBLIC_PATH
     const :metadata, MetadataYmlType
     const :dependencies, T::Array[String]
+    const :config, T::Hash[T.untyped, T.untyped]
 
     sig { params(pathname: Pathname).returns(Package) }
     def self.from(pathname)
@@ -18,11 +19,12 @@ module ParsePackwerk
 
       new(
         name: package_name,
-        enforce_dependencies: package_loaded_yml[ENFORCE_DEPENDENCIES] ? true : false,
-        enforce_privacy: package_loaded_yml[ENFORCE_PRIVACY] ? true : false,
+        enforce_dependencies: package_loaded_yml[ENFORCE_DEPENDENCIES],
+        enforce_privacy: package_loaded_yml[ENFORCE_PRIVACY],
         public_path: package_loaded_yml[PUBLIC_PATH] || DEFAULT_PUBLIC_PATH,
         metadata: package_loaded_yml[METADATA] || {},
-        dependencies: package_loaded_yml[DEPENDENCIES] || []
+        dependencies: package_loaded_yml[DEPENDENCIES] || [],
+        config: package_loaded_yml,
       )
     end
 

data/lib/parse_packwerk.rb

@@ -53,44 +53,42 @@ module ParsePackwerk
   sig { params(package: ParsePackwerk::Package).void }
   def self.write_package_yml!(package)
     FileUtils.mkdir_p(package.directory)
+    
     File.open(package.yml, 'w') do |file|
-      # We do not use `YAML.dump` or `contents.to_yaml` because it seems like packwerk writes a variation of the default YAML spec.
-      # If you'd like to see the difference, change this to `package_yaml = YAML.dump(contents)` to and run tests to see the difference.
-      package_yml = <<~PACKAGEYML
-        enforce_dependencies: #{package.enforces_dependencies?}
-        enforce_privacy: #{package.enforces_privacy?}
-      PACKAGEYML
+      merged_config = package.config
+
+      merged_config.merge!(
+        'enforce_dependencies' => package.enforce_dependencies,
+        'enforce_privacy' => package.enforce_privacy
+      )
+
+      # We want checkers of the form `enforce_xyz` to be at the top
+      merged_config_arr = merged_config.sort_by do |k, v|
+        if k.include?('enforce')
+          0
+        else
+          1
+        end
+      end
+
+      merged_config = merged_config_arr.to_h
 
       unless package.public_path == DEFAULT_PUBLIC_PATH
-        public_path = <<~PUBLICPATH
-          public_path: #{package.public_path}
-        PUBLICPATH
-        package_yml += public_path
+        merged_config.merge!('public_path' => package.public_path)
       end
 
       if package.dependencies.any?
-        dependencies = <<~STATEDDEPS
-          dependencies:
-          #{package.dependencies.map { |dep| "  - #{dep}" }.join("\n")}
-        STATEDDEPS
-
-        package_yml += dependencies
+        merged_config.merge!('dependencies' => package.dependencies)
       end
 
-      if package.metadata.keys.any?
-        raw_yaml = YAML.dump(package.metadata)
-        stylized_yaml = raw_yaml.gsub("---\n", '')
-        indented_yaml = stylized_yaml.split("\n").map { |line| "  #{line}" }.join("\n")
-
-        metadata = <<~METADATA
-          metadata:
-          #{indented_yaml}
-        METADATA
-
-        package_yml += metadata
+      if package.metadata.any?
+        merged_config.merge!('metadata' => package.metadata)
       end
-
-      file.write(package_yml)
+      raw_yaml = YAML.dump(merged_config)
+      # Add indentation for dependencies
+      raw_yaml.gsub!(/^- /,"  - ")
+      stylized_yaml = raw_yaml.gsub("---\n", '')
+      file.write(stylized_yaml)
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parse_packwerk
 version: !ruby/object:Gem::Version
-  version: 0.17.0
+  version: 0.18.1
 platform: ruby
 authors:
 - Gusto Engineers
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-12-15 00:00:00.000000000 Z
+date: 2023-03-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: sorbet-runtime
@@ -137,10 +137,6 @@ files:
 - lib/parse_packwerk/package_set.rb
 - lib/parse_packwerk/package_todo.rb
 - lib/parse_packwerk/violation.rb
-- sorbet/config
-- sorbet/rbi/gems/hashdiff@1.0.1.rbi
-- sorbet/rbi/gems/rspec@3.10.0.rbi
-- sorbet/rbi/gems/rspec_override.rbi
 homepage: https://github.com/rubyatscale/parse_packwerk
 licenses:
 - MIT

data/sorbet/config

@@ -1,3 +0,0 @@
---dir
-.
---ignore=/vendor/bundle

data/sorbet/rbi/gems/hashdiff@1.0.1.rbi

@@ -1,82 +0,0 @@
-# DO NOT EDIT MANUALLY
-# This is an autogenerated file for types exported from the `hashdiff` gem.
-# Please instead update this file by running `bin/tapioca sync`.
-
-# typed: true
-
-module Hashdiff
-  class << self
-    def best_diff(obj1, obj2, options = T.unsafe(nil), &block); end
-    def comparable?(obj1, obj2, strict = T.unsafe(nil)); end
-    def compare_values(obj1, obj2, options = T.unsafe(nil)); end
-    def count_diff(diffs); end
-    def count_nodes(obj); end
-    def custom_compare(method, key, obj1, obj2); end
-    def decode_property_path(path, delimiter = T.unsafe(nil)); end
-    def diff(obj1, obj2, options = T.unsafe(nil), &block); end
-    def diff_array_lcs(arraya, arrayb, options = T.unsafe(nil)); end
-    def lcs(arraya, arrayb, options = T.unsafe(nil)); end
-    def node(hash, parts); end
-    def patch!(obj, changes, options = T.unsafe(nil)); end
-    def prefix_append_array_index(prefix, array_index, opts); end
-    def prefix_append_key(prefix, key, opts); end
-    def similar?(obja, objb, options = T.unsafe(nil)); end
-    def unpatch!(obj, changes, options = T.unsafe(nil)); end
-
-    private
-
-    def any_hash_or_array?(obja, objb); end
-  end
-end
-
-class Hashdiff::CompareHashes
-  class << self
-    def call(obj1, obj2, opts = T.unsafe(nil)); end
-  end
-end
-
-class Hashdiff::LcsCompareArrays
-  class << self
-    def call(obj1, obj2, opts = T.unsafe(nil)); end
-  end
-end
-
-class Hashdiff::LinearCompareArray
-  def initialize(old_array, new_array, options); end
-
-  def call; end
-
-  private
-
-  def additions; end
-  def append_addition(item, index); end
-  def append_addititions_before_match(match_index); end
-  def append_deletion(item, index); end
-  def append_deletions_before_match(match_index); end
-  def append_differences(difference); end
-  def changes; end
-  def compare_at_index; end
-  def deletions; end
-  def differences; end
-  def expected_additions; end
-  def expected_additions=(_arg0); end
-  def extra_items_in_new_array?; end
-  def extra_items_in_old_array?; end
-  def index_of_match_after_additions; end
-  def index_of_match_after_deletions; end
-  def item_difference(old_item, new_item, item_index); end
-  def iterated_through_both_arrays?; end
-  def new_array; end
-  def new_index; end
-  def new_index=(_arg0); end
-  def old_array; end
-  def old_index; end
-  def old_index=(_arg0); end
-  def options; end
-
-  class << self
-    def call(old_array, new_array, options = T.unsafe(nil)); end
-  end
-end
-
-Hashdiff::VERSION = T.let(T.unsafe(nil), String)

data/sorbet/rbi/gems/rspec@3.10.0.rbi

@@ -1,34 +0,0 @@
-# DO NOT EDIT MANUALLY
-# This is an autogenerated file for types exported from the `rspec` gem.
-# Please instead update this file by running `bin/tapioca sync`.
-
-# typed: true
-
-module RSpec
-  class << self
-    def clear_examples; end
-    def configuration; end
-    def configuration=(_arg0); end
-    def configure; end
-    def const_missing(name); end
-    def context(*args, &example_group_block); end
-    def current_example; end
-    def current_example=(example); end
-    def describe(*args, &example_group_block); end
-    def example_group(*args, &example_group_block); end
-    def fcontext(*args, &example_group_block); end
-    def fdescribe(*args, &example_group_block); end
-    def reset; end
-    def shared_context(name, *args, &block); end
-    def shared_examples(name, *args, &block); end
-    def shared_examples_for(name, *args, &block); end
-    def world; end
-    def world=(_arg0); end
-    def xcontext(*args, &example_group_block); end
-    def xdescribe(*args, &example_group_block); end
-  end
-end
-
-RSpec::MODULES_TO_AUTOLOAD = T.let(T.unsafe(nil), Hash)
-module RSpec::Version; end
-RSpec::Version::STRING = T.let(T.unsafe(nil), String)

data/sorbet/rbi/gems/rspec_override.rbi

@@ -1,4 +0,0 @@
-module RSpec
-  module Matchers
-  end
-end