parse_date 0.4.2 → 0.4.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 184d14ddbda19e12229fd0b245505ee8a0891593bade0e99ca44d51603b3fa90
-  data.tar.gz: 293f5d385495c6fca24b94445d22a9680affa2a4cd50cf47b19733a12b612656
+  metadata.gz: 60c444ed79ea6842f49bfb44d2adc5bd1a6790d483fe43e0bd4a0880001a6005
+  data.tar.gz: a62f906a4c908c4b774ef9fe1dae2a047deee79ee6569688d1c2db9796bb3b2e
 SHA512:
-  metadata.gz: d8aca40d9e0ad5ccab88e589120a6009a4116026e6501974eb63bf13e7be018677ba581352b84d72f1ea288fbb8fd120a7717a85ce40770e289b97dbf695940e
-  data.tar.gz: e7c14cf9101f297982104c4aa5fe23597ee3932134770cd829ca38c67f4118b1c280962719a01f9f30dc917e01f9c076b7a909f157633cce842466218a9dd2b6
+  metadata.gz: a949b307fb3259f1a20fa279aa2af395137b514b35b15dbce8c63701047462b06b5b6cb31723f25dbef2c8f1db249cf8e95914d92c113dd4439ed6737267878f
+  data.tar.gz: e1e3e154a6bc4851a7aafa199da3ee66e0d4b7d5d27537528cee36d2f0b2f80761fbbffffa1d2a544ca4a204f4fd7816f85a6d0b975824fff06cead4d64cf3f2

data/.github/pull_request_template.md

@@ -1,4 +1,12 @@
 ## Why was this change made?
 
 
-## Was the documentation (README, API, wiki, ...) updated?
+
+## How was this change tested?
+
+
+
+## Which documentation and/or configurations were updated?
+
+
+

data/.rubocop.yml

@@ -1,7 +1,7 @@
 inherit_from: .rubocop_todo.yml
 
-AllCops:
-  TargetRubyVersion: 2.6
+Gemspec/RequiredRubyVersion:
+  Enabled: false
 
 Layout/EmptyLinesAroundClassBody:
   Enabled: false
@@ -9,23 +9,28 @@ Layout/EmptyLinesAroundClassBody:
 Layout/EmptyLinesAroundModuleBody:
   Enabled: false
 
+Layout/LineLength:
+  Exclude:
+    - parse_date.gemspec
+
+Lint/MixedRegexpCaptureTypes:
+  Enabled: false
+
 Metrics/BlockLength:
   Exclude:
     - spec/**/*
 
-Metrics/LineLength:
-  Max: 120
-
 Metrics/MethodLength:
   Max: 15
-  ExcludedMethods:
-    - earliest_year
-    - latest_year
 
 Metrics/ModuleLength:
   Exclude:
     - lib/parse_date/int_from_string.rb
 
+Style/Documentation:
+  Exclude:
+    - lib/parse_date.rb
+
 Style/NumericLiterals:
   Enabled: false
 
@@ -42,3 +47,64 @@ Style/WordArray:
 
 Style/YodaCondition:
   Enabled: false
+
+Gemspec/DateAssignment: # (new in 1.10)
+  Enabled: true
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: true
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: true
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: true
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: true
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: true
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+Style/HashConversion: # (new in 1.10)
+  Enabled: true
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: true
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+Style/StringChars: # (new in 1.12)
+  Enabled: true
+Style/SwapValues: # (new in 1.1)
+  Enabled: true

data/.rubocop_todo.yml

@@ -1,42 +1,7 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2019-11-06 14:49:31 -0800 using RuboCop version 0.74.0.
+# on 2021-03-26 19:20:09 UTC using RuboCop version 1.12.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 5
-Metrics/AbcSize:
-  Max: 45
-
-# Offense count: 4
-Metrics/CyclomaticComplexity:
-  Max: 12
-
-# Offense count: 4
-Metrics/PerceivedComplexity:
-  Max: 12
-
-# Offense count: 2
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/parse_date.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedOctalStyle.
-# SupportedOctalStyles: zero_with_o, zero_only
-Style/NumericLiteralPrefix:
-  Exclude:
-    - 'spec/parse_date/int_from_string_spec.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, AllowInnerSlashes.
-# SupportedStyles: slashes, percent_r, mixed
-Style/RegexpLiteral:
-  Exclude:
-    - 'lib/parse_date/int_from_string.rb'

data/README.md

@@ -1,5 +1,5 @@
 [![Gem Version](https://badge.fury.io/rb/parse_date.svg)](https://badge.fury.io/rb/parse_date)
-[![Build Status](https://travis-ci.org/sul-dlss/parse_date.svg?branch=master)](https://travis-ci.org/sul-dlss/parse_date)
+[![Build Status](https://travis-ci.com/sul-dlss/parse_date.svg?branch=main)](https://travis-ci.com/sul-dlss/parse_date)
 [![Maintainability](https://api.codeclimate.com/v1/badges/2d006b4ccb3100434f4a/maintainability)](https://codeclimate.com/github/sul-dlss/parse_date/maintainability)
 [![Test Coverage](https://api.codeclimate.com/v1/badges/2d006b4ccb3100434f4a/test_coverage)](https://codeclimate.com/github/sul-dlss/parse_date/test_coverage)
 

data/lib/parse_date.rb

@@ -65,6 +65,8 @@ class ParseDate
   # @param [Integer, String] first_year, expecting integer or parseable string for .to_i
   # @param [Integer, String] last_year, expecting integer or parseable string for .to_i
   # @return [Array] array of Integer year values from first to last, inclusive
+  # rubocop:disable Metrics/CyclomaticComplexity
+  # rubocop:disable Metrics/PerceivedComplexity
   def self.range_array(first_year, last_year)
     first_year = first_year.to_i if first_year.is_a?(String) && first_year.match?(/^-?\d+$/)
     last_year = last_year.to_i if last_year.is_a?(String) && last_year.match?(/^-?\d+$/)
@@ -77,4 +79,6 @@ class ParseDate
 
     Range.new(first_year, last_year).to_a
   end
+  # rubocop:enable Metrics/CyclomaticComplexity
+  # rubocop:enable Metrics/PerceivedComplexity
 end

data/lib/parse_date/int_from_string.rb

@@ -1,7 +1,5 @@
 # frozen_string_literal: true
 
-require 'date' # so upstream callers don't have to require it
-
 class ParseDate
 
   # Parse (Year) Integers from Date Strings
@@ -20,24 +18,15 @@ class ParseDate
       return if date_str == '0000-00-00' # shpc collection has these useless dates
 
       # B.C. first (match longest string first)
-      return ParseDate.send(:earliest_century_bc, date_str) if date_str.match(YY_YY_CENTURY_BC_REGEX)
-      return ParseDate.send(:between_bc_earliest_year, date_str) if date_str.match(BETWEEN_Yn_AND_Yn_BC_REGEX)
-      return ParseDate.send(:year_int_for_bc, date_str) if date_str.match(YEAR_BC_REGEX)
+      bc_result = ParseDate.send(:earliest_year_bc_parsing, date_str)
+      return bc_result if bc_result
 
-      result ||= ParseDate.send(:between_earliest_year, date_str)
-      result ||= ParseDate.send(:hyphen_4digit_earliest_year, date_str)
-      result ||= ParseDate.send(:negative_first_four_digits, date_str)
-      result ||= ParseDate.send(:first_four_digits, date_str)
-      result ||= ParseDate.send(:year_from_mm_dd_yy, date_str)
-      result ||= ParseDate.send(:first_year_for_decade, date_str) # 198x or 201x
-      result ||= ParseDate.send(:first_year_for_century, date_str) # includes BC
-      result ||= ParseDate.send(:year_for_early_numeric, date_str)
-      unless result
-        # try removing brackets between digits in case we have 169[5] or [18]91
-        no_brackets = ParseDate.send(:remove_brackets, date_str)
-        return earliest_year(no_brackets) if no_brackets
-      end
-      result.to_i if result && year_int_valid?(result.to_i)
+      result = ParseDate.send(:earliest_year_parsing, date_str)
+      return result if result
+
+      # try removing brackets between digits in case we have 169[5] or [18]91
+      no_brackets = ParseDate.send(:remove_brackets, date_str)
+      earliest_year(no_brackets) if no_brackets
     end
 
     # latest year as Integer if we can parse one from date_str
@@ -53,32 +42,15 @@ class ParseDate
       return if date_str == '0000-00-00' # shpc collection has these useless dates
 
       # B.C. first (match longest string first)
-      return ParseDate.send(:last_year_mult_centuries_bc, date_str) if date_str.match(YY_YY_CENTURY_BC_REGEX)
-      return ParseDate.send(:between_bc_latest_year, date_str) if date_str.match(BETWEEN_Yn_AND_Yn_BC_REGEX)
-      return ParseDate.send(:last_year_for_bc_century, date_str) if date_str.match(BC_CENTURY_REGEX)
-      return ParseDate.send(:year_int_for_bc, date_str) if date_str.match(BC_REGEX)
+      bc_result = ParseDate.send(:latest_year_bc_parsing, date_str)
+      return bc_result if bc_result
 
-      result ||= ParseDate.send(:between_latest_year, date_str)
-      result ||= ParseDate.send(:hyphen_4digit_latest_year, date_str)
-      result ||= ParseDate.send(:hyphen_2digit_latest_year, date_str)
-      result ||= ParseDate.send(:hyphen_1digit_latest_year, date_str)
-      result ||= ParseDate.send(:yyuu_after_hyphen, date_str)
-      result ||= ParseDate.send(:year_after_or, date_str)
-      result ||= ParseDate.send(:negative_4digits_after_hyphen, date_str)
-      result ||= ParseDate.send(:negative_first_four_digits, date_str)
-      result ||= ParseDate.send(:last_year_for_0s_decade, date_str)
-      result ||= ParseDate.send(:first_four_digits, date_str)
-      result ||= ParseDate.send(:year_from_mm_dd_yy, date_str)
-      result ||= ParseDate.send(:last_year_for_decade, date_str) # 198x or 201x
-      result ||= ParseDate.send(:last_year_mult_centuries, date_str) # nth-nth century
-      result ||= ParseDate.send(:last_year_for_century, date_str)
-      result ||= ParseDate.send(:last_year_for_early_numeric, date_str)
-      unless result
-        # try removing brackets between digits in case we have 169[5] or [18]91
-        no_brackets = ParseDate.send(:remove_brackets, date_str)
-        return latest_year(no_brackets) if no_brackets
-      end
-      result.to_i if result && year_int_valid?(result.to_i)
+      result = ParseDate.send(:latest_year_parsing, date_str)
+      return result if result
+
+      # try removing brackets between digits in case we have 169[5] or [18]91
+      no_brackets = ParseDate.send(:remove_brackets, date_str)
+      latest_year(no_brackets) if no_brackets
     end
 
     # true if the year is between -9999 and (current year + 1), inclusive
@@ -91,9 +63,68 @@ class ParseDate
 
     protected
 
+    def earliest_year_bc_parsing(date_str)
+      return ParseDate.send(:earliest_century_bc, date_str) if date_str.match(YY_YY_CENTURY_BC_REGEX)
+      return ParseDate.send(:between_bc_earliest_year, date_str) if date_str.match(BETWEEN_Yn_AND_Yn_BC_REGEX)
+      return ParseDate.send(:year_int_for_bc, date_str) if date_str.match(YEAR_BC_REGEX)
+    end
+
+    def earliest_year_parsing(date_str)
+      [
+        # longest string first, more or less
+        :between_earliest_year,
+        :hyphen_4digit_earliest_year,
+        :negative_first_four_digits,
+        :first_four_digits,
+        :year_from_mm_dd_yy,
+        :first_year_for_decade, # 198x or 201x
+        :first_year_for_century, # includes some BC
+        :year_for_early_numeric
+      ].each do |method_name|
+        result = ParseDate.send(method_name, date_str)
+        return result.to_i if result && year_int_valid?(result.to_i)
+      end
+      nil
+    end
+
+    def latest_year_bc_parsing(date_str)
+      return ParseDate.send(:last_year_mult_centuries_bc, date_str) if date_str.match(YY_YY_CENTURY_BC_REGEX)
+      return ParseDate.send(:between_bc_latest_year, date_str) if date_str.match(BETWEEN_Yn_AND_Yn_BC_REGEX)
+      return ParseDate.send(:last_year_for_bc_century, date_str) if date_str.match(BC_CENTURY_REGEX)
+      return ParseDate.send(:year_int_for_bc, date_str) if date_str.match(BC_REGEX)
+    end
+
+    # rubocop:disable Metrics/MethodLength
+    def latest_year_parsing(date_str)
+      result = nil
+      [
+        # longest string first, more or less
+        :between_latest_year,
+        :hyphen_4digit_latest_year,
+        :hyphen_2digit_latest_year,
+        :hyphen_1digit_latest_year,
+        :yyuu_after_hyphen,
+        :year_after_or,
+        :negative_4digits_after_hyphen,
+        :negative_first_four_digits,
+        :last_year_for_0s_decade,
+        :first_four_digits,
+        :year_from_mm_dd_yy,
+        :last_year_for_decade, # 198x or 201x
+        :last_year_mult_centuries, # nth-nth century
+        :last_year_for_century,
+        :last_year_for_early_numeric
+      ].each do |method|
+        result ||= ParseDate.send(method, date_str)
+        return result.to_i if result && year_int_valid?(result.to_i)
+      end
+      nil
+    end
+    # rubocop:enable Metrics/MethodLength
+
     REGEX_OPTS = Regexp::IGNORECASE | Regexp::MULTILINE
     BC_REGEX = Regexp.new(/\s*B\.?\s*C\.?/im)
-    BRACKETS_BETWEEN_DIGITS_REGEX = Regexp.new('\d[' + Regexp.escape('[]') + ']\d')
+    BRACKETS_BETWEEN_DIGITS_REGEX = Regexp.new("\\d[#{Regexp.escape('[]')}]\\d")
 
     # removes brackets between digits such as 169[5] or [18]91
     def remove_brackets(date_str)
@@ -206,13 +237,13 @@ class ParseDate
     # looks for -yyyy at beginning of date_str and returns if found
     # @return [String, nil] negative 4 digit year (e.g. -1865) if date_str has -yyyy, nil otherwise
     def negative_first_four_digits(date_str)
-      Regexp.last_match(1) if date_str.match(/^(\-\d{4})/)
+      Regexp.last_match(1) if date_str.match(/^(-\d{4})/)
     end
 
     # looks for -yyyy after hyphen and returns if found
     # @return [String, nil] negative 4 digit year (e.g. -1865) if date_str has -yyyy - -yyyy, nil otherwise
     def negative_4digits_after_hyphen(date_str)
-      Regexp.last_match(1) if date_str.match(/\-\d{4}\s*(?:-|–|–|or|to)\s*(\-\d{4})/)
+      Regexp.last_match(1) if date_str.match(/-\d{4}\s*(?:-|–|–|or|to)\s*(-\d{4})/)
     end
 
     # looks for 4 consecutive digits in date_str and returns first occurrence if found
@@ -228,7 +259,7 @@ class ParseDate
     #   1/1/27  ->  1927
     # @return [String, nil] 4 digit year (e.g. 1865, 0950) if date_str matches pattern, nil otherwise
     def year_from_mm_dd_yy(date_str)
-      slash_matches = date_str.match(/\d{1,2}\/\d{1,2}\/\d{2}/)
+      slash_matches = date_str.match(%r{\d{1,2}/\d{1,2}/\d{2}})
       if slash_matches
         date_obj = Date.strptime(date_str, '%m/%d/%y')
       else
@@ -247,7 +278,7 @@ class ParseDate
     # @return [String, nil] 4 digit year (e.g. 1869, 1959) if date_str matches pattern, nil otherwise
     def last_year_for_0s_decade(date_str)
       decade_matches = date_str.match(DECADE_0S_REGEX)
-      changed_to_nine = decade_matches.to_s.sub(/0\'?s/, '9') if decade_matches
+      changed_to_nine = decade_matches.to_s.sub(/0'?s/, '9') if decade_matches
       ParseDate.first_four_digits(changed_to_nine) if changed_to_nine
     end
 
@@ -277,12 +308,14 @@ class ParseDate
 
     # first year of century if we have:  yyuu, yy--, yy--? or xxth century pattern; handles B.C.
     # @return [Integer, nil] yy00 if date_str matches pattern, nil otherwise
+    # rubocop:disable Metrics/AbcSize
     def first_year_for_century(date_str)
       return Regexp.last_match(1).to_i * -100 - 99 if date_str.match(BC_CENTURY_REGEX)
       return Regexp.last_match(1).to_i * 100 if date_str.match(CENTURY_4CHAR_REGEX)
       return (Regexp.last_match(:first).to_i - 1) * 100 if date_str.match(YY_YY_CENTURY_REGEX)
       return (Regexp.last_match(1).to_i - 1) * 100 if date_str.match(CENTURY_WORD_REGEX)
     end
+    # rubocop:enable Metrics/AbcSize
 
     # last year of century if we have:  yyuu, yy--, yy--? or xxth century pattern
     # @return [Integer, nil] yy99 if date_str matches pattern, nil otherwise; also nil if B.C. in pattern
@@ -344,7 +377,7 @@ class ParseDate
     end
 
     FIRST_LAST_EARLY_NUMERIC_REGEX =
-      Regexp.new(/^(?<first>\-?\d{1,3})\??\s*(-|–|–|or|to)\s*(?<last>\-?\d{1,4})\??([^\du\-\[]|$)/im)
+      Regexp.new(/^(?<first>-?\d{1,3})\??\s*(-|–|–|or|to)\s*(?<last>-?\d{1,4})\??([^\du\-\[]|$)/im)
 
     # Integer value for latest year if we have early numeric year range or single early numeric year
     # @return [Integer, nil] year if date_str matches pattern; nil otherwise

data/lib/parse_date/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 class ParseDate
-  VERSION = '0.4.2'
+  VERSION = '0.4.3'
 end

data/parse_date.gemspec

@@ -32,8 +32,9 @@ Gem::Specification.new do |spec|
 
   spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'pry-byebug'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0.3'
   spec.add_development_dependency 'rspec', '~> 3.0'
-  spec.add_development_dependency 'rubocop', '~> 0.74.0'
-  spec.add_development_dependency 'simplecov'
+  spec.add_development_dependency 'rubocop', '~> 1.12'
+  spec.add_development_dependency 'rubocop-rspec'
+  spec.add_development_dependency 'simplecov', '~> 0.17.1' # CodeClimate cannot use SimpleCov >= 0.18.0 for generating test coverage
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parse_date
 version: !ruby/object:Gem::Version
-  version: 0.4.2
+  version: 0.4.3
 platform: ruby
 authors:
 - Naomi Dushay
-autorequire: 
+autorequire:
 bindir: exe
 cert_chain: []
-date: 2019-11-06 00:00:00.000000000 Z
+date: 2021-03-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: zeitwerk
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 13.0.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 13.0.3
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
@@ -86,16 +86,16 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: '1.12'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: '1.12'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -108,6 +108,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.17.1
 description: Get normalized date values for searching, faceting and display (e.g.
   in Solr search engine)
 email:
@@ -138,7 +152,7 @@ metadata:
   allowed_push_host: https://rubygems.org/
   homepage_uri: https://github.com/sul-dlss/parse_date
   source_code_uri: https://github.com/sul-dlss/parse_date
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -153,8 +167,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
-signing_key: 
+rubygems_version: 3.2.3
+signing_key:
 specification_version: 4
 summary: parse date values out of strings and normalize them
 test_files: []