parole 0.1.3 → 0.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: def12cc4e8ebdfb3f39c397a95eef9443af3822f
-  data.tar.gz: a7addb2a86084f9267e34de818f1f9f20d59745c
+  metadata.gz: 838fd260344d7edc5895fdb763bf4c620916096f
+  data.tar.gz: 38e7429fd0ea23bc0b95f92154c779624225c007
 SHA512:
-  metadata.gz: 3d9e9c53c499ace305e53f61f1e2c2f0f6deebeff566bd1b4f7849e774f1ba8373e29ed3e3c52fe0e958863b6eeeb3b4c51c96874ff3e6e3b24a6d1378d32bfc
-  data.tar.gz: cf0aea744c44063f9f4c15a35f9805e243071dc93433174026bd9d1bed125e106830c9bc3c3d695adde127b56198cd8af6730b9b07e3c5a74312f22902b033dd
+  metadata.gz: f0c2609fa1850536ceae8464d4ff7a2f4084ca7a2128715dfedc1ffc639f8957e2221153f5b883ebd436c111ccaa26d5d16203b5905146bb3a02e445c9a26c38
+  data.tar.gz: 0b45b10e8f8626506bb981e02ee5b7ff5feb362d112d0183a9c6692ad142972b23f072bc6738fd2efe0d2f90d17411294331746da1860941e67b9345de2aa8ef

data/.travis.yml

@@ -8,3 +8,11 @@ gemfile:
   - gemfiles/Gemfile.activerecord-4.0
 
 script: "echo 'DO IT' && bundle exec rake spec"
+
+notifications:
+  hipchat:
+    rooms:
+      secure: "kgVFUfn1gDlKVX9kIWC7AWaxhBa+nLI9R9I25BcvvbqstMVtQAEu5qfKYUvFGDlYU7R9lSNiwz55nGxAnr7izh1dLd40phlBTWH0tWx6QvjQ14M4xwWYoLjj+rif2izR3lEZS+rJdVYNfUjocVHUnDiFQqH3gZzyfETmQGOwR6k="
+    template:
+      - '%{repository}#%{build_number} (%{branch} - %{commit} : %{author}): %{message} (<a href="%{build_url}">Build</a>/<a href="%{compare_url}">Changes</a>)'
+    format: 'html'

data/CHANGELOG.md

@@ -0,0 +1,5 @@
+# Parole Changelog
+
+## v0.1.4
+
+* Add cache counter for commenter model

data/LICENSE.md

@@ -1,4 +1,4 @@
-Copyright (c) 2013, Mirego
+Copyright (c) 2013-2015, Mirego
 All rights reserved.
 
 Redistribution and use in source and binary forms, with or without

data/README.md

@@ -5,11 +5,12 @@
   <br />
   Parole adds the ability to comment on ActiveRecord records.
   <br /><br />
-  <a href="https://rubygems.org/gems/parole"><img src="https://badge.fury.io/rb/parole.png" /></a>
-  <a href="https://codeclimate.com/github/mirego/parole"><img src="https://codeclimate.com/github/mirego/parole.png" /></a>
-  <a href="https://travis-ci.org/mirego/parole"><img src="https://travis-ci.org/mirego/parole.png?branch=master" /></a>
+  <a href="https://rubygems.org/gems/parole"><img src="http://img.shields.io/gem/v/parole.svg" /></a>
+  <a href="https://codeclimate.com/github/mirego/parole"><img src="http://img.shields.io/codeclimate/github/mirego/parole.svg" /></a>
+  <a href="https://travis-ci.org/mirego/parole"><img src="http://img.shields.io/travis/mirego/parole.svg" /></a>
 </p>
 
+
 ---
 
 ## Installation
@@ -63,17 +64,23 @@ article.comments.count # => 1
 
 ### Cache counters
 
-Whenever a comment is created or destroyed, Parole looks into the commentable record and check
-if there’s a `<role>_comments_count` column and/or a `comments_count` column. If so, it updates
-them so they reflect the total number of comments and the number of comments of this role for
-the record.
+Whenever a comment is created or destroyed, Parole looks into the commentable record and the commenter
+record and check if there’s a `<role>_comments_count` column and/or a `comments_count` column.
+If so, it updates them so they reflect the total number of comments and the number of comments
+of this role for the record.
+
+_Note:_ The commenter model must implements a `has_many` relationship that fetch its comments.
 
-So let’s say the `Article` model has the following columns: `photos_comments_count`, `videos_comments_count` and `comments_count`.
+So let’s say the `Article` model has the following columns: `photos_comments_count`, `videos_comments_count` and `comments_count`,
+and the `User` model has the following column: `comments_count`.
 
 ```ruby
 class Article < ActiveRecord::Base
   acts_as_commentable roles: [:photos, :videos]
 end
+class User < ActiveRecord::Base
+  has_many :comments, -> { where(commenter_type: 'User') }, foreign_key: :commenter_id
+end
 
 user = User.find(1)
 article = Article.find(1)
@@ -82,19 +89,21 @@ article.photos_comments.create(commenter: user, comment: 'Hello world!')
 article.photos_comments_count # => 1
 article.videos_comments_count # => 0
 article.comments_count # => 1
+user.comments_count # => 1
 
 article.videos_comments.create(commenter: user, comment: 'Hello world again!')
 article.photos_comments_count # => 1
 article.videos_comments_count # => 1
 article.comments_count # => 2
+user.comments_count # => 2
 ```
 
 ## License
 
-`Parole` is © 2013 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/parole/blob/master/LICENSE.md) file.
+`Parole` is © 2013-2015 [Mirego](http://www.mirego.com) and may be freely distributed under the [New BSD license](http://opensource.org/licenses/BSD-3-Clause).  See the [`LICENSE.md`](https://github.com/mirego/parole/blob/master/LICENSE.md) file.
 
 ## About Mirego
 
-Mirego is a team of passionate people who believe that work is a place where you can innovate and have fun. We proudly build mobile applications for [iPhone](http://mirego.com/en/iphone-app-development/ "iPhone application development"), [iPad](http://mirego.com/en/ipad-app-development/ "iPad application development"), [Android](http://mirego.com/en/android-app-development/ "Android application development"), [Blackberry](http://mirego.com/en/blackberry-app-development/ "Blackberry application development"), [Windows Phone](http://mirego.com/en/windows-phone-app-development/ "Windows Phone application development") and [Windows 8](http://mirego.com/en/windows-8-app-development/ "Windows 8 application development") in beautiful Quebec City.
+[Mirego](http://mirego.com) is a team of passionate people who believe that work is a place where you can innovate and have fun. We're a team of [talented people](http://life.mirego.com) who imagine and build beautiful Web and mobile applications. We come together to share ideas and [change the world](http://mirego.org).
 
-We also love [open-source software](http://open.mirego.com/) and we try to extract as much code as possible from our projects to give back to the community.
+We also [love open-source software](http://open.mirego.com) and we try to give back to the community as much as we can.

data/lib/parole/comment.rb

@@ -24,19 +24,28 @@ module Parole
     # Update the commentable cache counter columns
     #
     # Look for a `<role>_comments_count` and a `comments_count` column
-    # in the commentable model and update their value with the count.
+    # in the commentable model and the commenter model and update their value with the count.
     def update_cache_counters
+      commenter_has_comments = commenter.respond_to?(:comments)
+
       role_method = :"#{self.role}_comments_count="
       if commentable.respond_to?(role_method)
         commentable.send role_method, commentable.comments.where(role: self.role).count
       end
+      if commenter_has_comments && commenter.respond_to?(role_method)
+        commenter.send role_method, commenter.comments.where(role: self.role).count
+      end
 
       total_method = :comments_count=
       if commentable.respond_to?(total_method)
         commentable.send total_method, commentable.comments.count
       end
+      if commenter_has_comments && commenter.respond_to?(total_method)
+        commenter.send total_method, commenter.comments.count
+      end
 
       commentable.save(validate: false)
+      commenter.save(validate: false)
     end
 
     # Make sure that the value of the `role` attribute is a valid role

data/lib/parole/version.rb

@@ -1,3 +1,3 @@
 module Parole
-  VERSION = '0.1.3'
+  VERSION = '0.1.4'
 end

data/spec/parole/comment_spec.rb

@@ -124,13 +124,19 @@ describe Parole::Comment do
     describe :update_cache_counters do
       before do
         spawn_comment_model
-        spawn_commenter_model 'User'
+        spawn_commenter_model 'User' do
+          has_many :comments, -> { where(commenter_type: 'User') }, foreign_key: :commenter_id
+        end
         spawn_commentable_model 'Article' do
           acts_as_commentable roles: [:photos, :videos]
         end
 
         run_migration do
-          create_table(:users, force: true)
+          create_table(:users, force: true) do |t|
+            t.integer :photos_comments_count, default: 0
+            t.integer :videos_comments_count, default: 0
+            t.integer :comments_count, default: 0
+          end
           create_table(:articles, force: true) do |t|
             t.integer :photos_comments_count, default: 0
             t.integer :videos_comments_count, default: 0
@@ -143,9 +149,15 @@ describe Parole::Comment do
       let(:commentable) { Article.create }
       let(:create_comment!) { commentable.photos_comments.create(commenter: commenter, comment: 'Booya') }
 
+      # Commentable cache counter
       it { expect { create_comment! }.to change { commentable.reload.photos_comments_count }.from(0).to(1) }
       it { expect { create_comment! }.to_not change { commentable.reload.videos_comments_count } }
       it { expect { create_comment! }.to change { commentable.reload.comments_count }.from(0).to(1) }
+
+      # Commenter cache counter
+      it { expect { create_comment! }.to change { commenter.reload.photos_comments_count }.from(0).to(1) }
+      it { expect { create_comment! }.to_not change { commenter.reload.videos_comments_count } }
+      it { expect { create_comment! }.to change { commenter.reload.comments_count }.from(0).to(1) }
     end
   end
 

metadata

@@ -1,97 +1,97 @@
 --- !ruby/object:Gem::Specification
 name: parole
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Rémi Prévost
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-08 00:00:00.000000000 Z
+date: 2015-04-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '2.14'
 - !ruby/object:Gem::Dependency
   name: activerecord
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: 4.0.0
 description: Parole adds the ability to comment on ActiveRecord models.
@@ -101,9 +101,10 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
-- .gitignore
-- .rspec
-- .travis.yml
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
+- CHANGELOG.md
 - Gemfile
 - LICENSE.md
 - README.md
@@ -133,17 +134,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.1.0
+rubygems_version: 2.4.5
 signing_key: 
 specification_version: 4
 summary: Parole adds the ability to comment on ActiveRecord models.