parliament-grom-decorators 0.18.0 → 0.19.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a37464b31a1038a3b556533191d1c290a8914399
-  data.tar.gz: 4dc6e7f0c32b3bac054a4de54ee9aa383943f63e
+  metadata.gz: 742d93ef812fedee07314bb1ada949b19f74f792
+  data.tar.gz: 70597d5d914cbb9a69616b01212bc0d0fa19196c
 SHA512:
-  metadata.gz: 219c237c04e747ffaa0ef2ebad94d011cdbfb7f1d58e4b681dcb72ea55826edbb3f1cad05261268b4a7b5b06da87ae5b0696128dab8e188a9ac803ecb106eca5
-  data.tar.gz: df53ce058ebca4e96954a98c5e10d9374fff1c6e12b9a515dbb86406c04b9d97bdcd42978461c2f507d4dd3de7e6b5501cedee7cb7ee0a4000cb638835515789
+  metadata.gz: a7d9fad3a90a6a24f4a8f9dd0992362c7d0da67590c1841d0c78cc0f6092932e40330e697ad21c56328c0a77f371c72bb3d13ca89d8675f0e83c0575cea03b16
+  data.tar.gz: 531e1e5af2dd78b77bee189157393601f70c54755251a518737f1075fe069b2c5e91c4d9067a52c9e8e8d48f7710fb6d75c474d364102bef6b571c204cbd193b

data/lib/parliament/grom/decorator/contact_point.rb

@@ -3,32 +3,36 @@ module Parliament
     module Decorator
       # Decorator namespace for Grom::Node instances with type: https://id.parliament.uk/schema/ContactPoint
       module ContactPoint
+        # A hack has been added to postal_addresses, email, phone_number and fax_number
+        # to remove any details that are less than ATTRIBUTE_LENGTH_LIMIT_HACK in length
+        # including "." and "-" addresses when these have been mistakenly entered into Mnis
+        ATTRIBUTE_LENGTH_LIMIT_HACK = 1
         # Alias contactPointHasPostalAddress with fallback.
         #
         # @return [Array, Array] an array of the postal addresses for the Grom::Node or an empty array.
         def postal_addresses
-          respond_to?(:contactPointHasPostalAddress) ? contactPointHasPostalAddress : []
+          @postal_addresses ||= respond_to?(:contactPointHasPostalAddress) ? contactPointHasPostalAddress.reject { |address| address.full_address.length <= ATTRIBUTE_LENGTH_LIMIT_HACK } : []
         end
 
         # Alias email with fallback.
         #
         # @return [String, String] the email of the Grom::Node or an empty string.
         def email
-          instance_variable_get('@email'.to_sym).nil? ? '' : instance_variable_get('@email'.to_sym)
+          @email_decorator ||= instance_variable_get('@email'.to_sym) && instance_variable_get('@email'.to_sym).length > ATTRIBUTE_LENGTH_LIMIT_HACK ? instance_variable_get('@email'.to_sym).strip : ''
         end
 
         # Alias phoneNumber with fallback.
         #
         # @return [String, String] the phone number of the Grom::Node or an empty string.
         def phone_number
-          respond_to?(:phoneNumber) ? phoneNumber : ''
+          @phone_number ||= respond_to?(:phoneNumber) && phoneNumber.length > ATTRIBUTE_LENGTH_LIMIT_HACK ? phoneNumber : ''
         end
 
         # Alias faxNumber with fallback.
         #
         # @return [String, String] the fax number of the Grom::Node or an empty string.
         def fax_number
-          respond_to?(:faxNumber) ? faxNumber : ''
+          @fax_number ||= respond_to?(:faxNumber) && faxNumber.length > ATTRIBUTE_LENGTH_LIMIT_HACK ? faxNumber : ''
         end
 
         # Alias contactPointHasPerson with fallback.

data/lib/parliament/grom/decorator/version.rb

@@ -1,7 +1,7 @@
 module Parliament
   module Grom
     module Decorator
-      VERSION = '0.18.0'.freeze
+      VERSION = '0.19.0'.freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parliament-grom-decorators
 version: !ruby/object:Gem::Version
-  version: 0.18.0
+  version: 0.19.0
 platform: ruby
 authors:
 - Rebecca Appleyard
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-03-12 00:00:00.000000000 Z
+date: 2018-03-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler