paratrooper 2.3.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 74b8eb08a58894b414fa18f4606c28d484e33fe3
-  data.tar.gz: 9748e2ca46f3dee5317501278f6b53c1fc57ffa0
+  metadata.gz: af4cf12a15977e47b772161b7acb99494f710126
+  data.tar.gz: 01d567099249dafbbb418a3f6882265222ed1b03
 SHA512:
-  metadata.gz: 647ec0a0781443343560a2fcc0339d11da6d28c8c337775519461a84e811fecaea883c26edfb496eb3d7fd382ca2dab23f9bfc1973e59bb2da9fcc24cc30c314
-  data.tar.gz: d0babc17feeab3f6a8350284057de3cffcd0e296ccc5c109f05b90ed9487e6b0656b353373c050fe7d4e0d516c4ec0da6ae9c3a63efe380180a13ff4139c8f67
+  metadata.gz: 8c3a3302dbf94762959b00613c4ae66a58978460d40ebbff6cbac49907cd6dc20c81cb5e4af0a2f3f2c4c446c4d7250b99329e90ac67f77b5e9215754a94299f
+  data.tar.gz: 8d2a914587895cd37dedaaa5e7c4bf32e76aea5658d091f227839c5685891365c41f8074dca1fda214582a461953fce09b6b579498603ad7ddb60a1548257104

data/CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## 2.4.0
+
+- Maintenance mode only runs around migrations now
+- README updates around maintenance_mode=
+
 ## 2.3.0
 
 - Http calls no longer being made from system cURL

data/README.md

@@ -155,9 +155,8 @@ namespace :deploy do
   desc 'Deploy app in production environment'
   task :production do
     deployment = Paratrooper::Deploy.new("amazing-production-app") do |deploy|
-      deploy.tag              = 'production',
-      deploy.match_tag        = 'staging',
-      deploy.maintenance_mode = !ENV['NO_MAINTENANCE']
+      deploy.tag              = 'production'
+      deploy.match_tag        = 'staging'
     end
 
     deployment.deploy

data/lib/paratrooper/deploy.rb

@@ -106,6 +106,12 @@ module Paratrooper
       end
     end
 
+    def maintenance_mode(&block)
+      activate_maintenance_mode
+      block.call if block_given?
+      deactivate_maintenance_mode
+    end
+
     # Public: Creates a git tag and pushes it to repository.
     #
     def update_repo_tag
@@ -178,12 +184,12 @@ module Paratrooper
     # Alias: #deploy
     def default_deploy
       setup
-      activate_maintenance_mode
       update_repo_tag
       push_repo
-      run_migrations
-      app_restart
-      deactivate_maintenance_mode
+      maintenance_mode do
+        run_migrations
+        app_restart
+      end
       warm_instance
       teardown
     end

data/lib/paratrooper/pending_migration_check.rb

@@ -11,13 +11,19 @@ module Paratrooper
     end
 
     def migrations_waiting?
-      call = %Q[git diff --shortstat #{last_deployed_commit} #{match_tag_name} -- db/migrate]
-      self.diff = system_caller.execute(call)
-      !diff.strip.empty?
+      @migrations_waiting ||= check_for_pending_migrations
     end
 
     def last_deployed_commit
       @last_deploy_commit ||= heroku.last_deploy_commit
     end
+
+    private
+
+    def check_for_pending_migrations
+      call = %Q[git diff --shortstat #{last_deployed_commit} #{match_tag_name} -- db/migrate]
+      self.diff = system_caller.execute(call)
+      !diff.strip.empty?
+    end
   end
 end

data/lib/paratrooper/version.rb

@@ -1,3 +1,3 @@
 module Paratrooper
-  VERSION = "2.3.0".freeze
+  VERSION = "2.4.0".freeze
 end

data/spec/paratrooper/pending_migration_check_spec.rb

@@ -21,6 +21,11 @@ describe Paratrooper::PendingMigrationCheck do
       migration_check.migrations_waiting?
     end
 
+    it "memoizes the git diff" do
+      system_caller.should_receive(:execute).exactly(1).times.and_return("DIFF")
+      migration_check.migrations_waiting?
+    end
+
     context "and migrations are in diff" do
       it "returns true" do
         expected_call = %Q[git diff --shortstat LAST_DEPLOYED_COMMIT MATCH -- db/migrate]

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paratrooper
 version: !ruby/object:Gem::Version
-  version: 2.3.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Matt Polito
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-03 00:00:00.000000000 Z
+date: 2014-04-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake