params_ready 0.0.1 → 0.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 16b29937985fac59ceb959ed77ada492f9e943a81e926eb1fb0d5668f3868f97
-  data.tar.gz: 4aab416caa7d1663265d09eacf8229a3e280db9a1d1e29c8b154d07b74543a50
+  metadata.gz: 6e0db6411b802c544350d14eb54c921ae019ac7b2365fc2639b4f2f1b77ee40a
+  data.tar.gz: 3811299181627e888b1ac97970a4264f850db87f0475be355a138a30aa825eb1
 SHA512:
-  metadata.gz: 7e1ae323719b369cf6da284cd95e8596fe7e2071e0d4e7cb4e20253559a02b8ac06d34e1e79b02d7b16fd12ad0acfabd14ea57429895c0f55510e2fbf78a4790
-  data.tar.gz: 9df1e4edf7cb7996a4f91e4036c2656abad0c980100c37166de5b014431f9093ff307a3ff374360a0eae20357b2f60ca28ac64ef33df105ec80f3b76229684a8
+  metadata.gz: f2f339b6dd2a649244d53c94168ad3e3b238a42268632175c08c3928e01861d75c5c19d7fc3c29b8e0482e8658ed6e5f3a17d9ccda34d0b63808b5e1538b4870
+  data.tar.gz: 355252607fd9c47d58acf4cf1176bc5d35677390bbfeecfe1e24d881f9303be23d20dbcc8611b9c4cff25ff277944e0a2ad9e85aef7ccf0e7174a0a02856f1c3

data/lib/params_ready.rb

@@ -28,9 +28,9 @@ require_relative 'params_ready/query/variable_operator_predicate'
 
 
 module ParamsReady
-  VERSION = '0.0.1'.freeze
+  VERSION = '0.0.2'.freeze
 
   def self.gem_version
     ::Gem::Version.new(VERSION)
   end
-end
+end

data/lib/params_ready/ordering/ordering.rb

@@ -27,8 +27,8 @@ module ParamsReady
       end
 
       def by_columns
-        bare_value.each_with_object(Hash.new(:none)) do |tuple, hash|
-          hash[tuple[0].unwrap] = tuple[1].unwrap
+        bare_value.each_with_index.each_with_object(Hash.new([:none, nil])) do |(tuple, index), hash|
+          hash[tuple[0].unwrap] = [tuple[1].unwrap, index]
         end
       end
 

data/lib/params_ready/pagination/abstract_pagination.rb

@@ -10,8 +10,8 @@ module ParamsReady
         update_in(first_page_value, [])
       end
 
-      def last_page(*args)
-        update_in(last_page_value(*args), [])
+      def last_page(*args, **opts)
+        update_in(last_page_value(*args, **opts), [])
       end
     end
   end

data/lib/params_ready/parameter/value_parameter.rb

@@ -113,7 +113,7 @@ module ParamsReady
       name_for_formatter :value
 
       def name_for_formatter
-        coder_name = @coder.type_identifier
+        coder_name = @coder.type_identifier if @coder.respond_to? :type_identifier
         return coder_name unless coder_name.nil?
 
         super

data/lib/params_ready/value/coder.rb

@@ -6,26 +6,29 @@ require_relative '../extensions/class_reader_writer'
 
 module ParamsReady
   module Value
+    module Coercion
+      def try_coerce(input, context)
+        coerce input, context
+      rescue => _error
+        raise CoercionError.new(input, value_class_name)
+      end
+
+      def strict_default?
+        true
+      end
+    end
+
     class Coder
       extend Extensions::ClassReaderWriter
-
-      class_reader_writer :type_identifier
-      type_identifier :value
+      extend Coercion
 
       def self.value_class_name
         last = self.name.split("::").last
         last.remove('Coder')
       end
 
-      def self.try_coerce(input, context)
-        coerce input, context
-      rescue => _error
-        raise CoercionError.new(input, value_class_name)
-      end
-
-      def self.strict_default?
-        true
-      end
+      class_reader_writer :type_identifier
+      type_identifier :value
     end
 
     class GenericCoder

data/lib/params_ready/value/validator.rb

@@ -13,15 +13,26 @@ module ParamsReady
           type = Value::Constraint.constraint_type(name_or_constraint)
           type.build(*args, **opts, &block)
         else
-          if name_or_constraint.respond_to?(:valid?) && name_or_constraint.respond_to?(:error_message)
-            name_or_constraint
-          else
-            raise ParamsReadyError, "Not a constraint: #{name_or_constraint.class.name}"
-          end
+          valid, missing_method = valid_constraint?(name_or_constraint, strategy)
+          on_constraint_invalid(missing_method) unless valid
+          name_or_constraint
         end
         new(constraint, strategy: strategy)
       end
 
+      def self.on_constraint_invalid(missing_method)
+        raise ParamsReadyError, "Not a valid constraint, '#{missing_method}' unimplemented"
+      end
+
+      def self.valid_constraint?(constraint, strategy)
+        return [false, 'valid?'] unless constraint.respond_to?(:valid?)
+        return [false, 'error_message'] unless constraint.respond_to?(:error_message)
+        return [true, nil] unless strategy == :clamp
+        return [false, 'clamp'] unless constraint.respond_to? :clamp
+
+        [true, nil]
+      end
+
       def initialize(constraint, strategy: :raise)
         @constraint = constraint
         @strategy = check_strategy(constraint, strategy)
@@ -33,7 +44,9 @@ module ParamsReady
         when :raise, :undefine
           strategy.to_sym
         when :clamp
-          raise ParamsReadyError, 'Clamping not applicable' unless constraint.clamp?
+          if constraint.respond_to? :clamp?
+            raise ParamsReadyError, 'Clamping not applicable' unless constraint.clamp?
+          end
           strategy.to_sym
         else
           raise ParamsReadyError, "Unexpected constraint strategy #{strategy}"

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: params_ready
 version: !ruby/object:Gem::Version
-  version: 0.0.1
+  version: 0.0.2
 platform: ruby
 authors:
 - Tomas Milsimer
@@ -174,7 +174,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
+rubygems_version: 3.1.2
 signing_key: 
 specification_version: 4
 summary: Define controller interfaces in Rails