parallelized_specs 0.4.42 → 0.4.43

data/Rakefile

@@ -12,7 +12,7 @@ begin
     gem.email    = "jake@instructure.com"
     gem.homepage = "http://github.com/jakesorce/#{gem.name}"
     gem.authors  = "Jake Sorce, Bryan Madsen, Shawn Meredith"
-    gem.version = "0.4.42"
+    gem.version = "0.4.43"
   end
   Jeweler::GemcutterTasks.new
 rescue LoadError

data/lib/parallelized_specs/outcome_builder.rb

@@ -9,8 +9,8 @@ module RSpec
       env_test_number = ENV['TEST_ENV_NUMBER']
       env_test_number = 1 if ENV['TEST_ENV_NUMBER'].blank?
       puts "Thread #{env_test_number.to_s} has #{@example_count} specs"
-      File.open("#{RAILS_ROOT}/tmp/parallel_log/spec_count/total_specs#{env_test_number}.txt", 'a+') { |f| f.write(@example_count) }
-      File.open("#{RAILS_ROOT}/tmp/parallel_log/thread_started/thread_#{env_test_number}.txt", 'a+') { |f| f.write("") }
+      File.open("#{Rails.root}/tmp/parallel_log/spec_count/total_specs#{env_test_number}.txt", 'a+') { |f| f.write(@example_count) }
+      File.open("#{Rails.root}/tmp/parallel_log/thread_started/thread_#{env_test_number}.txt", 'a+') { |f| f.write("") }
       super
     end
 
@@ -18,8 +18,8 @@ module RSpec
     def dump_summary(duration, example_count, failure_count, pending_count)
       env_test_number = ENV['TEST_ENV_NUMBER']
       env_test_number = 1 if ENV['TEST_ENV_NUMBER'].blank?
-      spec_file = "#{RAILS_ROOT}/tmp/parallel_log/spec_count/total_specs#{env_test_number}.txt"
-      failure_file = "#{RAILS_ROOT}/tmp/parallel_log/failed_specs/failed_specs#{env_test_number}.txt"
+      spec_file = "#{Rails.root}/tmp/parallel_log/spec_count/total_specs#{env_test_number}.txt"
+      failure_file = "#{Rails.root}/tmp/parallel_log/failed_specs/failed_specs#{env_test_number}.txt"
       expected_example_count = File.open(spec_file, &:readline).to_s
       puts "Expected example count = #{expected_example_count} from rspec example count = #{example_count}"
       File.delete(spec_file) if expected_example_count.to_i - example_count.to_i < 2

data/lib/parallelized_specs.rb

@@ -84,6 +84,7 @@ class ParallelizedSpecs
   end
 
   def self.run_specs(tests, options)
+    formatters = formatters_used
     num_processes = options[:count] || Parallel.processor_count
     name = 'spec'
 
@@ -107,55 +108,61 @@ class ParallelizedSpecs
     test_results = Parallel.map(groups, :in_processes => num_processes) do |group|
       run_tests(group, groups.index(group), options)
     end
-
-    slowest_spec_determination("#{RAILS_ROOT}/tmp/parallel_log/slowest_specs.log")
+    slowest_spec_determination("#{Rails.root}/tmp/parallel_log/slowest_specs.log")
 
     #parse and print results
     results = find_results(test_results.map { |result| result[:stdout] }*"")
-    #puts ""
     puts summarize_results(results)
+    puts "INFO: Took #{Time.now - start} seconds"
 
+    #determines if any tricky conditions happened that can cause false positives and offers logging into what was the last spec to start or finishing running
+    false_positive_sniffer(num_processes) if formatters.any? { |formatter| formatter.match(/OutcomeBuilder/) }
+    failed = test_results.any? { |result| result[:exit_status] != 0 } #ruby 1.8.7 works breaks on 1.9.3
+    formatters.any? { |formatter| formatter.match(/FailuresFormatter/) } ? rerun_initializer(name, failed) : abort "SEVERE: #{name.capitalize}s Failed" if failed
+    puts "INFO: marking build as PASSED"
+    end
 
-    #report total time taken
-    puts ""
-    puts "INFO: Took #{Time.now - start} seconds"
+  def self.formatters_used
+    File.open("#{Rails.root}/spec/spec.opts").each_line do |line|
+      formatters << line
+    end
+    formatters
+  end
+
+  def self.rerun_initializer(name, failed)
+    if Dir.glob("#{Rails.root}/tmp/parallel_log/failed_specs/{*,.*}").count > 2 && !File.zero?("#{Rails.root}/tmp/parallel_log/rspec.failures") # works on both 1.8.7\1.9.3
+      puts "INFO: some specs failed, about to start the rerun process\n INFO: no more than 9 specs may be rerun and shared specs are not allowed\n...\n..\n."
+      ParallelizedSpecs.rerun()
+    else
+      #works on both 1.8.7\1.9.3
+      abort "SEVERE: #{name.capitalize}s Failed" if Dir.glob("#{Rails.root}/tmp/parallel_log/failed_specs/{*,.*}").count > 2 || failed
+    end
+  end
 
-    if Dir.glob("#{RAILS_ROOT}/tmp/parallel_log/spec_count/{*,.*}").count == 2 && Dir.glob("#{RAILS_ROOT}/tmp/parallel_log/thread_started/{*,.*}").count == num_processes + 2
+  def self.false_positive_sniffer(num_processes)
+    if Dir.glob("#{Rails.root}/tmp/parallel_log/spec_count/{*,.*}").count == 2 && Dir.glob("#{Rails.root}/tmp/parallel_log/thread_started/{*,.*}").count == num_processes + 2
       (puts "INFO: All threads completed")
-    elsif Dir.glob("#{RAILS_ROOT}/tmp/parallel_log/thread_started/{*,.*}").count != num_processes + 2
-      File.open("#{RAILS_ROOT}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n syntax issues" }
-      File.open("#{RAILS_ROOT}/tmp/failure_cause.log", 'a+') { |f| f.write "Syntax errors" }
+    elsif Dir.glob("#{Rails.root}/tmp/parallel_log/thread_started/{*,.*}").count != num_processes + 2
+      File.open("#{Rails.root}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n syntax issues" }
+      File.open("#{Rails.root}/tmp/failure_cause.log", 'a+') { |f| f.write "Syntax errors" }
       abort "SEVERE: one or more threads didn't get started by rspec, this may be caused by a syntax issue in specs, check logs right before specs start running"
     else
-      threads = Dir["#{RAILS_ROOT}/tmp/parallel_log/spec_count/*"]
+      threads = Dir["#{Rails.root}/tmp/parallel_log/spec_count/*"]
       threads.each do |t|
         failed_thread = t.match(/\d/).to_s
         if failed_thread == "1"
           puts "INFO: Thread 1 last spec to start running"
-          last_spec = IO.readlines("#{RAILS_ROOT}/tmp/parallel_log/thread_.log")[-1]
-          File.open("#{RAILS_ROOT}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n\nrspec thread #{failed_thread} failed to complete\n the last spec to try to run was #{last_spec}" }
+          last_spec = IO.readlines("#{Rails.root}/tmp/parallel_log/thread_.log")[-1]
+          File.open("#{Rails.root}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n\nrspec thread #{failed_thread} failed to complete\n the last spec to try to run was #{last_spec}" }
         else
           puts "INFO: Thread #{failed_thread} last spec to start running"
-          last_spec = IO.readlines("#{RAILS_ROOT}/tmp/parallel_log/thread_#{failed_thread}.log")[-1]
-          File.open("#{RAILS_ROOT}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n\nrspec thread #{failed_thread} failed to complete\n the last spec to try to run was #{last_spec}" }
+          last_spec = IO.readlines("#{Rails.root}/tmp/parallel_log/thread_#{failed_thread}.log")[-1]
+          File.open("#{Rails.root}/tmp/parallel_log/error.log", 'a+') { |f| f.write "\n\n\n\nrspec thread #{failed_thread} failed to complete\n the last spec to try to run was #{last_spec}" }
         end
       end
-      File.open("#{RAILS_ROOT}/tmp/failure_cause.log", 'a+') { |f| f.write "rspec thread failed to complete" }
+      File.open("#{Rails.root}/tmp/failure_cause.log", 'a+') { |f| f.write "rspec thread failed to complete" }
       abort "SEVERE: One or more threads have failed to complete, this may be caused by a rspec runtime crashing prematurely" #works on both 1.8.7\1.9.3
     end
-    #exit with correct status code so rake parallel:test && echo 123 works
-
-    failed = test_results.any? { |result| result[:exit_status] != 0 } #ruby 1.8.7 works breaks on 1.9.3
-    puts "INFO: this is the exit status of the rspec suites #{failed}"
-
-    if Dir.glob("#{RAILS_ROOT}/tmp/parallel_log/failed_specs/{*,.*}").count > 2 && !File.zero?("#{RAILS_ROOT}/tmp/parallel_log/rspec.failures") # works on both 1.8.7\1.9.3
-      puts "INFO: some specs failed, about to start the rerun process\n INFO: no more than 9 specs may be rerun and shared specs are not allowed\n...\n..\n."
-      ParallelizedSpecs.rerun()
-    else
-      #works on both 1.8.7\1.9.3
-      abort "SEVERE: #{name.capitalize}s Failed" if Dir.glob("#{RAILS_ROOT}/tmp/parallel_log/failed_specs/{*,.*}").count > 2 || failed
-    end
-    puts "INFO: marking build as PASSED"
   end
 
 # parallel:spec[:count, :pattern, :options]
@@ -303,7 +310,7 @@ class ParallelizedSpecs
 
   def self.update_rerun_summary(l, outcome, stack = "")
     File.open(@failure_summary, 'a+') { |f| f.puts("Outcome #{outcome} for #{l}\n #{stack}") }
-    File.open("#{RAILS_ROOT}/tmp/parallel_log/error.log", 'a+') { |f| f.puts("Outcome #{outcome} for #{l}\n #{stack}") } if outcome == "FAILED"
+    File.open("#{Rails.root}/tmp/parallel_log/error.log", 'a+') { |f| f.puts("Outcome #{outcome} for #{l}\n #{stack}") } if outcome == "FAILED"
   end
 
   def self.parse_result(result)
@@ -336,7 +343,7 @@ class ParallelizedSpecs
   def self.abort_reruns(code, result = "", l = "")
     case
       when code == 1
-        print_failures("#{RAILS_ROOT}/tmp/parallel_log/error.log")
+        print_failures("#{Rails.root}/tmp/parallel_log/error.log")
         abort "SEVERE: shared specs currently are not eligiable for reruns, marking build as a failure"
       when code == 2 # <--- won't ever happen, 2 and 3 are duplicate clean up on refactor
         update_rerun_summary(l, "FAILED", result)
@@ -353,14 +360,14 @@ class ParallelizedSpecs
       when code == 5
         abort "SEVERE: #{@error_count} errors, but the build failed, errors were not written to the file or there is something else wrong, marking build as a failure"
       when code == 6
-        print_failures("#{RAILS_ROOT}/tmp/parallel_log/error.log")
+        print_failures("#{Rails.root}/tmp/parallel_log/error.log")
         abort "SEVERE: #{@error_count} errors are to many to rerun, marking the build as a failure. Max errors defined for this build is #{@max_reruns}"
       when code == 7
         puts "#Total errors #{@error_count}"
         abort "SEVERE: unexpected error information, please check errors are being written to file correctly"
       when code == 8
         print_failures(@failure_summary, "RERUN")
-        File.open("#{RAILS_ROOT}/tmp/failure_cause.log", 'a+') { |f| f.write "#{@rerun_failures.count} failures" }
+        File.open("#{Rails.root}/tmp/failure_cause.log", 'a+') { |f| f.write "#{@rerun_failures.count} failures" }
         abort "SEVERE: some specs failed on rerun, the build will be marked as failed"
       when code == 9
         abort "SEVERE: unexpected situation on rerun, marking build as failure"
@@ -422,7 +429,7 @@ class ParallelizedSpecs
       end
     end
     puts "INFO: failures meet rerun criteria \n INFO: rerunning #{@error_count} examples"
-    File.open("#{RAILS_ROOT}/tmp/parallel_log/error.log", 'a+') { |f| f.puts("\n\n\n\n\n *****RERUN FAILURES*****\n") }
+    File.open("#{Rails.root}/tmp/parallel_log/error.log", 'a+') { |f| f.puts("\n\n\n\n\n *****RERUN FAILURES*****\n") }
   end
 
   def self.start_reruns
@@ -470,8 +477,8 @@ class ParallelizedSpecs
 
   def self.runtime_setup
     @rerun_specs = []
-    @filename = "#{RAILS_ROOT}/tmp/parallel_log/rspec.failures"
-    @failure_summary = "#{RAILS_ROOT}/tmp/parallel_log/rerun_failure_summary.log"
+    @filename = "#{Rails.root}/tmp/parallel_log/rspec.failures"
+    @failure_summary = "#{Rails.root}/tmp/parallel_log/rerun_failure_summary.log"
   end
 
   def self.rerun()

data/parallelized_specs.gemspec

@@ -5,7 +5,7 @@
 
 Gem::Specification.new do |s|
   s.name = "parallelized_specs"
-  s.version = "0.4.42"
+  s.version = "0.4.43"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Jake Sorce, Bryan Madsen, Shawn Meredith"]

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: parallelized_specs
 version: !ruby/object:Gem::Version 
-  hash: 91
+  hash: 89
   prerelease: 
   segments: 
   - 0
   - 4
-  - 42
-  version: 0.4.42
+  - 43
+  version: 0.4.43
 platform: ruby
 authors: 
 - Jake Sorce, Bryan Madsen, Shawn Meredith