parallel_rspec 2.2.0 → 2.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6d2e2199456f48d4b9726672b0c5e223b536350826d46b1bc14ff28e5d83ef45
-  data.tar.gz: ae4b625e1041147f8e6c4087196fe34bb97977fb0034549e9436b4056363f184
+  metadata.gz: 6a72d4e48cb7e1973a00e66c2fcae145cbe17c238ed051666856365716f1cd67
+  data.tar.gz: e4b27f1a20a0e3d329fb146592af425aa0f5887cd18fe71784c8f432e62993ad
 SHA512:
-  metadata.gz: a27c85ac8cc1ef08b04ac61054848eeed0dfbe08465fd4814d0a6909dd18891df71d7bbe9011f2fe0281a028bdd62550988d2716f707d3ea1a11d12139d67772
-  data.tar.gz: 584531e1f3027132097cebb1a36e600ae7e470ce62b91bc23522352dc39f14a7c1c80b34b92a1c5298bbdb079fb51c1204962945577c6cdf549e14dd944f8a22
+  metadata.gz: 12770663bed8e75c5cd24743a177ac3ba01b3d07165dce4ef2e921219dd4a2dc62eaa013c12ffd43d0f7f2565484b0b33330249a1b46ea4e4e6d046518f5b469
+  data.tar.gz: e15b6a238cbf5249472eaca4fbd52073ea001f7f01ca8a41be1732cea1aa529d3c3159d5dcef22353d25815d0ea814e100785ad977fd1f2862f904dda47e2273

data/CHANGES.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 2.4.0
+
+* Wrap Exception objects so they can always be dumped and loaded, even if they contain non-marshallable objects such as Procs or anonymous classes.
+
+## 2.3.0
+
+* Increase default workers from 2 to 4.
+* Fix behavioral inconsistency with rspec-core in nested describe blocks on helper methods with clashing let methods.
+
 ## 2.2.0
 
 * Fix incompatibility with `rspec --profile`.

data/README.md

@@ -28,9 +28,9 @@ This version of ParallelRSpec has been tested with RSpec 3.12.
 
 ## Usage
 
-By default, ParallelRSpec will use two workers.  If you would like to use more, set an environment variable:
+By default, ParallelRSpec will use four workers.  If you would like to use more, set an environment variable:
 
-    $ export WORKERS=4
+    $ export WORKERS=8
 
 ParallelRSpec runs each worker with its own copy of the test database to avoid locking and deadlocking problems.  To create these and populate them with your schema, run:
 
@@ -59,7 +59,7 @@ By default, there's a task called `parallel_rspec` which will run all specs. To
   require 'parallel_rspec'
 
   ParallelRSpec::RakeTask.new(:prspec) do |t|
-    ENV['WORKERS'] = '4'
+    ENV['WORKERS'] = '8'
     t.pattern = "spec/**/*_spec.rb"
     t.rspec_opts = "--tag parallel"
     # etc...

data/lib/parallel_rspec/client.rb

@@ -1,4 +1,33 @@
 module ParallelRSpec
+  # Some Exception objects contain non-marshallable ivars such as Proc objects. This wrapper
+  # represents the bits needed by RSpec's ExceptionPresenter, and can be dumped and loaded.
+  class ExceptionMarshallingWrapper < Exception
+    attr_reader :class_name, :message, :backtrace, :cause
+
+    def initialize(class_name, message, backtrace, cause)
+      @class_name = class_name
+      @message = message
+      @backtrace = backtrace
+      @cause = cause
+    end
+
+    def class
+      eval "class #{@class_name}; end; #{@class_name}"
+    end
+
+    def inspect
+      "#<#{@class_name}: #{@message}>"
+    end
+
+    def ==(other)
+      other.is_a?(ExceptionMarshallingWrapper) &&
+        class_name == other.class_name &&
+        message == other.message &&
+        backtrace == other.backtrace &&
+        cause == other.cause
+    end
+  end
+
   class Client
     attr_reader :channel_to_server
 
@@ -39,8 +68,9 @@ module ParallelRSpec
     end
 
     def updates_from(example)
+      example.execution_result.exception = dumpable_exception(example.execution_result.exception)
       {
-        exception: example.exception,
+        exception: dumpable_exception(example.exception),
         metadata: example.metadata.slice(
           :execution_result,
           :pending,
@@ -49,6 +79,11 @@ module ParallelRSpec
       }
     end
 
+    def dumpable_exception(exception)
+      return exception if exception.nil? || exception.is_a?(ExceptionMarshallingWrapper)
+      ExceptionMarshallingWrapper.new(exception.class.name, exception.to_s, exception.backtrace, dumpable_exception(exception.cause))
+    end
+
     def next_example_to_run
       channel_to_server.write([:next_example_to_run])
       channel_to_server.read

data/lib/parallel_rspec/runner.rb

@@ -77,6 +77,7 @@ module ParallelRSpec
         while next_example = client.next_example_to_run
           example_group, example_index = *next_example
           example = RSpec.world.filtered_examples[example_group][example_index]
+          example_group.parent_groups.reverse_each { |parent_group| parent_group.new("dummy instance to trigger helper loading order") }
           example_group_instance = example_group.new(example.inspect_output)
           success = example.run(example_group_instance, client) && success
         end

data/lib/parallel_rspec/tasks.rake

@@ -59,7 +59,8 @@ db_namespace = namespace :db do
     desc "Recreate the test databases from the current schema"
     task :load do
       db_namespace["parallel:purge"].invoke
-      case ActiveRecord::Base.schema_format
+      schema_format = ActiveRecord.respond_to?(:schema_format) ? ActiveRecord.schema_format : ActiveRecord::Base.schema_format
+      case schema_format
       when :ruby
         db_namespace["parallel:load_schema"].invoke
       when :sql

data/lib/parallel_rspec/version.rb

@@ -1,3 +1,3 @@
 module ParallelRSpec
-  VERSION = "2.2.0"
+  VERSION = "2.4.0"
 end

data/lib/parallel_rspec/workers.rb

@@ -2,7 +2,7 @@ module ParallelRSpec
   class Workers
     def self.number_of_workers
       workers = ENV['WORKERS'].to_i
-      workers = 2 if workers.zero?
+      workers = 4 if workers.zero?
       workers
     end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parallel_rspec
 version: !ruby/object:Gem::Version
-  version: 2.2.0
+  version: 2.4.0
 platform: ruby
 authors:
 - Will Bryant, Powershop New Zealand Ltd
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-07-02 00:00:00.000000000 Z
+date: 2023-07-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake