parallel_minion 0.4.0 → 0.4.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 8c335c7e0f70e6146ac47496db7148e38f3bd65b
-  data.tar.gz: 69102288e568ff93f50179160ec4ea589289d1a0
+  metadata.gz: 982df7415c5b0672c4a8c5d8aa6e32d31677a9b7
+  data.tar.gz: cc64cd982068008a6b233eb72339e11892dfee34
 SHA512:
-  metadata.gz: c3809ec290a32c2afb8661bc5c926ab9dc386006a5b519f790c5960d01cbdc785b34a902dbf7754b67b3b20584237fe0d51429bfb23457d331e7938e531a9423
-  data.tar.gz: b519e6ded5b402a48c37cc06ad5727fde6a61f670be000309629a471a292dc36fca1445ed13256828f98a2532a9e4f8f2c379ed8bf504fc5892b023b61814a0a
+  metadata.gz: d0ce188896ad20800f4727a02c71985efce109952e7ae1d51bf0e3e35b40928dccf4833b82e96fc9f6595153fde5f5777cbd9d366d2be535609322d4aa8c2551
+  data.tar.gz: b4a1c1f63c43f34e8c38d24ae4bb98347566cfceddb856824041541e1cb0eee1562aa4426cb7bbb746b2d43ef64583cc84b854921db1670cabd1d90c1db487f9

data/lib/parallel_minion/minion.rb

@@ -152,7 +152,7 @@ module ParallelMinion
           logger.info("Started #{@description}")
 
           begin
-            logger.benchmark_info("Completed #{@description}", log_exception: @log_exception) do
+            logger.benchmark_info("Completed #{@description}", log_exception: @log_exception, metric: @metric) do
               # Use the current scope for the duration of the task execution
               if scopes.nil? || (scopes.size == 0)
                 @result = instance_exec(*args, &block)

data/lib/parallel_minion/version.rb

@@ -1,3 +1,3 @@
 module ParallelMinion #:nodoc
-  VERSION = "0.4.0"
+  VERSION = "0.4.1"
 end

data/test/minion_test.rb

@@ -9,6 +9,11 @@ require 'parallel_minion'
 SemanticLogger.default_level = :trace
 SemanticLogger.add_appender('test.log', &SemanticLogger::Appender::Base.colorized_formatter) if SemanticLogger.appenders.size == 0
 
+# Setup global callback for metric so that it can be tested below
+SemanticLogger.on_metric do |log_struct|
+  $log_struct = log_struct.dup
+end
+
 # Test ParallelMinion standalone without Rails
 # Run this test standalone to verify it has no Rails dependencies
 class MinionTest < Test::Unit::TestCase
@@ -20,6 +25,7 @@ class MinionTest < Test::Unit::TestCase
       context ".new with enabled: #{enabled.inspect}" do
         setup do
           ParallelMinion::Minion.enabled = enabled
+          $log_struct = nil
         end
 
         should 'without parameters' do
@@ -47,15 +53,15 @@ class MinionTest < Test::Unit::TestCase
           end
         end
 
-# TODO Blocks still have access to their original scope if variables cannot be
-#      resolved first by the parameters, then by the values in Minion itself
-#        should 'not have access to local variables' do
-#          name = 'Jack'
-#          minion = ParallelMinion::Minion.new(description: 'Test') { puts name }
-#          assert_raise NameError do
-#            minion.result
-#          end
-#        end
+        # TODO Blocks still have access to their original scope if variables cannot be
+        #      resolved first by the parameters, then by the values in Minion itself
+        #        should 'not have access to local variables' do
+        #          name = 'Jack'
+        #          minion = ParallelMinion::Minion.new(description: 'Test') { puts name }
+        #          assert_raise NameError do
+        #            minion.result
+        #          end
+        #        end
 
         should 'run minion' do
           hash = { value: 23 }
@@ -81,6 +87,22 @@ class MinionTest < Test::Unit::TestCase
           assert_equal 'TAG', minion.result
         end
 
+        should 'include metric' do
+          metric_name = '/Custom/metric'
+          hash = { value: 23 }
+          value = 47
+          minion = ParallelMinion::Minion.new(hash, description: 'Test', metric: metric_name) do |h|
+            value = 321
+            h[:value] = 123
+            456
+          end
+          assert_equal 456, minion.result
+          assert_equal 123, hash[:value]
+          assert_equal 321, value
+          SemanticLogger.flush
+          assert_equal metric_name, $log_struct.metric
+        end
+
         should 'handle multiple minions concurrently' do
           # Start 10 minions
           minions = 10.times.collect do |i|

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: parallel_minion
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.4.1
 platform: ruby
 authors:
 - Reid Morrison
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-04-14 00:00:00.000000000 Z
+date: 2014-04-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: semantic_logger