parallel 0.5.10 → 0.5.11

data/VERSION

@@ -1 +1 @@
-0.5.10
+0.5.11

data/lib/parallel.rb

@@ -149,11 +149,8 @@ class Parallel
           end
         end
       ensure
-        worker[:read].close
-        worker[:write].close
-
-        # if it goes zombie, rather wait here to be able to debug
-        wait_for_process worker[:pid]
+        close_pipes(worker)
+        wait_for_process worker[:pid] # if it goes zombie, rather wait here to be able to debug
       end
     end
 
@@ -163,7 +160,11 @@ class Parallel
   end
 
   def self.create_workers(items, options, &block)
-    workers = Array.new(options[:count]).map{ worker(items, options, &block) }
+    workers = []
+    Array.new(options[:count]).each do
+      workers << worker(items, options.merge(:started_workers => workers), &block)
+    end
+
     pids = workers.map{|worker| worker[:pid] }
     kill_on_ctrl_c(pids)
     workers
@@ -178,6 +179,8 @@ class Parallel
 
     pid = Process.fork do
       begin
+        options.delete(:started_workers).each{|w| close_pipes w }
+
         parent_write.close
         parent_read.close
 
@@ -194,6 +197,11 @@ class Parallel
     {:read => parent_read, :write => parent_write, :pid => pid}
   end
 
+  def self.close_pipes(worker)
+    worker[:read].close
+    worker[:write].close
+  end
+
   def self.process_incoming_jobs(read, write, items, options, &block)
     while input = read.gets and input != "\n"
       index = decode(input.chomp)

data/parallel.gemspec

@@ -4,13 +4,13 @@
 # -*- encoding: utf-8 -*-
 
 Gem::Specification.new do |s|
-  s.name = %q{parallel}
-  s.version = "0.5.10"
+  s.name = "parallel"
+  s.version = "0.5.11"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["Michael Grosser"]
-  s.date = %q{2011-12-06}
-  s.email = %q{grosser.michael@gmail.com}
+  s.date = "2011-12-08"
+  s.email = "grosser.michael@gmail.com"
   s.files = [
     "Gemfile",
      "Gemfile.lock",
@@ -20,6 +20,7 @@ Gem::Specification.new do |s|
      "lib/parallel.rb",
      "parallel.gemspec",
      "spec/cases/closes_processes_at_runtime.rb",
+     "spec/cases/count_open_pipes.rb",
      "spec/cases/each.rb",
      "spec/cases/each_with_index.rb",
      "spec/cases/host_os_override_processor_count.rb",
@@ -44,12 +45,12 @@ Gem::Specification.new do |s|
      "spec/parallel_spec.rb",
      "spec/spec_helper.rb"
   ]
-  s.homepage = %q{http://github.com/grosser/parallel}
+  s.homepage = "http://github.com/grosser/parallel"
   s.licenses = ["MIT"]
   s.rdoc_options = ["--charset=UTF-8"]
   s.require_paths = ["lib"]
-  s.rubygems_version = %q{1.6.2}
-  s.summary = %q{Run any kind of code in parallel processes}
+  s.rubygems_version = "1.8.12"
+  s.summary = "Run any kind of code in parallel processes"
   s.test_files = [
     "spec/spec_helper.rb",
      "spec/parallel_spec.rb",
@@ -57,6 +58,7 @@ Gem::Specification.new do |s|
      "spec/cases/parallel_map_range.rb",
      "spec/cases/map_with_threads_and_exceptions.rb",
      "spec/cases/parallel_influence_outside_data.rb",
+     "spec/cases/count_open_pipes.rb",
      "spec/cases/parallel_with_set_processes.rb",
      "spec/cases/parallel_with_detected_cpus.rb",
      "spec/cases/parallel_start_and_kill.rb",

data/spec/cases/count_open_pipes.rb

@@ -0,0 +1,6 @@
+require File.expand_path('spec/spec_helper')
+
+results = Parallel.map(Array.new(20), :in_processes => 20) do
+  `lsof | grep pipe | wc -l`.to_i
+end
+puts results.max

data/spec/cases/parallel_sleeping_2.rb

@@ -2,4 +2,4 @@ require File.expand_path('spec/spec_helper')
 
 Parallel.in_processes(5) do
   sleep 2
-end
+end

data/spec/parallel_spec.rb

@@ -78,6 +78,12 @@ describe Parallel do
     it 'does not leave processes behind while running' do
       `ruby spec/cases/closes_processes_at_runtime.rb`.should == 'OK'
     end
+
+    it "does not open unnecessary pipes" do
+      open_pipes = `lsof | grep pipe | wc -l`.to_i
+      max_pipes = `ruby spec/cases/count_open_pipes.rb`.to_i
+      (max_pipes - open_pipes).should < 400
+    end
   end
 
   describe :in_threads do

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: parallel
 version: !ruby/object:Gem::Version 
-  hash: 31
+  hash: 29
   prerelease: 
   segments: 
   - 0
   - 5
-  - 10
-  version: 0.5.10
+  - 11
+  version: 0.5.11
 platform: ruby
 authors: 
 - Michael Grosser
@@ -15,8 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-12-06 00:00:00 -08:00
-default_executable: 
+date: 2011-12-08 00:00:00 Z
 dependencies: []
 
 description: 
@@ -36,6 +35,7 @@ files:
 - lib/parallel.rb
 - parallel.gemspec
 - spec/cases/closes_processes_at_runtime.rb
+- spec/cases/count_open_pipes.rb
 - spec/cases/each.rb
 - spec/cases/each_with_index.rb
 - spec/cases/host_os_override_processor_count.rb
@@ -59,7 +59,6 @@ files:
 - spec/cases/parallel_with_set_processes.rb
 - spec/parallel_spec.rb
 - spec/spec_helper.rb
-has_rdoc: true
 homepage: http://github.com/grosser/parallel
 licenses: 
 - MIT
@@ -89,7 +88,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: 
-rubygems_version: 1.6.2
+rubygems_version: 1.8.12
 signing_key: 
 specification_version: 3
 summary: Run any kind of code in parallel processes
@@ -100,6 +99,7 @@ test_files:
 - spec/cases/parallel_map_range.rb
 - spec/cases/map_with_threads_and_exceptions.rb
 - spec/cases/parallel_influence_outside_data.rb
+- spec/cases/count_open_pipes.rb
 - spec/cases/parallel_with_set_processes.rb
 - spec/cases/parallel_with_detected_cpus.rb
 - spec/cases/parallel_start_and_kill.rb