paraduct 1.0.0.beta6 → 1.0.0

data/lib/paraduct/test_response.rb

@@ -9,7 +9,7 @@ module Paraduct
     delegate :push, :count, to: :jobs, prefix: true
 
     def successful?
-      @jobs.all?{ |result| result[:successful] }
+      @jobs.all? { |result| result[:successful] }
     end
 
     def failure?
@@ -18,14 +18,14 @@ module Paraduct
 
     def detail_message
       all_count = @jobs.count
-      successful_count = @jobs.select{ |result| result[:successful] }.count
+      successful_count = @jobs.count { |result| result[:successful] }
       failure_count = all_count - successful_count
 
       message = "======================================================\n"
 
       if successful_count > 0
         message << "Passed:\n\n"
-        @jobs.select{ |result| result[:successful] }.each_with_index do |result, i|
+        @jobs.select { |result| result[:successful] }.each_with_index do |result, i|
           message << "  #{i + 1}) #{result[:formatted_params]}\n"
         end
         message << "\n"
@@ -33,7 +33,7 @@ module Paraduct
 
       if failure_count > 0
         message << "Failures:\n\n"
-        @jobs.select{ |result| !result[:successful] }.each_with_index do |result, i|
+        @jobs.select { |result| !result[:successful] }.each_with_index do |result, i|
           message << "  #{i + 1}) #{result[:formatted_params]}\n"
         end
         message << "\n"

data/lib/paraduct/variable_converter.rb

@@ -25,9 +25,8 @@ module Paraduct
     end
 
     def self.reject(product_variables, exclude_variables)
-      product_variables.inject([]) do |rejected_product_variables, variables|
-        rejected_product_variables << variables unless exclude_variables.any?{ |exclude| partial_match?(variables, exclude) }
-        rejected_product_variables
+      product_variables.each_with_object([]) do |variables, rejected_product_variables|
+        rejected_product_variables << variables unless exclude_variables.any? { |exclude| partial_match?(variables, exclude) }
       end
     end
 

data/lib/paraduct/version.rb

@@ -1,3 +1,3 @@
 module Paraduct
-  VERSION = "1.0.0.beta6"
+  VERSION = "1.0.0".freeze
 end

data/paraduct.gemspec

@@ -1,15 +1,15 @@
 # coding: utf-8
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path("../lib", __FILE__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'paraduct/version'
+require "paraduct/version"
 
 Gem::Specification.new do |spec|
   spec.name          = "paraduct"
   spec.version       = Paraduct::VERSION
   spec.authors       = ["sue445"]
   spec.email         = ["sue445@sue445.net"]
-  spec.summary       = %q{matrix test runner}
-  spec.description   = %q{Paraduct(parallel + parameterize + product) is matrix test runner}
+  spec.summary       = "matrix test runner"
+  spec.description   = "Paraduct(parallel + parameterize + product) is matrix test runner"
   spec.homepage      = "https://github.com/sue445/paraduct"
   spec.license       = "MIT"
 
@@ -28,6 +28,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", ">= 1.5"
   spec.add_development_dependency "codeclimate-test-reporter"
   spec.add_development_dependency "coveralls"
+  spec.add_development_dependency "rubocop", "0.37.0"
   spec.add_development_dependency "pry-byebug"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "redcarpet"

data/spec/paraduct/cli_spec.rb

@@ -1,20 +1,20 @@
 describe Paraduct::CLI do
   subject { Paraduct::CLI.start(args) }
 
-  let(:args){ [command] }
+  let(:args) { [command] }
 
   describe "#version" do
     %w(version --version).each do |_command|
       context "with #{_command}" do
-        let(:command){ _command }
+        let(:command) { _command }
 
-        it { expect{ subject }.to output("#{Paraduct::VERSION}\n").to_stdout }
+        it { expect { subject }.to output("#{Paraduct::VERSION}\n").to_stdout }
       end
     end
   end
 
   describe "#test" do
-    let(:command){ "test" }
+    let(:command) { "test" }
 
     include_context :stub_configuration
     include_context :within_temp_dir
@@ -33,8 +33,8 @@ describe Paraduct::CLI do
           }
         end
 
-        let(:script){ "./script/build_success.sh" }
-        let(:after_script){ "./script/build_finish.sh" }
+        let(:script) { "./script/build_success.sh" }
+        let(:after_script) { "./script/build_finish.sh" }
         let(:product_variables) do
           [
             { "RUBY" => "1.9.3", "DATABASE" => "mysql"      },
@@ -52,7 +52,7 @@ describe Paraduct::CLI do
 
         it "should call perform_all" do
           expect(Paraduct::ParallelRunner).to receive(:perform_all).
-            with(script: script, after_script: after_script, product_variables: product_variables){ test_response }
+            with(script: script, after_script: after_script, product_variables: product_variables) { test_response }
           subject
         end
       end
@@ -60,7 +60,7 @@ describe Paraduct::CLI do
       context "failure test" do
         let(:config_data) do
           {
-            script: %q(exit ${STATUS}),
+            script: "exit ${STATUS}",
             work_dir: "tmp/paraduct_workspace",
             variables: {
               "STATUS" => [0, 1],
@@ -73,7 +73,7 @@ describe Paraduct::CLI do
     end
 
     context "with --dry-run" do
-      let(:args){ [command, "--dry-run"] }
+      let(:args) { [command, "--dry-run"] }
 
       it "should not call perform_all" do
         expect(Paraduct::ParallelRunner).not_to receive(:perform_all)
@@ -83,7 +83,7 @@ describe Paraduct::CLI do
   end
 
   describe "#generate" do
-    let(:command){ "generate" }
+    let(:command) { "generate" }
 
     include_context :within_temp_dir
 
@@ -94,7 +94,7 @@ describe Paraduct::CLI do
 
     %w(.paraduct.yml .paraduct_rsync_exclude.txt).each do |template_file|
       describe "whether copy #{template_file}" do
-        let(:generated_config_file){ temp_dir_path.join(template_file) }
+        let(:generated_config_file) { temp_dir_path.join(template_file) }
 
         it { expect(generated_config_file).to be_exist }
       end

data/spec/paraduct/configuration_spec.rb

@@ -1,19 +1,19 @@
 describe Paraduct::Configuration do
-  let(:config){ Paraduct.configuration }
+  let(:config) { Paraduct.configuration }
 
   before do
     # use spec/.paraduct.yml
-    allow_any_instance_of(Paraduct::Configuration).to receive(:root_dir){ spec_dir }
+    allow_any_instance_of(Paraduct::Configuration).to receive(:root_dir) { spec_dir }
   end
 
   describe "#variables" do
-    subject{ config.variables }
+    subject { config.variables }
 
     it "should get variables in .paraduct.yml" do
       is_expected.to match(
         "RUBY"     => ["1.9.3", "2.0.0", "2.1.2"],
         "DATABASE" => ["mysql", "postgresql"],
-        "RAILS"    => ["3.2.0", "4.0.0", "4.1.0"],
+        "RAILS"    => ["3.2.0", "4.0.0", "4.1.0"]
       )
     end
   end

data/spec/paraduct/parallel_runner_spec.rb

@@ -1,6 +1,6 @@
 describe Paraduct::ParallelRunner do
   describe "#perform_all" do
-    subject{ Paraduct::ParallelRunner.perform_all(script: script, product_variables: product_variables, after_script: after_script) }
+    subject { Paraduct::ParallelRunner.perform_all(script: script, product_variables: product_variables, after_script: after_script) }
 
     include_context :within_temp_work_dir
 
@@ -9,23 +9,23 @@ describe Paraduct::ParallelRunner do
     # end
 
     shared_examples :create_job_directories do
-      let(:job_dir)    { temp_dir_path.join("tmp/paraduct_workspace/#{job_name}") }
-      let(:copied_file){ job_dir.join("script/build_success.sh") }
+      let(:job_dir) { temp_dir_path.join("tmp/paraduct_workspace/#{job_name}") }
+      let(:copied_file) { job_dir.join("script/build_success.sh") }
 
       it { expect(job_dir).to be_exist }
       it { expect(copied_file).to be_exist }
     end
 
     shared_examples :dont_create_job_directories do
-      let(:job_dir)    { temp_dir_path.join("tmp/paraduct_workspace/#{job_name}") }
-      let(:copied_file){ job_dir.join("script/build_success.sh") }
+      let(:job_dir) { temp_dir_path.join("tmp/paraduct_workspace/#{job_name}") }
+      let(:copied_file) { job_dir.join("script/build_success.sh") }
 
       it { expect(job_dir).not_to be_exist }
       it { expect(copied_file).not_to be_exist }
     end
 
     describe "with script file test" do
-      let(:script){ "./script/build_success.sh" }
+      let(:script) { "./script/build_success.sh" }
       let(:after_script) { "./script/build_finish.sh" }
       let(:product_variables) do
         [
@@ -36,22 +36,22 @@ describe Paraduct::ParallelRunner do
 
       its(:jobs) do
         should include(
-                 job_name:         "RUBY_1.9_DATABASE_mysql",
-                 params:           { "RUBY" => "1.9", "DATABASE" => "mysql" },
-                 formatted_params: "RUBY=1.9, DATABASE=mysql",
-                 successful:       true,
-                 stdout:           "RUBY=1.9\nDATABASE=mysql\nFinish: RUBY=1.9, DATABASE=mysql\n"
-               )
+          job_name:         "RUBY_1.9_DATABASE_mysql",
+          params:           { "RUBY" => "1.9", "DATABASE" => "mysql" },
+          formatted_params: "RUBY=1.9, DATABASE=mysql",
+          successful:       true,
+          stdout:           "RUBY=1.9\nDATABASE=mysql\nFinish: RUBY=1.9, DATABASE=mysql\n"
+        )
       end
 
       its(:jobs) do
         should include(
-                 job_name:         "RUBY_2.0_DATABASE_postgresql",
-                 params:           { "RUBY" => "2.0", "DATABASE" => "postgresql" },
-                 formatted_params: "RUBY=2.0, DATABASE=postgresql",
-                 successful:       true,
-                 stdout:           "RUBY=2.0\nDATABASE=postgresql\nFinish: RUBY=2.0, DATABASE=postgresql\n"
-               )
+          job_name:         "RUBY_2.0_DATABASE_postgresql",
+          params:           { "RUBY" => "2.0", "DATABASE" => "postgresql" },
+          formatted_params: "RUBY=2.0, DATABASE=postgresql",
+          successful:       true,
+          stdout:           "RUBY=2.0\nDATABASE=postgresql\nFinish: RUBY=2.0, DATABASE=postgresql\n"
+        )
       end
 
       context "When work_dir is not empty" do
@@ -66,11 +66,11 @@ describe Paraduct::ParallelRunner do
           end
 
           it_behaves_like :create_job_directories do
-            let(:job_name){ "RUBY_1.9_DATABASE_mysql" }
+            let(:job_name) { "RUBY_1.9_DATABASE_mysql" }
           end
 
           it_behaves_like :create_job_directories do
-            let(:job_name){ "RUBY_2.0_DATABASE_postgresql" }
+            let(:job_name) { "RUBY_2.0_DATABASE_postgresql" }
           end
         end
       end
@@ -87,19 +87,19 @@ describe Paraduct::ParallelRunner do
           end
 
           it_behaves_like :dont_create_job_directories do
-            let(:job_name){ "RUBY_1.9_DATABASE_mysql" }
+            let(:job_name) { "RUBY_1.9_DATABASE_mysql" }
           end
 
           it_behaves_like :dont_create_job_directories do
-            let(:job_name){ "RUBY_2.0_DATABASE_postgresql" }
+            let(:job_name) { "RUBY_2.0_DATABASE_postgresql" }
           end
         end
       end
     end
 
     describe "without script file test" do
-      let(:script){ %q(echo "RUBY=${RUBY} DATABASE=${DATABASE}") }
-      let(:after_script) { %q(echo "Finish: RUBY=${RUBY}, DATABASE=${DATABASE}") }
+      let(:script) { 'echo "RUBY=${RUBY} DATABASE=${DATABASE}"' }
+      let(:after_script) { 'echo "Finish: RUBY=${RUBY}, DATABASE=${DATABASE}"' }
       let(:product_variables) do
         [
           { "RUBY" => "1.9", "DATABASE" => "mysql" },
@@ -109,22 +109,22 @@ describe Paraduct::ParallelRunner do
 
       its(:jobs) do
         should include(
-                 job_name:         "RUBY_1.9_DATABASE_mysql",
-                 params:           { "RUBY" => "1.9", "DATABASE" => "mysql" },
-                 formatted_params: "RUBY=1.9, DATABASE=mysql",
-                 successful:       true,
-                 stdout:           "RUBY=1.9 DATABASE=mysql\nFinish: RUBY=1.9, DATABASE=mysql\n"
-               )
+          job_name:         "RUBY_1.9_DATABASE_mysql",
+          params:           { "RUBY" => "1.9", "DATABASE" => "mysql" },
+          formatted_params: "RUBY=1.9, DATABASE=mysql",
+          successful:       true,
+          stdout:           "RUBY=1.9 DATABASE=mysql\nFinish: RUBY=1.9, DATABASE=mysql\n"
+        )
       end
 
       its(:jobs) do
         should include(
-                 job_name:         "RUBY_2.0_DATABASE_postgresql",
-                 params:           { "RUBY" => "2.0", "DATABASE" => "postgresql" },
-                 formatted_params: "RUBY=2.0, DATABASE=postgresql",
-                 successful:       true,
-                 stdout:           "RUBY=2.0 DATABASE=postgresql\nFinish: RUBY=2.0, DATABASE=postgresql\n"
-               )
+          job_name:         "RUBY_2.0_DATABASE_postgresql",
+          params:           { "RUBY" => "2.0", "DATABASE" => "postgresql" },
+          formatted_params: "RUBY=2.0, DATABASE=postgresql",
+          successful:       true,
+          stdout:           "RUBY=2.0 DATABASE=postgresql\nFinish: RUBY=2.0, DATABASE=postgresql\n"
+        )
       end
 
       context "When work_dir is not empty" do
@@ -139,11 +139,11 @@ describe Paraduct::ParallelRunner do
           end
 
           it_behaves_like :create_job_directories do
-            let(:job_name){ "RUBY_1.9_DATABASE_mysql" }
+            let(:job_name) { "RUBY_1.9_DATABASE_mysql" }
           end
 
           it_behaves_like :create_job_directories do
-            let(:job_name){ "RUBY_2.0_DATABASE_postgresql" }
+            let(:job_name) { "RUBY_2.0_DATABASE_postgresql" }
           end
         end
       end
@@ -160,11 +160,11 @@ describe Paraduct::ParallelRunner do
           end
 
           it_behaves_like :dont_create_job_directories do
-            let(:job_name){ "RUBY_1.9_DATABASE_mysql" }
+            let(:job_name) { "RUBY_1.9_DATABASE_mysql" }
           end
 
           it_behaves_like :dont_create_job_directories do
-            let(:job_name){ "RUBY_2.0_DATABASE_postgresql" }
+            let(:job_name) { "RUBY_2.0_DATABASE_postgresql" }
           end
         end
       end

data/spec/paraduct/runner_spec.rb

@@ -3,22 +3,25 @@ describe Paraduct::Runner do
     Paraduct::Runner.new(
       params:       params,
       base_job_dir: base_job_dir,
-      job_id:       job_id,
+      job_id:       job_id
     )
   end
 
   include_context "uses temp dir"
 
-  let(:base_job_dir){ temp_dir }
+  let(:base_job_dir) { temp_dir }
   let(:params)      { {} }
   let(:job_id)      { 1 }
 
   describe "#perform" do
-    subject{ runner.perform(script) }
+    subject { runner.perform(script) }
 
     let(:script) { "./script/build_success.sh" }
     let(:params) { { "RUBY" => "1.9", "DATABASE" => "mysql" } }
-    let(:command){ 'export PARADUCT_JOB_ID="1"; export PARADUCT_JOB_NAME="RUBY_1.9_DATABASE_mysql"; export RUBY="1.9"; export DATABASE="mysql"; ./script/build_success.sh' }
+
+    # rubocop:disable Metrics/LineLength
+    let(:command) { 'export PARADUCT_JOB_ID="1"; export PARADUCT_JOB_NAME="RUBY_1.9_DATABASE_mysql"; export RUBY="1.9"; export DATABASE="mysql"; ./script/build_success.sh' }
+    # rubocop:enable Metrics/LineLength
 
     context "with mock system" do
       it "script is call with capitalized variable" do
@@ -31,12 +34,12 @@ describe Paraduct::Runner do
       include_context :within_spec_dir
 
       context "when success" do
-        it { should match /RUBY=1.9/ }
-        it { should match /DATABASE=mysql/ }
+        it { should match(/RUBY=1.9/) }
+        it { should match(/DATABASE=mysql/) }
       end
 
       context "when error in script file" do
-        let(:script){ "./script/build_error.sh" }
+        let(:script) { "./script/build_error.sh" }
 
         let(:stdout) do
           <<-EOS
@@ -45,25 +48,25 @@ DATABASE=mysql
           EOS
         end
 
-        it { expect{ subject }.to raise_error(Paraduct::Errors::ProcessError, stdout) }
+        it { expect { subject }.to raise_error(Paraduct::Errors::ProcessError, stdout) }
       end
     end
 
     context "with single command" do
-      let(:script){ 'echo RUBY=${RUBY}' }
+      let(:script) { "echo RUBY=${RUBY}" }
 
       it { should eq "RUBY=1.9\n" }
     end
 
     context "with multiple commands" do
-      let(:script){ ['echo RUBY=${RUBY}', 'echo DATABASE=${DATABASE}'] }
+      let(:script) { ["echo RUBY=${RUBY}", "echo DATABASE=${DATABASE}"] }
 
       it { should eq "RUBY=1.9\nDATABASE=mysql\n" }
     end
   end
 
   describe "#job_dir" do
-    subject{ runner.job_dir }
+    subject { runner.job_dir }
 
     let(:params) { { "RUBY" => "1.9", "DATABASE" => "mysql" } }
 
@@ -71,15 +74,15 @@ DATABASE=mysql
   end
 
   describe "#formatted_params" do
-    subject{ runner.formatted_params }
+    subject { runner.formatted_params }
 
-    let(:params){ { "RUBY" => "1.9", "DATABASE" => "mysql" } }
+    let(:params) { { "RUBY" => "1.9", "DATABASE" => "mysql" } }
 
-    it{ should eq "RUBY=1.9, DATABASE=mysql" }
+    it { should eq "RUBY=1.9, DATABASE=mysql" }
   end
 
   describe "#job_name" do
-    subject{ runner.job_name }
+    subject { runner.job_name }
 
     context "basic case" do
       let(:params) { { "RUBY" => "1.9", "DATABASE" => "mysql" } }

data/spec/paraduct/sync_utils_spec.rb

@@ -1,6 +1,6 @@
 describe Paraduct::SyncUtils do
   describe "#copy_recursive" do
-    subject{ Paraduct::SyncUtils.copy_recursive(source_dir, destination_dir) }
+    subject { Paraduct::SyncUtils.copy_recursive(source_dir, destination_dir) }
 
     include_context :within_temp_dir
     include_context :stub_configuration
@@ -13,10 +13,10 @@ describe Paraduct::SyncUtils do
       }
     end
 
-    let(:source_dir)     { temp_dir_path }
-    let(:destination_dir){ temp_dir_path.join("tmp/paraduct_workspace/RUBY_1.9_DATABASE_mysql") }
-    let(:copied_file)    { destination_dir.join("build_success.sh") }
-    let(:not_copied_file){ destination_dir.join("tmp/paraduct_workspace/dummy.txt") }
+    let(:source_dir) { temp_dir_path }
+    let(:destination_dir) { temp_dir_path.join("tmp/paraduct_workspace/RUBY_1.9_DATABASE_mysql") }
+    let(:copied_file) { destination_dir.join("build_success.sh") }
+    let(:not_copied_file) { destination_dir.join("tmp/paraduct_workspace/dummy.txt") }
 
     before do
       # setup