para 0.9.3.2 → 0.9.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6deb45940599a543b4257463561e645256df1db47b9cef62f1d287b97e841abd
-  data.tar.gz: a37ab4aca7ab0c23baf41a65083c84bdbdb6d6fe12437621b08f9a4f49baf22d
+  metadata.gz: 45b33c0018d1c19e222c84f62ef8c0eb3820fbbe60dcc6c99da7a40bf229fc1b
+  data.tar.gz: fe48b49c545495cc4103418d4c75f3d34447b1003ef690ac45076768509cfc30
 SHA512:
-  metadata.gz: 229be291a706963be79ef902fb99fdedad27092a62f8c855d912b57c21d10f94ed8e9ffd254a9bb1f29ae465ab6ec1cbe3753af53096778ce6131bdca83ef3b3
-  data.tar.gz: 10e5675bb29448fd949112632bda77b2dc897d7ca3b2d2dd8dfbac4ef47a19d8ddf629aa6ef40cea98dbfed05bfc716afe8fe06b1c57b950e2af8b541f859672
+  metadata.gz: f8e403bd825fbeba4dd042eb2a01a0f17562b9ab145ec400aa216ed81ed07e483b2b22984e9c6a63b55408367ef7b0faf7022e931a262fe61640a1fffc7c03da
+  data.tar.gz: c9e6a4da03d11873890d5c7c1c338f109fe03f0ebfe605022b304bce43758f650e05580df1899b5c68bfe523d47b16e3988f86ed5247b9e999bd4dd1816fef87

data/lib/para/breadcrumbs/controller.rb

@@ -2,6 +2,7 @@ module Para
   module Breadcrumbs
     module Controller
       extend ActiveSupport::Concern
+      include ActionController::Helpers
 
       included do
         class_attribute :_class_level_breadcrumbs

data/lib/para/cloneable/include_tree_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Para
   module Cloneable
     # This object acts as a service to compile a nested cloneable options hash to be
@@ -49,7 +51,7 @@ module Para
     #          }
     #
     class IncludeTreeBuilder
-      attr_reader :resource,  :cloneable_options
+      attr_reader :resource, :cloneable_options
 
       def initialize(resource)
         @resource = resource
@@ -73,26 +75,56 @@ module Para
       # if it exist, which include the attributes that shouldn't be duplicated when
       # the resource is cloned.
       #
-      def build_cloneable_options_tree(resource)
+      def build_cloneable_options_tree(resource, path = [])
         cloneable_options = resource.cloneable_options
-        options = {}
 
         # Iterate over the resource's cloneable options' :include array and recursively
         # add nested included resources to its own included resources.
         options = cloneable_options[:include].each_with_object({}) do |reflection_name, hash|
+          # This avoids cyclic dependencies issues by stopping nested association
+          # inclusions before the cycle starts.
+          #
+          # For example, if a post includes its author, and the author includes its posts,
+          # this would make the system fail with a stack level too deep error. Here this
+          # guard allows the inclusion to stop at :
+          #
+          #   { posts: { author: { posts: { author: {}}}}}
+          #
+          # Which ensures that, using the dictionary strategy of deep_cloneable, all
+          # posts' authors' posts will have their author mapped to an already cloned
+          # author when it comes to cloning the "author" 4th level of the include tree.
+          #
+          # This is not the most optimized solution, but works well enough as if the
+          # author's posts match previously cloned posts, they won't be cloned as they'll
+          # exist in the cloned resources dictionary.
+          next if path.length >= 4 &&
+                  path[-4] == path[-2] &&
+                  path[-2] == reflection_name &&
+                  path[-3] == path[-1]
+
           hash[reflection_name] = {}
 
-          if (reflection = resource.class.reflections[reflection_name.to_s])
-            reflection_options = hash[reflection_name]
-            association_target = resource.send(reflection_name)
+          unless (reflection = resource.class.reflections[reflection_name.to_s])
+            next
+          end
 
-            if reflection.collection?
-              association_target.each do |nested_resource|
-                add_reflection_options(reflection_options, nested_resource)
-              end
-            else
-              add_reflection_options(reflection_options, association_target)
+          reflection_options = hash[reflection_name]
+          association_target = resource.send(reflection_name)
+
+          if reflection.collection?
+            association_target.each do |nested_resource|
+              add_reflection_options(
+                reflection_options,
+                nested_resource,
+                [*path, reflection_name]
+              )
             end
+          else
+            add_reflection_options(
+              reflection_options,
+              association_target,
+              [*path, reflection_name]
+            )
           end
         end
 
@@ -104,11 +136,11 @@ module Para
         options
       end
 
-      def add_reflection_options(reflection_options, nested_resource)
+      def add_reflection_options(reflection_options, nested_resource, path)
         options = nested_resource.class.try(:cloneable_options)
         return reflection_options unless options
 
-        target_options = build_cloneable_options_tree(nested_resource)
+        target_options = build_cloneable_options_tree(nested_resource, path)
         reflection_options.deep_merge!(target_options)
       end
 

data/lib/para/components_cleaner.rb

@@ -1,17 +1,21 @@
+# frozen_string_literal: true
+
 module Para
   class ComponentsCleaner
     # Hide class instanciation
-    def self.run; new.run; end
+    def self.run
+      new.run
+    end
 
     def run
       components.each do |component|
-        unless component == Para.components.component_for(component.identifier)
+        if component.id != Para.components.components_ids_hash[component.identifier]
           component.destroy
         end
       end
 
       Para::ComponentSection.find_each do |section|
-        unless Para.components.section_for(section.identifier)
+        unless Para.components.sections_ids_hash[section.identifier]
           section.destroy
         end
       end

data/lib/para/components_configuration.rb

@@ -76,6 +76,14 @@ module Para
       nil
     end
 
+    def sections_ids_hash
+      @sections_ids_hash ||= {}.with_indifferent_access
+    end
+
+    def components_ids_hash
+      @components_ids_hash ||= {}.with_indifferent_access
+    end
+
     private
 
     def build
@@ -93,14 +101,6 @@ module Para
       end
     end
 
-    def sections_ids_hash
-      @sections_ids_hash ||= {}.with_indifferent_access
-    end
-
-    def components_ids_hash
-      @components_ids_hash ||= {}.with_indifferent_access
-    end
-
     # Only store sections cache for the request duration to avoid expired
     # references to AR objects between requests
     #

data/lib/para/inputs/multi_select_input.rb

@@ -88,6 +88,8 @@ module Para
           join_resources.find do |res|
             res.send(attribute_field.through_relation_source_foreign_key) == resource.id
           end
+        else
+          resource
         end
 
         existing_resource.position

data/lib/para/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Para
-  VERSION = '0.9.3.2'
+  VERSION = '0.9.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: para
 version: !ruby/object:Gem::Version
-  version: 0.9.3.2
+  version: 0.9.4
 platform: ruby
 authors:
 - Valentin Ballestrino
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2021-12-02 00:00:00.000000000 Z
+date: 2022-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -19,7 +19,7 @@ dependencies:
         version: '4.0'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '4.0'
     - - "<="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '8.0'
 - !ruby/object:Gem::Dependency
   name: rails-i18n
   requirement: !ruby/object:Gem::Requirement
@@ -852,7 +852,7 @@ homepage: http://github.com/glyph-fr/para
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -867,8 +867,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.1.4
-signing_key: 
+rubygems_version: 3.3.7
+signing_key:
 specification_version: 4
 summary: Rails admin engine
 test_files: []