para 0.9.3.2 → 0.9.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6deb45940599a543b4257463561e645256df1db47b9cef62f1d287b97e841abd
-  data.tar.gz: a37ab4aca7ab0c23baf41a65083c84bdbdb6d6fe12437621b08f9a4f49baf22d
+  metadata.gz: 8f742ef6484e0ccd595c1a79e219f4cb2a03c72a7fbf9f584990c638412f19e0
+  data.tar.gz: 8c231925d6c2ecc4d0eb7208c5c4b530410d1a30d8a1276d849f31d3e52f5f76
 SHA512:
-  metadata.gz: 229be291a706963be79ef902fb99fdedad27092a62f8c855d912b57c21d10f94ed8e9ffd254a9bb1f29ae465ab6ec1cbe3753af53096778ce6131bdca83ef3b3
-  data.tar.gz: 10e5675bb29448fd949112632bda77b2dc897d7ca3b2d2dd8dfbac4ef47a19d8ddf629aa6ef40cea98dbfed05bfc716afe8fe06b1c57b950e2af8b541f859672
+  metadata.gz: e42df31fcb4d4d490f5b5127939494fbc9e07855ee1123fd720f089c2e36737b4e1f706b347d36699270ed00eeeb4a228ca81050bdc8ae35b84bbde8a7dfd7b6
+  data.tar.gz: 707696ad2b1f6a2c43f6944f6543ca5dd8dd5a17c3c91942d0d3c38b43e5d2c652d1b76a35409c2de0019c11658f81a6922931d3e4126a6490a77ed189bd8e8a

data/lib/para/cloneable/include_tree_builder.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 module Para
   module Cloneable
     # This object acts as a service to compile a nested cloneable options hash to be
@@ -49,7 +51,7 @@ module Para
     #          }
     #
     class IncludeTreeBuilder
-      attr_reader :resource,  :cloneable_options
+      attr_reader :resource, :cloneable_options
 
       def initialize(resource)
         @resource = resource
@@ -73,26 +75,56 @@ module Para
       # if it exist, which include the attributes that shouldn't be duplicated when
       # the resource is cloned.
       #
-      def build_cloneable_options_tree(resource)
+      def build_cloneable_options_tree(resource, path = [])
         cloneable_options = resource.cloneable_options
-        options = {}
 
         # Iterate over the resource's cloneable options' :include array and recursively
         # add nested included resources to its own included resources.
         options = cloneable_options[:include].each_with_object({}) do |reflection_name, hash|
+          # This avoids cyclic dependencies issues by stopping nested association
+          # inclusions before the cycle starts.
+          #
+          # For example, if a post includes its author, and the author includes its posts,
+          # this would make the system fail with a stack level too deep error. Here this
+          # guard allows the inclusion to stop at :
+          #
+          #   { posts: { author: { posts: { author: {}}}}}
+          #
+          # Which ensures that, using the dictionary strategy of deep_cloneable, all
+          # posts' authors' posts will have their author mapped to an already cloned
+          # author when it comes to cloning the "author" 4th level of the include tree.
+          #
+          # This is not the most optimized solution, but works well enough as if the
+          # author's posts match previously cloned posts, they won't be cloned as they'll
+          # exist in the cloned resources dictionary.
+          next if path.length >= 4 &&
+                  path[-4] == path[-2] &&
+                  path[-2] == reflection_name &&
+                  path[-3] == path[-1]
+
           hash[reflection_name] = {}
 
-          if (reflection = resource.class.reflections[reflection_name.to_s])
-            reflection_options = hash[reflection_name]
-            association_target = resource.send(reflection_name)
+          unless (reflection = resource.class.reflections[reflection_name.to_s])
+            next
+          end
 
-            if reflection.collection?
-              association_target.each do |nested_resource|
-                add_reflection_options(reflection_options, nested_resource)
-              end
-            else
-              add_reflection_options(reflection_options, association_target)
+          reflection_options = hash[reflection_name]
+          association_target = resource.send(reflection_name)
+
+          if reflection.collection?
+            association_target.each do |nested_resource|
+              add_reflection_options(
+                reflection_options,
+                nested_resource,
+                [*path, reflection_name]
+              )
             end
+          else
+            add_reflection_options(
+              reflection_options,
+              association_target,
+              [*path, reflection_name]
+            )
           end
         end
 
@@ -104,11 +136,11 @@ module Para
         options
       end
 
-      def add_reflection_options(reflection_options, nested_resource)
+      def add_reflection_options(reflection_options, nested_resource, path)
         options = nested_resource.class.try(:cloneable_options)
         return reflection_options unless options
 
-        target_options = build_cloneable_options_tree(nested_resource)
+        target_options = build_cloneable_options_tree(nested_resource, path)
         reflection_options.deep_merge!(target_options)
       end
 

data/lib/para/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Para
-  VERSION = '0.9.3.2'
+  VERSION = '0.9.3.3'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: para
 version: !ruby/object:Gem::Version
-  version: 0.9.3.2
+  version: 0.9.3.3
 platform: ruby
 authors:
 - Valentin Ballestrino