para 0.12.5 → 0.12.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bac06958cd2f4e9d4d35a59338f77934fcb812341d56778e2284f8165a18b978
-  data.tar.gz: '085f64e0d60c60e5562219db39a1fdc90d37eaa3e549918bed9a80814ac3acca'
+  metadata.gz: 5339b2dc5c28403fd3e4ba08fbb1bfc7b2b2196269f9927d25eb1d428eb99d71
+  data.tar.gz: 6266de04143dbd8e18aa9826e8a007d2d96909d4d4f6d9704791e30893f0cffe
 SHA512:
-  metadata.gz: 6f32e3e3bd4c33a87ca98f900a0d46d03cc005737eb9131dd3395cb7247e0e926d45ceeefb2c8215f87eda98c19f77dd3e59b841d84dd544e250010fb8422f8f
-  data.tar.gz: 748a7875b0783387d1ebb8fbcb545827431e908aedd5381580a6aeed0703acf7354ef9aec4d03899110574e6cdd9071555519d86b441d0b812047bb6c56063af
+  metadata.gz: aa7cfd1587567f56a06853bfc0acf74736d4082d79a59f51af90de4fc4afc4fc840085e1e4580aa8372eee4e6e2299584f262ba7d064ee47fffc4abf71ed6fd9
+  data.tar.gz: 5ad58a35c8f690c2ce70063f12cc04ebf0f2e1b812ea22c8f2918193f16e3b7f98a4758b0a780affbb3e7e72a4f319906dae122c650bd3c183aba84ac2a4db14

data/app/views/para/admin/nested_forms/show.html.haml

@@ -13,6 +13,5 @@
   - form.object_name = @object_name
   - nested_form = capture do
     = render(partial: find_partial_for(@model, :remote_nested_form), locals: { form: form, model: @model, object: @object, object_name: @object_name })
-    = form.attributes_mappings_field_for(form)
 
 = nested_form

data/app/views/para/inputs/nested_many/_add.html.haml

@@ -1,2 +1,2 @@
-= link_to_add_association form, attribute_name, partial: find_partial_for(model, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: "btn btn-shadow add-button nested-many-inset-add-button #{add_button_class}", data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, locals: { model: model, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, allow_destroy_if: allow_destroy_if, render_partial: render_partial, remote_partial_params: remote_partial_params } } do
+= link_to_add_association form, attribute_name, partial: find_partial_for(model, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: "btn btn-shadow add-button nested-many-inset-add-button #{add_button_class}", data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, track_attribute_mappings: render_partial, locals: { model: model, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, allow_destroy_if: allow_destroy_if, render_partial: render_partial, remote_partial_params: remote_partial_params } } do
   = add_button_label

data/app/views/para/inputs/nested_many/_add_with_subclasses.html.haml

@@ -1,7 +1,7 @@
 - if subclasses.one?
   - submodel = subclasses.first
 
-  = link_to_add_association form, attribute_name, wrap_object: proc { with_inverse_association_for(submodel.new, attribute_name, form.object) }, partial: find_partial_for(model, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: "btn btn-shadow add-button nested-many-inset-add-button #{add_button_class}", data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, locals: { model: submodel, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, render_partial: render_partial, remote_partial_params: remote_partial_params, allow_destroy_if: allow_destroy_if } } do
+  = link_to_add_association form, attribute_name, wrap_object: proc { with_inverse_association_for(submodel.new, attribute_name, form.object) }, partial: find_partial_for(model, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: "btn btn-shadow add-button nested-many-inset-add-button #{add_button_class}", data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, track_attribute_mappings: render_partial, locals: { model: submodel, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, render_partial: render_partial, remote_partial_params: remote_partial_params, allow_destroy_if: allow_destroy_if } } do
     = add_button_label
 - else
   .add-button.nested-many-inset-add-button.dropdown
@@ -11,5 +11,5 @@
     %ul.dropdown-menu
       - subclasses.each do |submodel|
         %li
-          = link_to_add_association form, attribute_name, wrap_object: proc { with_inverse_association_for(submodel.new, attribute_name, form.object) }, partial: find_partial_for(submodel, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: 'dropdown-link', data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, locals: { model: submodel, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, allow_destroy_if: allow_destroy_if, render_partial: render_partial, remote_partial_params: remote_partial_params } } do
+          = link_to_add_association form, attribute_name, wrap_object: proc { with_inverse_association_for(submodel.new, attribute_name, form.object) }, partial: find_partial_for(submodel, 'nested_many/container', partial_dir: 'inputs'), form_name: 'form', class: 'dropdown-link', data: { :'association-insertion-node' => "##{ dom_identifier }", :'association-insertion-method' => 'append' }, render_options: { nested_attribute_name: attribute_name, orderable: orderable, track_attribute_mappings: render_partial, locals: { model: submodel, nested_locals: nested_locals, inset: inset, uncollapsed: uncollapsed, allow_destroy_if: allow_destroy_if, render_partial: render_partial, remote_partial_params: remote_partial_params } } do
             = submodel.model_name.human

data/lib/para/cloneable/include_tree_builder.rb

@@ -97,10 +97,7 @@ module Para
           # This is not the most optimized solution, but works well enough as if the
           # author's posts match previously cloned posts, they won't be cloned as they'll
           # exist in the cloned resources dictionary.
-          next if path.length >= 4 &&
-                  path[-4] == path[-2] &&
-                  path[-2] == reflection_name &&
-                  path[-3] == path[-1]
+          next if circular_reference?(path, reflection_name)
 
           hash[reflection_name] = {}
 
@@ -140,6 +137,8 @@ module Para
         options = nested_resource.class.try(:cloneable_options)
         return reflection_options unless options
 
+        puts "Building cloneable options for #{nested_resource.class.name} at path #{path.join(' -> ')}"
+
         target_options = build_cloneable_options_tree(nested_resource, path)
         reflection_options.deep_merge!(target_options)
       end
@@ -191,6 +190,43 @@ module Para
 
         deep_relations.empty? ? shallow_relations : shallow_relations + [deep_relations]
       end
+
+      # Checks if adding reflection_name to the path would create a circular reference
+      # of 2 levels deep with a cycle length between 2 and 10.
+      #
+      # Examples of detected patterns:
+      #
+      #   Length 2: [:a, :b, :a, :b]
+      #   Length 3: [:a, :b, :c, :a, :b, :c]
+      #   Length 4: [:a, :b, :c, :d, :a, :b, :c, :d]
+      #
+      def circular_reference?(path, reflection_name)
+        # Check for cycle lengths from 2 to 10
+        (2..10).each do |cycle_length|
+          # We need at least 2 * cycle_length elements in the path to detect a cycle
+          required_length = cycle_length * 2
+          next if path.length < required_length
+
+          # Check if the pattern repeats exactly twice
+          # The new reflection_name would be at position -cycle_length
+          match = true
+
+          # First, check if the element at -cycle_length position matches reflection_name
+          next unless path[-cycle_length] == reflection_name
+
+          # Then check if all other elements in the first cycle match the second cycle
+          (1...cycle_length).each do |offset|
+            if path[-(cycle_length + offset)] != path[-offset]
+              match = false
+              break
+            end
+          end
+
+          return true if match
+        end
+
+        false
+      end
     end
   end
 end

data/lib/para/form_builder/attributes_mappings_tracker.rb

@@ -1,7 +1,7 @@
 module Para
   module FormBuilder
     module AttributesMappingsTracker
-      def initialize(*) #:nodoc:
+      def initialize(*) # :nodoc:
         @attributes_mappings = {}
 
         super
@@ -22,10 +22,9 @@ module Para
       def fields_for(*args, &block)
         fields_options = args.extract_options!
 
-        track_attribute_mappings = (
+        track_attribute_mappings =
           fields_options[:track_attribute_mappings] != false &&
           options[:track_attribute_mappings]
-        )
 
         fields_options.reverse_merge!(
           track_attribute_mappings: track_attribute_mappings
@@ -42,7 +41,7 @@ module Para
         return unless options[:track_attribute_mappings]
 
         hidden_field :_attributes_mappings, value: @attributes_mappings.to_json,
-                     data: { :'attributes-mappings' => fields.options[:child_index] }
+                                            data: { 'attributes-mappings': fields.options[:child_index] }
       end
 
       private
@@ -51,11 +50,11 @@ module Para
         return unless options[:track_attribute_mappings]
 
         type = if input_options[:as]
-          input_options[:as]
-        else
-          input = find_input(attribute_name, input_options, &block)
-          input.class.name.demodulize.underscore.gsub(/_input\z/, '')
-        end
+                 input_options[:as]
+               else
+                 input = find_input(attribute_name, input_options, &block)
+                 input.class.name.demodulize.underscore.gsub(/_input\z/, '')
+               end
 
         @attributes_mappings[attribute_name] = type
       end

data/lib/para/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Para
-  VERSION = '0.12.5'
+  VERSION = '0.12.7'
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: para
 version: !ruby/object:Gem::Version
-  version: 0.12.5
+  version: 0.12.7
 platform: ruby
 authors:
 - Valentin Ballestrino
-autorequire:
 bindir: bin
 cert_chain: []
-date: 2025-02-10 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: active_decorator
@@ -777,7 +776,6 @@ homepage: http://github.com/glyph-fr/para
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -792,8 +790,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.16
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Rails admin engine
 test_files: []