papierkram_api_client 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a1a03790a5079d46fc57b6efa84682046fbfd4f4e916e68fd9e4132863dc07c3
-  data.tar.gz: b6edd7e886bcaf9a9f761fec07494c2f6e292f77b946e0fc2f2ee33b8228d60e
+  metadata.gz: 149edeeed9ee09d36a1c017a9a831eb00dcf347c507d89b37c498bef24ff87f6
+  data.tar.gz: 48e326b8fc0c92af833e8e928daba56ca0b8f9d28e3d2490af07ffad5cf317de
 SHA512:
-  metadata.gz: 299c6bcf0f35da94d1e1e6298f2aee5cc70b4eaddc3abe2e36fd051a3286290f9182f87331debc8c79f4ddca429f4fbb14aa4a95c0276fa857177165ab7ac36f
-  data.tar.gz: df625c5ce0e31b68b4ebcbd80e681d58674396843c43f5631544891b6e8eeeef1e788d19b38930e3cd4555755444b5e7430ebee7610df2550d22225d136df2b5
+  metadata.gz: fc5b3801503c34095ae1cad9695e78eb749ba8b1c65f2704978bda859640f8e342339aaa1a7b0354a672be2433366bee7436ec6d57b42eaa560216dde9f025e8
+  data.tar.gz: 669678b6e1cc39a506c95ad3d05ab705acbc3ee51f0377ef682ad06b7b1b0daacceb58b8c3da7a9e692f7d7960a7faeac51e2af11c9d79be3d735feb26b31304

data/.rubocop.yml

@@ -33,6 +33,7 @@ Metrics/ParameterLists:
     - "lib/api/v1/**/*"
 
 Metrics/ClassLength:
+  Max: 150
   CountAsOne:
     - "array"
     - "hash"

data/CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+[0.2.4] - 2023-06-30
+
+#### Fixed
+
+- [#48](https://github.com/simonneutert/papierkram_api_client/pull/48) Arguments weren't truly optional when possible. [@simonneutert](https://github.com/simonneutert)
+
 [0.2.3] - 2023-06-29
 
 ### Added

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    papierkram_api_client (0.2.3)
+    papierkram_api_client (0.2.4)
       faraday (~> 2.7)
       httpx (>= 0.22.5, < 0.25.0)
 

data/lib/papierkram_api/v1/endpoints/contact/companies.rb

@@ -24,7 +24,7 @@ module PapierkramApi
             get("#{@url_api_path}/contact/companies", query)
           end
 
-          def create_supplier( # rubocop:disable Metrics/ParameterLists
+          def create_supplier( # rubocop:disable Metrics/ParameterLists, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
             name:,
             phone: nil,
             fax: nil,
@@ -50,37 +50,36 @@ module PapierkramApi
             color: nil
           )
 
-            body = {
-              contact_type: :supplier,
-              name: name,
-              phone: phone,
-              fax: fax,
-              email: email,
-              delivery_method: delivery_method,
-              ust_idnr: ust_idnr,
-              website: website,
-              twitter: twitter,
-              postal_street: postal_street,
-              postal_city: postal_city,
-              postal_zip: postal_zip,
-              postal_country: postal_country,
-              physical_street: physical_street,
-              physical_city: physical_city,
-              physical_zip: physical_zip,
-              physical_country: physical_country,
-              bank_blz: bank_blz,
-              bank_institute: bank_institute,
-              bank_account_no: bank_account_no,
-              bank_bic: bank_bic,
-              bank_iban: bank_iban,
-              notes: notes,
-              color: color
-            }
+            body = {}
+            body[:contact_type] = 'supplier'
+            body[:name] = name
+            body[:phone] = phone if phone
+            body[:fax] = fax if fax
+            body[:email] = email if email
+            body[:delivery_method] = delivery_method if delivery_method
+            body[:ust_idnr] = ust_idnr if ust_idnr
+            body[:website] = website if website
+            body[:twitter] = twitter if twitter
+            body[:postal_street] = postal_street if postal_street
+            body[:postal_city] = postal_city if postal_city
+            body[:postal_zip] = postal_zip if postal_zip
+            body[:postal_country] = postal_country if postal_country
+            body[:physical_street] = physical_street if physical_street
+            body[:physical_city] = physical_city if physical_city
+            body[:physical_zip] = physical_zip if physical_zip
+            body[:physical_country] = physical_country if physical_country
+            body[:bank_blz] = bank_blz if bank_blz
+            body[:bank_institute] = bank_institute if bank_institute
+            body[:bank_account_no] = bank_account_no if bank_account_no
+            body[:bank_bic] = bank_bic if bank_bic
+            body[:bank_iban] = bank_iban if bank_iban
+            body[:notes] = notes if notes
+            body[:color] = color if color
 
             post("#{@url_api_path}/contact/companies", body)
           end
 
-          def create_customer( # rubocop:disable Metrics/ParameterLists
+          def create_customer( # rubocop:disable Metrics/ParameterLists, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/MethodLength, Metrics/PerceivedComplexity
             name:,
             phone: nil,
             fax: nil,
@@ -106,32 +105,31 @@ module PapierkramApi
             color: nil
           )
 
-            body = {
-              contact_type: :customer,
-              name: name,
-              phone: phone,
-              fax: fax,
-              email: email,
-              delivery_method: delivery_method,
-              ust_idnr: ust_idnr,
-              website: website,
-              twitter: twitter,
-              postal_street: postal_street,
-              postal_city: postal_city,
-              postal_zip: postal_zip,
-              postal_country: postal_country,
-              physical_street: physical_street,
-              physical_city: physical_city,
-              physical_zip: physical_zip,
-              physical_country: physical_country,
-              bank_blz: bank_blz,
-              bank_institute: bank_institute,
-              bank_account_no: bank_account_no,
-              bank_bic: bank_bic,
-              bank_iban: bank_iban,
-              notes: notes,
-              color: color
-            }
+            body = {}
+            body[:contact_type] = 'customer'
+            body[:name] = name
+            body[:phone] = phone if phone
+            body[:fax] = fax if fax
+            body[:email] = email if email
+            body[:delivery_method] = delivery_method if delivery_method
+            body[:ust_idnr] = ust_idnr if ust_idnr
+            body[:website] = website if website
+            body[:twitter] = twitter if twitter
+            body[:postal_street] = postal_street if postal_street
+            body[:postal_city] = postal_city if postal_city
+            body[:postal_zip] = postal_zip if postal_zip
+            body[:postal_country] = postal_country if postal_country
+            body[:physical_street] = physical_street if physical_street
+            body[:physical_city] = physical_city if physical_city
+            body[:physical_zip] = physical_zip if physical_zip
+            body[:physical_country] = physical_country if physical_country
+            body[:bank_blz] = bank_blz if bank_blz
+            body[:bank_institute] = bank_institute if bank_institute
+            body[:bank_account_no] = bank_account_no if bank_account_no
+            body[:bank_bic] = bank_bic if bank_bic
+            body[:bank_iban] = bank_iban if bank_iban
+            body[:notes] = notes if notes
+            body[:color] = color if color
 
             post("#{@url_api_path}/contact/companies", body)
           end

data/lib/papierkram_api/v1/endpoints/contact/companies_persons.rb

@@ -22,7 +22,7 @@ module PapierkramApi
             get("#{@url_api_path}/contact/companies/#{company_id}/persons", query)
           end
 
-          def create( # rubocop:disable Metrics/ParameterLists
+          def create( # rubocop:disable Metrics/ParameterLists, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
             company_id:,
             first_name:,
             last_name:,
@@ -37,20 +37,19 @@ module PapierkramApi
             skype: nil,
             comment: nil
           )
-            body = {
-              first_name: first_name,
-              last_name: last_name,
-              title: title,
-              salutation: salutation,
-              position: position,
-              department: department,
-              email: email,
-              phone: phone,
-              mobile: mobile,
-              fax: fax,
-              skype: skype,
-              comment: comment
-            }
+            body = {}
+            body[:first_name] = first_name
+            body[:last_name] = last_name
+            body[:title] = title if title
+            body[:salutation] = salutation if salutation
+            body[:position] = position if position
+            body[:department] = department if department
+            body[:email] = email if email
+            body[:phone] = phone if phone
+            body[:mobile] = mobile if mobile
+            body[:fax] = fax if fax
+            body[:skype] = skype if skype
+            body[:comment] = comment if comment
 
             post("#{@url_api_path}/contact/companies/#{company_id}/persons", body)
           end

data/lib/papierkram_api/v1/endpoints/income/propositions.rb

@@ -21,24 +21,23 @@ module PapierkramApi
             time_unit: nil,
             proposition_type: nil,
             price: nil,
-            vat_rate: ''
+            vat_rate: nil
           )
-            body = {
-              name: name,
-              article_no: article_no,
-              description: description,
-              time_unit: time_unit,
-              proposition_type: proposition_type,
-              price: price,
-              vat_rate: vat_rate
-            }
+
+            body = {}
+            body[:name] = name
+            body[:article_no] = article_no
+            body[:description] = description if description
+            body[:time_unit] = time_unit if time_unit
+            body[:proposition_type] = proposition_type if proposition_type
+            body[:price] = price if price
+            body[:vat_rate] = vat_rate if vat_rate
+
             post("#{@url_api_path}/income/propositions", body)
           end
 
           def update_by(id:, attributes: {})
-            attributes[:vat_rate] ||= attributes['vat_rate']
-            attributes[:vat_rate] ||= ''
-            if attributes[:vat_rate].empty? || !attributes[:vat_rate].include?('%')
+            if attributes[:vat_rate] && (attributes[:vat_rate].empty? || !attributes[:vat_rate].include?('%'))
               raise ArgumentError, 'vat_rate must be a percentage and include a % sign'
             end
 

data/lib/papierkram_api/v1/endpoints/projects.rb

@@ -21,7 +21,7 @@ module PapierkramApi
           get("#{@url_api_path}/projects", query)
         end
 
-        def create( # rubocop:disable Metrics/ParameterLists
+        def create( # rubocop:disable Metrics/ParameterLists, Metrics/AbcSize, Metrics/CyclomaticComplexity, Metrics/PerceivedComplexity
           name:,
           customer_id:,
           description: nil,
@@ -33,24 +33,24 @@ module PapierkramApi
           budget_time: nil,
           budget_time_unit: nil,
           color: nil,
-          default_proposition: {},
-          team_members: []
+          default_proposition: nil,
+          team_members: nil
         )
-          body = {
-            name: name,
-            description: description,
-            start_date: start_date,
-            end_date: end_date,
-            flagged: flagged,
-            budget_type: budget_type,
-            budget_money: budget_money,
-            budget_time: budget_time,
-            budget_time_unit: budget_time_unit,
-            color: color,
-            customer: { id: customer_id },
-            default_proposition: default_proposition,
-            team_members: team_members
-          }
+
+          body = {}
+          body[:name] = name
+          body[:customer] = { id: customer_id }
+          body[:description] = description if description
+          body[:start_date] = start_date if start_date
+          body[:end_date] = end_date if end_date
+          body[:flagged] = flagged if flagged
+          body[:budget_type] = budget_type if budget_type
+          body[:budget_money] = budget_money if budget_money
+          body[:budget_time] = budget_time if budget_time
+          body[:budget_time_unit] = budget_time_unit if budget_time_unit
+          body[:color] = color if color
+          body[:default_proposition] = default_proposition if default_proposition
+          body[:team_members] = team_members if team_members
 
           post("#{@url_api_path}/projects", body)
         end

data/lib/papierkram_api_client/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module PapierkramApiClient
-  VERSION = '0.2.3'
+  VERSION = '0.2.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: papierkram_api_client
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Simon Neutert
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2023-06-29 00:00:00.000000000 Z
+date: 2023-06-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday