papers 1.3.2 → 1.4.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 853ae8cf71390d0158e03316b260bfe0cdb6c0ca
-  data.tar.gz: 71dcbec230a9bb2363eeb02dea72e3b961f591a4
+  metadata.gz: 602d2e8efd00f7bda59f79de438fa79552e746ca
+  data.tar.gz: 1f129b2abe8801b64282b66737335f57bc94d198
 SHA512:
-  metadata.gz: da08736d68659f2b5929ca8fe0c58a5deaca3f7e73490fa334c3fd5b8878deeed6d687c31d54b7f29026077d1220a6b3ac26727215f139c031884c9a5f23f6a4
-  data.tar.gz: 2faa06656c4dfc338d7ef6758a0079fb370fbde4cd3b2ce0a6266c99c22e7ba699d5ac6cf4e75352124c7f1083b270e935ae25b89c4217da4dc8f917b07c2cfd
+  metadata.gz: 41ed2f34f0bfb9fa62e2641be4db5f81fba749f00473449ffd2df6d7c126a94d93b53a51e47d27b97d986c8456845b705d46e95ad6c4a217c9da094243abcf3e
+  data.tar.gz: 6952d6905f4f021906cb994de7e010cc655fee265a96ec32b94a545d99004a011cbc510a18eb34c01a8b82bd476dc2f752300ee3223b810b96bb756770fae8f8

data/lib/papers/configuration.rb

@@ -11,6 +11,7 @@ module Papers
     attr_accessor :validate_npm_packages
 
     attr_accessor :javascript_paths
+    attr_accessor :whitelist_javascript_paths
     attr_accessor :bower_components_path
     attr_accessor :npm_package_json_path
 
@@ -42,6 +43,7 @@ module Papers
         File.join(Dir.pwd, 'lib',    'assets', 'javascripts'),
         File.join(Dir.pwd, 'vendor', 'assets', 'javascripts')
       ]
+      @whitelist_javascript_paths = []
 
       @bower_components_path = File.join(Dir.pwd, 'vendor', 'assets', 'components')
 

data/lib/papers/dependency_specification/javascript.rb

@@ -11,10 +11,15 @@ module Papers
 
     def self.introspected
       dirs = Papers.config.javascript_paths
+      whitelist_dirs = Papers.config.whitelist_javascript_paths
 
       # TODO: add logic for determining rails. Is Rails.root better than Dir.pwd for such a case?
       root_regexp = /^#{Regexp.escape Dir.pwd.to_s}\//
-      dirs.map { |dir| Dir["#{dir}/**/*.{js,coffee}"] }.flatten.map { |name| name.sub(root_regexp, '') }
+      files = dirs.map { |dir| Dir.glob("#{dir}/**/*.{js,coffee}") }.flatten.map do |name|
+        name = name.sub(root_regexp, '')
+        name unless whitelist_dirs.any? { |dir| name.start_with?(dir) }
+      end
+      files.compact
     end
 
     def self.manifest_key

data/lib/papers/version.rb

@@ -1,8 +1,8 @@
 module Papers
   class Version
     MAJOR = 1
-    MINOR = 3
-    PATCH = 2
+    MINOR = 4
+    PATCH = 0
 
     def self.to_s
       [MAJOR, MINOR, PATCH].join('.')

data/spec/npm_package_spec.rb

@@ -13,8 +13,8 @@ describe 'NpmPackageSpecification' do
       ])
     end
 
-    it "raises an error when package.json is not found" do
-      expect { Papers::NpmPackage.full_introspected_entries }.to raise_error Errno::ENOENT
+    it "returns an empty list if package.json is not found" do
+      expect(Papers::NpmPackage.full_introspected_entries).to eq([])
     end
 
     it "raises an error when package.json does not parse properly" do

data/spec/papers_spec.rb

@@ -307,4 +307,33 @@ describe 'Papers' do
     gemspec = Papers::Gem.new(name: 'foo')
     expect('foo').to eq(gemspec.name_without_version)
   end
+
+  it 'is OK with whitelisting javascript javascript_paths' do
+    # contents of javascript dir and no gems
+    Dir.stub(:glob){[
+      'app/javascripts/node_modules/should_be_whitelisted.js',
+      'app/javascripts/test.js'
+    ]}
+    Papers::Gem.stub(:introspected).and_return([])
+
+    Papers::LicenseValidator.any_instance.stub(:manifest).and_return({
+      'javascripts' => {
+        'app/javascripts/test.js' => {
+          'license' => 'MIT',
+          'license_url' => nil,
+          'project_url' => nil
+        }
+      },
+      'gems' => {}
+    })
+    Papers::Configuration.any_instance.stub(:javascript_paths).and_return(['app/javascripts/'])
+
+    # whitelist this directory
+    Papers::Configuration.any_instance.stub(:whitelist_javascript_paths).and_return(['app/javascripts/node_modules'])
+
+    expect(Papers::Javascript.introspected).to_not include('app/javascripts/node_modules/should_be_whitelisted.js')
+    expect(validator).to be_valid
+  end
+
+
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: papers
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.4.0
 platform: ruby
 authors:
 - Ralph Bodenner
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-07-18 00:00:00.000000000 Z
+date: 2014-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake