paperclip 4.3.4 → 4.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 83567677f13e381c3c2808fb4351ebe5ab1d9472
-  data.tar.gz: c6b76b6377eb8635a698be2c4aca1c3fe803bf39
+  metadata.gz: 33906ec8f0fa8be6fd6df7df38d355a736cd574a
+  data.tar.gz: de38c7e728dcfc5e938115706b27ba716475b8f3
 SHA512:
-  metadata.gz: 6d6985f2ea18d7b5924555ada101da7575603ccf3df435902e3388dc81750c4028a5abd9e8eaeff15b005716c86a9c066c7a172b11806278dde485abf0b7bd0c
-  data.tar.gz: ee7e8530249f6015fc49d7cb45167490dd26f011177b273a7284773b965c375beb8a38692a885af12fba83ef1a55452e1dcc6f1ca51fb655ea2b560f4d4b7bf5
+  metadata.gz: 55a6e285fe1f1a7a32f4e15e05f73119047b3bbcb5e7c3bda18ef49c008d2cb2db4c407bf23b7d1da363f16a509cda486dbbee0d4de52e225d2497118231cc95
+  data.tar.gz: 8d85e18f6f1438538e8116cd93166362954700f8e4b31896b045cb1966ded6861d669b53057995caaa127a0918baed6076e414cdeab006e90678c78e434e360c

data/NEWS

@@ -1,3 +1,6 @@
+4.3.5 (2/8/2016):
+* Bug Fix: Remove deprecation warnings for v5.0 for now. Will re-add once the version has landed.
+
 4.3.4 (2/2/2016):
 * Bug Fix: Fix incompatible change from v4.3.3.
 

data/lib/paperclip.rb

@@ -56,7 +56,6 @@ require 'paperclip/has_attached_file'
 require 'paperclip/attachment_registry'
 require 'paperclip/filename_cleaner'
 require 'paperclip/rails_environment'
-require "paperclip/deprecations"
 
 begin
   # Use mime/types/columnar if available, for reduced memory usage
@@ -192,7 +191,6 @@ module Paperclip
     #     end
     #   end
     def has_attached_file(name, options = {})
-      Paperclip::Deprecations.check
       HasAttachedFile.define_on(self, name, options)
     end
   end

data/lib/paperclip/version.rb

@@ -1,3 +1,3 @@
 module Paperclip
-  VERSION = "4.3.4" unless defined? Paperclip::VERSION
+  VERSION = "4.3.5" unless defined? Paperclip::VERSION
 end

data/spec/paperclip/paperclip_spec.rb

@@ -109,7 +109,6 @@ describe Paperclip do
 
   context "An ActiveRecord model with an 'avatar' attachment" do
     before do
-      Paperclip::Deprecations.stubs(:check)
       rebuild_model path: "tmp/:class/omg/:style.:extension"
       @file = File.new(fixture_file("5k.png"), 'rb')
     end
@@ -151,10 +150,6 @@ describe Paperclip do
       end
     end
 
-    it "calls Paperclip::Deprecations.check" do
-      expect(Paperclip::Deprecations).to have_received(:check)
-    end
-
     context "with a subclass" do
       before do
         class ::SubDummy < Dummy; end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paperclip
 version: !ruby/object:Gem::Version
-  version: 4.3.4
+  version: 4.3.5
 platform: ruby
 authors:
 - Jon Yurek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-02 00:00:00.000000000 Z
+date: 2016-02-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -429,7 +429,6 @@ files:
 - lib/paperclip/attachment_registry.rb
 - lib/paperclip/callbacks.rb
 - lib/paperclip/content_type_detector.rb
-- lib/paperclip/deprecations.rb
 - lib/paperclip/errors.rb
 - lib/paperclip/file_command_content_type_detector.rb
 - lib/paperclip/filename_cleaner.rb
@@ -500,7 +499,6 @@ files:
 - spec/paperclip/attachment_registry_spec.rb
 - spec/paperclip/attachment_spec.rb
 - spec/paperclip/content_type_detector_spec.rb
-- spec/paperclip/deprecations_spec.rb
 - spec/paperclip/file_command_content_type_detector_spec.rb
 - spec/paperclip/filename_cleaner_spec.rb
 - spec/paperclip/geometry_detector_spec.rb
@@ -552,7 +550,6 @@ files:
 - spec/paperclip/validators_spec.rb
 - spec/spec_helper.rb
 - spec/support/assertions.rb
-- spec/support/deprecations.rb
 - spec/support/fake_model.rb
 - spec/support/fake_rails.rb
 - spec/support/fixtures/12k.png
@@ -631,7 +628,6 @@ test_files:
 - spec/paperclip/attachment_registry_spec.rb
 - spec/paperclip/attachment_spec.rb
 - spec/paperclip/content_type_detector_spec.rb
-- spec/paperclip/deprecations_spec.rb
 - spec/paperclip/file_command_content_type_detector_spec.rb
 - spec/paperclip/filename_cleaner_spec.rb
 - spec/paperclip/geometry_detector_spec.rb
@@ -683,7 +679,6 @@ test_files:
 - spec/paperclip/validators_spec.rb
 - spec/spec_helper.rb
 - spec/support/assertions.rb
-- spec/support/deprecations.rb
 - spec/support/fake_model.rb
 - spec/support/fake_rails.rb
 - spec/support/fixtures/12k.png

data/lib/paperclip/deprecations.rb

@@ -1,42 +0,0 @@
-require "active_support/deprecation"
-
-module Paperclip
-  class Deprecations
-    class << self
-      def check
-        warn_aws_sdk_v1 if aws_sdk_v1?
-        warn_outdated_rails if active_model_version < "4.2"
-      end
-
-      private
-
-      def active_model_version
-        ::ActiveModel::VERSION::STRING
-      end
-
-      def aws_sdk_v1?
-        defined?(::AWS) && aws_sdk_version < "2"
-      end
-
-      def warn_aws_sdk_v1
-        warn "[paperclip] [deprecation] AWS SDK v1 has been deprecated in " \
-             "paperclip 5. Please consider upgrading to AWS 2 before " \
-             "upgrading paperclip."
-      end
-
-      def warn_outdated_rails
-        warn "[paperclip] [deprecation] Rails 3.2 and 4.1 are unsupported as " \
-             "of Rails 5 release. Please upgrade to Rails 4.2 before " \
-             "upgrading paperclip."
-      end
-
-      def aws_sdk_version
-        ::AWS::VERSION
-      end
-
-      def warn(message)
-        ActiveSupport::Deprecation.warn(message)
-      end
-    end
-  end
-end

data/spec/paperclip/deprecations_spec.rb

@@ -1,65 +0,0 @@
-require "spec_helper"
-require "aws-sdk"
-require "active_support/testing/deprecation"
-
-describe Paperclip::Deprecations do
-  include ActiveSupport::Testing::Deprecation
-
-  describe ".check" do
-    before do
-      ActiveSupport::Deprecation.silenced = false
-    end
-
-    after do
-      ActiveSupport::Deprecation.silenced = true
-    end
-
-    context "when active model version is < 4.2" do
-      it "displays deprecation warning" do
-        Paperclip::Deprecations.stubs(:active_model_version).returns("4.1")
-
-        assert_deprecated("Rails 3.2 and 4.1 are unsupported") do
-          Paperclip::Deprecations.check
-        end
-      end
-    end
-
-    context "when active model version is 4.2" do
-      it "do not display deprecation warning" do
-        Paperclip::Deprecations.stubs(:active_model_version).returns("4.2")
-
-        assert_not_deprecated do
-          Paperclip::Deprecations.check
-        end
-      end
-    end
-
-    context "when aws sdk version is < 2" do
-      before do
-        ::AWS.stub! if !defined?(::AWS)
-      end
-
-      it "displays deprecation warning" do
-        Paperclip::Deprecations.stubs(:aws_sdk_version).returns("1.68.0")
-
-        assert_deprecated("AWS SDK v1 has been deprecated") do
-          Paperclip::Deprecations.check
-        end
-      end
-    end
-
-    context "when aws sdk version is 2" do
-      before do
-        ::AWS.stub! if !defined?(::AWS)
-      end
-
-      it "do not display deprecation warning" do
-        Paperclip::Deprecations.stubs(:aws_sdk_version).returns("2.0.0")
-
-        assert_not_deprecated do
-          Paperclip::Deprecations.check
-        end
-      end
-    end
-  end
-end

data/spec/support/deprecations.rb

@@ -1,9 +0,0 @@
-RSpec.configure do |config|
-  config.before(:all) do
-    ActiveSupport::Deprecation.silenced = true
-  end
-  config.before(:each) do
-    Paperclip::Deprecations.stubs(:active_model_version).returns("4.2")
-    Paperclip::Deprecations.stubs(:aws_sdk_version).returns("2.0.0")
-  end
-end