paperclip 4.3.2 → 4.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0e139df6e8e24d624d436566d794642b848aba04
-  data.tar.gz: 4ebe1f32b8ce077f35d56ab232d07f71a3e39267
+  metadata.gz: 79d2d73240dea47e979d28e67b670fe4ebe03b1c
+  data.tar.gz: 1f826ab0f3018bf26378e9e37eff2280cc8d6ada
 SHA512:
-  metadata.gz: 445e6c03d40f5c72e2cc45eb818685917d450607a37c37ecb413be50534036a4606572a2f1990c851705fe5c767e3861700732de81894633bcb54b26ec50b36a
-  data.tar.gz: 2ab2c5ba3f14288f3e906d7f6410b2a1cc2727ec7adeada4c6fd6ce34b81c2270df75a4391447b047de8ab5797bc3c898ab3181fd03bded34b1329277fa2c30d
+  metadata.gz: ebd4d6366d1686162a153b30c68777d9b27a9177e0b00e6a7489091bc0b656e8917fb35840dfe13c873c9e154e7c37fa6c10c4d0d1e409c3e9d2980eef325393
+  data.tar.gz: fdc49800c9d04ffef94feb901e46de2481ba3a3eca536551b5afe6cc997e315a1be075ccf48f02ce45cfd1da513bb339e4565c58cff7e546ea7d39494883598e

data/NEWS

@@ -1,3 +1,7 @@
+4.3.3 (1/29/2016):
+
+*Improvement: Add deprecation warnings in preparation for release of v5.0
+
 4.3.2 (11/18/2015):
 
 * Performance: Reduce memory allocations (#2056)

data/lib/paperclip.rb

@@ -56,6 +56,7 @@ require 'paperclip/has_attached_file'
 require 'paperclip/attachment_registry'
 require 'paperclip/filename_cleaner'
 require 'paperclip/rails_environment'
+require "paperclip/deprecations"
 
 begin
   # Use mime/types/columnar if available, for reduced memory usage
@@ -191,6 +192,7 @@ module Paperclip
     #     end
     #   end
     def has_attached_file(name, options = {})
+      Paperclip::Deprecations.check
       HasAttachedFile.define_on(self, name, options)
     end
   end

data/lib/paperclip/deprecations.rb

@@ -0,0 +1,42 @@
+require "active_support/deprecation"
+
+module Paperclip
+  class Deprecations
+    class << self
+      def check
+        warn_aws_sdk_v1 if aws_sdk_v1?
+        warn_outdated_rails if active_record_version < "4.2"
+      end
+
+      private
+
+      def active_record_version
+        ::ActiveRecord::VERSION::STRING
+      end
+
+      def aws_sdk_v1?
+        defined?(::AWS) && aws_sdk_version < "2"
+      end
+
+      def warn_aws_sdk_v1
+        warn "[paperclip] [deprecation] AWS SDK v1 has been deprecated in " \
+             "paperclip 5. Please consider upgrading to AWS 2 before " \
+             "upgrading paperclip."
+      end
+
+      def warn_outdated_rails
+        warn "[paperclip] [deprecation] Rails 3.2 and 4.1 are unsupported as " \
+             "of Rails 5 release. Please upgrade to Rails 4.2 before " \
+             "upgrading paperclip."
+      end
+
+      def aws_sdk_version
+        ::AWS::VERSION
+      end
+
+      def warn(message)
+        ActiveSupport::Deprecation.warn(message)
+      end
+    end
+  end
+end

data/lib/paperclip/version.rb

@@ -1,3 +1,3 @@
 module Paperclip
-  VERSION = "4.3.2" unless defined? Paperclip::VERSION
+  VERSION = "4.3.3" unless defined? Paperclip::VERSION
 end

data/spec/paperclip/deprecations_spec.rb

@@ -0,0 +1,65 @@
+require "spec_helper"
+require "aws-sdk"
+require "active_support/testing/deprecation"
+
+describe Paperclip::Deprecations do
+  include ActiveSupport::Testing::Deprecation
+
+  describe ".check" do
+    before do
+      ActiveSupport::Deprecation.silenced = false
+    end
+
+    after do
+      ActiveSupport::Deprecation.silenced = true
+    end
+
+    context "when active record version is < 4.2" do
+      it "displays deprecation warning" do
+        Paperclip::Deprecations.stubs(:active_record_version).returns("4.1")
+
+        assert_deprecated("Rails 3.2 and 4.1 are unsupported") do
+          Paperclip::Deprecations.check
+        end
+      end
+    end
+
+    context "when active record version is 4.2" do
+      it "do not display deprecation warning" do
+        Paperclip::Deprecations.stubs(:active_record_version).returns("4.2")
+
+        assert_not_deprecated do
+          Paperclip::Deprecations.check
+        end
+      end
+    end
+
+    context "when aws sdk version is < 2" do
+      before do
+        ::AWS.stub! if !defined?(::AWS)
+      end
+
+      it "displays deprecation warning" do
+        Paperclip::Deprecations.stubs(:aws_sdk_version).returns("1.68.0")
+
+        assert_deprecated("AWS SDK v1 has been deprecated") do
+          Paperclip::Deprecations.check
+        end
+      end
+    end
+
+    context "when aws sdk version is 2" do
+      before do
+        ::AWS.stub! if !defined?(::AWS)
+      end
+
+      it "do not display deprecation warning" do
+        Paperclip::Deprecations.stubs(:aws_sdk_version).returns("2.0.0")
+
+        assert_not_deprecated do
+          Paperclip::Deprecations.check
+        end
+      end
+    end
+  end
+end

data/spec/paperclip/paperclip_spec.rb

@@ -109,6 +109,7 @@ describe Paperclip do
 
   context "An ActiveRecord model with an 'avatar' attachment" do
     before do
+      Paperclip::Deprecations.stubs(:check)
       rebuild_model path: "tmp/:class/omg/:style.:extension"
       @file = File.new(fixture_file("5k.png"), 'rb')
     end
@@ -150,6 +151,10 @@ describe Paperclip do
       end
     end
 
+    it "calls Paperclip::Deprecations.check" do
+      expect(Paperclip::Deprecations).to have_received(:check)
+    end
+
     context "with a subclass" do
       before do
         class ::SubDummy < Dummy; end

data/spec/support/deprecations.rb

@@ -0,0 +1,9 @@
+RSpec.configure do |config|
+  config.before(:all) do
+    ActiveSupport::Deprecation.silenced = true
+  end
+  config.before(:each) do
+    Paperclip::Deprecations.stubs(:active_record_version).returns("4.2")
+    Paperclip::Deprecations.stubs(:aws_sdk_version).returns("2.0.0")
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paperclip
 version: !ruby/object:Gem::Version
-  version: 4.3.2
+  version: 4.3.3
 platform: ruby
 authors:
 - Jon Yurek
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-11-19 00:00:00.000000000 Z
+date: 2016-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -429,6 +429,7 @@ files:
 - lib/paperclip/attachment_registry.rb
 - lib/paperclip/callbacks.rb
 - lib/paperclip/content_type_detector.rb
+- lib/paperclip/deprecations.rb
 - lib/paperclip/errors.rb
 - lib/paperclip/file_command_content_type_detector.rb
 - lib/paperclip/filename_cleaner.rb
@@ -499,6 +500,7 @@ files:
 - spec/paperclip/attachment_registry_spec.rb
 - spec/paperclip/attachment_spec.rb
 - spec/paperclip/content_type_detector_spec.rb
+- spec/paperclip/deprecations_spec.rb
 - spec/paperclip/file_command_content_type_detector_spec.rb
 - spec/paperclip/filename_cleaner_spec.rb
 - spec/paperclip/geometry_detector_spec.rb
@@ -550,6 +552,7 @@ files:
 - spec/paperclip/validators_spec.rb
 - spec/spec_helper.rb
 - spec/support/assertions.rb
+- spec/support/deprecations.rb
 - spec/support/fake_model.rb
 - spec/support/fake_rails.rb
 - spec/support/fixtures/12k.png
@@ -600,7 +603,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - ImageMagick
 rubyforge_project: 
-rubygems_version: 2.4.5.1
+rubygems_version: 2.5.1
 signing_key: 
 specification_version: 4
 summary: File attachments as attributes for ActiveRecord
@@ -628,6 +631,7 @@ test_files:
 - spec/paperclip/attachment_registry_spec.rb
 - spec/paperclip/attachment_spec.rb
 - spec/paperclip/content_type_detector_spec.rb
+- spec/paperclip/deprecations_spec.rb
 - spec/paperclip/file_command_content_type_detector_spec.rb
 - spec/paperclip/filename_cleaner_spec.rb
 - spec/paperclip/geometry_detector_spec.rb
@@ -679,6 +683,7 @@ test_files:
 - spec/paperclip/validators_spec.rb
 - spec/spec_helper.rb
 - spec/support/assertions.rb
+- spec/support/deprecations.rb
 - spec/support/fake_model.rb
 - spec/support/fake_rails.rb
 - spec/support/fixtures/12k.png
@@ -708,3 +713,4 @@ test_files:
 - spec/support/rails_helpers.rb
 - spec/support/test_data.rb
 - spec/support/version_helper.rb
+has_rdoc: