paperclip 4.1.1 → 4.2.0

data/{test/validators/media_type_spoof_detection_validator_test.rb → spec/paperclip/validators/media_type_spoof_detection_validator_spec.rb}

@@ -1,22 +1,22 @@
-require './test/helper'
+require 'spec_helper'
 
-class MediaTypeSpoofDetectionValidatorTest < Test::Unit::TestCase
-  def setup
+describe Paperclip::Validators::MediaTypeSpoofDetectionValidator do
+  before do
     rebuild_model
     @dummy = Dummy.new
   end
 
   def build_validator(options = {})
     @validator = Paperclip::Validators::MediaTypeSpoofDetectionValidator.new(options.merge(
-      :attributes => :avatar
+      attributes: :avatar
     ))
   end
 
-  should "be on the attachment without being explicitly added" do
+  it "is on the attachment without being explicitly added" do
     assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :media_type_spoof_detection }
   end
 
-  should "return default error message for spoofed media type" do
+  it "returns default error message for spoofed media type" do
     build_validator
     file = File.new(fixture_file("5k.png"), "rb")
     @dummy.avatar.assign(file)
@@ -28,7 +28,7 @@ class MediaTypeSpoofDetectionValidatorTest < Test::Unit::TestCase
     assert_equal "has an extension that does not match its contents", @dummy.errors[:avatar].first
   end
 
-  should "run when attachment is dirty" do
+  it "runs when attachment is dirty" do
     build_validator
     file = File.new(fixture_file("5k.png"), "rb")
     @dummy.avatar.assign(file)
@@ -39,7 +39,7 @@ class MediaTypeSpoofDetectionValidatorTest < Test::Unit::TestCase
     assert_received(Paperclip::MediaTypeSpoofDetector, :using){|e| e.once }
   end
 
-  should "not run when attachment is not dirty" do
+  it "does not run when attachment is not dirty" do
     Paperclip::MediaTypeSpoofDetector.stubs(:using).never
     @dummy.valid?
     assert_received(Paperclip::MediaTypeSpoofDetector, :using){|e| e.never }

data/spec/paperclip/validators_spec.rb

@@ -0,0 +1,164 @@
+require 'spec_helper'
+
+describe Paperclip::Validators do
+  context "using the helper" do
+    before do
+      Dummy.validates_attachment :avatar, presence: true, content_type: { content_type: "image/jpeg" }, size: { in: 0..10240 }
+    end
+
+    it "adds the attachment_presence validator to the class" do
+      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_presence }
+    end
+
+    it "adds the attachment_content_type validator to the class" do
+      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_content_type }
+    end
+
+    it "adds the attachment_size validator to the class" do
+      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_size }
+    end
+
+    it 'prevents you from attaching a file that violates that validation' do
+      Dummy.class_eval{ validate(:name) { raise "DO NOT RUN THIS" } }
+      dummy = Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      expect(dummy.errors.keys).to match_array [:avatar_content_type, :avatar, :avatar_file_size]
+      assert_raises(RuntimeError){ dummy.valid? }
+    end
+  end
+
+  context 'using the helper with array of validations' do
+    before do
+      rebuild_class
+      Dummy.validates_attachment :avatar, file_type_ignorance: true, file_name: [
+          { matches: /\A.*\.jpe?g\Z/i, message: :invalid_extension },
+          { matches: /\A.{,8}\..+\Z/i, message: [:too_long, count: 8] },
+      ]
+    end
+
+    it 'adds the attachment_file_name validator to the class' do
+      assert Dummy.validators_on(:avatar).any?{ |validator| validator.kind == :attachment_file_name }
+    end
+
+    it 'adds the attachment_file_name validator with two validations' do
+      assert_equal 2, Dummy.validators_on(:avatar).select{ |validator| validator.kind == :attachment_file_name }.size
+    end
+
+    it 'prevents you from attaching a file that violates all of these validations' do
+      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
+      dummy = Dummy.new(avatar: File.new(fixture_file('spaced file.png')))
+      expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
+      assert_raises(RuntimeError){ dummy.valid? }
+    end
+
+    it 'prevents you from attaching a file that violates only first of these validations' do
+      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
+      dummy = Dummy.new(avatar: File.new(fixture_file('5k.png')))
+      expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
+      assert_raises(RuntimeError){ dummy.valid? }
+    end
+
+    it 'prevents you from attaching a file that violates only second of these validations' do
+      Dummy.class_eval{ validate(:name) { raise 'DO NOT RUN THIS' } }
+      dummy = Dummy.new(avatar: File.new(fixture_file('spaced file.jpg')))
+      expect(dummy.errors.keys).to match_array [:avatar, :avatar_file_name]
+      assert_raises(RuntimeError){ dummy.valid? }
+    end
+
+    it 'allows you to attach a file that does not violates these validations' do
+      dummy = Dummy.new(avatar: File.new(fixture_file('rotated.jpg')))
+      expect(dummy.errors.keys).to match_array []
+      assert dummy.valid?
+    end
+
+  end
+
+  context "using the helper with a conditional" do
+    before do
+      rebuild_class
+      Dummy.validates_attachment :avatar, presence: true,
+        content_type: { content_type: "image/jpeg" },
+        size: { in: 0..10240 },
+        if: :title_present?
+    end
+
+    it "validates the attachment if title is present" do
+      Dummy.class_eval do
+        def title_present?
+          true
+        end
+      end
+      dummy = Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      expect(dummy.errors.keys).to match_array [:avatar_content_type, :avatar, :avatar_file_size]
+    end
+
+    it "does not validate attachment if title is not present" do
+      Dummy.class_eval do
+        def title_present?
+          false
+        end
+      end
+      dummy = Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      assert_equal [], dummy.errors.keys
+    end
+  end
+
+  context 'with no other validations on the Dummy#avatar attachment' do
+    before do
+      reset_class("Dummy")
+      Dummy.has_attached_file :avatar
+      Paperclip.reset_duplicate_clash_check!
+    end
+
+    it 'raises an error when no content_type validation exists' do
+      assert_raises(Paperclip::Errors::MissingRequiredValidatorError) do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+
+    it 'does not raise an error when a content_type validation exists' do
+      Dummy.validates_attachment :avatar, content_type: { content_type: "image/jpeg" }
+
+      assert_nothing_raised do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+
+    it 'does not raise an error when a content_type validation exists using validates_with' do
+      Dummy.validates_with Paperclip::Validators::AttachmentContentTypeValidator, attributes: :attachment, content_type: 'images/jpeg'
+
+      assert_nothing_raised do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+
+    it 'does not raise an error when an inherited validator is used' do
+      class MyValidator < Paperclip::Validators::AttachmentContentTypeValidator
+        def initialize(options)
+          options[:content_type] = "images/jpeg" unless options.has_key?(:content_type)
+          super
+        end
+      end
+      Dummy.validates_with MyValidator, attributes: :attachment
+
+      assert_nothing_raised do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+
+    it 'does not raise an error when a file_name validation exists' do
+      Dummy.validates_attachment :avatar, file_name: { matches: /png$/ }
+
+      assert_nothing_raised do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+
+    it 'does not raise an error when a the validation has been explicitly rejected' do
+      Dummy.validates_attachment :avatar, file_type_ignorance: true
+
+      assert_nothing_raised do
+        Dummy.new(avatar: File.new(fixture_file("12k.png")))
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,40 @@
+require 'rubygems'
+require 'rspec'
+require 'active_record'
+require 'active_record/version'
+require 'active_support'
+require 'active_support/core_ext'
+require 'mocha/api'
+require 'bourne'
+require 'ostruct'
+
+ROOT = Pathname(File.expand_path(File.join(File.dirname(__FILE__), '..')))
+
+puts "Testing against version #{ActiveRecord::VERSION::STRING}"
+
+$LOAD_PATH << File.join(ROOT, 'lib')
+$LOAD_PATH << File.join(ROOT, 'lib', 'paperclip')
+require File.join(ROOT, 'lib', 'paperclip.rb')
+
+FIXTURES_DIR = File.join(File.dirname(__FILE__), "fixtures")
+config = YAML::load(IO.read(File.dirname(__FILE__) + '/database.yml'))
+ActiveRecord::Base.logger = Logger.new(File.dirname(__FILE__) + "/debug.log")
+ActiveRecord::Base.establish_connection(config['test'])
+Paperclip.options[:logger] = ActiveRecord::Base.logger
+
+Dir[File.join(ROOT, 'spec', 'support', '**', '*.rb')].each{|f| require f }
+
+Rails = FakeRails.new('test', Pathname.new(ROOT).join('tmp'))
+ActiveSupport::Deprecation.silenced = true
+
+RSpec.configure do |config|
+  config.include Assertions
+  config.include ModelReconstruction
+  config.include TestData
+  config.extend VersionHelper
+  config.extend RailsHelpers::ClassMethods
+  config.mock_framework = :mocha
+  config.before(:all) do
+    rebuild_model
+  end
+end

data/spec/support/assertions.rb

@@ -0,0 +1,71 @@
+module Assertions
+  def assert(truthy, message = nil)
+    expect(!!truthy).to(eq(true), message)
+  end
+
+  def assert_equal(expected, actual, message = nil)
+    expect(actual).to(eq(expected), message)
+  end
+
+  def assert_not_equal(expected, actual, message = nil)
+    expect(actual).to_not(eq(expected), message)
+  end
+
+  def assert_raises(exception_class, message = nil, &block)
+    expect(&block).to raise_error(exception_class, message)
+  end
+
+  def assert_nothing_raised(&block)
+    expect(&block).to_not raise_error
+  end
+
+  def assert_nil(thing)
+    expect(thing).to be_nil
+  end
+
+  def assert_contains(haystack, needle)
+    expect(haystack).to include(needle)
+  end
+
+  def assert_match(pattern, value)
+    expect(value).to match(pattern)
+  end
+
+  def assert_no_match(pattern, value)
+    expect(value).to_not match(pattern)
+  end
+
+  def assert_file_exists(path_to_file)
+    expect(path_to_file).to exist
+  end
+
+  def assert_file_not_exists(path_to_file)
+    expect(path_to_file).to_not exist
+  end
+
+  def assert_empty(object)
+    expect(object).to be_empty
+  end
+
+  def assert_success_response(url)
+    Net::HTTP.get_response(URI.parse(url)) do |response|
+      assert_equal "200", response.code,
+        "Expected HTTP response code 200, got #{response.code}"
+    end
+  end
+
+  def assert_not_found_response(url)
+    Net::HTTP.get_response(URI.parse(url)) do |response|
+      assert_equal "404", response.code,
+        "Expected HTTP response code 404, got #{response.code}"
+    end
+  end
+
+  def assert_frame_dimensions(range, frames)
+    frames.each_with_index do |frame, frame_index|
+      frame.split('x').each_with_index do |dimension, dimension_index |
+        assert range.include?(dimension.to_i), "Frame #{frame_index}[#{dimension_index}] should have been within #{range.inspect}, but was #{dimension}"
+      end
+    end
+  end
+end

data/spec/support/fake_model.rb

@@ -0,0 +1,21 @@
+class FakeModel
+  attr_accessor(
+    :avatar_file_name,
+    :avatar_file_size,
+    :avatar_updated_at,
+    :avatar_content_type,
+    :avatar_fingerprint,
+    :id
+  )
+
+  def errors
+    @errors ||= []
+  end
+
+  def run_paperclip_callbacks name, *args
+  end
+
+  def valid?
+    errors.empty?
+  end
+end

data/spec/support/fake_rails.rb

@@ -0,0 +1,12 @@
+class FakeRails
+  def initialize(env, root)
+    @env = env
+    @root = root
+  end
+
+  attr_accessor :env, :root
+
+  def const_defined?(const)
+    false
+  end
+end

data/spec/support/matchers/accept.rb

@@ -0,0 +1,5 @@
+RSpec::Matchers.define :accept do |expected|
+  match do |actual|
+    actual.matches?(expected)
+  end
+end

data/spec/support/matchers/exist.rb

@@ -0,0 +1,5 @@
+RSpec::Matchers.define :exist do |expected|
+  match do |actual|
+    File.exist?(actual)
+  end
+end

data/spec/support/model_reconstruction.rb

@@ -0,0 +1,60 @@
+module ModelReconstruction
+  def reset_class class_name
+    ActiveRecord::Base.send(:include, Paperclip::Glue)
+    Object.send(:remove_const, class_name) rescue nil
+    klass = Object.const_set(class_name, Class.new(ActiveRecord::Base))
+
+    klass.class_eval do
+      include Paperclip::Glue
+    end
+
+    klass.reset_column_information
+    klass.connection_pool.clear_table_cache!(klass.table_name) if klass.connection_pool.respond_to?(:clear_table_cache!)
+    klass.connection.schema_cache.clear_table_cache!(klass.table_name) if klass.connection.respond_to?(:schema_cache)
+    klass
+  end
+
+  def reset_table table_name, &block
+    block ||= lambda { |table| true }
+    ActiveRecord::Base.connection.create_table :dummies, {force: true}, &block
+  end
+
+  def modify_table table_name, &block
+    ActiveRecord::Base.connection.change_table :dummies, &block
+  end
+
+  def rebuild_model options = {}
+    ActiveRecord::Base.connection.create_table :dummies, force: true do |table|
+      table.column :title, :string
+      table.column :other, :string
+      table.column :avatar_file_name, :string
+      table.column :avatar_content_type, :string
+      table.column :avatar_file_size, :integer
+      table.column :avatar_updated_at, :datetime
+      table.column :avatar_fingerprint, :string
+    end
+    rebuild_class options
+  end
+
+  def rebuild_class options = {}
+    reset_class("Dummy").tap do |klass|
+      klass.has_attached_file :avatar, options
+      klass.do_not_validate_attachment_file_type :avatar
+      Paperclip.reset_duplicate_clash_check!
+    end
+  end
+
+  def rebuild_meta_class_of obj, options = {}
+    meta_class_of(obj).tap do |metaklass|
+      metaklass.has_attached_file :avatar, options
+      metaklass.do_not_validate_attachment_file_type :avatar
+      Paperclip.reset_duplicate_clash_check!
+    end
+  end
+
+  def meta_class_of(obj)
+    class << obj
+      self
+    end
+  end
+end