paperclip 3.5.4 → 5.3.0
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +4 -4
- data/.codeclimate.yml +17 -0
- data/.gitignore +0 -6
- data/.hound.yml +1055 -0
- data/.rubocop.yml +1 -0
- data/.travis.yml +17 -20
- data/Appraisals +4 -16
- data/CONTRIBUTING.md +29 -13
- data/Gemfile +11 -3
- data/LICENSE +1 -3
- data/NEWS +241 -49
- data/README.md +471 -166
- data/RELEASING.md +17 -0
- data/Rakefile +6 -8
- data/UPGRADING +12 -9
- data/features/basic_integration.feature +27 -8
- data/features/migration.feature +0 -24
- data/features/step_definitions/attachment_steps.rb +36 -28
- data/features/step_definitions/html_steps.rb +2 -2
- data/features/step_definitions/rails_steps.rb +68 -37
- data/features/step_definitions/s3_steps.rb +2 -2
- data/features/step_definitions/web_steps.rb +1 -103
- data/features/support/env.rb +3 -2
- data/features/support/file_helpers.rb +2 -2
- data/features/support/fixtures/gemfile.txt +1 -1
- data/features/support/paths.rb +1 -1
- data/features/support/rails.rb +2 -25
- data/gemfiles/4.2.gemfile +17 -0
- data/gemfiles/5.0.gemfile +17 -0
- data/lib/generators/paperclip/paperclip_generator.rb +9 -3
- data/lib/generators/paperclip/templates/paperclip_migration.rb.erb +2 -2
- data/lib/paperclip/attachment.rb +151 -46
- data/lib/paperclip/attachment_registry.rb +3 -2
- data/lib/paperclip/callbacks.rb +13 -1
- data/lib/paperclip/content_type_detector.rb +26 -22
- data/lib/paperclip/errors.rb +8 -1
- data/lib/paperclip/file_command_content_type_detector.rb +6 -8
- data/lib/paperclip/geometry_detector_factory.rb +5 -3
- data/lib/paperclip/geometry_parser_factory.rb +1 -1
- data/lib/paperclip/glue.rb +1 -1
- data/lib/paperclip/has_attached_file.rb +17 -1
- data/lib/paperclip/helpers.rb +15 -11
- data/lib/paperclip/interpolations/plural_cache.rb +6 -5
- data/lib/paperclip/interpolations.rb +26 -13
- data/lib/paperclip/io_adapters/abstract_adapter.rb +32 -4
- data/lib/paperclip/io_adapters/attachment_adapter.rb +13 -8
- data/lib/paperclip/io_adapters/data_uri_adapter.rb +11 -16
- data/lib/paperclip/io_adapters/empty_string_adapter.rb +5 -4
- data/lib/paperclip/io_adapters/file_adapter.rb +12 -6
- data/lib/paperclip/io_adapters/http_url_proxy_adapter.rb +7 -7
- data/lib/paperclip/io_adapters/identity_adapter.rb +12 -6
- data/lib/paperclip/io_adapters/nil_adapter.rb +8 -5
- data/lib/paperclip/io_adapters/registry.rb +6 -2
- data/lib/paperclip/io_adapters/stringio_adapter.rb +15 -16
- data/lib/paperclip/io_adapters/uploaded_file_adapter.rb +10 -6
- data/lib/paperclip/io_adapters/uri_adapter.rb +41 -19
- data/lib/paperclip/locales/en.yml +1 -0
- data/lib/paperclip/matchers/have_attached_file_matcher.rb +2 -1
- data/lib/paperclip/matchers/validate_attachment_content_type_matcher.rb +4 -4
- data/lib/paperclip/matchers/validate_attachment_presence_matcher.rb +2 -1
- data/lib/paperclip/matchers/validate_attachment_size_matcher.rb +2 -1
- data/lib/paperclip/media_type_spoof_detector.rb +90 -0
- data/lib/paperclip/processor.rb +5 -41
- data/lib/paperclip/processor_helpers.rb +50 -0
- data/lib/paperclip/rails_environment.rb +25 -0
- data/lib/paperclip/schema.rb +9 -7
- data/lib/paperclip/storage/filesystem.rb +14 -3
- data/lib/paperclip/storage/fog.rb +37 -19
- data/lib/paperclip/storage/s3.rb +129 -69
- data/lib/paperclip/style.rb +8 -2
- data/lib/paperclip/tempfile_factory.rb +5 -1
- data/lib/paperclip/thumbnail.rb +30 -18
- data/lib/paperclip/url_generator.rb +26 -14
- data/lib/paperclip/validators/attachment_content_type_validator.rb +4 -0
- data/lib/paperclip/validators/attachment_file_name_validator.rb +80 -0
- data/lib/paperclip/validators/attachment_file_type_ignorance_validator.rb +29 -0
- data/lib/paperclip/validators/attachment_presence_validator.rb +4 -0
- data/lib/paperclip/validators/attachment_size_validator.rb +5 -3
- data/lib/paperclip/validators/media_type_spoof_detection_validator.rb +27 -0
- data/lib/paperclip/validators.rb +11 -4
- data/lib/paperclip/version.rb +3 -1
- data/lib/paperclip.rb +30 -11
- data/lib/tasks/paperclip.rake +34 -5
- data/paperclip.gemspec +21 -16
- data/shoulda_macros/paperclip.rb +0 -1
- data/spec/paperclip/attachment_definitions_spec.rb +13 -0
- data/{test/attachment_processing_test.rb → spec/paperclip/attachment_processing_spec.rb} +17 -20
- data/spec/paperclip/attachment_registry_spec.rb +158 -0
- data/{test/attachment_test.rb → spec/paperclip/attachment_spec.rb} +502 -407
- data/{test/content_type_detector_test.rb → spec/paperclip/content_type_detector_spec.rb} +17 -20
- data/spec/paperclip/file_command_content_type_detector_spec.rb +40 -0
- data/spec/paperclip/filename_cleaner_spec.rb +14 -0
- data/spec/paperclip/geometry_detector_spec.rb +39 -0
- data/{test/geometry_parser_test.rb → spec/paperclip/geometry_parser_spec.rb} +27 -27
- data/{test/geometry_test.rb → spec/paperclip/geometry_spec.rb} +50 -52
- data/spec/paperclip/glue_spec.rb +44 -0
- data/spec/paperclip/has_attached_file_spec.rb +158 -0
- data/{test/integration_test.rb → spec/paperclip/integration_spec.rb} +137 -128
- data/{test/interpolations_test.rb → spec/paperclip/interpolations_spec.rb} +70 -46
- data/spec/paperclip/io_adapters/abstract_adapter_spec.rb +132 -0
- data/{test/io_adapters/attachment_adapter_test.rb → spec/paperclip/io_adapters/attachment_adapter_spec.rb} +33 -32
- data/spec/paperclip/io_adapters/data_uri_adapter_spec.rb +89 -0
- data/spec/paperclip/io_adapters/empty_string_adapter_spec.rb +17 -0
- data/{test/io_adapters/file_adapter_test.rb → spec/paperclip/io_adapters/file_adapter_spec.rb} +38 -42
- data/spec/paperclip/io_adapters/http_url_proxy_adapter_spec.rb +121 -0
- data/spec/paperclip/io_adapters/identity_adapter_spec.rb +8 -0
- data/{test/io_adapters/nil_adapter_test.rb → spec/paperclip/io_adapters/nil_adapter_spec.rb} +7 -7
- data/{test/io_adapters/registry_test.rb → spec/paperclip/io_adapters/registry_spec.rb} +12 -9
- data/{test/io_adapters/stringio_adapter_test.rb → spec/paperclip/io_adapters/stringio_adapter_spec.rb} +21 -18
- data/{test/io_adapters/uploaded_file_adapter_test.rb → spec/paperclip/io_adapters/uploaded_file_adapter_spec.rb} +46 -46
- data/spec/paperclip/io_adapters/uri_adapter_spec.rb +172 -0
- data/spec/paperclip/matchers/have_attached_file_matcher_spec.rb +19 -0
- data/spec/paperclip/matchers/validate_attachment_content_type_matcher_spec.rb +109 -0
- data/spec/paperclip/matchers/validate_attachment_presence_matcher_spec.rb +69 -0
- data/spec/paperclip/matchers/validate_attachment_size_matcher_spec.rb +88 -0
- data/spec/paperclip/media_type_spoof_detector_spec.rb +94 -0
- data/spec/paperclip/meta_class_spec.rb +30 -0
- data/spec/paperclip/paperclip_missing_attachment_styles_spec.rb +84 -0
- data/spec/paperclip/paperclip_spec.rb +192 -0
- data/spec/paperclip/plural_cache_spec.rb +37 -0
- data/spec/paperclip/processor_helpers_spec.rb +57 -0
- data/{test/processor_test.rb → spec/paperclip/processor_spec.rb} +7 -7
- data/spec/paperclip/rails_environment_spec.rb +33 -0
- data/{test/rake_test.rb → spec/paperclip/rake_spec.rb} +15 -15
- data/spec/paperclip/schema_spec.rb +248 -0
- data/{test/storage/filesystem_test.rb → spec/paperclip/storage/filesystem_spec.rb} +18 -18
- data/spec/paperclip/storage/fog_spec.rb +566 -0
- data/spec/paperclip/storage/s3_live_spec.rb +188 -0
- data/spec/paperclip/storage/s3_spec.rb +1693 -0
- data/spec/paperclip/style_spec.rb +255 -0
- data/spec/paperclip/tempfile_factory_spec.rb +33 -0
- data/spec/paperclip/tempfile_spec.rb +35 -0
- data/{test/thumbnail_test.rb → spec/paperclip/thumbnail_spec.rb} +153 -134
- data/spec/paperclip/url_generator_spec.rb +222 -0
- data/spec/paperclip/validators/attachment_content_type_validator_spec.rb +322 -0
- data/spec/paperclip/validators/attachment_file_name_validator_spec.rb +160 -0
- data/{test/validators/attachment_presence_validator_test.rb → spec/paperclip/validators/attachment_presence_validator_spec.rb} +20 -20
- data/{test/validators/attachment_size_validator_test.rb → spec/paperclip/validators/attachment_size_validator_spec.rb} +77 -64
- data/spec/paperclip/validators/media_type_spoof_detection_validator_spec.rb +52 -0
- data/spec/paperclip/validators_spec.rb +164 -0
- data/spec/spec_helper.rb +47 -0
- data/spec/support/assertions.rb +82 -0
- data/spec/support/conditional_filter_helper.rb +5 -0
- data/spec/support/fake_model.rb +25 -0
- data/spec/support/fake_rails.rb +12 -0
- data/spec/support/fixtures/empty.html +1 -0
- data/spec/support/fixtures/empty.xlsx +0 -0
- data/spec/support/fixtures/spaced file.jpg +0 -0
- data/spec/support/matchers/accept.rb +5 -0
- data/spec/support/matchers/exist.rb +5 -0
- data/spec/support/matchers/have_column.rb +23 -0
- data/{test → spec}/support/mock_attachment.rb +2 -0
- data/{test → spec}/support/mock_url_generator_builder.rb +2 -2
- data/spec/support/model_reconstruction.rb +68 -0
- data/spec/support/reporting.rb +11 -0
- data/spec/support/test_data.rb +13 -0
- data/spec/support/version_helper.rb +9 -0
- metadata +348 -225
- data/RUNNING_TESTS.md +0 -4
- data/cucumber/paperclip_steps.rb +0 -6
- data/gemfiles/3.0.gemfile +0 -11
- data/gemfiles/3.1.gemfile +0 -11
- data/gemfiles/3.2.gemfile +0 -11
- data/gemfiles/4.0.gemfile +0 -11
- data/test/attachment_definitions_test.rb +0 -12
- data/test/attachment_registry_test.rb +0 -88
- data/test/file_command_content_type_detector_test.rb +0 -27
- data/test/filename_cleaner_test.rb +0 -14
- data/test/generator_test.rb +0 -84
- data/test/geometry_detector_test.rb +0 -24
- data/test/has_attached_file_test.rb +0 -125
- data/test/helper.rb +0 -232
- data/test/io_adapters/abstract_adapter_test.rb +0 -58
- data/test/io_adapters/data_uri_adapter_test.rb +0 -74
- data/test/io_adapters/empty_string_adapter_test.rb +0 -18
- data/test/io_adapters/http_url_proxy_adapter_test.rb +0 -102
- data/test/io_adapters/identity_adapter_test.rb +0 -8
- data/test/io_adapters/uri_adapter_test.rb +0 -102
- data/test/matchers/have_attached_file_matcher_test.rb +0 -24
- data/test/matchers/validate_attachment_content_type_matcher_test.rb +0 -110
- data/test/matchers/validate_attachment_presence_matcher_test.rb +0 -69
- data/test/matchers/validate_attachment_size_matcher_test.rb +0 -86
- data/test/meta_class_test.rb +0 -32
- data/test/paperclip_missing_attachment_styles_test.rb +0 -90
- data/test/paperclip_test.rb +0 -217
- data/test/plural_cache_test.rb +0 -36
- data/test/schema_test.rb +0 -200
- data/test/storage/fog_test.rb +0 -473
- data/test/storage/s3_live_test.rb +0 -179
- data/test/storage/s3_test.rb +0 -1356
- data/test/style_test.rb +0 -213
- data/test/support/mock_model.rb +0 -2
- data/test/tempfile_factory_test.rb +0 -17
- data/test/url_generator_test.rb +0 -187
- data/test/validators/attachment_content_type_validator_test.rb +0 -324
- data/test/validators_test.rb +0 -61
- /data/{test → spec}/database.yml +0 -0
- /data/{test → spec/support}/fixtures/12k.png +0 -0
- /data/{test → spec/support}/fixtures/50x50.png +0 -0
- /data/{test → spec/support}/fixtures/5k.png +0 -0
- /data/{test → spec/support}/fixtures/animated +0 -0
- /data/{test → spec/support}/fixtures/animated.gif +0 -0
- /data/{test → spec/support}/fixtures/animated.unknown +0 -0
- /data/{test → spec/support}/fixtures/bad.png +0 -0
- /data/{test → spec/support}/fixtures/fog.yml +0 -0
- /data/{test → spec/support}/fixtures/rotated.jpg +0 -0
- /data/{test → spec/support}/fixtures/s3.yml +0 -0
- /data/{test → spec/support}/fixtures/spaced file.png +0 -0
- /data/{test → spec/support}/fixtures/text.txt +0 -0
- /data/{test → spec/support}/fixtures/twopage.pdf +0 -0
- /data/{test → spec/support}/fixtures/uppercase.PNG +0 -0
- /data/{test → spec}/support/mock_interpolator.rb +0 -0
@@ -0,0 +1,94 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe Paperclip::MediaTypeSpoofDetector do
|
4
|
+
it 'rejects a file that is named .html and identifies as PNG' do
|
5
|
+
file = File.open(fixture_file("5k.png"))
|
6
|
+
assert Paperclip::MediaTypeSpoofDetector.using(file, "5k.html", "image/png").spoofed?
|
7
|
+
end
|
8
|
+
|
9
|
+
it 'does not reject a file that is named .jpg and identifies as PNG' do
|
10
|
+
file = File.open(fixture_file("5k.png"))
|
11
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(file, "5k.jpg", "image/png").spoofed?
|
12
|
+
end
|
13
|
+
|
14
|
+
it 'does not reject a file that is named .html and identifies as HTML' do
|
15
|
+
file = File.open(fixture_file("empty.html"))
|
16
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "text/html").spoofed?
|
17
|
+
end
|
18
|
+
|
19
|
+
it 'does not reject a file that does not have a name' do
|
20
|
+
file = File.open(fixture_file("empty.html"))
|
21
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(file, "", "text/html").spoofed?
|
22
|
+
end
|
23
|
+
|
24
|
+
it 'does not reject a file that does have an extension' do
|
25
|
+
file = File.open(fixture_file("empty.html"))
|
26
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(file, "data", "text/html").spoofed?
|
27
|
+
end
|
28
|
+
|
29
|
+
it 'does not reject when the supplied file is an IOAdapter' do
|
30
|
+
adapter = Paperclip.io_adapters.for(File.new(fixture_file("5k.png")))
|
31
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(adapter, adapter.original_filename, adapter.content_type).spoofed?
|
32
|
+
end
|
33
|
+
|
34
|
+
it 'does not reject when the extension => content_type is in :content_type_mappings' do
|
35
|
+
begin
|
36
|
+
Paperclip.options[:content_type_mappings] = { pem: "text/plain" }
|
37
|
+
file = Tempfile.open(["test", ".PEM"])
|
38
|
+
file.puts "Certificate!"
|
39
|
+
file.close
|
40
|
+
adapter = Paperclip.io_adapters.for(File.new(file.path));
|
41
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(adapter, adapter.original_filename, adapter.content_type).spoofed?
|
42
|
+
ensure
|
43
|
+
Paperclip.options[:content_type_mappings] = {}
|
44
|
+
end
|
45
|
+
end
|
46
|
+
|
47
|
+
context "file named .html and is as HTML, but we're told JPG" do
|
48
|
+
let(:file) { File.open(fixture_file("empty.html")) }
|
49
|
+
let(:spoofed?) { Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "image/jpg").spoofed? }
|
50
|
+
|
51
|
+
it "rejects the file" do
|
52
|
+
assert spoofed?
|
53
|
+
end
|
54
|
+
|
55
|
+
it "logs info about the detected spoof" do
|
56
|
+
Paperclip.expects(:log).with('Content Type Spoof: Filename empty.html (image/jpg from Headers, ["text/html"] from Extension), content type discovered from file command: text/html. See documentation to allow this combination.')
|
57
|
+
spoofed?
|
58
|
+
end
|
59
|
+
end
|
60
|
+
|
61
|
+
it "does not reject if content_type is empty but otherwise checks out" do
|
62
|
+
file = File.open(fixture_file("empty.html"))
|
63
|
+
assert ! Paperclip::MediaTypeSpoofDetector.using(file, "empty.html", "").spoofed?
|
64
|
+
end
|
65
|
+
|
66
|
+
it 'does allow array as :content_type_mappings' do
|
67
|
+
begin
|
68
|
+
Paperclip.options[:content_type_mappings] = {
|
69
|
+
html: ['binary', 'text/html']
|
70
|
+
}
|
71
|
+
file = File.open(fixture_file('empty.html'))
|
72
|
+
spoofed = Paperclip::MediaTypeSpoofDetector
|
73
|
+
.using(file, "empty.html", "text/html").spoofed?
|
74
|
+
assert !spoofed
|
75
|
+
ensure
|
76
|
+
Paperclip.options[:content_type_mappings] = {}
|
77
|
+
end
|
78
|
+
end
|
79
|
+
|
80
|
+
context "#type_from_file_command" do
|
81
|
+
let(:file) { File.new(fixture_file("empty.html")) }
|
82
|
+
let(:detector) { Paperclip::MediaTypeSpoofDetector.new(file, "html", "") }
|
83
|
+
|
84
|
+
it "does work with the output of old versions of file" do
|
85
|
+
Paperclip.stubs(:run).returns("text/html charset=us-ascii")
|
86
|
+
expect(detector.send(:type_from_file_command)).to eq("text/html")
|
87
|
+
end
|
88
|
+
|
89
|
+
it "does work with the output of new versions of file" do
|
90
|
+
Paperclip.stubs(:run).returns("text/html; charset=us-ascii")
|
91
|
+
expect(detector.send(:type_from_file_command)).to eq("text/html")
|
92
|
+
end
|
93
|
+
end
|
94
|
+
end
|
@@ -0,0 +1,30 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe 'Metaclasses' do
|
4
|
+
context "A meta-class of dummy" do
|
5
|
+
if active_support_version >= "4.1" || ruby_version < "2.1"
|
6
|
+
before do
|
7
|
+
rebuild_model
|
8
|
+
reset_class("Dummy")
|
9
|
+
end
|
10
|
+
|
11
|
+
it "is able to use Paperclip like a normal class" do
|
12
|
+
@dummy = Dummy.new
|
13
|
+
|
14
|
+
assert_nothing_raised do
|
15
|
+
rebuild_meta_class_of(@dummy)
|
16
|
+
end
|
17
|
+
end
|
18
|
+
|
19
|
+
it "works like any other instance" do
|
20
|
+
@dummy = Dummy.new
|
21
|
+
rebuild_meta_class_of(@dummy)
|
22
|
+
|
23
|
+
assert_nothing_raised do
|
24
|
+
@dummy.avatar = File.new(fixture_file("5k.png"), 'rb')
|
25
|
+
end
|
26
|
+
assert @dummy.save
|
27
|
+
end
|
28
|
+
end
|
29
|
+
end
|
30
|
+
end
|
@@ -0,0 +1,84 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe 'Missing Attachment Styles' do
|
4
|
+
before do
|
5
|
+
Paperclip::AttachmentRegistry.clear
|
6
|
+
end
|
7
|
+
|
8
|
+
after do
|
9
|
+
File.unlink(Paperclip.registered_attachments_styles_path) rescue nil
|
10
|
+
end
|
11
|
+
|
12
|
+
it "enables to get and set path to registered styles file" do
|
13
|
+
assert_equal ROOT.join('tmp/public/system/paperclip_attachments.yml').to_s, Paperclip.registered_attachments_styles_path
|
14
|
+
Paperclip.registered_attachments_styles_path = '/tmp/config/paperclip_attachments.yml'
|
15
|
+
assert_equal '/tmp/config/paperclip_attachments.yml', Paperclip.registered_attachments_styles_path
|
16
|
+
Paperclip.registered_attachments_styles_path = nil
|
17
|
+
assert_equal ROOT.join('tmp/public/system/paperclip_attachments.yml').to_s, Paperclip.registered_attachments_styles_path
|
18
|
+
end
|
19
|
+
|
20
|
+
it "is able to get current attachment styles" do
|
21
|
+
assert_equal Hash.new, Paperclip.send(:current_attachments_styles)
|
22
|
+
rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
|
23
|
+
expected_hash = { Dummy: {avatar: [:big, :croppable]}}
|
24
|
+
assert_equal expected_hash, Paperclip.send(:current_attachments_styles)
|
25
|
+
end
|
26
|
+
|
27
|
+
it "is able to save current attachment styles for further comparison" do
|
28
|
+
rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
|
29
|
+
Paperclip.save_current_attachments_styles!
|
30
|
+
expected_hash = { Dummy: {avatar: [:big, :croppable]}}
|
31
|
+
assert_equal expected_hash, YAML.load_file(Paperclip.registered_attachments_styles_path)
|
32
|
+
end
|
33
|
+
|
34
|
+
it "is able to read registered attachment styles from file" do
|
35
|
+
rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
|
36
|
+
Paperclip.save_current_attachments_styles!
|
37
|
+
expected_hash = { Dummy: {avatar: [:big, :croppable]}}
|
38
|
+
assert_equal expected_hash, Paperclip.send(:get_registered_attachments_styles)
|
39
|
+
end
|
40
|
+
|
41
|
+
it "is able to calculate differences between registered styles and current styles" do
|
42
|
+
rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
|
43
|
+
Paperclip.save_current_attachments_styles!
|
44
|
+
rebuild_model styles: {thumb: 'x100', export: 'x400>', croppable: '600x600>', big: '1000x1000>'}
|
45
|
+
expected_hash = { Dummy: {avatar: [:export, :thumb]} }
|
46
|
+
assert_equal expected_hash, Paperclip.missing_attachments_styles
|
47
|
+
|
48
|
+
ActiveRecord::Base.connection.create_table :books, force: true
|
49
|
+
class ::Book < ActiveRecord::Base
|
50
|
+
has_attached_file :cover, styles: {small: 'x100', large: '1000x1000>'}
|
51
|
+
has_attached_file :sample, styles: {thumb: 'x100'}
|
52
|
+
end
|
53
|
+
|
54
|
+
expected_hash = {
|
55
|
+
Dummy: {avatar: [:export, :thumb]},
|
56
|
+
Book: {sample: [:thumb], cover: [:large, :small]}
|
57
|
+
}
|
58
|
+
assert_equal expected_hash, Paperclip.missing_attachments_styles
|
59
|
+
Paperclip.save_current_attachments_styles!
|
60
|
+
assert_equal Hash.new, Paperclip.missing_attachments_styles
|
61
|
+
end
|
62
|
+
|
63
|
+
it "is able to calculate differences when a new attachment is added to a model" do
|
64
|
+
rebuild_model styles: {croppable: '600x600>', big: '1000x1000>'}
|
65
|
+
Paperclip.save_current_attachments_styles!
|
66
|
+
|
67
|
+
class ::Dummy
|
68
|
+
has_attached_file :photo, styles: {small: 'x100', large: '1000x1000>'}
|
69
|
+
end
|
70
|
+
|
71
|
+
expected_hash = {
|
72
|
+
Dummy: {photo: [:large, :small]}
|
73
|
+
}
|
74
|
+
assert_equal expected_hash, Paperclip.missing_attachments_styles
|
75
|
+
Paperclip.save_current_attachments_styles!
|
76
|
+
assert_equal Hash.new, Paperclip.missing_attachments_styles
|
77
|
+
end
|
78
|
+
|
79
|
+
# It's impossible to build styles hash without loading from database whole bunch of records
|
80
|
+
it "skips lambda-styles" do
|
81
|
+
rebuild_model styles: lambda{ |attachment| attachment.instance.other == 'a' ? {thumb: "50x50#"} : {large: "400x400"} }
|
82
|
+
assert_equal Hash.new, Paperclip.send(:current_attachments_styles)
|
83
|
+
end
|
84
|
+
end
|
@@ -0,0 +1,192 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe Paperclip do
|
4
|
+
context ".run" do
|
5
|
+
before do
|
6
|
+
Paperclip.options[:log_command] = false
|
7
|
+
Terrapin::CommandLine.expects(:new).with("convert", "stuff", {}).returns(stub(:run))
|
8
|
+
@original_command_line_path = Terrapin::CommandLine.path
|
9
|
+
end
|
10
|
+
|
11
|
+
after do
|
12
|
+
Paperclip.options[:log_command] = true
|
13
|
+
Terrapin::CommandLine.path = @original_command_line_path
|
14
|
+
end
|
15
|
+
|
16
|
+
it "runs the command with Terrapin" do
|
17
|
+
Paperclip.run("convert", "stuff")
|
18
|
+
end
|
19
|
+
|
20
|
+
it "saves Terrapin::CommandLine.path that set before" do
|
21
|
+
Terrapin::CommandLine.path = "/opt/my_app/bin"
|
22
|
+
Paperclip.run("convert", "stuff")
|
23
|
+
expect(Terrapin::CommandLine.path).to match("/opt/my_app/bin")
|
24
|
+
end
|
25
|
+
|
26
|
+
it "does not duplicate Terrapin::CommandLine.path on multiple runs" do
|
27
|
+
Terrapin::CommandLine.expects(:new).with("convert", "more_stuff", {}).returns(stub(:run))
|
28
|
+
Terrapin::CommandLine.path = nil
|
29
|
+
Paperclip.options[:command_path] = "/opt/my_app/bin"
|
30
|
+
Paperclip.run("convert", "stuff")
|
31
|
+
Paperclip.run("convert", "more_stuff")
|
32
|
+
|
33
|
+
cmd_path = Paperclip.options[:command_path]
|
34
|
+
assert_equal 1, Terrapin::CommandLine.path.scan(cmd_path).count
|
35
|
+
end
|
36
|
+
end
|
37
|
+
|
38
|
+
it 'does not raise errors when doing a lot of running' do
|
39
|
+
Paperclip.options[:command_path] = ["/usr/local/bin"] * 1024
|
40
|
+
Terrapin::CommandLine.path = "/something/else"
|
41
|
+
100.times do |x|
|
42
|
+
Paperclip.run("echo", x.to_s)
|
43
|
+
end
|
44
|
+
end
|
45
|
+
|
46
|
+
context "Calling Paperclip.log without options[:logger] set" do
|
47
|
+
before do
|
48
|
+
Paperclip.logger = nil
|
49
|
+
Paperclip.options[:logger] = nil
|
50
|
+
end
|
51
|
+
|
52
|
+
after do
|
53
|
+
Paperclip.options[:logger] = ActiveRecord::Base.logger
|
54
|
+
Paperclip.logger = ActiveRecord::Base.logger
|
55
|
+
end
|
56
|
+
|
57
|
+
it "does not raise an error when log is called" do
|
58
|
+
silence_stream(STDOUT) do
|
59
|
+
Paperclip.log('something')
|
60
|
+
end
|
61
|
+
end
|
62
|
+
end
|
63
|
+
context "Calling Paperclip.run with a logger" do
|
64
|
+
it "passes the defined logger if :log_command is set" do
|
65
|
+
Paperclip.options[:log_command] = true
|
66
|
+
Terrapin::CommandLine.expects(:new).with("convert", "stuff", logger: Paperclip.logger).returns(stub(:run))
|
67
|
+
Paperclip.run("convert", "stuff")
|
68
|
+
end
|
69
|
+
end
|
70
|
+
|
71
|
+
context "Paperclip.each_instance_with_attachment" do
|
72
|
+
before do
|
73
|
+
@file = File.new(fixture_file("5k.png"), 'rb')
|
74
|
+
d1 = Dummy.create(avatar: @file)
|
75
|
+
d2 = Dummy.create
|
76
|
+
d3 = Dummy.create(avatar: @file)
|
77
|
+
@expected = [d1, d3]
|
78
|
+
end
|
79
|
+
|
80
|
+
after { @file.close }
|
81
|
+
|
82
|
+
it "yields every instance of a model that has an attachment" do
|
83
|
+
actual = []
|
84
|
+
Paperclip.each_instance_with_attachment("Dummy", "avatar") do |instance|
|
85
|
+
actual << instance
|
86
|
+
end
|
87
|
+
expect(actual).to match_array @expected
|
88
|
+
end
|
89
|
+
end
|
90
|
+
|
91
|
+
it "raises when sent #processor and the name of a class that doesn't exist" do
|
92
|
+
assert_raises(LoadError){ Paperclip.processor(:boogey_man) }
|
93
|
+
end
|
94
|
+
|
95
|
+
it "returns a class when sent #processor and the name of a class under Paperclip" do
|
96
|
+
assert_equal ::Paperclip::Thumbnail, Paperclip.processor(:thumbnail)
|
97
|
+
end
|
98
|
+
|
99
|
+
it "gets a class from a namespaced class name" do
|
100
|
+
class ::One; class Two; end; end
|
101
|
+
assert_equal ::One::Two, Paperclip.class_for("One::Two")
|
102
|
+
end
|
103
|
+
|
104
|
+
it "raises when class doesn't exist in specified namespace" do
|
105
|
+
class ::Three; end
|
106
|
+
class ::Four; end
|
107
|
+
assert_raises NameError do
|
108
|
+
Paperclip.class_for("Three::Four")
|
109
|
+
end
|
110
|
+
end
|
111
|
+
|
112
|
+
context "An ActiveRecord model with an 'avatar' attachment" do
|
113
|
+
before do
|
114
|
+
rebuild_model path: "tmp/:class/omg/:style.:extension"
|
115
|
+
@file = File.new(fixture_file("5k.png"), 'rb')
|
116
|
+
end
|
117
|
+
|
118
|
+
after { @file.close }
|
119
|
+
|
120
|
+
it "does not error when trying to also create a 'blah' attachment" do
|
121
|
+
assert_nothing_raised do
|
122
|
+
Dummy.class_eval do
|
123
|
+
has_attached_file :blah
|
124
|
+
end
|
125
|
+
end
|
126
|
+
end
|
127
|
+
|
128
|
+
context "with a subclass" do
|
129
|
+
before do
|
130
|
+
class ::SubDummy < Dummy; end
|
131
|
+
end
|
132
|
+
|
133
|
+
it "is able to use the attachment from the subclass" do
|
134
|
+
assert_nothing_raised do
|
135
|
+
@subdummy = SubDummy.create(avatar: @file)
|
136
|
+
end
|
137
|
+
end
|
138
|
+
|
139
|
+
after do
|
140
|
+
SubDummy.delete_all
|
141
|
+
Object.send(:remove_const, "SubDummy") rescue nil
|
142
|
+
end
|
143
|
+
end
|
144
|
+
|
145
|
+
it "has an avatar getter method" do
|
146
|
+
assert Dummy.new.respond_to?(:avatar)
|
147
|
+
end
|
148
|
+
|
149
|
+
it "has an avatar setter method" do
|
150
|
+
assert Dummy.new.respond_to?(:avatar=)
|
151
|
+
end
|
152
|
+
|
153
|
+
context "that is valid" do
|
154
|
+
before do
|
155
|
+
@dummy = Dummy.new
|
156
|
+
@dummy.avatar = @file
|
157
|
+
end
|
158
|
+
|
159
|
+
it "is valid" do
|
160
|
+
assert @dummy.valid?
|
161
|
+
end
|
162
|
+
end
|
163
|
+
|
164
|
+
it "does not have Attachment in the ActiveRecord::Base namespace" do
|
165
|
+
assert_raises(NameError) do
|
166
|
+
ActiveRecord::Base::Attachment
|
167
|
+
end
|
168
|
+
end
|
169
|
+
end
|
170
|
+
|
171
|
+
context "configuring a custom processor" do
|
172
|
+
before do
|
173
|
+
@freedom_processor = Class.new do
|
174
|
+
def make(file, options = {}, attachment = nil)
|
175
|
+
file
|
176
|
+
end
|
177
|
+
end.new
|
178
|
+
|
179
|
+
Paperclip.configure do |config|
|
180
|
+
config.register_processor(:freedom, @freedom_processor)
|
181
|
+
end
|
182
|
+
end
|
183
|
+
|
184
|
+
it "is able to find the custom processor" do
|
185
|
+
assert_equal @freedom_processor, Paperclip.processor(:freedom)
|
186
|
+
end
|
187
|
+
|
188
|
+
after do
|
189
|
+
Paperclip.clear_processors!
|
190
|
+
end
|
191
|
+
end
|
192
|
+
end
|
@@ -0,0 +1,37 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe 'Plural cache' do
|
4
|
+
it 'caches pluralizations' do
|
5
|
+
cache = Paperclip::Interpolations::PluralCache.new
|
6
|
+
symbol = :box
|
7
|
+
|
8
|
+
first = cache.pluralize_symbol(symbol)
|
9
|
+
second = cache.pluralize_symbol(symbol)
|
10
|
+
expect(first).to equal(second)
|
11
|
+
end
|
12
|
+
|
13
|
+
it 'caches pluralizations and underscores' do
|
14
|
+
class BigBox ; end
|
15
|
+
cache = Paperclip::Interpolations::PluralCache.new
|
16
|
+
klass = BigBox
|
17
|
+
|
18
|
+
first = cache.underscore_and_pluralize_class(klass)
|
19
|
+
second = cache.underscore_and_pluralize_class(klass)
|
20
|
+
expect(first).to equal(second)
|
21
|
+
end
|
22
|
+
|
23
|
+
it 'pluralizes words' do
|
24
|
+
cache = Paperclip::Interpolations::PluralCache.new
|
25
|
+
symbol = :box
|
26
|
+
|
27
|
+
expect(cache.pluralize_symbol(symbol)).to eq("boxes")
|
28
|
+
end
|
29
|
+
|
30
|
+
it 'pluralizes and underscore class names' do
|
31
|
+
class BigBox ; end
|
32
|
+
cache = Paperclip::Interpolations::PluralCache.new
|
33
|
+
klass = BigBox
|
34
|
+
|
35
|
+
expect(cache.underscore_and_pluralize_class(klass)).to eq("big_boxes")
|
36
|
+
end
|
37
|
+
end
|
@@ -0,0 +1,57 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe Paperclip::ProcessorHelpers do
|
4
|
+
describe '.load_processor' do
|
5
|
+
context 'when the file exists in lib/paperclip' do
|
6
|
+
it 'loads it correctly' do
|
7
|
+
pathname = Pathname.new('my_app')
|
8
|
+
main_path = 'main_path'
|
9
|
+
alternate_path = 'alternate_path'
|
10
|
+
|
11
|
+
Rails.stubs(:root).returns(pathname)
|
12
|
+
File.expects(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
|
13
|
+
File.expects(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
|
14
|
+
File.expects(:exist?).with(main_path).returns(true)
|
15
|
+
File.expects(:exist?).with(alternate_path).returns(false)
|
16
|
+
|
17
|
+
Paperclip.expects(:require).with(main_path)
|
18
|
+
|
19
|
+
Paperclip.load_processor(:custom)
|
20
|
+
end
|
21
|
+
end
|
22
|
+
|
23
|
+
context 'when the file exists in lib/paperclip_processors' do
|
24
|
+
it 'loads it correctly' do
|
25
|
+
pathname = Pathname.new('my_app')
|
26
|
+
main_path = 'main_path'
|
27
|
+
alternate_path = 'alternate_path'
|
28
|
+
|
29
|
+
Rails.stubs(:root).returns(pathname)
|
30
|
+
File.expects(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
|
31
|
+
File.expects(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
|
32
|
+
File.expects(:exist?).with(main_path).returns(false)
|
33
|
+
File.expects(:exist?).with(alternate_path).returns(true)
|
34
|
+
|
35
|
+
Paperclip.expects(:require).with(alternate_path)
|
36
|
+
|
37
|
+
Paperclip.load_processor(:custom)
|
38
|
+
end
|
39
|
+
end
|
40
|
+
|
41
|
+
context 'when the file does not exist in lib/paperclip_processors' do
|
42
|
+
it 'raises an error' do
|
43
|
+
pathname = Pathname.new('my_app')
|
44
|
+
main_path = 'main_path'
|
45
|
+
alternate_path = 'alternate_path'
|
46
|
+
|
47
|
+
Rails.stubs(:root).returns(pathname)
|
48
|
+
File.stubs(:expand_path).with(pathname.join('lib/paperclip', 'custom.rb')).returns(main_path)
|
49
|
+
File.stubs(:expand_path).with(pathname.join('lib/paperclip_processors', 'custom.rb')).returns(alternate_path)
|
50
|
+
File.stubs(:exist?).with(main_path).returns(false)
|
51
|
+
File.stubs(:exist?).with(alternate_path).returns(false)
|
52
|
+
|
53
|
+
assert_raises(LoadError) { Paperclip.processor(:custom) }
|
54
|
+
end
|
55
|
+
end
|
56
|
+
end
|
57
|
+
end
|
@@ -1,7 +1,7 @@
|
|
1
|
-
require '
|
1
|
+
require 'spec_helper'
|
2
2
|
|
3
|
-
|
4
|
-
|
3
|
+
describe Paperclip::Processor do
|
4
|
+
it "instantiates and call #make when sent #make to the class" do
|
5
5
|
processor = mock
|
6
6
|
processor.expects(:make).with()
|
7
7
|
Paperclip::Processor.expects(:new).with(:one, :two, :three).returns(processor)
|
@@ -9,17 +9,17 @@ class ProcessorTest < Test::Unit::TestCase
|
|
9
9
|
end
|
10
10
|
|
11
11
|
context "Calling #convert" do
|
12
|
-
|
12
|
+
it "runs the convert command with Terrapin" do
|
13
13
|
Paperclip.options[:log_command] = false
|
14
|
-
|
14
|
+
Terrapin::CommandLine.expects(:new).with("convert", "stuff", {}).returns(stub(:run))
|
15
15
|
Paperclip::Processor.new('filename').convert("stuff")
|
16
16
|
end
|
17
17
|
end
|
18
18
|
|
19
19
|
context "Calling #identify" do
|
20
|
-
|
20
|
+
it "runs the identify command with Terrapin" do
|
21
21
|
Paperclip.options[:log_command] = false
|
22
|
-
|
22
|
+
Terrapin::CommandLine.expects(:new).with("identify", "stuff", {}).returns(stub(:run))
|
23
23
|
Paperclip::Processor.new('filename').identify("stuff")
|
24
24
|
end
|
25
25
|
end
|
@@ -0,0 +1,33 @@
|
|
1
|
+
require 'spec_helper'
|
2
|
+
|
3
|
+
describe Paperclip::RailsEnvironment do
|
4
|
+
|
5
|
+
it "returns nil when Rails isn't defined" do
|
6
|
+
resetting_rails_to(nil) do
|
7
|
+
expect(Paperclip::RailsEnvironment.get).to be_nil
|
8
|
+
end
|
9
|
+
end
|
10
|
+
|
11
|
+
it "returns nil when Rails.env isn't defined" do
|
12
|
+
resetting_rails_to({}) do
|
13
|
+
expect(Paperclip::RailsEnvironment.get).to be_nil
|
14
|
+
end
|
15
|
+
end
|
16
|
+
|
17
|
+
it "returns the value of Rails.env if it is set" do
|
18
|
+
resetting_rails_to(OpenStruct.new(env: "foo")) do
|
19
|
+
expect(Paperclip::RailsEnvironment.get).to eq "foo"
|
20
|
+
end
|
21
|
+
end
|
22
|
+
|
23
|
+
def resetting_rails_to(new_value)
|
24
|
+
begin
|
25
|
+
previous_rails = Object.send(:remove_const, "Rails")
|
26
|
+
Object.const_set("Rails", new_value) unless new_value.nil?
|
27
|
+
yield
|
28
|
+
ensure
|
29
|
+
Object.send(:remove_const, "Rails") if Object.const_defined?("Rails")
|
30
|
+
Object.const_set("Rails", previous_rails)
|
31
|
+
end
|
32
|
+
end
|
33
|
+
end
|
@@ -1,10 +1,10 @@
|
|
1
|
-
require '
|
1
|
+
require 'spec_helper'
|
2
2
|
require 'rake'
|
3
3
|
load './lib/tasks/paperclip.rake'
|
4
4
|
|
5
|
-
|
5
|
+
describe Rake do
|
6
6
|
context "calling `rake paperclip:refresh:thumbnails`" do
|
7
|
-
|
7
|
+
before do
|
8
8
|
rebuild_model
|
9
9
|
Paperclip::Task.stubs(:obtain_class).returns('Dummy')
|
10
10
|
@bogus_instance = Dummy.new
|
@@ -16,22 +16,22 @@ class RakeTest < Test::Unit::TestCase
|
|
16
16
|
Paperclip.stubs(:each_instance_with_attachment).multiple_yields @bogus_instance, @valid_instance
|
17
17
|
end
|
18
18
|
context "when there is an exception in reprocess!" do
|
19
|
-
|
19
|
+
before do
|
20
20
|
@bogus_instance.avatar.stubs(:reprocess!).raises
|
21
21
|
end
|
22
22
|
|
23
|
-
|
23
|
+
it "catches the exception" do
|
24
24
|
assert_nothing_raised do
|
25
25
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
26
26
|
end
|
27
27
|
end
|
28
28
|
|
29
|
-
|
29
|
+
it "continues to the next instance" do
|
30
30
|
@valid_instance.avatar.expects(:reprocess!)
|
31
31
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
32
32
|
end
|
33
33
|
|
34
|
-
|
34
|
+
it "prints the exception" do
|
35
35
|
exception_msg = 'Some Exception'
|
36
36
|
@bogus_instance.avatar.stubs(:reprocess!).raises(exception_msg)
|
37
37
|
Paperclip::Task.expects(:log_error).with do |str|
|
@@ -40,14 +40,14 @@ class RakeTest < Test::Unit::TestCase
|
|
40
40
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
41
41
|
end
|
42
42
|
|
43
|
-
|
43
|
+
it "prints the class name" do
|
44
44
|
Paperclip::Task.expects(:log_error).with do |str|
|
45
45
|
str.match 'Dummy'
|
46
46
|
end
|
47
47
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
48
48
|
end
|
49
49
|
|
50
|
-
|
50
|
+
it "prints the instance ID" do
|
51
51
|
Paperclip::Task.expects(:log_error).with do |str|
|
52
52
|
str.match "ID #{@bogus_instance.id}"
|
53
53
|
end
|
@@ -56,19 +56,19 @@ class RakeTest < Test::Unit::TestCase
|
|
56
56
|
end
|
57
57
|
|
58
58
|
context "when there is an error in reprocess!" do
|
59
|
-
|
59
|
+
before do
|
60
60
|
@errors = mock('errors')
|
61
61
|
@errors.stubs(:full_messages).returns([''])
|
62
62
|
@errors.stubs(:blank?).returns(false)
|
63
63
|
@bogus_instance.stubs(:errors).returns(@errors)
|
64
64
|
end
|
65
65
|
|
66
|
-
|
66
|
+
it "continues to the next instance" do
|
67
67
|
@valid_instance.avatar.expects(:reprocess!)
|
68
68
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
69
69
|
end
|
70
70
|
|
71
|
-
|
71
|
+
it "prints the error" do
|
72
72
|
error_msg = 'Some Error'
|
73
73
|
@errors.stubs(:full_messages).returns([error_msg])
|
74
74
|
Paperclip::Task.expects(:log_error).with do |str|
|
@@ -77,14 +77,14 @@ class RakeTest < Test::Unit::TestCase
|
|
77
77
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
78
78
|
end
|
79
79
|
|
80
|
-
|
80
|
+
it "prints the class name" do
|
81
81
|
Paperclip::Task.expects(:log_error).with do |str|
|
82
82
|
str.match 'Dummy'
|
83
83
|
end
|
84
84
|
::Rake::Task['paperclip:refresh:thumbnails'].execute
|
85
85
|
end
|
86
86
|
|
87
|
-
|
87
|
+
it "prints the instance ID" do
|
88
88
|
Paperclip::Task.expects(:log_error).with do |str|
|
89
89
|
str.match "ID #{@bogus_instance.id}"
|
90
90
|
end
|
@@ -94,7 +94,7 @@ class RakeTest < Test::Unit::TestCase
|
|
94
94
|
end
|
95
95
|
|
96
96
|
context "Paperclip::Task.log_error method" do
|
97
|
-
|
97
|
+
it "prints its argument to STDERR" do
|
98
98
|
msg = 'Some Message'
|
99
99
|
$stderr.expects(:puts).with(msg)
|
100
100
|
Paperclip::Task.log_error(msg)
|