paperclip 3.5.2 → 5.2.1

Sign up to get free protection for your applications and to get access to all the features.
Files changed (211) hide show
  1. checksums.yaml +7 -0
  2. data/.codeclimate.yml +17 -0
  3. data/.gitignore +0 -6
  4. data/.hound.yml +1055 -0
  5. data/.rubocop.yml +1 -0
  6. data/.travis.yml +19 -13
  7. data/Appraisals +4 -16
  8. data/CONTRIBUTING.md +29 -13
  9. data/Gemfile +10 -7
  10. data/LICENSE +1 -3
  11. data/NEWS +226 -23
  12. data/README.md +494 -152
  13. data/RELEASING.md +17 -0
  14. data/Rakefile +6 -8
  15. data/UPGRADING +12 -9
  16. data/features/basic_integration.feature +27 -8
  17. data/features/migration.feature +0 -24
  18. data/features/step_definitions/attachment_steps.rb +36 -28
  19. data/features/step_definitions/html_steps.rb +2 -2
  20. data/features/step_definitions/rails_steps.rb +68 -37
  21. data/features/step_definitions/s3_steps.rb +2 -2
  22. data/features/step_definitions/web_steps.rb +1 -103
  23. data/features/support/env.rb +3 -2
  24. data/features/support/file_helpers.rb +2 -2
  25. data/features/support/fixtures/gemfile.txt +1 -1
  26. data/features/support/paths.rb +1 -1
  27. data/features/support/rails.rb +2 -25
  28. data/gemfiles/4.2.gemfile +17 -0
  29. data/gemfiles/5.0.gemfile +17 -0
  30. data/lib/generators/paperclip/paperclip_generator.rb +0 -2
  31. data/lib/generators/paperclip/templates/paperclip_migration.rb.erb +1 -1
  32. data/lib/paperclip/attachment.rb +160 -47
  33. data/lib/paperclip/attachment_registry.rb +4 -1
  34. data/lib/paperclip/callbacks.rb +13 -1
  35. data/lib/paperclip/content_type_detector.rb +26 -24
  36. data/lib/paperclip/errors.rb +8 -1
  37. data/lib/paperclip/file_command_content_type_detector.rb +6 -8
  38. data/lib/paperclip/geometry_detector_factory.rb +10 -3
  39. data/lib/paperclip/geometry_parser_factory.rb +1 -1
  40. data/lib/paperclip/glue.rb +1 -1
  41. data/lib/paperclip/has_attached_file.rb +17 -1
  42. data/lib/paperclip/helpers.rb +14 -10
  43. data/lib/paperclip/interpolations/plural_cache.rb +6 -5
  44. data/lib/paperclip/interpolations.rb +27 -14
  45. data/lib/paperclip/io_adapters/abstract_adapter.rb +28 -4
  46. data/lib/paperclip/io_adapters/attachment_adapter.rb +13 -8
  47. data/lib/paperclip/io_adapters/data_uri_adapter.rb +11 -16
  48. data/lib/paperclip/io_adapters/empty_string_adapter.rb +5 -4
  49. data/lib/paperclip/io_adapters/file_adapter.rb +12 -6
  50. data/lib/paperclip/io_adapters/http_url_proxy_adapter.rb +8 -8
  51. data/lib/paperclip/io_adapters/identity_adapter.rb +12 -6
  52. data/lib/paperclip/io_adapters/nil_adapter.rb +8 -5
  53. data/lib/paperclip/io_adapters/registry.rb +6 -2
  54. data/lib/paperclip/io_adapters/stringio_adapter.rb +15 -16
  55. data/lib/paperclip/io_adapters/uploaded_file_adapter.rb +10 -6
  56. data/lib/paperclip/io_adapters/uri_adapter.rb +41 -19
  57. data/lib/paperclip/locales/en.yml +1 -0
  58. data/lib/paperclip/matchers/have_attached_file_matcher.rb +2 -1
  59. data/lib/paperclip/matchers/validate_attachment_content_type_matcher.rb +4 -4
  60. data/lib/paperclip/matchers/validate_attachment_presence_matcher.rb +2 -1
  61. data/lib/paperclip/matchers/validate_attachment_size_matcher.rb +2 -1
  62. data/lib/paperclip/media_type_spoof_detector.rb +89 -0
  63. data/lib/paperclip/processor.rb +5 -41
  64. data/lib/paperclip/processor_helpers.rb +50 -0
  65. data/lib/paperclip/rails_environment.rb +25 -0
  66. data/lib/paperclip/schema.rb +9 -7
  67. data/lib/paperclip/storage/filesystem.rb +14 -3
  68. data/lib/paperclip/storage/fog.rb +47 -22
  69. data/lib/paperclip/storage/s3.rb +144 -73
  70. data/lib/paperclip/style.rb +8 -2
  71. data/lib/paperclip/tempfile_factory.rb +6 -4
  72. data/lib/paperclip/thumbnail.rb +26 -14
  73. data/lib/paperclip/url_generator.rb +25 -14
  74. data/lib/paperclip/validators/attachment_content_type_validator.rb +4 -0
  75. data/lib/paperclip/validators/attachment_file_name_validator.rb +80 -0
  76. data/lib/paperclip/validators/attachment_file_type_ignorance_validator.rb +29 -0
  77. data/lib/paperclip/validators/attachment_presence_validator.rb +4 -0
  78. data/lib/paperclip/validators/attachment_size_validator.rb +5 -3
  79. data/lib/paperclip/validators/media_type_spoof_detection_validator.rb +27 -0
  80. data/lib/paperclip/validators.rb +12 -3
  81. data/lib/paperclip/version.rb +3 -1
  82. data/lib/paperclip.rb +31 -11
  83. data/lib/tasks/paperclip.rake +34 -5
  84. data/paperclip.gemspec +18 -17
  85. data/shoulda_macros/paperclip.rb +13 -3
  86. data/{test → spec}/database.yml +0 -0
  87. data/spec/paperclip/attachment_definitions_spec.rb +13 -0
  88. data/{test/attachment_processing_test.rb → spec/paperclip/attachment_processing_spec.rb} +17 -20
  89. data/spec/paperclip/attachment_registry_spec.rb +158 -0
  90. data/{test/attachment_test.rb → spec/paperclip/attachment_spec.rb} +524 -400
  91. data/{test/content_type_detector_test.rb → spec/paperclip/content_type_detector_spec.rb} +17 -19
  92. data/{test/file_command_content_type_detector_test.rb → spec/paperclip/file_command_content_type_detector_spec.rb} +7 -6
  93. data/spec/paperclip/filename_cleaner_spec.rb +14 -0
  94. data/spec/paperclip/geometry_detector_spec.rb +39 -0
  95. data/{test/geometry_parser_test.rb → spec/paperclip/geometry_parser_spec.rb} +27 -27
  96. data/{test/geometry_test.rb → spec/paperclip/geometry_spec.rb} +50 -52
  97. data/spec/paperclip/glue_spec.rb +44 -0
  98. data/spec/paperclip/has_attached_file_spec.rb +158 -0
  99. data/{test/integration_test.rb → spec/paperclip/integration_spec.rb} +141 -133
  100. data/{test/interpolations_test.rb → spec/paperclip/interpolations_spec.rb} +70 -46
  101. data/spec/paperclip/io_adapters/abstract_adapter_spec.rb +101 -0
  102. data/{test/io_adapters/attachment_adapter_test.rb → spec/paperclip/io_adapters/attachment_adapter_spec.rb} +38 -34
  103. data/spec/paperclip/io_adapters/data_uri_adapter_spec.rb +89 -0
  104. data/spec/paperclip/io_adapters/empty_string_adapter_spec.rb +17 -0
  105. data/spec/paperclip/io_adapters/file_adapter_spec.rb +131 -0
  106. data/spec/paperclip/io_adapters/http_url_proxy_adapter_spec.rb +121 -0
  107. data/spec/paperclip/io_adapters/identity_adapter_spec.rb +8 -0
  108. data/{test/io_adapters/nil_adapter_test.rb → spec/paperclip/io_adapters/nil_adapter_spec.rb} +7 -7
  109. data/{test/io_adapters/registry_test.rb → spec/paperclip/io_adapters/registry_spec.rb} +12 -9
  110. data/{test/io_adapters/stringio_adapter_test.rb → spec/paperclip/io_adapters/stringio_adapter_spec.rb} +21 -18
  111. data/{test/io_adapters/uploaded_file_adapter_test.rb → spec/paperclip/io_adapters/uploaded_file_adapter_spec.rb} +46 -46
  112. data/spec/paperclip/io_adapters/uri_adapter_spec.rb +172 -0
  113. data/spec/paperclip/matchers/have_attached_file_matcher_spec.rb +19 -0
  114. data/spec/paperclip/matchers/validate_attachment_content_type_matcher_spec.rb +109 -0
  115. data/spec/paperclip/matchers/validate_attachment_presence_matcher_spec.rb +69 -0
  116. data/spec/paperclip/matchers/validate_attachment_size_matcher_spec.rb +88 -0
  117. data/spec/paperclip/media_type_spoof_detector_spec.rb +79 -0
  118. data/spec/paperclip/meta_class_spec.rb +30 -0
  119. data/spec/paperclip/paperclip_missing_attachment_styles_spec.rb +84 -0
  120. data/{test/paperclip_test.rb → spec/paperclip/paperclip_spec.rb} +46 -71
  121. data/spec/paperclip/plural_cache_spec.rb +37 -0
  122. data/spec/paperclip/processor_helpers_spec.rb +57 -0
  123. data/{test/processor_test.rb → spec/paperclip/processor_spec.rb} +5 -5
  124. data/spec/paperclip/rails_environment_spec.rb +33 -0
  125. data/{test/rake_test.rb → spec/paperclip/rake_spec.rb} +15 -15
  126. data/spec/paperclip/schema_spec.rb +248 -0
  127. data/{test/storage/filesystem_test.rb → spec/paperclip/storage/filesystem_spec.rb} +18 -18
  128. data/spec/paperclip/storage/fog_spec.rb +561 -0
  129. data/spec/paperclip/storage/s3_live_spec.rb +188 -0
  130. data/spec/paperclip/storage/s3_spec.rb +1693 -0
  131. data/spec/paperclip/style_spec.rb +255 -0
  132. data/spec/paperclip/tempfile_factory_spec.rb +33 -0
  133. data/spec/paperclip/tempfile_spec.rb +35 -0
  134. data/{test/thumbnail_test.rb → spec/paperclip/thumbnail_spec.rb} +150 -131
  135. data/spec/paperclip/url_generator_spec.rb +222 -0
  136. data/spec/paperclip/validators/attachment_content_type_validator_spec.rb +322 -0
  137. data/spec/paperclip/validators/attachment_file_name_validator_spec.rb +160 -0
  138. data/{test/validators/attachment_presence_validator_test.rb → spec/paperclip/validators/attachment_presence_validator_spec.rb} +20 -20
  139. data/{test/validators/attachment_size_validator_test.rb → spec/paperclip/validators/attachment_size_validator_spec.rb} +77 -64
  140. data/spec/paperclip/validators/media_type_spoof_detection_validator_spec.rb +52 -0
  141. data/spec/paperclip/validators_spec.rb +164 -0
  142. data/spec/spec_helper.rb +47 -0
  143. data/spec/support/assertions.rb +82 -0
  144. data/spec/support/conditional_filter_helper.rb +5 -0
  145. data/spec/support/fake_model.rb +25 -0
  146. data/spec/support/fake_rails.rb +12 -0
  147. data/{test → spec/support}/fixtures/12k.png +0 -0
  148. data/{test → spec/support}/fixtures/50x50.png +0 -0
  149. data/{test → spec/support}/fixtures/5k.png +0 -0
  150. data/{test → spec/support}/fixtures/animated +0 -0
  151. data/{test → spec/support}/fixtures/animated.gif +0 -0
  152. data/{test → spec/support}/fixtures/animated.unknown +0 -0
  153. data/{test → spec/support}/fixtures/bad.png +0 -0
  154. data/spec/support/fixtures/empty.html +1 -0
  155. data/spec/support/fixtures/empty.xlsx +0 -0
  156. data/{test → spec/support}/fixtures/fog.yml +0 -0
  157. data/{test → spec/support}/fixtures/rotated.jpg +0 -0
  158. data/{test → spec/support}/fixtures/s3.yml +0 -0
  159. data/spec/support/fixtures/spaced file.jpg +0 -0
  160. data/{test → spec/support}/fixtures/spaced file.png +0 -0
  161. data/{test → spec/support}/fixtures/text.txt +0 -0
  162. data/{test → spec/support}/fixtures/twopage.pdf +0 -0
  163. data/{test → spec/support}/fixtures/uppercase.PNG +0 -0
  164. data/spec/support/matchers/accept.rb +5 -0
  165. data/spec/support/matchers/exist.rb +5 -0
  166. data/spec/support/matchers/have_column.rb +23 -0
  167. data/{test → spec}/support/mock_attachment.rb +2 -0
  168. data/{test → spec}/support/mock_interpolator.rb +0 -0
  169. data/{test → spec}/support/mock_url_generator_builder.rb +2 -2
  170. data/spec/support/model_reconstruction.rb +68 -0
  171. data/spec/support/reporting.rb +11 -0
  172. data/spec/support/test_data.rb +13 -0
  173. data/spec/support/version_helper.rb +9 -0
  174. metadata +262 -297
  175. data/RUNNING_TESTS.md +0 -4
  176. data/cucumber/paperclip_steps.rb +0 -6
  177. data/gemfiles/3.0.gemfile +0 -11
  178. data/gemfiles/3.1.gemfile +0 -11
  179. data/gemfiles/3.2.gemfile +0 -11
  180. data/gemfiles/4.0.gemfile +0 -11
  181. data/test/attachment_definitions_test.rb +0 -12
  182. data/test/attachment_registry_test.rb +0 -77
  183. data/test/filename_cleaner_test.rb +0 -14
  184. data/test/generator_test.rb +0 -80
  185. data/test/geometry_detector_test.rb +0 -24
  186. data/test/has_attached_file_test.rb +0 -125
  187. data/test/helper.rb +0 -215
  188. data/test/io_adapters/abstract_adapter_test.rb +0 -58
  189. data/test/io_adapters/data_uri_adapter_test.rb +0 -67
  190. data/test/io_adapters/empty_string_adapter_test.rb +0 -17
  191. data/test/io_adapters/file_adapter_test.rb +0 -119
  192. data/test/io_adapters/http_url_proxy_adapter_test.rb +0 -102
  193. data/test/io_adapters/identity_adapter_test.rb +0 -8
  194. data/test/io_adapters/uri_adapter_test.rb +0 -102
  195. data/test/matchers/have_attached_file_matcher_test.rb +0 -24
  196. data/test/matchers/validate_attachment_content_type_matcher_test.rb +0 -110
  197. data/test/matchers/validate_attachment_presence_matcher_test.rb +0 -69
  198. data/test/matchers/validate_attachment_size_matcher_test.rb +0 -86
  199. data/test/meta_class_test.rb +0 -32
  200. data/test/paperclip_missing_attachment_styles_test.rb +0 -90
  201. data/test/plural_cache_test.rb +0 -36
  202. data/test/schema_test.rb +0 -200
  203. data/test/storage/fog_test.rb +0 -453
  204. data/test/storage/s3_live_test.rb +0 -179
  205. data/test/storage/s3_test.rb +0 -1348
  206. data/test/style_test.rb +0 -213
  207. data/test/support/mock_model.rb +0 -2
  208. data/test/tempfile_factory_test.rb +0 -13
  209. data/test/url_generator_test.rb +0 -187
  210. data/test/validators/attachment_content_type_validator_test.rb +0 -323
  211. data/test/validators_test.rb +0 -32
@@ -1,67 +0,0 @@
1
- require './test/helper'
2
-
3
- class DataUriAdapterTest < Test::Unit::TestCase
4
- context "a new instance" do
5
- setup do
6
- @contents = "data:image/png;base64,#{original_base64_content}"
7
- @subject = Paperclip.io_adapters.for(@contents)
8
- end
9
-
10
- should "return a file name" do
11
- assert_equal "base64.txt", @subject.original_filename
12
- end
13
-
14
- should "return a content type" do
15
- assert_equal "image/png", @subject.content_type
16
- end
17
-
18
- should "return the size of the data" do
19
- assert_equal 4456, @subject.size
20
- end
21
-
22
- should "generate a correct MD5 hash of the contents" do
23
- assert_equal(
24
- Digest::MD5.hexdigest(Base64.decode64(original_base64_content)),
25
- @subject.fingerprint
26
- )
27
- end
28
-
29
- should "generate correct fingerprint after read" do
30
- fingerprint = Digest::MD5.hexdigest(@subject.read)
31
- assert_equal fingerprint, @subject.fingerprint
32
- end
33
-
34
- should "generate same fingerprint" do
35
- assert_equal @subject.fingerprint, @subject.fingerprint
36
- end
37
-
38
- should 'accept a content_type' do
39
- @subject.content_type = 'image/png'
40
- assert_equal 'image/png', @subject.content_type
41
- end
42
-
43
- should 'accept an original_filename' do
44
- @subject.original_filename = 'image.png'
45
- assert_equal 'image.png', @subject.original_filename
46
- end
47
-
48
- should "not generate filenames that include restricted characters" do
49
- @subject.original_filename = 'image:restricted.png'
50
- assert_equal 'image_restricted.png', @subject.original_filename
51
- end
52
-
53
- should "not generate paths that include restricted characters" do
54
- @subject.original_filename = 'image:restricted.png'
55
- assert_no_match /:/, @subject.path
56
- end
57
-
58
- end
59
-
60
- def original_base64_content
61
- Base64.encode64(original_file_contents)
62
- end
63
-
64
- def original_file_contents
65
- @original_file_contents ||= File.read(fixture_file('5k.png'))
66
- end
67
- end
@@ -1,17 +0,0 @@
1
- require './test/helper'
2
-
3
- class EmptyStringAdapterTest < Test::Unit::TestCase
4
- context 'a new instance' do
5
- setup do
6
- @subject = Paperclip.io_adapters.for('')
7
- end
8
-
9
- should "return false for a call to nil?" do
10
- assert !@subject.nil?
11
- end
12
-
13
- should 'return false for a call to assignment?' do
14
- assert !@subject.assignment?
15
- end
16
- end
17
- end
@@ -1,119 +0,0 @@
1
- require './test/helper'
2
-
3
- class FileAdapterTest < Test::Unit::TestCase
4
- context "a new instance" do
5
- context "with normal file" do
6
- setup do
7
- @file = File.new(fixture_file("5k.png"))
8
- @file.binmode
9
- @subject = Paperclip.io_adapters.for(@file)
10
- end
11
-
12
- teardown { @file.close }
13
-
14
- should "get the right filename" do
15
- assert_equal "5k.png", @subject.original_filename
16
- end
17
-
18
- should "force binmode on tempfile" do
19
- assert @subject.instance_variable_get("@tempfile").binmode?
20
- end
21
-
22
- should "get the content type" do
23
- assert_equal "image/png", @subject.content_type
24
- end
25
-
26
- should "return content type as a string" do
27
- assert_kind_of String, @subject.content_type
28
- end
29
-
30
- should "get the file's size" do
31
- assert_equal 4456, @subject.size
32
- end
33
-
34
- should "return false for a call to nil?" do
35
- assert ! @subject.nil?
36
- end
37
-
38
- should "generate a MD5 hash of the contents" do
39
- expected = Digest::MD5.file(@file.path).to_s
40
- assert_equal expected, @subject.fingerprint
41
- end
42
-
43
- should "read the contents of the file" do
44
- expected = @file.read
45
- assert expected.length > 0
46
- assert_equal expected, @subject.read
47
- end
48
-
49
- context "file with multiple possible content type" do
50
- setup do
51
- MIME::Types.stubs(:type_for).returns([MIME::Type.new('image/x-png'), MIME::Type.new('image/png')])
52
- end
53
-
54
- should "prefer officially registered mime type" do
55
- assert_equal "image/png", @subject.content_type
56
- end
57
-
58
- should "return content type as a string" do
59
- assert_kind_of String, @subject.content_type
60
- end
61
- end
62
-
63
- context "file with multiple possible x-types but no official type" do
64
- setup do
65
- MIME::Types.stubs(:type_for).returns([MIME::Type.new('image/x-mp4'), MIME::Type.new('image/x-video')])
66
- @subject = Paperclip.io_adapters.for(@file)
67
- end
68
-
69
- should "return the first" do
70
- assert_equal "image/x-mp4", @subject.content_type
71
- end
72
- end
73
-
74
- context "file with content type derived from file command on *nix" do
75
- setup do
76
- MIME::Types.stubs(:type_for).returns([])
77
- Paperclip.stubs(:run).returns("application/vnd.ms-office\n")
78
- @subject = Paperclip.io_adapters.for(@file)
79
- end
80
-
81
- should "return content type without newline character" do
82
- assert_equal "application/vnd.ms-office", @subject.content_type
83
- end
84
- end
85
- end
86
-
87
- context "filename with restricted characters" do
88
- setup do
89
- file_contents = File.new(fixture_file("animated.gif"))
90
- @file = StringIO.new(file_contents.read)
91
- @file.stubs(:original_filename).returns('image:restricted.gif')
92
- @subject = Paperclip.io_adapters.for(@file)
93
- end
94
-
95
- teardown { @file.close }
96
-
97
- should "not generate filenames that include restricted characters" do
98
- assert_equal 'image_restricted.gif', @subject.original_filename
99
- end
100
-
101
- should "not generate paths that include restricted characters" do
102
- assert_no_match /:/, @subject.path
103
- end
104
- end
105
-
106
- context "empty file" do
107
- setup do
108
- @file = Tempfile.new("file_adapter_test")
109
- @subject = Paperclip.io_adapters.for(@file)
110
- end
111
-
112
- teardown { @file.close }
113
-
114
- should "provide correct mime-type" do
115
- assert_match %r{.*/x-empty}, @subject.content_type
116
- end
117
- end
118
- end
119
- end
@@ -1,102 +0,0 @@
1
- require './test/helper'
2
-
3
- class HttpUrlProxyAdapterTest < Test::Unit::TestCase
4
- context "a new instance" do
5
- setup do
6
- @open_return = StringIO.new("xxx")
7
- @open_return.stubs(:content_type).returns("image/png")
8
- Paperclip::HttpUrlProxyAdapter.any_instance.stubs(:download_content).returns(@open_return)
9
- @url = "http://thoughtbot.com/images/thoughtbot-logo.png"
10
- @subject = Paperclip.io_adapters.for(@url)
11
- end
12
-
13
- teardown do
14
- @subject.close
15
- end
16
-
17
- should "return a file name" do
18
- assert_equal "thoughtbot-logo.png", @subject.original_filename
19
- end
20
-
21
- should 'close open handle after reading' do
22
- assert_equal true, @open_return.closed?
23
- end
24
-
25
- should "return a content type" do
26
- assert_equal "image/png", @subject.content_type
27
- end
28
-
29
- should "return the size of the data" do
30
- assert_equal @open_return.size, @subject.size
31
- end
32
-
33
- should "generate an MD5 hash of the contents" do
34
- assert_equal Digest::MD5.hexdigest("xxx"), @subject.fingerprint
35
- end
36
-
37
- should "generate correct fingerprint after read" do
38
- fingerprint = Digest::MD5.hexdigest(@subject.read)
39
- assert_equal fingerprint, @subject.fingerprint
40
- end
41
-
42
- should "generate same fingerprint" do
43
- assert_equal @subject.fingerprint, @subject.fingerprint
44
- end
45
-
46
- should "return the data contained in the StringIO" do
47
- assert_equal "xxx", @subject.read
48
- end
49
-
50
- should 'accept a content_type' do
51
- @subject.content_type = 'image/png'
52
- assert_equal 'image/png', @subject.content_type
53
- end
54
-
55
- should 'accept an original_filename' do
56
- @subject.original_filename = 'image.png'
57
- assert_equal 'image.png', @subject.original_filename
58
- end
59
- end
60
-
61
- context "a url with query params" do
62
- setup do
63
- Paperclip::HttpUrlProxyAdapter.any_instance.stubs(:download_content).returns(StringIO.new("x"))
64
- @url = "https://github.com/thoughtbot/paperclip?file=test"
65
- @subject = Paperclip.io_adapters.for(@url)
66
- end
67
-
68
- teardown do
69
- @subject.close
70
- end
71
-
72
- should "return a file name" do
73
- assert_equal "paperclip", @subject.original_filename
74
- end
75
- end
76
-
77
- context "a url with restricted characters in the filename" do
78
- setup do
79
- Paperclip::HttpUrlProxyAdapter.any_instance.stubs(:download_content).returns(StringIO.new("x"))
80
- @url = "https://github.com/thoughtbot/paper:clip.jpg"
81
- @subject = Paperclip.io_adapters.for(@url)
82
- end
83
-
84
- teardown do
85
- begin
86
- @subject.close
87
- rescue Exception => e
88
- binding.pry
89
- true
90
- end
91
- end
92
-
93
- should "not generate filenames that include restricted characters" do
94
- assert_equal "paper_clip.jpg", @subject.original_filename
95
- end
96
-
97
- should "not generate paths that include restricted characters" do
98
- assert_no_match /:/, @subject.path
99
- end
100
- end
101
-
102
- end
@@ -1,8 +0,0 @@
1
- require './test/helper'
2
-
3
- class IdentityAdapterTest < Test::Unit::TestCase
4
- should "respond to #new by returning the argument" do
5
- adapter = Paperclip::IdentityAdapter.new
6
- assert_equal :target, adapter.new(:target)
7
- end
8
- end
@@ -1,102 +0,0 @@
1
- require './test/helper'
2
-
3
- class UriProxyTest < Test::Unit::TestCase
4
- context "a new instance" do
5
- setup do
6
- @open_return = StringIO.new("xxx")
7
- @open_return.stubs(:content_type).returns("image/png")
8
- Paperclip::UriAdapter.any_instance.stubs(:download_content).returns(@open_return)
9
- @uri = URI.parse("http://thoughtbot.com/images/thoughtbot-logo.png")
10
- @subject = Paperclip.io_adapters.for(@uri)
11
- end
12
-
13
- should "return a file name" do
14
- assert_equal "thoughtbot-logo.png", @subject.original_filename
15
- end
16
-
17
- should 'close open handle after reading' do
18
- assert_equal true, @open_return.closed?
19
- end
20
-
21
- should "return a content type" do
22
- assert_equal "image/png", @subject.content_type
23
- end
24
-
25
- should "return the size of the data" do
26
- assert_equal @open_return.size, @subject.size
27
- end
28
-
29
- should "generate an MD5 hash of the contents" do
30
- assert_equal Digest::MD5.hexdigest("xxx"), @subject.fingerprint
31
- end
32
-
33
- should "generate correct fingerprint after read" do
34
- fingerprint = Digest::MD5.hexdigest(@subject.read)
35
- assert_equal fingerprint, @subject.fingerprint
36
- end
37
-
38
- should "generate same fingerprint" do
39
- assert_equal @subject.fingerprint, @subject.fingerprint
40
- end
41
-
42
- should "return the data contained in the StringIO" do
43
- assert_equal "xxx", @subject.read
44
- end
45
-
46
- should 'accept a content_type' do
47
- @subject.content_type = 'image/png'
48
- assert_equal 'image/png', @subject.content_type
49
- end
50
-
51
- should 'accept an orgiginal_filename' do
52
- @subject.original_filename = 'image.png'
53
- assert_equal 'image.png', @subject.original_filename
54
- end
55
-
56
- end
57
-
58
- context "a directory index url" do
59
- setup do
60
- Paperclip::UriAdapter.any_instance.stubs(:download_content).returns(StringIO.new("xxx"))
61
- @uri = URI.parse("http://thoughtbot.com")
62
- @subject = Paperclip.io_adapters.for(@uri)
63
- end
64
-
65
- should "return a file name" do
66
- assert_equal "index.html", @subject.original_filename
67
- end
68
-
69
- should "return a content type" do
70
- assert_equal "text/html", @subject.content_type
71
- end
72
- end
73
-
74
- context "a url with query params" do
75
- setup do
76
- Paperclip::UriAdapter.any_instance.stubs(:download_content).returns(StringIO.new("xxx"))
77
- @uri = URI.parse("https://github.com/thoughtbot/paperclip?file=test")
78
- @subject = Paperclip.io_adapters.for(@uri)
79
- end
80
-
81
- should "return a file name" do
82
- assert_equal "paperclip", @subject.original_filename
83
- end
84
- end
85
-
86
- context "a url with restricted characters in the filename" do
87
- setup do
88
- Paperclip::UriAdapter.any_instance.stubs(:download_content).returns(StringIO.new("xxx"))
89
- @uri = URI.parse("https://github.com/thoughtbot/paper:clip.jpg")
90
- @subject = Paperclip.io_adapters.for(@uri)
91
- end
92
-
93
- should "not generate filenames that include restricted characters" do
94
- assert_equal "paper_clip.jpg", @subject.original_filename
95
- end
96
-
97
- should "not generate paths that include restricted characters" do
98
- assert_no_match /:/, @subject.path
99
- end
100
- end
101
-
102
- end
@@ -1,24 +0,0 @@
1
- require './test/helper'
2
-
3
- class HaveAttachedFileMatcherTest < Test::Unit::TestCase
4
- context "have_attached_file" do
5
- setup do
6
- @dummy_class = reset_class "Dummy"
7
- reset_table "dummies"
8
- @matcher = self.class.have_attached_file(:avatar)
9
- end
10
-
11
- context "given a class with no attachment" do
12
- should_reject_dummy_class
13
- end
14
-
15
- context "given a class with an attachment" do
16
- setup do
17
- modify_table("dummies"){|d| d.string :avatar_file_name }
18
- @dummy_class.has_attached_file :avatar
19
- end
20
-
21
- should_accept_dummy_class
22
- end
23
- end
24
- end
@@ -1,110 +0,0 @@
1
- require './test/helper'
2
-
3
- class ValidateAttachmentContentTypeMatcherTest < Test::Unit::TestCase
4
- context "validate_attachment_content_type" do
5
- setup do
6
- reset_table("dummies") do |d|
7
- d.string :title
8
- d.string :avatar_file_name
9
- d.string :avatar_content_type
10
- end
11
- @dummy_class = reset_class "Dummy"
12
- @dummy_class.has_attached_file :avatar
13
- @matcher = self.class.validate_attachment_content_type(:avatar).
14
- allowing(%w(image/png image/jpeg)).
15
- rejecting(%w(audio/mp3 application/octet-stream))
16
- end
17
-
18
- context "given a class with no validation" do
19
- should_reject_dummy_class
20
- end
21
-
22
- context "given a class with a validation that doesn't match" do
23
- setup do
24
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{audio/.*}
25
- end
26
-
27
- should_reject_dummy_class
28
- end
29
-
30
- context "given a class with a matching validation" do
31
- setup do
32
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{image/.*}
33
- end
34
-
35
- should_accept_dummy_class
36
- end
37
-
38
- context "given a class with other validations but matching types" do
39
- setup do
40
- @dummy_class.validates_presence_of :title
41
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{image/.*}
42
- end
43
-
44
- should_accept_dummy_class
45
- end
46
-
47
- context "given a class that matches and a matcher that only specifies 'allowing'" do
48
- setup do
49
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{image/.*}
50
- @matcher = self.class.validate_attachment_content_type(:avatar).
51
- allowing(%w(image/png image/jpeg))
52
- end
53
-
54
- should_accept_dummy_class
55
- end
56
-
57
- context "given a class that does not match and a matcher that only specifies 'allowing'" do
58
- setup do
59
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{audio/.*}
60
- @matcher = self.class.validate_attachment_content_type(:avatar).
61
- allowing(%w(image/png image/jpeg))
62
- end
63
-
64
- should_reject_dummy_class
65
- end
66
-
67
- context "given a class that matches and a matcher that only specifies 'rejecting'" do
68
- setup do
69
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{image/.*}
70
- @matcher = self.class.validate_attachment_content_type(:avatar).
71
- rejecting(%w(audio/mp3 application/octet-stream))
72
- end
73
-
74
- should_accept_dummy_class
75
- end
76
-
77
- context "given a class that does not match and a matcher that only specifies 'rejecting'" do
78
- setup do
79
- @dummy_class.validates_attachment_content_type :avatar, :content_type => %r{audio/.*}
80
- @matcher = self.class.validate_attachment_content_type(:avatar).
81
- rejecting(%w(audio/mp3 application/octet-stream))
82
- end
83
-
84
- should_reject_dummy_class
85
- end
86
-
87
- context "using an :if to control the validation" do
88
- setup do
89
- @dummy_class.class_eval do
90
- validates_attachment_content_type :avatar, :content_type => %r{image/*} , :if => :go
91
- attr_accessor :go
92
- end
93
- @matcher = self.class.validate_attachment_content_type(:avatar).
94
- allowing(%w(image/png image/jpeg)).
95
- rejecting(%w(audio/mp3 application/octet-stream))
96
- @dummy = @dummy_class.new
97
- end
98
-
99
- should "run the validation if the control is true" do
100
- @dummy.go = true
101
- assert_accepts @matcher, @dummy
102
- end
103
-
104
- should "not run the validation if the control is false" do
105
- @dummy.go = false
106
- assert_rejects @matcher, @dummy
107
- end
108
- end
109
- end
110
- end
@@ -1,69 +0,0 @@
1
- require './test/helper'
2
-
3
- class ValidateAttachmentPresenceMatcherTest < Test::Unit::TestCase
4
- context "validate_attachment_presence" do
5
- setup do
6
- reset_table("dummies") do |d|
7
- d.string :avatar_file_name
8
- end
9
- @dummy_class = reset_class "Dummy"
10
- @dummy_class.has_attached_file :avatar
11
- @matcher = self.class.validate_attachment_presence(:avatar)
12
- end
13
-
14
- context "given a class with no validation" do
15
- should_reject_dummy_class
16
- end
17
-
18
- context "given a class with a matching validation" do
19
- setup do
20
- @dummy_class.validates_attachment_presence :avatar
21
- end
22
-
23
- should_accept_dummy_class
24
- end
25
-
26
- context "given an instance with other attachment validations" do
27
- setup do
28
- reset_table("dummies") do |d|
29
- d.string :avatar_file_name
30
- d.string :avatar_content_type
31
- end
32
-
33
- @dummy_class.class_eval do
34
- validates_attachment_presence :avatar
35
- validates_attachment_content_type :avatar, :content_type => 'image/gif'
36
- end
37
-
38
- @dummy = @dummy_class.new
39
- @matcher = self.class.validate_attachment_presence(:avatar)
40
- end
41
-
42
- should "it should validate properly" do
43
- @dummy.avatar = File.new fixture_file('5k.png')
44
- assert_accepts @matcher, @dummy
45
- end
46
- end
47
-
48
- context "using an :if to control the validation" do
49
- setup do
50
- @dummy_class.class_eval do
51
- validates_attachment_presence :avatar, :if => :go
52
- attr_accessor :go
53
- end
54
- @dummy = @dummy_class.new
55
- @dummy.avatar = nil
56
- end
57
-
58
- should "run the validation if the control is true" do
59
- @dummy.go = true
60
- assert_accepts @matcher, @dummy
61
- end
62
-
63
- should "not run the validation if the control is false" do
64
- @dummy.go = false
65
- assert_rejects @matcher, @dummy
66
- end
67
- end
68
- end
69
- end