paperclip 3.4.0 → 6.1.0

data/{test/thumbnail_test.rb → spec/paperclip/thumbnail_spec.rb}

@@ -1,70 +1,38 @@
-require './test/helper'
-
-class ThumbnailTest < Test::Unit::TestCase
-
-  context "A Paperclip Tempfile" do
-    setup do
-      @tempfile = Paperclip::Tempfile.new(["file", ".jpg"])
-    end
-
-    teardown { @tempfile.close }
-
-    should "have its path contain a real extension" do
-      assert_equal ".jpg", File.extname(@tempfile.path)
-    end
-
-    should "be a real Tempfile" do
-      assert @tempfile.is_a?(::Tempfile)
-    end
-  end
-
-  context "Another Paperclip Tempfile" do
-    setup do
-      @tempfile = Paperclip::Tempfile.new("file")
-    end
-
-    teardown { @tempfile.close }
-
-    should "not have an extension if not given one" do
-      assert_equal "", File.extname(@tempfile.path)
-    end
-
-    should "still be a real Tempfile" do
-      assert @tempfile.is_a?(::Tempfile)
-    end
-  end
+require 'spec_helper'
 
+describe Paperclip::Thumbnail do
   context "An image" do
-    setup do
+    before do
       @file = File.new(fixture_file("5k.png"), 'rb')
     end
 
-    teardown { @file.close }
+    after { @file.close }
 
     [["600x600>", "434x66"],
      ["400x400>", "400x61"],
-     ["32x32<", "434x66"]
+     ["32x32<", "434x66"],
+     [nil, "434x66"]
     ].each do |args|
       context "being thumbnailed with a geometry of #{args[0]}" do
-        setup do
-          @thumb = Paperclip::Thumbnail.new(@file, :geometry => args[0])
+        before do
+          @thumb = Paperclip::Thumbnail.new(@file, geometry: args[0])
         end
 
-        should "start with dimensions of 434x66" do
+        it "starts with dimensions of 434x66" do
           cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
           assert_equal "434x66", `#{cmd}`.chomp
         end
 
-        should "report the correct target geometry" do
-          assert_equal args[0], @thumb.target_geometry.to_s
+        it "reports the correct target geometry" do
+          assert_equal args[0].to_s, @thumb.target_geometry.to_s
         end
 
         context "when made" do
-          setup do
+          before do
             @thumb_result = @thumb.make
           end
 
-          should "be the size we expect it to be" do
+          it "is the size we expect it to be" do
             cmd = %Q[identify -format "%wx%h" "#{@thumb_result.path}"]
             assert_equal args[1], `#{cmd}`.chomp
           end
@@ -73,14 +41,14 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "being thumbnailed at 100x50 with cropping" do
-      setup do
-        @thumb = Paperclip::Thumbnail.new(@file, :geometry => "100x50#")
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "100x50#")
       end
 
-      should "let us know when a command isn't found versus a processing error" do
+      it "lets us know when a command isn't found versus a processing error" do
         old_path = ENV['PATH']
         begin
-          Cocaine::CommandLine.path = ''
+          Terrapin::CommandLine.path = ''
           Paperclip.options[:command_path] = ''
           ENV['PATH'] = ''
           assert_raises(Paperclip::Errors::CommandNotFoundError) do
@@ -93,28 +61,28 @@ class ThumbnailTest < Test::Unit::TestCase
         end
       end
 
-      should "report its correct current and target geometries" do
+      it "reports its correct current and target geometries" do
         assert_equal "100x50#", @thumb.target_geometry.to_s
         assert_equal "434x66", @thumb.current_geometry.to_s
       end
 
-      should "report its correct format" do
+      it "reports its correct format" do
         assert_nil @thumb.format
       end
 
-      should "have whiny turned on by default" do
+      it "has whiny turned on by default" do
         assert @thumb.whiny
       end
 
-      should "have convert_options set to nil by default" do
+      it "has convert_options set to nil by default" do
         assert_equal nil, @thumb.convert_options
       end
 
-      should "have source_file_options set to nil by default" do
+      it "has source_file_options set to nil by default" do
         assert_equal nil, @thumb.source_file_options
       end
 
-      should "send the right command to convert when sent #make" do
+      it "sends the right command to convert when sent #make" do
         @thumb.expects(:convert).with do |*arg|
           arg[0] == ':source -auto-orient -resize "x50" -crop "100x50+114+0" +repage :dest' &&
           arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
@@ -122,34 +90,34 @@ class ThumbnailTest < Test::Unit::TestCase
         @thumb.make
       end
 
-      should "create the thumbnail when sent #make" do
+      it "creates the thumbnail when sent #make" do
         dst = @thumb.make
         assert_match /100x50/, `identify "#{dst.path}"`
       end
     end
 
-    should 'properly crop a EXIF-rotated image' do
+    it 'crops a EXIF-rotated image properly' do
       file = File.new(fixture_file('rotated.jpg'))
-      thumb = Paperclip::Thumbnail.new(file, :geometry => "50x50#")
+      thumb = Paperclip::Thumbnail.new(file, geometry: "50x50#")
 
       output_file = thumb.make
 
-      command = Cocaine::CommandLine.new("identify", "-format %wx%h :file")
-      assert_equal "50x50", command.run(:file => output_file.path).strip
+      command = Terrapin::CommandLine.new("identify", "-format %wx%h :file")
+      assert_equal "50x50", command.run(file: output_file.path).strip
     end
 
     context "being thumbnailed with source file options set" do
-      setup do
+      before do
         @thumb = Paperclip::Thumbnail.new(@file,
-                                          :geometry            => "100x50#",
-                                          :source_file_options => "-strip")
+                                          geometry: "100x50#",
+                                          source_file_options: "-strip")
       end
 
-      should "have source_file_options value set" do
+      it "has source_file_options value set" do
         assert_equal ["-strip"], @thumb.source_file_options
       end
 
-      should "send the right command to convert when sent #make" do
+      it "sends the right command to convert when sent #make" do
         @thumb.expects(:convert).with do |*arg|
           arg[0] == '-strip :source -auto-orient -resize "x50" -crop "100x50+114+0" +repage :dest' &&
           arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
@@ -157,19 +125,19 @@ class ThumbnailTest < Test::Unit::TestCase
         @thumb.make
       end
 
-      should "create the thumbnail when sent #make" do
+      it "creates the thumbnail when sent #make" do
         dst = @thumb.make
         assert_match /100x50/, `identify "#{dst.path}"`
       end
 
       context "redefined to have bad source_file_options setting" do
-        setup do
+        before do
           @thumb = Paperclip::Thumbnail.new(@file,
-                                            :geometry => "100x50#",
-                                            :source_file_options => "-this-aint-no-option")
+                                            geometry: "100x50#",
+                                            source_file_options: "-this-aint-no-option")
         end
 
-        should "error when trying to create the thumbnail" do
+        it "errors when trying to create the thumbnail" do
           assert_raises(Paperclip::Error) do
             silence_stream(STDERR) do
               @thumb.make
@@ -180,17 +148,17 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "being thumbnailed with convert options set" do
-      setup do
+      before do
         @thumb = Paperclip::Thumbnail.new(@file,
-                                          :geometry        => "100x50#",
-                                          :convert_options => "-strip -depth 8")
+                                          geometry: "100x50#",
+                                          convert_options: "-strip -depth 8")
       end
 
-      should "have convert_options value set" do
+      it "has convert_options value set" do
         assert_equal %w"-strip -depth 8", @thumb.convert_options
       end
 
-      should "send the right command to convert when sent #make" do
+      it "sends the right command to convert when sent #make" do
         @thumb.expects(:convert).with do |*arg|
           arg[0] == ':source -auto-orient -resize "x50" -crop "100x50+114+0" +repage -strip -depth 8 :dest' &&
           arg[1][:source] == "#{File.expand_path(@thumb.file.path)}[0]"
@@ -198,30 +166,32 @@ class ThumbnailTest < Test::Unit::TestCase
         @thumb.make
       end
 
-      should "create the thumbnail when sent #make" do
+      it "creates the thumbnail when sent #make" do
         dst = @thumb.make
         assert_match /100x50/, `identify "#{dst.path}"`
       end
 
       context "redefined to have bad convert_options setting" do
-        setup do
+        before do
           @thumb = Paperclip::Thumbnail.new(@file,
-                                            :geometry => "100x50#",
-                                            :convert_options => "-this-aint-no-option")
+                                            geometry: "100x50#",
+                                            convert_options: "-this-aint-no-option")
         end
 
-        should "error when trying to create the thumbnail" do
-          assert_raises(Paperclip::Error) do
-            silence_stream(STDERR) do
+        it "errors when trying to create the thumbnail" do
+          silence_stream(STDERR) do
+            expect {
               @thumb.make
-            end
+            }.to raise_error(
+              Paperclip::Error, /unrecognized option `-this-aint-no-option'/
+            )
           end
         end
 
-        should "let us know when a command isn't found versus a processing error" do
+        it "lets us know when a command isn't found versus a processing error" do
           old_path = ENV['PATH']
           begin
-            Cocaine::CommandLine.path = ''
+            Terrapin::CommandLine.path = ''
             Paperclip.options[:command_path] = ''
             ENV['PATH'] = ''
             assert_raises(Paperclip::Errors::CommandNotFoundError) do
@@ -237,20 +207,20 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "being thumbnailed with a blank geometry string" do
-      setup do
+      before do
         @thumb = Paperclip::Thumbnail.new(@file,
-                                          :geometry        => "",
-                                          :convert_options => "-gravity center -crop \"300x300+0-0\"")
+                                          geometry: "",
+                                          convert_options: "-gravity center -crop \"300x300+0-0\"")
       end
 
-      should "not get resized by default" do
+      it "does not get resized by default" do
         assert !@thumb.transformation_command.include?("-resize")
       end
     end
 
     context "being thumbnailed with default animated option (true)" do
-      should "call identify to check for animated images when sent #make" do
-        thumb = Paperclip::Thumbnail.new(@file, :geometry => "100x50#")
+      it "calls identify to check for animated images when sent #make" do
+        thumb = Paperclip::Thumbnail.new(@file, geometry: "100x50#")
         thumb.expects(:identify).at_least_once.with do |*arg|
           arg[0] == '-format %m :file' &&
           arg[1][:file] == "#{File.expand_path(thumb.file.path)}[0]"
@@ -260,11 +230,11 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "passing a custom file geometry parser" do
-      teardown do
-        self.class.send(:remove_const, :GeoParser)
+      after do
+        Object.send(:remove_const, :GeoParser) if Object.const_defined?(:GeoParser)
       end
 
-      should "produce the appropriate transformation_command" do
+      it "produces the appropriate transformation_command" do
         GeoParser = Class.new do
           def self.from_file(file)
             new
@@ -275,7 +245,7 @@ class ThumbnailTest < Test::Unit::TestCase
           end
         end
 
-        thumb = Paperclip::Thumbnail.new(@file, :geometry => '50x50', :file_geometry_parser => GeoParser)
+        thumb = Paperclip::Thumbnail.new(@file, geometry: '50x50', file_geometry_parser: ::GeoParser)
 
         transformation_command = thumb.transformation_command
 
@@ -291,11 +261,11 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "passing a custom geometry string parser" do
-      teardown do
-        self.class.send(:remove_const, :GeoParser)
+      after do
+        Object.send(:remove_const, :GeoParser) if Object.const_defined?(:GeoParser)
       end
 
-      should "produce the appropriate transformation_command" do
+      it "produces the appropriate transformation_command" do
         GeoParser = Class.new do
           def self.parse(s)
             new
@@ -306,7 +276,7 @@ class ThumbnailTest < Test::Unit::TestCase
           end
         end
 
-        thumb = Paperclip::Thumbnail.new(@file, :geometry => '50x50', :string_geometry_parser => GeoParser)
+        thumb = Paperclip::Thumbnail.new(@file, geometry: '50x50', string_geometry_parser: ::GeoParser)
 
         transformation_command = thumb.transformation_command
 
@@ -317,32 +287,32 @@ class ThumbnailTest < Test::Unit::TestCase
   end
 
   context "A multipage PDF" do
-    setup do
+    before do
       @file = File.new(fixture_file("twopage.pdf"), 'rb')
     end
 
-    teardown { @file.close }
+    after { @file.close }
 
-    should "start with two pages with dimensions 612x792" do
+    it "starts with two pages with dimensions 612x792" do
       cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
       assert_equal "612x792"*2, `#{cmd}`.chomp
     end
 
     context "being thumbnailed at 100x100 with cropping" do
-      setup do
-        @thumb = Paperclip::Thumbnail.new(@file, :geometry => "100x100#", :format => :png)
+      before do
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "100x100#", format: :png)
       end
 
-      should "report its correct current and target geometries" do
+      it "reports its correct current and target geometries" do
         assert_equal "100x100#", @thumb.target_geometry.to_s
         assert_equal "612x792", @thumb.current_geometry.to_s
       end
 
-      should "report its correct format" do
+      it "reports its correct format" do
         assert_equal :png, @thumb.format
       end
 
-      should "create the thumbnail when sent #make" do
+      it "creates the thumbnail when sent #make" do
         dst = @thumb.make
         assert_match /100x100/, `identify "#{dst.path}"`
       end
@@ -350,23 +320,23 @@ class ThumbnailTest < Test::Unit::TestCase
   end
 
   context "An animated gif" do
-    setup do
+    before do
       @file = File.new(fixture_file("animated.gif"), 'rb')
     end
 
-    teardown { @file.close }
+    after { @file.close }
 
-    should "start with 12 frames with size 100x100" do
+    it "starts with 12 frames with size 100x100" do
       cmd = %Q[identify -format "%wx%h" "#{@file.path}"]
       assert_equal "100x100"*12, `#{cmd}`.chomp
     end
 
     context "with static output" do
-      setup do
-       @thumb = Paperclip::Thumbnail.new(@file, :geometry => "50x50", :format => :jpg)
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :jpg)
       end
 
-      should "create the single frame thumbnail when sent #make" do
+      it "creates the single frame thumbnail when sent #make" do
         dst = @thumb.make
         cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
         assert_equal "50x50", `#{cmd}`.chomp
@@ -374,87 +344,162 @@ class ThumbnailTest < Test::Unit::TestCase
     end
 
     context "with animated output format" do
-      setup do
-       @thumb = Paperclip::Thumbnail.new(@file, :geometry => "50x50", :format => :gif)
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :gif)
       end
 
-      should "create the 12 frames thumbnail when sent #make" do
+      it "creates the 12 frames thumbnail when sent #make" do
         dst = @thumb.make
-        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
-        assert_equal "50x50"*12, `#{cmd}`.chomp
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (45..50), frames
       end
 
-      should "use the -coalesce option" do
+      it "uses the -coalesce option" do
         assert_equal @thumb.transformation_command.first, "-coalesce"
       end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
     end
 
     context "with omitted output format" do
-      setup do
-       @thumb = Paperclip::Thumbnail.new(@file, :geometry => "50x50")
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50")
       end
 
-      should "create the 12 frames thumbnail when sent #make" do
+      it "creates the 12 frames thumbnail when sent #make" do
         dst = @thumb.make
-        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
-        assert_equal "50x50"*12, `#{cmd}`.chomp
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (45..50), frames
       end
 
-      should "use the -coalesce option" do
+      it "uses the -coalesce option" do
         assert_equal @thumb.transformation_command.first, "-coalesce"
       end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
     end
 
     context "with unidentified source format" do
-      setup do
+      before do
         @unidentified_file = File.new(fixture_file("animated.unknown"), 'rb')
-        @thumb = Paperclip::Thumbnail.new(@file, :geometry => "60x60")
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "60x60")
       end
 
-      should "create the 12 frames thumbnail when sent #make" do
+      it "creates the 12 frames thumbnail when sent #make" do
         dst = @thumb.make
-        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
-        assert_equal "60x60"*12, `#{cmd}`.chomp
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (55..60), frames
       end
 
-      should "use the -coalesce option" do
+      it "uses the -coalesce option" do
         assert_equal @thumb.transformation_command.first, "-coalesce"
       end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
     end
 
     context "with no source format" do
-      setup do
+      before do
         @unidentified_file = File.new(fixture_file("animated"), 'rb')
-        @thumb = Paperclip::Thumbnail.new(@file, :geometry => "70x70")
+        @thumb = Paperclip::Thumbnail.new(@file, geometry: "70x70")
       end
 
-      should "create the 12 frames thumbnail when sent #make" do
+      it "creates the 12 frames thumbnail when sent #make" do
         dst = @thumb.make
-        cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
-        assert_equal "70x70"*12, `#{cmd}`.chomp
+        cmd = %Q[identify -format "%wx%h," "#{dst.path}"]
+        frames = `#{cmd}`.chomp.split(',')
+        assert_equal 12, frames.size
+        assert_frame_dimensions (60..70), frames
       end
 
-      should "use the -coalesce option" do
+      it "uses the -coalesce option" do
         assert_equal @thumb.transformation_command.first, "-coalesce"
       end
+
+      it "uses the -layers 'optimize' option" do
+        assert_equal @thumb.transformation_command.last, '-layers "optimize"'
+      end
     end
 
     context "with animated option set to false" do
-      setup do
-       @thumb = Paperclip::Thumbnail.new(@file, :geometry => "50x50", :animated => false)
+      before do
+       @thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", animated: false)
       end
 
-      should "output the gif format" do
+      it "outputs the gif format" do
         dst = @thumb.make
         cmd = %Q[identify "#{dst.path}"]
         assert_match /GIF/, `#{cmd}`.chomp
       end
 
-      should "create the single frame thumbnail when sent #make" do
+      it "creates the single frame thumbnail when sent #make" do
         dst = @thumb.make
         cmd = %Q[identify -format "%wx%h" "#{dst.path}"]
         assert_equal "50x50", `#{cmd}`.chomp
       end
     end
+
+    context "with a specified frame_index" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(
+          @file,
+          geometry: "50x50",
+          frame_index: 5,
+          format: :jpg,
+        )
+      end
+
+      it "creates the thumbnail from the frame index when sent #make" do
+        @thumb.make
+        assert_equal 5, @thumb.frame_index
+      end
+    end
+
+    context "with a specified frame_index out of bounds" do
+      before do
+        @thumb = Paperclip::Thumbnail.new(
+          @file,
+          geometry: "50x50",
+          frame_index: 20,
+          format: :jpg,
+        )
+      end
+
+      it "errors when trying to create the thumbnail" do
+        assert_raises(Paperclip::Error) do
+          silence_stream(STDERR) do
+            @thumb.make
+          end
+        end
+      end
+    end
+  end
+
+  context "with a really long file name" do
+    before do
+      tempfile = Tempfile.new("f")
+      tempfile_additional_chars = tempfile.path.split("/")[-1].length + 15
+      image_file = File.new(fixture_file("5k.png"), "rb")
+      @file = Tempfile.new("f" * (255 - tempfile_additional_chars))
+      @file.write(image_file.read)
+      @file.rewind
+    end
+
+    it "does not throw Errno::ENAMETOOLONG" do
+      thumb = Paperclip::Thumbnail.new(@file, geometry: "50x50", format: :gif)
+      expect { thumb.make }.to_not raise_error
+    end
   end
 end