RubyGems - paperclip - Versions diffs - 2.3.11 → 2.3.16 - Mend

paperclip 2.3.11 → 2.3.16

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Potentially problematic release.

This version of paperclip might be problematic. Click here for more details.

Files changed (36) hide show

data/README.md +30 -4
data/Rakefile +3 -3
data/init.rb +3 -0
data/lib/generators/paperclip/paperclip_generator.rb +3 -1
data/lib/paperclip/attachment.rb +27 -12
data/lib/paperclip/{callback_compatability.rb → callback_compatibility.rb} +0 -0
data/lib/paperclip/geometry.rb +4 -1
data/lib/paperclip/interpolations.rb +8 -3
data/lib/paperclip/iostream.rb +1 -1
data/lib/paperclip/matchers/validate_attachment_content_type_matcher.rb +20 -14
data/lib/paperclip/processor.rb +1 -1
data/lib/paperclip/storage/filesystem.rb +8 -3
data/lib/paperclip/storage/fog.rb +48 -13
data/lib/paperclip/storage/s3.rb +54 -16
data/lib/paperclip/style.rb +4 -3
data/lib/paperclip/thumbnail.rb +18 -3
data/lib/paperclip/upfile.rb +20 -13
data/lib/paperclip/version.rb +1 -1
data/lib/paperclip.rb +60 -27
data/lib/tasks/paperclip.rake +32 -23
data/test/attachment_test.rb +116 -0
data/test/fixtures/animated.gif +0 -0
data/test/fog_test.rb +30 -19
data/test/geometry_test.rb +29 -0
data/test/helper.rb +3 -0
data/test/integration_test.rb +40 -4
data/test/interpolations_test.rb +14 -0
data/test/matchers/validate_attachment_content_type_matcher_test.rb +42 -2
data/test/paperclip_test.rb +18 -40
data/test/storage_test.rb +244 -7
data/test/style_test.rb +30 -5
data/test/thumbnail_test.rb +111 -6
data/test/upfile_test.rb +3 -2
metadata +103 -122
data/lib/paperclip/command_line.rb +0 -86
data/test/command_line_test.rb +0 -138

data/test/command_line_test.rb DELETED Viewed

@@ -1,138 +0,0 @@
-require './test/helper'
-class CommandLineTest < Test::Unit::TestCase
-  def setup
-    Paperclip::CommandLine.path = nil
-    File.stubs(:exist?).with("/dev/null").returns(true)
-  end
-  should "allow colons in parameters" do
-    cmd = Paperclip::CommandLine.new("convert", "'a.jpg' -resize 175x220> -size 175x220 xc:black +swap -gravity center -composite 'b.jpg'", :swallow_stderr => false)
-    assert_equal "convert 'a.jpg' -resize 175x220> -size 175x220 xc:black +swap -gravity center -composite 'b.jpg'", cmd.command
-  end
-  should "take a command and parameters and produce a shell command for bash" do
-    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
-    assert_equal "convert a.jpg b.png", cmd.command
-  end
-  should "be able to set a path and produce commands with that path" do
-    Paperclip::CommandLine.path = "/opt/bin"
-    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
-    assert_equal "/opt/bin/convert a.jpg b.png", cmd.command
-  end
-  should "be able to interpolate quoted variables into the parameters" do
-    cmd = Paperclip::CommandLine.new("convert",
-                                     ":one :{two}",
-                                     :one => "a.jpg",
-                                     :two => "b.png",
-                                     :swallow_stderr => false)
-    assert_equal "convert 'a.jpg' 'b.png'", cmd.command
-  end
-  should "quote command line options differently if we're on windows" do
-    File.stubs(:exist?).with("/dev/null").returns(false)
-    cmd = Paperclip::CommandLine.new("convert",
-                                     ":one :{two}",
-                                     :one => "a.jpg",
-                                     :two => "b.png",
-                                     :swallow_stderr => false)
-    assert_equal 'convert "a.jpg" "b.png"', cmd.command
-  end
-  should "be able to quote and interpolate dangerous variables" do
-    cmd = Paperclip::CommandLine.new("convert",
-                                     ":one :two",
-                                     :one => "`rm -rf`.jpg",
-                                     :two => "ha'ha.png",
-                                     :swallow_stderr => false)
-    assert_equal "convert '`rm -rf`.jpg' 'ha'\\''ha.png'", cmd.command
-  end
-  should "be able to quote and interpolate dangerous variables even on windows" do
-    File.stubs(:exist?).with("/dev/null").returns(false)
-    cmd = Paperclip::CommandLine.new("convert",
-                                     ":one :two",
-                                     :one => "`rm -rf`.jpg",
-                                     :two => "ha'ha.png",
-                                     :swallow_stderr => false)
-    assert_equal %{convert "`rm -rf`.jpg" "ha'ha.png"}, cmd.command
-  end
-  should "add redirection to get rid of stderr in bash" do
-    File.stubs(:exist?).with("/dev/null").returns(true)
-    cmd = Paperclip::CommandLine.new("convert",
-                                     "a.jpg b.png",
-                                     :swallow_stderr => true)
-    assert_equal "convert a.jpg b.png 2>/dev/null", cmd.command
-  end
-  should "add redirection to get rid of stderr in cmd.exe" do
-    File.stubs(:exist?).with("/dev/null").returns(false)
-    cmd = Paperclip::CommandLine.new("convert",
-                                     "a.jpg b.png",
-                                     :swallow_stderr => true)
-    assert_equal "convert a.jpg b.png 2>NUL", cmd.command
-  end
-  should "raise if trying to interpolate :swallow_stderr or :expected_outcodes" do
-    cmd = Paperclip::CommandLine.new("convert",
-                                     ":swallow_stderr :expected_outcodes",
-                                     :swallow_stderr => false,
-                                     :expected_outcodes => [0, 1])
-    assert_raise(Paperclip::PaperclipCommandLineError) do
-      cmd.command
-    end
-  end
-  should "run the #command it's given and return the output" do
-    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
-    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
-    with_exitstatus_returning(0) do
-      assert_equal :correct_value, cmd.run
-    end
-  end
-  should "raise a PaperclipCommandLineError if the result code isn't expected" do
-    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
-    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
-    with_exitstatus_returning(1) do
-      assert_raises(Paperclip::PaperclipCommandLineError) do
-        cmd.run
-      end
-    end
-  end
-  should "not raise a PaperclipCommandLineError if the result code is expected" do
-    cmd = Paperclip::CommandLine.new("convert",
-                                     "a.jpg b.png",
-                                     :expected_outcodes => [0, 1],
-                                     :swallow_stderr => false)
-    cmd.class.stubs(:"`").with("convert a.jpg b.png").returns(:correct_value)
-    with_exitstatus_returning(1) do
-      assert_nothing_raised do
-        cmd.run
-      end
-    end
-  end
-  should "log the command" do
-    cmd = Paperclip::CommandLine.new("convert", "a.jpg b.png", :swallow_stderr => false)
-    cmd.class.stubs(:'`')
-    Paperclip.expects(:log).with("convert a.jpg b.png")
-    cmd.run
-  end
-  should "detect that the system is unix or windows based on presence of /dev/null" do
-    File.stubs(:exist?).returns(true)
-    assert Paperclip::CommandLine.unix?
-  end
-  should "detect that the system is not unix or windows based on absence of /dev/null" do
-    File.stubs(:exist?).returns(false)
-    assert ! Paperclip::CommandLine.unix?
-  end
-end