paperclip-permanent_records 0.4.0 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: d3bdbba54470c8648d6c9142341358a972517d28
-  data.tar.gz: c08220d8ac31b12ac11bc89c58ac102eae0429fa
+SHA256:
+  metadata.gz: a3cc4b67b3ac8a02e0405be5da6e0975088ea86eb9f61fcd53f2738440885fee
+  data.tar.gz: d9bb55debfeb8e9392b822573eed97ba7799a1119d89ba1a9aaef71584bef1a7
 SHA512:
-  metadata.gz: 0889073c9419ff4a7dbeba7dca791e7b54058154b596509ae007f8beaa4124c041d5ddcb923a77336743b7b3f770e229863f3d0f9d41035748d8361e3a963ff2
-  data.tar.gz: 9db4b49baf4aad4b0a27ada9f2768e635eb34fc7a4d4e2583928f48e474f79656b642d4e4cd99c6ca3f78544a9034da6510cbdc067b48a01dd01b94d8928ae25
+  metadata.gz: d0ffedc08fa51d0991e4b2ff29ab993e58a4528ad869f43e86cf61c6f849e1a5d413e4af53c46c69821b6bd8d97504fbf24234cdbab2b37f69c9f03cab50d183
+  data.tar.gz: 31252601357c7cca94f29ac0ba72eb7bf8e33f2089d71c446cd435fbc0a40b69a244c64fea9e6dab2cfdcdde81fad63ec8196df98cd8e80b6771747fa0263b8b

data/.rubocop.yml

@@ -1,7 +1,13 @@
-require: rubocop-rspec
-
 inherit_from: .rubocop_todo.yml
 
+require:
+  - rubocop-performance
+  - rubocop-rspec
+
+inherit_mode:
+  merge:
+    - Exclude
+
 AllCops:
   Include:
     - 'Appraisals'
@@ -11,22 +17,224 @@ AllCops:
     - '**/Gemfile'
     - '**/Rakefile'
     - '**/Capfile'
-  TargetRubyVersion: 2.2
+  TargetRubyVersion: 2.5
 
-Layout/AlignHash:
-  EnforcedColonStyle: 'table'
+Gemspec/DateAssignment: # (new in 1.10)
+  Enabled: true
 
-Layout/AlignParameters:
+Layout/ArgumentAlignment:
   EnforcedStyle: 'with_fixed_indentation'
 
 Layout/DotPosition:
   EnforcedStyle: 'trailing'
 
+Layout/HashAlignment:
+  EnforcedColonStyle: 'table'
+  EnforcedHashRocketStyle: 'table'
+
+Layout/LineEndStringConcatenationIndentation: # (new in 1.18)
+  Enabled: true
+
+Layout/ParameterAlignment:
+  EnforcedStyle: 'with_fixed_indentation'
+
+Layout/SpaceBeforeBrackets: # (new in 1.7)
+  Enabled: true
+
 Layout/SpaceInsideHashLiteralBraces:
   EnforcedStyle: 'no_space'
 
-Metrics/LineLength:
-  Max: 120
+Lint/AmbiguousAssignment: # (new in 1.7)
+  Enabled: true
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - "spec/**/*"
+
+Lint/AmbiguousRange: # (new in 1.19)
+  Enabled: true
+
+Lint/DeprecatedConstants: # (new in 1.8)
+  Enabled: true
+
+Lint/DuplicateBranch: # (new in 1.3)
+  Enabled: true
+
+Lint/DuplicateRegexpCharacterClassElement: # (new in 1.1)
+  Enabled: true
+
+Lint/EmptyBlock: # (new in 1.1)
+  Enabled: true
+
+Lint/EmptyClass: # (new in 1.3)
+  Enabled: true
+
+Lint/EmptyInPattern: # (new in 1.16)
+  Enabled: true
+
+Lint/LambdaWithoutLiteralBlock: # (new in 1.8)
+  Enabled: true
+
+Lint/NoReturnInBeginEndBlocks: # (new in 1.2)
+  Enabled: true
+
+Lint/NumberedParameterAssignment: # (new in 1.9)
+  Enabled: true
+
+Lint/OrAssignmentToConstant: # (new in 1.9)
+  Enabled: true
+
+Lint/RedundantDirGlobSort: # (new in 1.8)
+  Enabled: true
+
+Lint/SymbolConversion: # (new in 1.9)
+  Enabled: true
+
+Lint/ToEnumArguments: # (new in 1.1)
+  Enabled: true
+
+Lint/TripleQuotes: # (new in 1.9)
+  Enabled: true
+
+Lint/UnexpectedBlockArity: # (new in 1.5)
+  Enabled: true
+
+Lint/UnmodifiedReduceAccumulator: # (new in 1.1)
+  Enabled: true
+
+Naming/InclusiveLanguage: # (new in 1.18)
+  Enabled: true
+
+Performance/AncestorsInclude: # (new in 1.7)
+  Enabled: true
+
+Performance/BigDecimalWithNumericArgument: # (new in 1.7)
+  Enabled: true
+
+Performance/BlockGivenWithExplicitBlock: # (new in 1.9)
+  Enabled: true
+
+Performance/CollectionLiteralInLoop: # (new in 1.8)
+  Enabled: true
+
+Performance/ConstantRegexp: # (new in 1.9)
+  Enabled: true
+
+Performance/MapCompact: # (new in 1.11)
+  Enabled: true
+
+Performance/MethodObjectAsBlock: # (new in 1.9)
+  Enabled: true
+
+Performance/RedundantEqualityComparisonBlock: # (new in 1.10)
+  Enabled: true
+
+Performance/RedundantSortBlock: # (new in 1.7)
+  Enabled: true
+
+Performance/RedundantSplitRegexpArgument: # (new in 1.10)
+  Enabled: true
+
+Performance/RedundantStringChars: # (new in 1.7)
+  Enabled: true
+
+Performance/ReverseFirst: # (new in 1.7)
+  Enabled: true
+
+Performance/SortReverse: # (new in 1.7)
+  Enabled: true
+
+Performance/Squeeze: # (new in 1.7)
+  Enabled: true
+
+Performance/StringInclude: # (new in 1.7)
+  Enabled: true
+
+Performance/Sum: # (new in 1.8)
+  Enabled: true
+
+RSpec/DescribeClass:
+  Exclude:
+    - 'spec/features/**/*'
+
+RSpec/DescribedClass:
+  Enabled: false
+
+RSpec/FilePath:
+  Enabled: false
+
+RSpec/IdenticalEqualityAssertion: # (new in 2.4)
+  Enabled: true
+
+RSpec/ImplicitSubject:
+  EnforcedStyle: 'single_statement_only'
+
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/Rails/AvoidSetupHook: # (new in 2.4)
+  Enabled: true
+
+Style/ArgumentsForwarding: # (new in 1.1)
+  Enabled: true
+
+Style/EndlessMethod: # (new in 1.8)
+  Enabled: true
+
+Style/CollectionCompact: # (new in 1.2)
+  Enabled: true
+
+Style/Documentation:
+  Exclude:
+    - 'db/migrate/**/*'
+
+Style/DocumentDynamicEvalDefinition: # (new in 1.1)
+  Enabled: true
+
+Style/FormatStringToken:
+  Enabled: false # too many false positives in version 0.49.1; see e.g. https://github.com/bbatsov/rubocop/issues/4425
+
+Style/HashConversion: # (new in 1.10)
+  Enabled: true
+
+Style/HashExcept: # (new in 1.7)
+  Enabled: true
+
+Style/IfWithBooleanLiteralBranches: # (new in 1.9)
+  Enabled: true
+
+Style/InPatternThen: # (new in 1.16)
+  Enabled: true
+
+Style/MultilineInPatternThen: # (new in 1.16)
+  Enabled: true
+
+Style/NegatedIfElseCondition: # (new in 1.2)
+  Enabled: true
+
+Style/NilLambda: # (new in 1.3)
+  Enabled: true
+
+Style/QuotedSymbols: # (new in 1.16)
+  Enabled: true
+
+Style/RedundantArgument: # (new in 1.4)
+  Enabled: true
+
+Style/RedundantSelfAssignmentBranch: # (new in 1.19)
+  Enabled: true
+
+Style/RescueStandardError:
+  Enabled: false
+
+Style/SignalException:
+  Enabled: false
+
+Style/SoleNestedConditional:
+  AllowModifier: true
+
+Style/StringChars: # (new in 1.12)
+  Enabled: true
 
-Naming/VariableNumber:
-  EnforcedStyle: 'snake_case'
+Style/SwapValues: # (new in 1.1)
+  Enabled: true

data/.rubocop_todo.yml

@@ -1,45 +1,7 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2018-01-18 16:08:39 +0100 using RuboCop version 0.52.1.
+# on 2021-08-12 11:38:34 UTC using RuboCop version 1.19.0.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
-
-# Offense count: 3
-# Configuration parameters: CountComments, ExcludedMethods.
-Metrics/BlockLength:
-  Max: 82
-
-# Offense count: 4
-# Configuration parameters: Prefixes.
-# Prefixes: when, with, without
-RSpec/ContextWording:
-  Exclude:
-    - 'spec/paperclip/permanent_records_spec.rb'
-
-# Offense count: 2
-# Configuration parameters: Max.
-RSpec/ExampleLength:
-  Exclude:
-    - 'spec/paperclip/permanent_records_spec.rb'
-
-# Offense count: 4
-# Configuration parameters: AggregateFailuresByDefault.
-RSpec/MultipleExpectations:
-  Max: 4
-
-# Offense count: 2
-# Configuration parameters: Max.
-RSpec/NestedGroups:
-  Exclude:
-    - 'spec/paperclip/permanent_records_spec.rb'
-
-# Offense count: 3
-Style/Documentation:
-  Exclude:
-    - 'spec/**/*'
-    - 'test/**/*'
-    - 'lib/paperclip/permanent_records.rb'
-    - 'lib/paperclip/permanent_records/active_record.rb'
-    - 'lib/paperclip/permanent_records/paperclip_patch.rb'

data/.travis.yml

@@ -1,24 +1,9 @@
 language: ruby
 rvm:
-  - 2.2.9
-  - 2.3.5
-  - 2.4.3
-  - 2.5.0
+  - 2.5.9
+  - 2.6.8
+  - 2.7.4
 script: "bundle exec rake spec"
 gemfile:
-  - gemfiles/rails_4.2_pc_4.1.gemfile
-  - gemfiles/rails_4.2_pc_4.2.gemfile
-  - gemfiles/rails_4.2_pc_5.0.gemfile
-  - gemfiles/rails_4.2_pc_5.1.gemfile
-  - gemfiles/rails_5.0_pc_5.0.gemfile
-  - gemfiles/rails_5.1_pc_5.1.gemfile
-matrix:
-  exclude:
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2_pc_4.1.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2_pc_4.2.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2_pc_5.0.gemfile
-    - rvm: 2.5.0
-      gemfile: gemfiles/rails_4.2_pc_5.1.gemfile
+  - gemfiles/rails_5.2_pc_6.0.gemfile
+  - gemfiles/rails_5.2_pc_6.1.gemfile

data/Appraisals

@@ -1,29 +1,11 @@
-appraise 'rails_4.2_pc_4.1' do
-  gem 'rails', '~> 4.2.0'
-  gem 'paperclip', '~> 4.1.1'
-end
-
-appraise 'rails_4.2_pc_4.2' do
-  gem 'rails', '~> 4.2.0'
-  gem 'paperclip', '~> 4.2.4'
-end
-
-appraise 'rails_4.2_pc_5.0' do
-  gem 'rails', '~> 4.2.0'
-  gem 'paperclip', '~> 5.0.0'
-end
-
-appraise 'rails_4.2_pc_5.1' do
-  gem 'rails', '~> 4.2.0'
-  gem 'paperclip', '~> 5.1.0'
-end
+# frozen_string_literal: true
 
-appraise 'rails_5.0_pc_5.0' do
-  gem 'rails', '~> 5.0.0'
-  gem 'paperclip', '~> 5.0.0'
+appraise 'rails_5.2_pc_6.0' do
+  gem 'rails', '~> 5.2.0'
+  gem 'paperclip', '~> 6.0.0'
 end
 
-appraise 'rails_5.1_pc_5.1' do
-  gem 'rails', '~> 5.1.0'
-  gem 'paperclip', '~> 5.1.0'
+appraise 'rails_5.2_pc_6.1' do
+  gem 'rails', '~> 5.2.0'
+  gem 'paperclip', '~> 6.1.0'
 end

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+# 0.5.0 (2021-08-12)
+
+* Drop support for rails < 5.2
+* Drop support for ruby < 2.5
+* Test with rails 5.2
+* Test on ruby 2.6 and 2.7
+* Update permanent_records to at least 5.0.0 (currently the latest)
+* paperclip: drop support for < 6.0, test 6.0 and 6.1
+* Update dev dependencies (+ some code style fixes), incl. bundler to 2.x
+  (UPGRADING: you might need to remove your local Gemfile.lock and check that you have bundler 2.x  
+  installed in all the rubies referenced in .travis.yml)
+
 # 0.4.0 (2018-01-18)
 
 * Remove support for rails < 4.2

data/Gemfile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in paperclip-permanent_records.gemspec

data/README.md

@@ -7,9 +7,9 @@ See [paperclip #804](https://github.com/thoughtbot/paperclip/issues/804#issuecom
 
 ## Compatibility
 
-* rails 4.2: works with paperclip 4.1 - 5.1 and ruby 2.2 - 2.4.
-* rails 5.0 - 5.1 : works with paperclip 5.0 - 5.1 and ruby 2.2 - 2.5.
-* all tested with permanent_records 4.2.7.
+* rails 5.2: works with paperclip 6.x and ruby 2.5 or later
+* tested with permanent_records 5.0.0
+* previous versions of ruby/rails/paperclip: please check version 0.4.x of this gem
 
 Please see `.travis.yml` and `Appraisals` for what combinations have actually been tested. Usage with other versions
 might cause data loss.

data/Rakefile

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 require 'paperclip/permanent_records/gem_tasks'
 require 'appraisal'

data/gemfiles/{rails_4.2_pc_4.1.gemfile → rails_5.2_pc_6.0.gemfile}

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source 'https://rubygems.org'
 
-gem 'rails', '~> 4.2.0'
-gem 'paperclip', '~> 4.1.1'
+gem 'paperclip', '~> 6.0.0'
+gem 'rails', '~> 5.2.0'
 
 gemspec path: '../'

data/gemfiles/{rails_4.2_pc_4.2.gemfile → rails_5.2_pc_6.1.gemfile}

@@ -1,8 +1,10 @@
+# frozen_string_literal: true
+
 # This file was generated by Appraisal
 
 source 'https://rubygems.org'
 
-gem 'rails', '~> 4.2.0'
-gem 'paperclip', '~> 4.2.4'
+gem 'paperclip', '~> 6.1.0'
+gem 'rails', '~> 5.2.0'
 
 gemspec path: '../'

data/lib/paperclip/permanent_records/paperclip_patch.rb

@@ -1,4 +1,4 @@
-# Patch for paperclip >= 3.5.0 (based on 5.1.0)
+# Patch for paperclip >= 3.5.0 (based on 6.1.0)
 
 module Paperclip
   class HasAttachedFile

data/lib/paperclip/permanent_records/version.rb

@@ -1,5 +1,5 @@
 module Paperclip
   module PermanentRecords
-    VERSION = '0.4.0'.freeze
+    VERSION = '0.5.0'.freeze
   end
 end

data/paperclip-permanent_records.gemspec

@@ -1,4 +1,6 @@
-lib = File.expand_path('../lib', __FILE__)
+# frozen_string_literal: true
+
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'paperclip/permanent_records/version'
 
@@ -17,17 +19,18 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.2'
+  spec.required_ruby_version = '>= 2.5'
 
-  spec.add_dependency 'activerecord', '>= 4.2'
-  spec.add_dependency 'paperclip', '>= 4.1'
-  spec.add_dependency 'permanent_records', '>= 4.2.7'
+  spec.add_dependency 'activerecord', '>= 5.2'
+  spec.add_dependency 'paperclip', '>= 6.0'
+  spec.add_dependency 'permanent_records', '>= 5.0'
 
   spec.add_development_dependency 'appraisal', '~> 2.2'
-  spec.add_development_dependency 'bundler', '~> 1.15'
+  spec.add_development_dependency 'bundler', '~> 2.0'
   spec.add_development_dependency 'rake', '>= 10.0'
-  spec.add_development_dependency 'rspec-rails', '~> 3.7'
+  spec.add_development_dependency 'rspec-rails', '~> 5.0'
   spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-performance'
   spec.add_development_dependency 'rubocop-rspec'
   spec.add_development_dependency 'sqlite3'
   spec.add_development_dependency 'wwtd', '~> 1.3'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: paperclip-permanent_records
 version: !ruby/object:Gem::Version
-  version: 0.4.0
+  version: 0.5.0
 platform: ruby
 authors:
 - Maximilian Herold
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2018-01-18 00:00:00.000000000 Z
+date: 2021-08-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,42 +16,42 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.2'
+        version: '5.2'
 - !ruby/object:Gem::Dependency
   name: paperclip
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '6.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '4.1'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: permanent_records
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.7
+        version: '5.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.7
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: appraisal
   requirement: !ruby/object:Gem::Requirement
@@ -72,14 +72,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: '2.0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -100,14 +100,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '5.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.7'
+        version: '5.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -122,6 +122,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: rubocop-performance
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
@@ -182,12 +196,8 @@ files:
 - LICENSE.txt
 - README.md
 - Rakefile
-- gemfiles/rails_4.2_pc_4.1.gemfile
-- gemfiles/rails_4.2_pc_4.2.gemfile
-- gemfiles/rails_4.2_pc_5.0.gemfile
-- gemfiles/rails_4.2_pc_5.1.gemfile
-- gemfiles/rails_5.0_pc_5.0.gemfile
-- gemfiles/rails_5.1_pc_5.1.gemfile
+- gemfiles/rails_5.2_pc_6.0.gemfile
+- gemfiles/rails_5.2_pc_6.1.gemfile
 - lib/paperclip/permanent_records.rb
 - lib/paperclip/permanent_records/active_record.rb
 - lib/paperclip/permanent_records/gem_helper.rb
@@ -204,7 +214,7 @@ homepage: ''
 licenses:
 - MIT
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -212,16 +222,15 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.2'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.6.14
-signing_key: 
+rubygems_version: 3.0.9
+signing_key:
 specification_version: 4
 summary: Make paperclip attachments work with permanent_records
 test_files:

data/gemfiles/rails_4.2_pc_5.0.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'rails', '~> 4.2.0'
-gem 'paperclip', '~> 5.0.0'
-
-gemspec path: '../'

data/gemfiles/rails_4.2_pc_5.1.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'rails', '~> 4.2.0'
-gem 'paperclip', '~> 5.1.0'
-
-gemspec path: '../'

data/gemfiles/rails_5.0_pc_5.0.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'rails', '~> 5.0.0'
-gem 'paperclip', '~> 5.0.0'
-
-gemspec path: '../'

data/gemfiles/rails_5.1_pc_5.1.gemfile

@@ -1,8 +0,0 @@
-# This file was generated by Appraisal
-
-source 'https://rubygems.org'
-
-gem 'rails', '~> 5.1.0'
-gem 'paperclip', '~> 5.1.0'
-
-gemspec path: '../'