paperclip-deflater 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 936994b83a0f58ce48c80d843df09abd36dd8a16
-  data.tar.gz: fd5e0814a4e0d5e760dc8fe6febffcfc9762e6a6
+  metadata.gz: b196a7dc955a47503b40b8cbf9216465c30b7f56
+  data.tar.gz: fb8631f41ee2bb5252b2fb82e37137ebb9219bb3
 SHA512:
-  metadata.gz: dd26871ffed60ec9eea0c37f904cb07cfd3488bb6bc22e142a29e79620722f20484b4ba40397b3af04d6594ee8f55a3b63677ae26746fe5fcf456d9516721cf8
-  data.tar.gz: ab704c08c39eef4572b9064ff217043b21630a6a5b7335c1076d9280c9e695e88dc34d465620c9b302df3f6fc4125b32782bc61a07b1dd96df055bf85fa03428
+  metadata.gz: 3c0661ca417643b37acf5b66a74947d70ad43ebfa62700716f22515a7db875d6d64329f47abaaa835e6eed2a697747bd7a358e9612a21c2cfb87139003054ab3
+  data.tar.gz: e2de539fa82076db90a64c1eefe5949f2f36c84f4c2dafedbbfd0f68806e1ef2c817b19deee6d9b98905d65fe410c69d731aa5bf64cfe284a632b7f6d59115cb

data/README.md

@@ -24,15 +24,11 @@ And run `bundle install`.
 class Something
   has_attached_file :js,
     s3_metadata: { content_encoding: 'gzip' },
-    styles: { gzip: {processors: [:deflater], format: '.gz'} },
+    styles: { gzip: {processors: [:gzip], format: '.gz'} },
     path: "test/:id.:extension:format"
 end
 ```
 
-## Per instance turn-off flag
-
-If the instance (`xx`) has `xx_no_deflate` method and it returns `true`, you can disable the deflating for the attachment.
-
 ## Contributing
 
 1. Fork it

data/VERSION

@@ -1 +1 @@
-0.0.3
+0.0.4

data/lib/paperclip/processors/deflater.rb

@@ -8,9 +8,7 @@ module Paperclip
         @deflate_options = @options[:deflate_options] || {}
       end
 
-      private
-
-      def make_impl
+      def make
         level       = @deflate_options[:level]
         window_bits = @deflate_options[:window_bits]
         memlevel    = @deflate_options[:memlevel]

data/lib/paperclip/processors/deflater_base.rb

@@ -13,16 +13,11 @@ module Paperclip
       end
 
       def make
-        return @file if @attachment.instance_read(:no_deflate) == true
-        make_impl
+        raise NotImplementedError
       end
 
       private
 
-      def make_impl
-        raise NotImplementedError
-      end
-
       def create_tempfile
         f = Tempfile.new([@basename, @format ? ".#{@format}" : ''])
         f.binmode

data/lib/paperclip/processors/gzip.rb

@@ -8,9 +8,7 @@ module Paperclip
         @gzip_options = @options[:gzip_options] || {}
       end
 
-      private
-
-      def make_impl
+      def make
         level       = @gzip_options[:level]
         strategy    = @gzip_options[:strategy]
 

data/spec/paperclip/processors/deflater_base_spec.rb

@@ -10,19 +10,11 @@ describe Paperclip::Processors::DeflaterBase do
     allow(attachment).to receive(:instance_read).with(:no_deflate).and_return(no_deflate)
   end
   describe "#make" do
-    context "no_deflate setting is true" do
-      let(:no_deflate) { true }
-      it "returns original" do
-        expect(subject.make).to eq(file)
-      end
+    it "raises an exception" do
+      expect{ subject.make }.to raise_error(NotImplementedError)
     end
   end
   describe "private methods" do
-    describe "#make_impl" do
-      it "raises an exception" do
-        expect{ subject.send(:make_impl) }.to raise_error(NotImplementedError)
-      end
-    end
     describe "create_tempfile" do
       it "returns a tempfile" do
         f = subject.send(:create_tempfile)

data/spec/paperclip/processors/deflater_spec.rb

@@ -10,7 +10,7 @@ describe Paperclip::Processors::Deflater do
     allow(attachment).to receive(:instance_read).with(:no_deflate)
   end
   describe "private methods" do
-    describe "#make_impl" do
+    describe "#make" do
       shared_examples "deflate" do
         it "deflates the file" do
           dst = subject.make

data/spec/paperclip/processors/gzip_spec.rb

@@ -10,7 +10,7 @@ describe Paperclip::Processors::Gzip do
     allow(attachment).to receive(:instance_read).with(:no_deflate)
   end
   describe "private methods" do
-    describe "#make_impl" do
+    describe "#make" do
       shared_examples "deflate" do
         it "deflates the file" do
           dst = subject.make

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paperclip-deflater
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Daisuke Taniwaki