paperclip-deflater 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 49bed0decc83cf5c31363c8157336688cad43572
-  data.tar.gz: b7422ea22f63a8bf21734bfbfa97093e325d40c3
+  metadata.gz: 936994b83a0f58ce48c80d843df09abd36dd8a16
+  data.tar.gz: fd5e0814a4e0d5e760dc8fe6febffcfc9762e6a6
 SHA512:
-  metadata.gz: 3beb013f2adebd189bf8b5e0e9dc162b83c2a29b0caf228bded75a9c04a6b6d52db4847400fc0ba6cd5b374a319cc056d06084ed76b4b5ddbb18ce543272d90c
-  data.tar.gz: 5be6bef8b0bf9b82181195598cc953e3171fd7d950f487270ff4d407a2af4b247f144787f3a8725a35ae3d9c1cae8904efb99f9bc71f64de7d00786c6253538d
+  metadata.gz: dd26871ffed60ec9eea0c37f904cb07cfd3488bb6bc22e142a29e79620722f20484b4ba40397b3af04d6594ee8f55a3b63677ae26746fe5fcf456d9516721cf8
+  data.tar.gz: ab704c08c39eef4572b9064ff217043b21630a6a5b7335c1076d9280c9e695e88dc34d465620c9b302df3f6fc4125b32782bc61a07b1dd96df055bf85fa03428

data/README.md

@@ -29,6 +29,10 @@ class Something
 end
 ```
 
+## Per instance turn-off flag
+
+If the instance (`xx`) has `xx_no_deflate` method and it returns `true`, you can disable the deflating for the attachment.
+
 ## Contributing
 
 1. Fork it

data/VERSION

@@ -1 +1 @@
-0.0.2
+0.0.3

data/lib/paperclip/processors/deflater_base.rb

@@ -13,7 +13,7 @@ module Paperclip
       end
 
       def make
-        return @file if @attachment.instance_read(:deflate) == false
+        return @file if @attachment.instance_read(:no_deflate) == true
         make_impl
       end
 

data/spec/paperclip/processors/deflater_base_spec.rb

@@ -2,16 +2,16 @@ require 'spec_helper'
 
 describe Paperclip::Processors::DeflaterBase do
   let(:attachment) { double }
-  let(:should_deflate) { true }
+  let(:no_deflate) { nil }
   let(:options) { {} }
   let(:file) { test_file }
   subject { Paperclip::Processors::DeflaterBase.new(file, options, attachment) }
   before do
-    allow(attachment).to receive(:instance_read).with(:deflate).and_return(should_deflate)
+    allow(attachment).to receive(:instance_read).with(:no_deflate).and_return(no_deflate)
   end
   describe "#make" do
-    context "deflate setting is false" do
-      let(:should_deflate) { false }
+    context "no_deflate setting is true" do
+      let(:no_deflate) { true }
       it "returns original" do
         expect(subject.make).to eq(file)
       end

data/spec/paperclip/processors/deflater_spec.rb

@@ -3,19 +3,27 @@ require 'spec_helper'
 
 describe Paperclip::Processors::Deflater do
   let(:attachment) { double }
-  let(:should_deflate) { true }
   let(:options) { {} }
   let(:file) { test_file }
   subject { Paperclip::Processors::Deflater.new(file, options, attachment) }
   before do
-    allow(attachment).to receive(:instance_read).with(:deflate).and_return(should_deflate)
+    allow(attachment).to receive(:instance_read).with(:no_deflate)
   end
   describe "private methods" do
     describe "#make_impl" do
-      it "deflates the file" do
-        dst = subject.make
-        data = dst.read
-        expect(data.unpack('H*').first).to eq("x\x9C".unpack('H*').first)
+      shared_examples "deflate" do
+        it "deflates the file" do
+          dst = subject.make
+          data = dst.read
+          expect(data.unpack('H*').first).to eq(result.unpack('H*').first)
+        end
+      end
+      let(:result) { "x\x9C" }
+      include_examples "deflate"
+      context "level gzip_options" do
+        let(:result) { "x\xDA" }
+        let(:options) { {deflate_options: {level: Zlib::BEST_COMPRESSION}} }
+        include_examples "deflate"
       end
     end
   end

data/spec/paperclip/processors/gzip_spec.rb

@@ -3,24 +3,30 @@ require 'spec_helper'
 
 describe Paperclip::Processors::Gzip do
   let(:attachment) { double }
-  let(:should_deflate) { true }
   let(:options) { {} }
   let(:file) { test_file }
   subject { Paperclip::Processors::Gzip.new(file, options, attachment) }
   before do
-    allow(attachment).to receive(:instance_read).with(:deflate).and_return(should_deflate)
+    allow(attachment).to receive(:instance_read).with(:no_deflate)
   end
   describe "private methods" do
     describe "#make_impl" do
-      before do
-        allow(file).to receive(:mtime).and_return(Time.new(2000, 1, 2, 3, 4, 5))
+      shared_examples "deflate" do
+        it "deflates the file" do
+          dst = subject.make
+          data = dst.read
+          expect(data[0..3]).to eq(result1)
+          # data[4..7] is modified time and it changes
+          expect(data[8..-1]).to eq(result2)
+        end
       end
-      it "deflates the file" do
-        dst = subject.make
-        data = dst.read
-        expect(data[0..3]).to eq("\u001F\x8B\b\u0000")
-        # data[4..7] is modified time and it changes
-        expect(data[8..-1]).to eq("\u0000\u0003+I-.\xE1\u0002\u0000\xC65\xB9;\u0005\u0000\u0000\u0000")
+      let(:result1) { "\u001F\x8B\b\u0000" }
+      let(:result2) { "\u0000\u0003+I-.\xE1\u0002\u0000\xC65\xB9;\u0005\u0000\u0000\u0000" }
+      include_examples "deflate"
+      context "level gzip_options" do
+        let(:result2) { "\u0002\u0003+I-.\xE1\u0002\u0000\xC65\xB9;\u0005\u0000\u0000\u0000" }
+        let(:options) { {gzip_options: {level: Zlib::BEST_COMPRESSION}} }
+        include_examples "deflate"
       end
     end
   end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paperclip-deflater
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - Daisuke Taniwaki