paperclip-azure 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a233ac7477aced4158a50fbed0ed87a16be96cc9
-  data.tar.gz: f2fd4c35c33316c5fa8da7bae2e2506b0d8390f5
+  metadata.gz: 911cdf6bd98931b2d25cb0dc5db1f0ce60b0bb9a
+  data.tar.gz: bc3c27455a1b7f9aba2e217eed8a8d245a2c1e55
 SHA512:
-  metadata.gz: bbf61c97fadc054badbb6f946502458303af5dde02c628ee0dd70acae763799c58b6925b88a8d5e76c59c7fb9e6ed23fe023ecc121abfc2af40e23aa16f2180b
-  data.tar.gz: edaee95e6fbd6a7965fadfc4964d69b696025bdeedc4c3af6d6d12b64d604742c169787dbf6ddbf277c0a3ef9da8b276d45488f26941666f69e37e72b14668da
+  metadata.gz: 858ac4cd36c47aa4bd052ed076af97357f57e407f25815ff0804ab5da2976e78200e749d5290d20a53e34397c51355617f8ef62fe608195fa5b0c5eb472b1648
+  data.tar.gz: 08744fa9bfadc893045c65966b35ddddb3dc3318490fe15f08771432d1d5904022e85d4a6aa6c72db814dbb0836cf75df2989a8ae55f6c8f4f6be62b9a6e31dc

data/Manifest.txt

@@ -3,10 +3,36 @@ History.txt
 Manifest.txt
 README.txt
 Rakefile
-lib/azure/core/auth/shared_access_signature.rb
 lib/paperclip/storage/azure/environment.rb
 lib/paperclip/storage/azure.rb
 lib/paperclip/azure.rb
 lib/paperclip-azure.rb
 spec/paperclip/storage/azure/environment_spec.rb
+spec/paperclip/storage/azure_spec.rb
+spec/support/fixtures/12k.png
+spec/support/fixtures/50x50.png
+spec/support/fixtures/5k.png
+spec/support/fixtures/animated
+spec/support/fixtures/animated.gif
+spec/support/fixtures/animated.unknown
+spec/support/fixtures/azure.yml
+spec/support/fixtures/bad.png
+spec/support/fixtures/empty.html
+spec/support/fixtures/empty.xlsx
+spec/support/fixtures/fog.yml
+spec/support/fixtures/rotated.jpg
+spec/support/fixtures/spaced file.jpg
+spec/support/fixtures/spaced file.png
+spec/support/fixtures/text.txt
+spec/support/fixtures/twopage.pdf
+spec/support/fixtures/uppercase.PNG
+spec/support/fake_model.rb
+spec/support/fake_rails.rb
+spec/support/mock_attachment.rb
+spec/support/mock_interpolator.rb
+spec/support/mock_url_generator_builder.rb
+spec/support/model_reconstruction.rb
+spec/support/test_data.rb
+spec/support/version_helper.rb
+spec/database.yml
 spec/spec_helper.rb

data/README.txt

@@ -18,12 +18,11 @@ Paperclip-Azure is a [Paperclip](https://github.com/thoughtbot/paperclip) storag
 The Azure storage engine has been developed to work as similarly to S3 storage configuration as is possible.  This gem can be configured in a Paperclip initializer or environment file as follows:
 
     Paperclip::Attachment.default_options[:storage] = :azure
-    Paperclip::Attachment.default_options[:url] = ':azure_path_url'
-    Paperclip::Attachment.default_options[:path] = ":class/:attachment/:id/:style/:filename"
-    Paperclip::Attachment.default_options[:storage] = :azure
+    Paperclip::Attachment.default_options[:url]     = ':azure_path_url'
+    Paperclip::Attachment.default_options[:path]    = ':class/:attachment/:id/:style/:filename'
     Paperclip::Attachment.default_options[:azure_credentials] = {
         storage_account_name: ENV['AZURE_STORAGE_ACCOUNT'],
-        access_key:           ENV['AZURE_ACCESS_KEY'],
+        storage_access_key:   ENV['AZURE_STORAGE_ACCESS_KEY'],
         container:            ENV['AZURE_CONTAINER_NAME']
     }
 
@@ -33,10 +32,29 @@ Or, at the level of the model such as in the following example:
                       storage: :azure,
                       azure_credentials: {
                         storage_account_name: ENV['AZURE_STORAGE_ACCOUNT'],
-                        access_key:           ENV['AZURE_ACCESS_KEY'],
+                        storage_access_key:   ENV['AZURE_STORAGE_ACCESS_KEY'],
                         container:            ENV['AZURE_CONTAINER_NAME']
                       }
 
+Additionally, you can also supply credentials using a path or a File that contains the +storage_access_key+ and +storage_account_name+ that Azure gives you. You can 'environment-space' this just like you do to your `database.yml` file, so different environments can use different accounts:
+
+    development:
+      storage_account_name: foo
+      storage_access_key: 123...
+    test:
+      storage_account_name: foo
+      storage_access_key: abc...
+    production:
+      storage_account_name: foo
+      storage_access_key: 456...
+
+This is not required, however, and the file may simply look like this:
+
+    storage_account_name: foo
+    storage_access_key: 456...
+
+In which case, those access keys will be used in all environments. You can also put your container name in this file, instead of adding it to the code directly. This is useful when you want the same account but a different container for development versus production.
+
 === Private Blob Access
 
 In the even that are using a Blob that has been configured for Private access, you will need to use the Shared Access Signature functionality of Azure.  This functionality has been baked in to the `Attachment#expiring_url` method. Simply specify a time and a style and you will get a proper URL as follows:
@@ -51,7 +69,7 @@ Microsoft offers specialized Azure implementations for special circumstances sho
 
     Paperclip::Attachment.default_options[:azure_credentials] = {
         storage_account_name: ENV['AZURE_STORAGE_ACCOUNT'],
-        access_key:           ENV['AZURE_ACCESS_KEY'],
+        storage_access_key:   ENV['AZURE_STORAGE_ACCESS_KEY'],
         container:            ENV['AZURE_CONTAINER_NAME'],
         region:               :de
     }
@@ -62,7 +80,7 @@ Or, in the instance where the credentials are specified at the model level:
                       storage: :azure,
                       azure_credentials: {
                         storage_account_name: ENV['AZURE_STORAGE_ACCOUNT'],
-                        access_key:           ENV['AZURE_ACCESS_KEY'],
+                        storage_access_key:   ENV['AZURE_STORAGE_ACCESS_KEY'],
                         container:            ENV['AZURE_CONTAINER_NAME'],
                         region:               :cn
                       }

data/Rakefile

@@ -13,12 +13,18 @@ Hoe.spec "paperclip-azure" do
   developer("hireross.com", "help@hireross.com")
   license "MIT" # this should match the license in the README
 
-  extra_deps << ['azure', '~> 0.7']
+  extra_deps << ['azure-storage', '~> 0.12']
   extra_deps << ['hashie', '~> 3.5']
   extra_deps << ['addressable', '~> 2.5']
 
+  extra_dev_deps << ['paperclip', '>= 4.3.6']
+  extra_dev_deps << ['sqlite3', '~> 1.3.8']
   extra_dev_deps << ['rspec', '~> 3.0']
   extra_dev_deps << ['simplecov', '~> 0.14']
+  extra_dev_deps << ['activerecord', '>= 4.2.0']
+  extra_dev_deps << ['activerecord-import', '~> 0.19']
+  extra_dev_deps << ['activemodel', '>= 4.2.0']
+  extra_dev_deps << ['activesupport', '>= 4.2.0']
 end
 
 # vim: syntax=ruby

data/lib/paperclip-azure.rb

@@ -1,6 +1,5 @@
 require 'azure'
 
-require File.join(File.dirname(__FILE__), 'azure', 'core', 'auth', 'shared_access_signature')
 require File.join(File.dirname(__FILE__), 'paperclip', 'storage', 'azure')
 
 module Azure

data/lib/paperclip/azure.rb

@@ -1,5 +1,5 @@
 module Paperclip; end
 
 class Paperclip::Azure
-  VERSION = "1.0.0"
+  VERSION = "1.0.1"
 end

data/lib/paperclip/storage/azure.rb

@@ -1,3 +1,4 @@
+require 'azure/storage'
 require 'paperclip/storage/azure/environment'
 
 module Paperclip
@@ -5,25 +6,23 @@ module Paperclip
     # Azure's container file hosting service is a scalable, easy place to store files for
     # distribution. You can find out more about it at http://azure.microsoft.com/en-us/services/storage/
     #
-    # To use Paperclip with Azure, include the +azure+ gem in your Gemfile:
-    #   gem 'azure'
     # There are a few Azure-specific options for has_attached_file:
     # * +azure_credentials+: Takes a path, a File, a Hash or a Proc. The path (or File) must point
-    #   to a YAML file containing the +access_key+ and +storage_account+ that azure
+    #   to a YAML file containing the +storage_access_key+ and +storage_account_name+ that azure
     #   gives you. You can 'environment-space' this just like you do to your
     #   database.yml file, so different environments can use different accounts:
     #     development:
     #       storage_account_name: foo
-    #       access_key: 123...
+    #       storage_access_key: 123...
     #     test:
     #       storage_account_name: foo
-    #       access_key: abc...
+    #       storage_access_key: abc...
     #     production:
     #       storage_account_name: foo
-    #       access_key: 456...
+    #       storage_access_key: 456...
     #   This is not required, however, and the file may simply look like this:
     #     storage_account_name: foo
-    #     access_key: 456...
+    #     storage_access_key: 456...
     #   In which case, those access keys will be used in all environments. You can also
     #   put your container name in this file, instead of adding it to the code directly.
     #   This is useful when you want the same account but a different container for
@@ -37,7 +36,7 @@ module Paperclip
     #                         :azure_credentials => Proc.new{|a| a.instance.azure_credentials }
     #
     #       def azure_credentials
-    #         { :container => "xxx", :storage_account_name => "xxx", :access_key => "xxx" }
+    #         { :container => "xxx", :storage_account_name => "xxx", :storage_access_key => "xxx" }
     #       end
     #     end
     #
@@ -64,26 +63,35 @@ module Paperclip
 
         base.instance_eval do
           @azure_options     = @options[:azure_options]     || {}
+
+          unless @options[:url].to_s.match(/\A:azure.*url\z/) || @options[:url] == ":asset_host".freeze
+            @options[:path] = path_option.gsub(/:url/, @options[:url]).sub(/\A:rails_root\/public\/system/, "".freeze)
+            @options[:url]  = ":azure_path_url".freeze
+          end
+          @options[:url] = @options[:url].inspect if @options[:url].is_a?(Symbol)
+
+          @http_proxy = @options[:http_proxy] || nil
         end
 
         Paperclip.interpolates(:azure_path_url) do |attachment, style|
           attachment.azure_uri(style)
         end unless Paperclip::Interpolations.respond_to? :azure_path_url
+        Paperclip.interpolates(:asset_host) do |attachment, style|
+          "#{attachment.path(style).sub(%r{\A/}, "".freeze)}"
+        end unless Paperclip::Interpolations.respond_to? :asset_host
       end
 
       def expiring_url(time = 3600, style_name = default_style)
         if path(style_name)
-          uri = azure_uri(style_name)
-          signer = ::Azure::Core::Auth::SharedAccessSignature.new(uri, {
-              resource:    'b',
-              permissions: 'r',
-              start:       5.minutes.ago.utc.iso8601,
-              expiry:      time.since.utc.iso8601,
-              access_key:  azure_credentials[:access_key]
-            },
-            azure_account_name
-          )
-          signer.sign
+          uri = URI azure_uri(style_name)
+          generator = ::Azure::Storage::Core::Auth::SharedAccessSignature.new azure_account_name,
+                                                                              azure_credentials[:storage_access_key]
+
+          generator.signed_uri uri, false, service:      'b',
+                                           resource:     'b',
+                                           permissions:  'r',
+                                           start:        (Time.now - (5 * 60)).utc.iso8601,
+                                           expiry:       (Time.now + time).utc.iso8601
         else
           url(style_name)
         end
@@ -115,7 +123,7 @@ module Paperclip
         @azure_interface ||= begin
           config = {}
 
-          [:storage_account_name, :access_key, :container].each do |opt|
+          [:storage_account_name, :storage_access_key, :container].each do |opt|
             config[opt] = azure_credentials[opt] if azure_credentials[opt]
           end
 
@@ -123,54 +131,32 @@ module Paperclip
         end
       end
 
-      def obtain_azure_instance_for(options)
-        instances = (Thread.current[:paperclip_azure_instances] ||= {})
+      def azure_storage_client
+        config = {}
 
-        unless instances[options]
-          signer = ::Azure::Core::Auth::SharedKey.new options[:storage_account_name], options[:access_key]
-          service = ::Azure::BlobService.new(signer, options[:storage_account_name])
-
-          require 'azure/core/http/retry_policy' # For Some Reason, All Other Loading Locations Fail
-          service.filters << ::Azure::Core::Http::RetryPolicy.new do |response, retry_data|
-            status_code = case
-                          when !response.nil?
-                            response.status_code
-                          when !retry_data[:error].nil?
-                            retry_data[:error].status_code
-                          else
-                            500
-                          end
-            status_code = 500 if status_code == 0
-            retry_data[:count] ||= 0
-
-            if  (!response.nil? && response.success? && retry_data[:error].nil?) ||
-                (status_code >= 300 && status_code < 500 && status_code != 408) ||
-                status_code == 501 ||
-                status_code == 505 ||
-                (!retry_data[:error].nil? && retry_data[:error].description == 'Blob type of the blob reference doesn\'t match blob type of the blob.') ||
-                retry_data[:count] >= 5
-              retry_data[:count] = 0
-            else
-              retry_data[:count] += 1
+        [:storage_account_name, :storage_access_key].each do |opt|
+          config[opt] = azure_credentials[opt] if azure_credentials[opt]
+        end
 
-              sleep (retry_data[:count] - 1) * 5
-            end
+        @azure_storage_client ||= ::Azure::Storage::Client.create config
+      end
 
-            retry_data[:count] > 0
-          end
+      def obtain_azure_instance_for(options)
+        instances = (Thread.current[:paperclip_azure_instances] ||= {})
+        return instances[options] if instance[options]
 
-          instances[options] = service
-        end
+        service = ::Azure::Storage::Blob::BlobService.new(client: azure_storage_client)
+        service.with_filter ::Azure::Storage::Core::Filter::ExponentialRetryPolicyFilter.new
 
-        instances[options]
+        instances[options] = service
       end
 
       def azure_uri(style_name = default_style)
-        "#{azure_base_url}/#{container_name}/#{path(style_name).gsub(%r{\A/}, '')}"
+        "https://#{azure_base_url}/#{container_name}/#{path(style_name).gsub(%r{\A/}, '')}"
       end
 
       def azure_base_url
-        Environment.url_for azure_account_name, @azure_credentials[:region]
+        Environment.url_for azure_account_name, azure_credentials[:region]
       end
 
       def azure_container

data/lib/paperclip/storage/azure/environment.rb

@@ -10,8 +10,8 @@ module Paperclip
           usgovt: 'core.usgovcloudapi.net'
         }
 
-        def self.url_for(account_name, region = :global)
-          "#{account_name}.blob.#{ENVIRONMENT_SUFFIX[region]}"
+        def self.url_for(account_name, region = nil)
+          "#{account_name}.blob.#{ENVIRONMENT_SUFFIX[region || :global]}"
         end
       end
     end

data/spec/database.yml

@@ -0,0 +1,3 @@
+test:
+  adapter: sqlite3
+  database: ":memory:"

data/spec/paperclip/storage/azure_spec.rb

@@ -0,0 +1,435 @@
+require 'spec_helper'
+require "base64"
+
+describe Paperclip::Storage::Azure do
+  let(:storage_access_key) { 'kiaY4+GkLMVxnfOK2X+eCJOE06J8QtHC6XNuXVwt8Pp4kMezYaa7cNjtYnZr4/b732RKdz5pZwl8RN9yb8gBCg==' }
+
+  describe "#parse_credentials" do
+    let(:credentials) {{
+      'production' => {key: '12345'},
+      development: {key: "54321"}
+    }}
+
+    before do
+      @proxy_settings = {host: "127.0.0.1", port: 8888, user: "foo", password: "bar"}
+      rebuild_model storage: :azure,
+                    container: "testing",
+                    azure_credentials: {not: :important}
+      @dummy = Dummy.new
+      @avatar = @dummy.avatar
+    end
+
+    it "gets the correct credentials when RAILS_ENV is production" do
+      rails_env("production") do
+        expect(@avatar.parse_credentials(credentials)).to eq({key: "12345"})
+      end
+    end
+
+    it "gets the correct credentials when RAILS_ENV is development" do
+      rails_env("development") do
+        expect(@avatar.parse_credentials(credentials)).to eq({key: "54321"})
+      end
+    end
+
+    it "returns the argument if the key does not exist" do
+      rails_env("not really an env") do
+        expect(@avatar.parse_credentials(test: "12345")).to eq({test: "12345"})
+      end
+    end
+
+  end
+
+  describe '#container_name' do
+    describe ":container option via :azure_credentials" do
+      before do
+        rebuild_model storage: :azure,
+                      azure_credentials: {container: 'testing'}
+        @dummy = Dummy.new
+      end
+
+      it "populates #container_name" do
+        expect(@dummy.avatar.container_name).to eq('testing')
+      end
+    end
+
+    describe ":container option" do
+      before do
+        rebuild_model storage: :azure,
+                      container: "testing",
+                      azure_credentials: {}
+        @dummy = Dummy.new
+      end
+
+      it "populates #container_name" do
+        expect(@dummy.avatar.container_name).to eq('testing')
+      end
+    end
+
+    describe "missing :container option" do
+      before do
+        rebuild_model storage: :azure,
+                      azure_credentials: {not: :important}
+
+        @dummy = Dummy.new
+        @dummy.avatar = stringy_file
+      end
+
+      it "raises an argument error" do
+        expect{ @dummy.avatar.container_name }.to raise_error(ArgumentError, /missing required :container option/)
+      end
+    end
+  end
+
+  describe "" do
+    before do
+      rebuild_model storage: :azure,
+                    azure_credentials: {
+                      storage_account_name: 'storage',
+                      storage_access_key: storage_access_key
+                    },
+                    container: "container",
+                    path: ":attachment/:basename:dotextension",
+                    url: ":azure_path_url"
+
+      @dummy = Dummy.new
+      @dummy.avatar = stringy_file
+
+      allow(@dummy).to receive(:new_record?).and_return(false)
+    end
+
+    it "returns urls based on Azure paths" do
+      expect(@dummy.avatar.url).to match(%r{^https://storage.blob.core.windows.net/container/avatars/data[^\.]})
+    end
+  end
+
+  describe "An attachment that uses Azure for storage and has styles that return different file types" do
+    before do
+      rebuild_model storage: :azure,
+                    styles: { large: ['500x500#', :jpg] },
+                    container: "container",
+                    path: ":attachment/:basename:dotextension",
+                    azure_credentials: {
+                      'access_key_id' => "12345",
+                      'secret_access_key' => "54321"
+                    }
+
+        File.open(fixture_file('5k.png'), 'rb') do |file|
+          @dummy = Dummy.new
+          @dummy.avatar = file
+
+          allow(@dummy).to receive(:new_record?).and_return(false)
+        end
+    end
+
+    it "returns a url containing the correct original file mime type" do
+      expect(@dummy.avatar.url).to match(/.+\/5k.png/)
+    end
+
+    it "returns a url containing the correct processed file mime type" do
+      expect(@dummy.avatar.url(:large)).to match(/.+\/5k.jpg/)
+    end
+  end
+
+  describe "An attachment that uses Azure for storage and has spaces in file name" do
+    before do
+      rebuild_model storage: :azure,
+                    styles: { large: ["500x500#", :jpg] },
+                    container: "container",
+                    azure_credentials: {
+                      "storage_access_key" => "54321"
+                    }
+
+      File.open(fixture_file("spaced file.png"), "rb") do |file|
+        @dummy = Dummy.new
+        @dummy.avatar = file
+
+        allow(@dummy).to receive(:new_record?).and_return(false)
+      end
+    end
+
+    it "returns a replaced version for path" do
+      expect(@dummy.avatar.path).to match(/.+\/spaced_file\.png/)
+    end
+
+    it "returns a replaced version for url" do
+      expect(@dummy.avatar.url).to match(/.+\/spaced_file\.png/)
+    end
+  end
+
+  describe "An attachment that uses Azure for storage and has a question mark in file name" do
+    before do
+      rebuild_model storage: :azure,
+                    styles: { large: ['500x500#', :jpg] },
+                    container: "container",
+                    azure_credentials: {
+                      'storage_access_key' => "54321"
+                    }
+
+      stringio = stringy_file
+      class << stringio
+        def original_filename
+          "question?mark.png"
+        end
+      end
+
+      file = Paperclip.io_adapters.for(stringio)
+
+      @dummy = Dummy.new
+      @dummy.avatar = file
+      @dummy.save
+
+      allow(@dummy).to receive(:new_record?).and_return(false)
+    end
+
+    it "returns a replaced version for path" do
+      expect(@dummy.avatar.path).to match(/.+\/question_mark\.png/)
+    end
+
+    it "returns a replaced version for url" do
+      expect(@dummy.avatar.url).to match(/.+\/question_mark\.png/)
+    end
+  end
+
+  describe ":asset_host path Interpolations" do
+    before do
+      rebuild_model storage: :azure,
+        azure_credentials: {},
+        container: "container",
+        path: ":attachment/:basename:dotextension",
+        url: ":asset_host"
+      @dummy = Dummy.new
+      @dummy.avatar = stringy_file
+      allow(@dummy).to receive(:new_record?).and_return(false)
+    end
+
+    it "returns a relative URL for Rails to calculate assets host" do
+      expect(@dummy.avatar.url).to match(%r{^avatars/data[^\.]})
+    end
+  end
+
+  describe "#expiring_url" do
+    before { @dummy = Dummy.new }
+
+    describe "with no attachment" do
+      before { expect(@dummy.avatar.exists?).to be_falsey }
+
+      it "returns the default URL" do
+        expect(@dummy.avatar.expiring_url).to eq(@dummy.avatar.url)
+      end
+
+      it 'generates a url for a style when a file does not exist' do
+        expect(@dummy.avatar.expiring_url(3600, :thumb)).to eq(@dummy.avatar.url(:thumb))
+      end
+    end
+  end
+
+  describe "Generating a url with an expiration for each style" do
+    before do
+      rebuild_model storage: :azure,
+                    azure_credentials: {
+                      production: {
+                        storage_account_name: 'prod_storage',
+                        storage_access_key: 'YWNjZXNzLWtleQ==',
+                        container: "prod_container"
+                      },
+                      development: {
+                        storage_account_name: 'dev_storage',
+                        storage_access_key: 'YWNjZXNzLWtleQ==',
+                        container: "dev_container"
+                      }
+                    },
+                    path: ":attachment/:style/:basename:dotextension"
+
+      rails_env("production") do
+        @dummy = Dummy.new
+        @dummy.avatar = stringy_file
+      end
+
+      allow(::Azure::Storage::Core::Auth::SharedAccessSignature).to receive(:new).and_call_original
+      allow(::Azure::Storage::Core::Auth::SharedAccessSignatureSigner).to receive(:new).and_call_original
+    end
+
+    it "generates a url for the thumb" do
+      rails_env("production") do
+        expect { @dummy.avatar.expiring_url(1800, :thumb) }.not_to raise_error
+      end
+
+      expect(::Azure::Storage::Core::Auth::SharedAccessSignature).to have_received(:new)
+        .with('prod_storage', anything)
+    end
+
+    it "generates a url for the default style" do
+      rails_env("production") do
+        expect { @dummy.avatar.expiring_url(1800) }.not_to raise_error
+      end
+
+      expect(::Azure::Storage::Core::Auth::SharedAccessSignature).to have_received(:new)
+        .with('prod_storage', anything)
+    end
+  end
+
+  context "Parsing Azure credentials with a container in them" do
+    before do
+      rebuild_model storage: :azure,
+                    azure_credentials: {
+                      production: { container: "prod_container" },
+                      development: { container: "dev_container" }
+                    }
+      @dummy = Dummy.new
+    end
+
+    it "gets the right container in production" do
+      rails_env("production") do
+        expect(@dummy.avatar.container_name).to eq("prod_container")
+      end
+    end
+
+    it "gets the right container in development" do
+      rails_env("development") do
+        expect(@dummy.avatar.container_name).to eq("dev_container")
+      end
+    end
+  end
+
+  context "An attachment with Azure storage" do
+    before do
+      rebuild_model storage: :azure,
+                    container: "testing",
+                    path: ":attachment/:style/:basename:dotextension",
+                    azure_credentials: {
+                      storage_account_name: 'storage',
+                      storage_access_key: storage_access_key
+                    }
+    end
+
+    it "is extended by the Azure module" do
+      expect(Dummy.new.avatar).to be_a(Paperclip::Storage::Azure)
+    end
+
+    it "won't be extended by the Filesystem module" do
+      expect(Dummy.new.avatar).not_to be_a(Paperclip::Storage::Filesystem)
+    end
+    end
+
+  describe "An attachment with Azure storage and container defined as a Proc" do
+    before do
+      rebuild_model storage: :azure,
+                    container: lambda { |attachment| "container_#{attachment.instance.other}" },
+                    azure_credentials: {not: :important}
+    end
+
+    it "gets the right container name" do
+      expect(Dummy.new(other: 'a').avatar.container_name).to eq("container_a")
+      expect(Dummy.new(other: 'b').avatar.container_name).to eq("container_b")
+    end
+  end
+
+  context "An attachment with Azure storage and Azure credentials defined as a Proc" do
+    before do
+      rebuild_model storage: :azure,
+                    container: {not: :important},
+                    azure_credentials: lambda { |attachment|
+                      Hash['storage_access_key' => "secret#{attachment.instance.other}"]
+                    }
+    end
+
+    it "gets the right credentials" do
+      expect(Dummy.new(other: '1234').avatar.azure_credentials[:storage_access_key]).to eq("secret1234")
+    end
+  end
+
+  context "An attachment with Azure storage and Azure credentials in an unsupported manor" do
+    before do
+      rebuild_model storage: :azure,
+                    container: "testing",
+                    azure_credentials: ["unsupported"]
+      @dummy = Dummy.new
+    end
+
+    it "does not accept the credentials" do
+      expect { @dummy.avatar.azure_credentials }.to raise_error(ArgumentError)
+    end
+  end
+
+  context "An attachment with Azure storage and Azure credentials not supplied" do
+    before do
+      rebuild_model storage: :azure, container: "testing"
+      @dummy = Dummy.new
+    end
+
+    it "does not parse any credentials" do
+      expect(@dummy.avatar.azure_credentials).to eq({})
+    end
+  end
+
+  describe "with Azure credentials supplied as Pathname" do
+    before do
+      ENV['AZURE_CONTAINER'] = 'pathname_container'
+      ENV['AZURE_STORAGE_ACCOUNT'] = 'pathname_storage_account'
+      ENV['AZURE_STORAGE_ACCESS_KEY'] = storage_access_key
+
+      rails_env('test') do
+        rebuild_model storage: :azure,
+          azure_credentials: Pathname.new(fixture_file('azure.yml'))
+
+        Dummy.delete_all
+        @dummy = Dummy.new
+      end
+    end
+
+    it "parses the credentials" do
+      expect(@dummy.avatar.container_name).to eq('pathname_container')
+    end
+  end
+
+  describe "with Azure credentials in a YAML file" do
+    before do
+      ENV['AZURE_CONTAINER'] = 'pathname_container'
+      ENV['AZURE_STORAGE_ACCOUNT'] = 'pathname_storage_account'
+      ENV['AZURE_STORAGE_ACCESS_KEY'] = storage_access_key
+
+      rails_env('test') do
+        rebuild_model storage: :azure,
+          azure_credentials: File.new(fixture_file('azure.yml'))
+
+        Dummy.delete_all
+
+        @dummy = Dummy.new
+      end
+    end
+
+    it "runs the file through ERB" do
+      expect(@dummy.avatar.container_name).to eq('pathname_container')
+    end
+  end
+
+  describe "path is a proc" do
+    before do
+      rebuild_model storage: :azure,
+                    path: ->(attachment) { attachment.instance.attachment_path }
+
+      @dummy = Dummy.new
+      @dummy.class_eval do
+        def attachment_path
+          '/some/dynamic/path'
+        end
+      end
+      @dummy.avatar = stringy_file
+    end
+
+    it "returns a correct path" do
+      expect(@dummy.avatar.path).to eq('/some/dynamic/path')
+    end
+  end
+
+  private
+
+  def rails_env(env)
+    stored_env, Rails.env = Rails.env, env
+    begin
+      yield
+    ensure
+      Rails.env = stored_env
+    end
+  end
+end