papercall 0.14.0 → 0.15.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d45807b08724dd63c5bb8dae2fd98930e55d9e24
-  data.tar.gz: 92dcc33bee8e958c271bc98a279baf8421b0c2fe
+  metadata.gz: ab9ff289a7b73ca13abe407dbf7faf36ad50e5f5
+  data.tar.gz: eca379283228ab7e574ad8ce594e7b73db34bd37
 SHA512:
-  metadata.gz: 47419fa06b5dc107315a84b65c78f310eb31702f68375faa98703c1ca7ba3aa05bb1cf16f2f6ea9e47f4c90f4408c1115326b197b43b3217c987a9b443480c44
-  data.tar.gz: 17eb8b781906f9a23e90de7e1613d38f96cd546ec4aec8e89e410af2635f43e260e824f8fc2754f71d7414cfafe7a23814039f76b677b8d14e4a43cde3bcda65
+  metadata.gz: d10215d20228deb40b8102efa206a9af260767cfe87899729ce134f1f1213c4c58b43f3e1e6c3bf21a4eba222bcf8da52ba022ef46bee82a96603c4d43ef8876
+  data.tar.gz: 478adce38dd114a1ce2e3a8606bfc7acf382577d98254bbbb89e0ea35fe25b5c90ba3d1f4b7bb55b6c2e05d1cb9f04945796a1d6f13b40de58901f74c77f60ee

data/.gitignore

@@ -10,3 +10,4 @@
 /*.json
 /*.rb
 /*.gem
+/*.idea

data/lib/papercall/analysis.rb

@@ -19,26 +19,26 @@ module Papercall
 
     def analyze
       startTime = Time.now
-      print "Performing analysis..."
+      print 'Performing analysis...'
       @analysis['submissions'].each do |submission|
-        submission["ratings"].each do |rating|
-          unless(@analysis['reviewers'].include?(rating["user"]["name"]))
-            @analysis['reviewers'][rating["user"]["name"]] = [{:id => rating["submission_id"]}]
+        submission['ratings'].each do |rating|
+          if !(@analysis['reviewers'].include? rating['user']['name'])
+            @analysis['reviewers'][rating['user']['name']] = [{:id => rating['submission_id']}]
           else
-            @analysis['reviewers'][rating['user']['name']] << {:id => rating["submission_id"]}
+            @analysis['reviewers'][rating['user']['name']] << {:id => rating['submission_id']}
           end
         end
-        @analysis['talksWithoutReviews'] << {:id => submission["id"], :submission => submission} if submission["ratings"].empty?
-        @analysis['talksWithFourOrMoreReviews'] << {:id => submission["id"], :submission => submission} if submission["ratings"].size >= 4
-        @analysis['talksWithLessThanThreeReviews'] << {:id => submission["id"], :submission => submission} if submission["ratings"].size < 3
-        @analysis['talksWithoutFeedback'] << {:id => submission["id"], :submission => submission} if submission["feedback"].empty?
-        @analysis['highlyRated'] << {:id => submission["id"], :submission => submission} if highlyRated? submission
-        @analysis['lowRated'] << {:id => submission["id"], :submission => submission} if lowRated? submission
-        @analysis['maybe'] << {:id => submission["id"], :submission => submission} if maybe? submission
-        @analysis['accepted'] << {:id => submission["id"], :submission => submission} if accepted? submission
-        @analysis['waitlist'] << {:id => submission["id"], :submission => submission} if waitlisted? submission
-        @analysis['rejected'] << {:id => submission["id"], :submission => submission} if rejected? submission
-        @analysis['confirmed'] << {:id => submission["id"], :submission => submission} if confirmed? submission
+        @analysis['talksWithoutReviews'] << {:id => submission['id'], :submission => submission} if submission['ratings'].empty?
+        @analysis['talksWithFourOrMoreReviews'] << {:id => submission['id'], :submission => submission} if submission['ratings'].size >= 4
+        @analysis['talksWithLessThanThreeReviews'] << {:id => submission['id'], :submission => submission} if submission['ratings'].size < 3
+        @analysis['talksWithoutFeedback'] << {:id => submission['id'], :submission => submission} if submission['feedback'].empty?
+        @analysis['highlyRated'] << {:id => submission['id'], :submission => submission} if highlyRated? submission
+        @analysis['lowRated'] << {:id => submission['id'], :submission => submission} if lowRated? submission
+        @analysis['maybe'] << {:id => submission['id'], :submission => submission} if maybe? submission
+        @analysis['accepted'] << {:id => submission['id'], :submission => submission} if accepted? submission
+        @analysis['waitlist'] << {:id => submission['id'], :submission => submission} if waitlisted? submission
+        @analysis['rejected'] << {:id => submission['id'], :submission => submission} if rejected? submission
+        @analysis['confirmed'] << {:id => submission['id'], :submission => submission} if confirmed? submission
       end
       @analysis['summary'] = summary
       puts "finished in #{Time.now - startTime} seconds."
@@ -48,11 +48,11 @@ module Papercall
     private
 
     def highlyRated?(submission)
-      submission["rating"] >= 75 && review_complete?(submission)
+      submission['rating'] >= 75 && review_complete?(submission)
     end
 
     def lowRated?(submission)
-      submission["rating"] <= 25 && review_complete?(submission)
+      submission['rating'] <= 25 && review_complete?(submission)
     end
 
     def maybe?(submission)
@@ -60,23 +60,23 @@ module Papercall
     end
 
     def review_complete?(submission)
-      submission["ratings"].size >= 3
+      submission['ratings'].size >= 3
     end
 
     def accepted?(submission)
-      submission["state"] == "accepted"
+      submission['state'] == 'accepted'
     end
 
     def rejected?(submission)
-      submission["state"] == "rejected"
+      submission['state'] == 'rejected'
     end
 
     def waitlisted?(submission)
-      submission["state"] == "waitlist"
+      submission['state'] == 'waitlist'
     end
 
     def confirmed?(submission)
-      accepted?(submission) && submission["confirmed"] == true
+      accepted?(submission) && submission['confirmed'] == true
     end
 
     def summary

data/lib/papercall/rest_fetcher.rb

@@ -1,5 +1,6 @@
 require 'json'
 require 'rest-client'
+require 'parallel'
 
 module Papercall
   #Fetches submissions from Papercall REST API
@@ -25,43 +26,49 @@ module Papercall
         RestClient::Request.execute(method: :get,
                                     url: papercall_url,
                                     headers: @auth_hash) # :timeout => 120
-      JSON.parse raw_results
+      if raw_results
+        JSON.parse raw_results
+      else
+        []
+      end
     end
 
     def fetch(*states)
-      states = [[:submitted, :accepted, :rejected, :waitlist, :declined]] if states == [[:all]]
+      states = [%i[submitted accepted rejected waitlist declined]] if states == [[:all]]
       states.flatten.each do |state|
-        if state
-          startTime = Time.now
-          print "Fetching #{state} submissions from PaperCall API..."
-          instance_variable_set("@#{state}", papercall(submission_url(state.to_s)))
-          puts "finished in #{Time.now - startTime} seconds."
-        end
+        next unless state
+        start_time = Time.now
+        print "Fetching #{state} submissions from PaperCall API..."
+        instance_variable_set("@#{state}", papercall(submission_url(state.to_s)))
+        puts "finished in #{Time.now - start_time} seconds."
       end
       fetch_ratings
       fetch_feedback
     end
 
     def fetch_ratings
-      startTime = Time.now
+      start_time = Time.now
       print "Fetching ratings for all submissions from Papercall API..."
-      analysis.each do |submission|
+
+      Parallel.each(analysis, in_threads: 8) do |submission|
         unless submission['ratings']
           ratings_url = "#{SUBMISSIONS_URL}/#{submission['id']}/ratings"
           submission['ratings'] = papercall(ratings_url)
         end
+        submission['ratings'] = [] unless submission['ratings']
       end
-      puts "finished in #{Time.now - startTime} seconds."
+      puts "finished in #{Time.now - start_time} seconds."
     end
 
     def fetch_feedback
       startTime = Time.now
       print "Fetching feedback for all submissions from Papercall API..."
-      analysis.each do |submission|
+      Parallel.each(analysis, in_threads: 8) do |submission|
         unless submission['feedback']
           feedback_url = "#{SUBMISSIONS_URL}/#{submission['id']}/feedback"
           submission['feedback'] = papercall(feedback_url)
         end
+        submission['feedback'] = [] unless submission['feedback']
       end
       puts "finished in #{Time.now - startTime} seconds."
     end

data/lib/papercall/version.rb

@@ -1,3 +1,3 @@
 module Papercall
-  VERSION = '0.14.0'.freeze
+  VERSION = '0.15.0'.freeze
 end

data/papercall.gemspec

@@ -33,4 +33,5 @@ Gem::Specification.new do |spec|
   spec.add_dependency "rest-client", "~> 2.0", ">= 2.0.2"
   spec.add_dependency "activesupport", "~> 5.0"
   spec.add_dependency "i18n", "~> 0.9.1"
+  spec.add_dependency "parallel", "~> 1.12.1"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: papercall
 version: !ruby/object:Gem::Version
-  version: 0.14.0
+  version: 0.15.0
 platform: ruby
 authors:
 - Jørn Ølmheim
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2018-01-29 00:00:00.000000000 Z
+date: 2018-07-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -176,6 +176,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 0.9.1
+- !ruby/object:Gem::Dependency
+  name: parallel
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.12.1
 description: Small client library for the PaperCall API. With some analytics for the
   submissions.
 email:
@@ -225,7 +239,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.14
 signing_key: 
 specification_version: 4
 summary: Small client library for the PaperCall API