paperbin 0.0.2 → 0.0.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 57b99cdc2558a90d6f5bf066f1277e8f7cb04585
-  data.tar.gz: 8cacd606f0b71d8aa5f9ea02c01932d9231b028f
+  metadata.gz: 37c978c091cd658200ee80b49bfc08afae0d195c
+  data.tar.gz: 63a6141de7602abdb15b8fde994e586eb49e607b
 SHA512:
-  metadata.gz: 97b57662315dce3d78bfe4ec3d0d4c909b95eed5c172267298eaff605b84a3c6a27656b1f989811202dcfe175978fa34b3ad23ecda6c751de2811c982f958aa9
-  data.tar.gz: 4439227f06d3c90236761801db296629054bdd20dc22b6ae82add253e7567eafab6c67d769a683d5c0637c79087774bf1fc2b3011503c3483fe6a06cf6131d7c
+  metadata.gz: be0a71594e218ad8ce48179b87d13acea5312663cee3307db411cf63ecd0c874e7634a22c0c12982c08e208da51a5c29031603f12ee7de77fc4b131123a98d0b
+  data.tar.gz: 7f44494d1dc2f4e5594f268c425d8ffd4eb20f50081bebfa9720bb78968840412b3e44e3a61d840cec99d178aed709b9731dda6a31c7961fecec6bd631e10ad5

data/.gitignore

@@ -19,3 +19,4 @@ tmp
 .ruby-version
 .ruby-gemset
 .*.swp
+bin

data/lib/paperbin/handler.rb

@@ -93,23 +93,22 @@ class Paperbin::Handler < Struct.new(:id, :type)
 
   def check_versions
     versions.each_with_index do |version, index|
-      # check both file exist or not
-      next unless files_exist?(md5_file(version), gz_file(version))
-
-      if md5_valid?(version)
-        process_valid_records(version, versions.last)
-      else
-        # remove both files
-        [gz_file(version), md5_file(version)].each do |f|
-          File.delete(f)
+        # check both file exist or not
+        next unless files_exist?(md5_file(version), gz_file(version))
+
+        if md5_valid?(version)
+          process_valid_records(version, versions.last)
+        else
+          # remove both files
+          [gz_file(version), md5_file(version)].each do |f|
+            File.delete(f)
+          end
+          raise Errno::ENOENT
         end
-        raise Errno::ENOENT
-      end
     end
-
   rescue Errno::ENOENT
     # lodge worker unless valid
-    Paperbin::WriteWorker.perform_async(version.item_id, version.item_type)
+    Paperbin::WriteWorker.perform_async(id, type)
   end
 end
 

data/lib/paperbin/version.rb

@@ -1,3 +1,3 @@
 module Paperbin
-  VERSION = "0.0.2"
+  VERSION = "0.0.3"
 end

data/spec/paperbin_handler_spec.rb

@@ -3,28 +3,30 @@ require "spec_helper"
 describe Paperbin::Handler do
 
   let(:item) { double(organisation_id: "org1") }
+  let(:target_id) { '123456789' }
+  let(:target_type) { 'Client' }
 
-  subject { Paperbin::Handler.new("123456789", "client") }
+  let!(:handler) { Paperbin::Handler.new target_id, target_type }
   before(:each) do
     Paperbin::Config.default_options[:path] = '/path'
     Paperbin::Config.default_options[:base_scope] = 'organisation_id'
-    subject.stub(item: item)
+    handler.stub(item: item)
   end
 
   it "return correct formatted_id" do
-    subject.formatted_id.should == "000123456789"
+    handler.formatted_id.should == "000123456789"
   end
 
   it "split formatted_id into 3 sections" do
-    subject.split_id.should == ['0001', '2345', '6789']
+    handler.split_id.should == ['0001', '2345', '6789']
   end
 
-  it 'return options', focus: true do
-    subject.options.should == {path: '/path', base_scope: 'organisation_id'}
+  it 'return options' do
+    handler.options.should == {path: '/path', base_scope: 'organisation_id'}
   end
 
   it "return directory" do
-    subject.directory_path.should == "/path/org1/client/0001/2345/6789"
+    handler.directory_path.should == "/path/org1/Client/0001/2345/6789"
   end
 
   context 'directories' do
@@ -32,31 +34,76 @@ describe Paperbin::Handler do
     it 'generate directory when no exists' do
       Dir.stub(exists?: false)
       FileUtils.should_receive(:mkdir_p)
-      subject.create_directory
+      handler.create_directory
     end
 
     it 'dont generate directory when exists' do
       Dir.stub(exists?: true)
       FileUtils.should_not_receive(:mkdir_p)
-      subject.create_directory
+      handler.create_directory
     end
 
   end
 
   context 'generate_files' do
-
     let(:version_1) { double(id: 1, to_json: "json") }
     let(:version_2) { double(id: 2, to_json: "json") }
     let(:file) { double(write: true) }
 
     before do
-      subject.stub(versions: [version_1, version_2])
+      handler.stub(versions: [version_1, version_2])
       File.stub(open: file)
     end
 
     it 'create correct Gzip files' do
       Zlib::GzipWriter.should_receive(:open).twice
-      subject.generate_files
+      handler.generate_files
+    end
+
+  end
+
+  describe '#check_versions' do
+    let(:version1) { double(id: 1, to_json: "json", delete: true) }
+    let(:version2) { double(id: 2, to_json: "json", delete: true) }
+    let(:file) { double(write: true) }
+
+    before do
+      handler.stub versions: [version1, version2]
+      handler.stub files_exist?: true
+      File.stub rename: true, delete: true
+      Paperbin::WriteWorker.stub perform_async: true
+    end
+
+    subject(:check_versions) { handler.check_versions }
+
+    context 'when md5 is valid' do
+      before { handler.stub md5_valid?: true }
+
+      it 'deletes the versions, except for the last one' do
+        expect(version1).to receive(:delete).once
+        expect(version2).to receive(:delete).never
+        check_versions
+      end
+
+      it 'renames the file' do
+        expect(File).to receive(:rename).twice
+        check_versions
+      end
+    end
+
+    context 'when md5 is invalid' do
+      before { handler.stub md5_valid?: false }
+
+      it 'removes the files' do
+        expect(File).to receive(:delete).twice
+        check_versions
+      end
+
+      it 'lodges a write worker to re-write the files' do
+        expect(Paperbin::WriteWorker).to receive(:perform_async).once
+          .with(target_id, target_type)
+        check_versions
+      end
     end
 
   end

data/spec/spec_helper.rb

@@ -1,2 +1,10 @@
 require 'paperbin'
 
+RSpec.configure do |config|
+  config.mock_with :rspec
+
+  config.filter_run focus: true
+  config.treat_symbols_as_metadata_keys_with_true_values = true
+  config.run_all_when_everything_filtered = true
+  config.alias_example_to :fit, focus: true
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paperbin
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
 platform: ruby
 authors:
 - morhekil
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-01-17 00:00:00.000000000 Z
+date: 2014-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler