paper_trail_manager 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 2549171549b22c9328db417189798ea21871029c
-  data.tar.gz: 150cc4d55fbf5db0818687c333c6df8d463226af
+SHA256:
+  metadata.gz: fcc29d8525d99579c156724e3ae0632d363f633419b1fe2e3d8424be01a2cc8f
+  data.tar.gz: 4a18af9ec1ce747d7f1be7cb090172694ac1cd05ff7bfdfe8b4cfbf7a064f73b
 SHA512:
-  metadata.gz: fea549305c1d60b72b0ee0cb7638967f5618789b8ee4fe709c200706a118ed4e5d6a7a63dfb30228313008ac41e61cbbd083fd663f03610108b73b409c257775
-  data.tar.gz: 2b3e7b426fd66283adabdfee001ce2415eec56537fdbc8c249509fb3428c893f2b736db4a3ad5e10e1739c70094aba8e0678b9042026fa13f00cdb2dd863a5d8
+  metadata.gz: b8d7880ea9aee2269b2d99702559bc30323bc3ba932c850124c640e0508ed841f1eb9ed11c81c1af9a233903cfa83f9cc526c0e57e6648a1d3b163c2d48439a8
+  data.tar.gz: d4daf880c144649090bf0d29d373783890d9b332f41a39c032aa11efb4489432272e60b683904884facdbdc1f62d4ee67d7f8109549e262c5ad3625f7c668240

data/.github/workflows/test.yml

@@ -0,0 +1,88 @@
+name: Tests
+
+on:
+  pull_request:
+    types:
+       - opened
+       - reopened
+       - synchronize
+       - ready_for_review
+  push:
+    branches:
+      - 'master'
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+
+    strategy:
+      fail-fast: false
+      matrix:
+        ruby:
+          - 2.5.7
+          - 2.6.5
+        gemfile:
+          - gemfiles/rails_4.2.2_paper_trail_3.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_3.0_will_paginate.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_4.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_4.0_will_paginate.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_5.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_5.0_will_paginate.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_6.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_6.0_will_paginate.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_7.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_7.0_will_paginate.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_8.0_kaminari.gemfile
+          - gemfiles/rails_4.2.2_paper_trail_8.0_will_paginate.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_5.0_kaminari.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_5.0_will_paginate.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_6.0_kaminari.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_6.0_will_paginate.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_7.0_kaminari.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_7.0_will_paginate.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_8.0_kaminari.gemfile
+          - gemfiles/rails_5.0.0_paper_trail_8.0_will_paginate.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_10.0_kaminari.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_10.0_will_paginate.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_7.0_kaminari.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_7.0_will_paginate.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_8.0_kaminari.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_8.0_will_paginate.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_9.0_kaminari.gemfile
+          - gemfiles/rails_5.1.0_paper_trail_9.0_will_paginate.gemfile
+          - gemfiles/rails_5.2.0_paper_trail_10.0_kaminari.gemfile
+          - gemfiles/rails_5.2.0_paper_trail_10.0_will_paginate.gemfile
+          - gemfiles/rails_5.2.0_paper_trail_9.0_kaminari.gemfile
+          - gemfiles/rails_5.2.0_paper_trail_9.0_will_paginate.gemfile
+          - gemfiles/rails_6.0.0_paper_trail_10.0_kaminari.gemfile
+          - gemfiles/rails_6.0.0_paper_trail_10.0_will_paginate.gemfile
+
+    env:
+      BUNDLER_VERSION: 1.17.3
+      BUNDLE_GEMFILE: ${{ matrix.gemfile }}
+
+    steps:
+      - uses: actions/checkout@v2
+      - uses: actions/setup-ruby@v1
+        with:
+          ruby-version: ${{ matrix.ruby }}
+      - uses: actions/cache@v1
+        with:
+          path: vendor/bundle
+          key: ${{ runner.os }}-${{ matrix.ruby}}-gems-${{ hashFiles('**/paper_trail_manager.gemspec') }}
+          restore-keys: |
+            ${{ runner.os }}-${{ matrix.ruby }}-gems-
+      - name: Install System Dependencies
+        run: |
+          sudo apt-get update
+          sudo apt-get install sqlite3 libsqlite3-dev
+          gem install bundler -v $BUNDLER_VERSION
+      - name: bundle install
+        run: |
+          bundle config path vendor/bundle
+          bundle install --jobs 4 --retry 3
+      - name: Generate host app for testing
+        run: bundle exec rake generate_spec_app
+      - name: Run RSpec
+        run: |
+          bundle exec rake spec

data/.gitignore

@@ -13,3 +13,4 @@ Gemfile.lock
 *.a
 mkmf.log
 *.gemfile.lock
+spec/dummy

data/.rubocop.yml

@@ -0,0 +1,33 @@
+require:
+  - rubocop-performance
+  - rubocop-rails
+  - rubocop-rspec
+
+AllCops:
+  TargetRubyVersion: 2.5
+  Exclude:
+    - 'spec/dummy/**/*'
+
+Rails:
+  Enabled: true
+
+Style/HashEachMethods:
+  Enabled: true
+
+Style/HashTransformKeys:
+  Enabled: true
+
+Style/HashTransformValues:
+  Enabled: true
+
+Layout/LineLength:
+  Max: 120
+
+RSpec/NestedGroups:
+  Enabled: false
+
+RSpec/MultipleExpectations:
+  Enabled: false
+
+Metrics/BlockLength:
+  Enabled: false

data/Appraisals

@@ -1,39 +1,31 @@
-appraise "rails-3.2-will-paginate" do
-  gem "rails", "~> 3.2.21"
-  gem "will_paginate", "~> 3.0"
-end
-
-appraise "rails-4.0-will-paginate" do
-  gem "rails", "~> 4.0.13"
-  gem "will_paginate", "~> 3.0"
-end
-
-appraise "rails-4.1-will-paginate" do
-  gem "rails", "~> 4.1.11"
-  gem "will_paginate", "~> 3.0"
-end
+# frozen_string_literal: true
 
-appraise "rails-4.2-will-paginate" do
-  gem "rails", "~> 4.2.2"
-  gem "will_paginate", "~> 3.0"
-end
+{
+  '4.2.2' => %w[3.0 4.0 5.0 6.0 7.0 8.0],
+  '5.0.0' => %w[5.0 6.0 7.0 8.0],
+  '5.1.0' => %w[7.0 8.0 9.0 10.0],
+  '5.2.0' => %w[9.0 10.0],
+  '6.0.0' => %w[10.0]
+}.each do |rails_version, paper_trail_versions|
+  paper_trail_versions.each do |paper_trail_version|
+    appraise "rails-#{rails_version}-paper_trail-#{paper_trail_version}-will-paginate" do
+      gem 'rails', "~> #{rails_version}"
+      gem 'jquery-rails'
+      gem 'sqlite3', rails_version == '6.0.0' ? '~> 1.4' : '~> 1.3.6'
+      gem 'paper_trail', "~> #{paper_trail_version}"
+      gem 'will_paginate', '~> 3.0'
 
-appraise "rails-3.2-kaminari" do
-  gem "rails", "~> 3.2.21"
-  gem "kaminari", "~> 0.16"
-end
+      gem 'webpacker' if rails_version == '6.0.0'
+    end
 
-appraise "rails-4.0-kaminari" do
-  gem "rails", "~> 4.0.13"
-  gem "kaminari", "~> 0.16"
-end
-
-appraise "rails-4.1-kaminari" do
-  gem "rails", "~> 4.1.11"
-  gem "kaminari", "~> 0.16"
-end
+    appraise "rails-#{rails_version}-paper_trail-#{paper_trail_version}-kaminari" do
+      gem 'rails', "~> #{rails_version}"
+      gem 'jquery-rails'
+      gem 'sqlite3', rails_version == '6.0.0' ? '~> 1.4' : '~> 1.3.6'
+      gem 'paper_trail', "~> #{paper_trail_version}"
+      gem 'kaminari', '>= 0.16'
 
-appraise "rails-4.2-kaminari" do
-  gem "rails", "~> 4.2.2"
-  gem "kaminari", "~> 0.16"
+      gem 'webpacker' if rails_version == '6.0.0'
+    end
+  end
 end

data/CHANGES.md

@@ -1,10 +1,22 @@
 Changes to `paper_trail_manager`
 ================================
 
+* 0.7.0
+    * Add support for Rails 5 and 6
+    * Add support for paper_trail 5.x – 10.x
+    * Drop support for Rails < 4.1
+    * Drop support for Ruby < 2.5
+
+* 0.6.0
+    * Add support for linking changes to user records via `PaperTrailManager.whodunnit_name_method` and `PaperTrailManager.user_path_method`
+    * Add new `PaperTrailManager.item_name_method` configuration option
+    * Add support for paper_trail 4.x
+    * Refactoring, code simplification, and performance improvements
+
 * 0.5.0
-    * Added support for pagination with [Kaminari](https://github.com/amatsuda/kaminari) in addition to [will_paginate](https://github.com/mislav/will_paginate).
+    * Add support for pagination with [Kaminari](https://github.com/amatsuda/kaminari) in addition to [will_paginate](https://github.com/mislav/will_paginate).
     * **[!]** Removed direct dependency on will_paginate. You must now include either `will_paginate` or `kaminari` in your Gemfile.
-    * Fixed a bug with route generation when paper_trail_manager is used within another Rails engine.
+    * Fix a bug with route generation when paper_trail_manager is used within another Rails engine.
 
 * 0.4.0
     * Allow configuration of ChangesController's parent class, route helpers, and layout

data/Gemfile

@@ -1,5 +1,6 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in paper_trail_manager.gemspec
 gemspec
-

data/README.md

@@ -35,7 +35,7 @@ Restart the server and go to the `/changes` URI to browse, subscribe, view and r
 ### Configuration
 
 Several aspects of PaperTrailManager may be optionally configured
-by creating an initializer in your application 
+by creating an initializer in your application
 (e.g. `config/initializers/paper_trail_manager.rb`).
 
 To specify when reverts are allowed:
@@ -49,6 +49,15 @@ To specify how to look up users/memebers/etc specified in Paper Trail's 'whodunn
     PaperTrailManager.whodunnit_class = User
     PaperTrailManager.whodunnit_name_method = :nicename   # defaults to :name
 
+To specify a method to call to identify an item on an index page:
+
+    PaperTrailManager.item_name_method = :nicename
+
+And for linking (or not) to the user with a custom path helper:
+
+    PaperTrailManager.user_path_method = :admin_path # defaults to :user_path
+    PaperTrailManager.user_path_method = nil # no "show user" page in app
+
 When including PaperTrailManager within another Rails engine, you may need to
 override PaperTrailManager::ChangesController's parent class to reference the
 engine's ApplicationController configure it to use your engine's url helpers:

data/Rakefile

@@ -1,18 +1,23 @@
-# encoding: UTF-8
+# frozen_string_literal: true
 
 require 'rubygems'
 
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
 Bundler::GemHelper.install_tasks
-APP_RAKEFILE = File.expand_path("../spec/dummy/Rakefile", __FILE__)
-load 'rails/tasks/engine.rake'
+
+app_rakefile_path = File.expand_path('spec/dummy/Rakefile', __dir__)
+
+if File.exist?(app_rakefile_path)
+  APP_RAKEFILE = app_rakefile_path
+  load 'rails/tasks/engine.rake'
+end
 
 require 'rake'
 require 'rdoc/task'
 
 require 'rspec/core/rake_task'
 RSpec::Core::RakeTask.new
-task :default => ["db:create", "db:migrate", "spec"]
+task default: ['db:create', 'db:migrate', 'spec']
 
 Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_dir = 'rdoc'
@@ -22,3 +27,10 @@ Rake::RDocTask.new(:rdoc) do |rdoc|
   rdoc.rdoc_files.include('lib/**/*.rb')
 end
 
+task :generate_spec_app do
+  sh 'rm -rf spec/dummy'
+  sh 'rails new spec/dummy --skip-bootsnap --skip-bundle --skip-yarn \
+    --skip-git --skip-action-mailer --skip-puma --skip-test --skip-coffee \
+    --skip-spring --skip-listen --skip-turbolinks \
+    --template=spec/app_template.rb'
+end

data/app/controllers/paper_trail_manager/changes_controller.rb

@@ -1,128 +1,131 @@
+# frozen_string_literal: true
+
 # Allow the parent class of ChangesController to be configured in the host app
 PaperTrailManager::ChangesController = Class.new(PaperTrailManager.base_controller.constantize)
 
-class PaperTrailManager::ChangesController
-  # Default number of changes to list on a pagenated index page.
-  PER_PAGE = 50
+class PaperTrailManager
+  class ChangesController
+    # Default number of changes to list on a pagenated index page.
+    PER_PAGE = 50
 
-  helper PaperTrailManager.route_helpers if PaperTrailManager.route_helpers
-  helper PaperTrailManager::ChangesHelper
-  layout PaperTrailManager.layout if PaperTrailManager.layout
+    helper PaperTrailManager.route_helpers if PaperTrailManager.route_helpers
+    helper PaperTrailManager::ChangesHelper
+    layout PaperTrailManager.layout if PaperTrailManager.layout
 
-  # List changes
-  def index
-    unless change_index_allowed?
-      flash[:error] = "You do not have permission to list changes."
-      return(redirect_to root_url)
-    end
+    # List changes
+    def index
+      unless change_index_allowed?
+        flash[:error] = 'You do not have permission to list changes.'
+        return(redirect_to root_url)
+      end
 
-    @versions = PaperTrail::Version.order('created_at DESC, id DESC')
-    if params[:type]
-      @versions = @versions.where(:item_type => params[:type])
-    end
-    if params[:id]
-      @versions = @versions.where(:item_id => params[:id])
-    end
+      @versions = PaperTrail::Version.order('created_at DESC, id DESC')
+      @versions = @versions.where(item_type: params[:type]) if params[:type]
+      @versions = @versions.where(item_id: params[:id]) if params[:id]
 
-    # Ensure pagination parameters have sensible values
-    @page = (v = params[:page].to_i; v == 0 ? nil : v)
-    @per_page = (v = params[:per_page].to_i; v == 0 ? PER_PAGE : v)
+      # Ensure pagination parameters have sensible values
+      @page = params[:page].to_i
+      @page = nil if @page.zero?
 
-    if defined?(WillPaginate)
-      @versions = @versions.paginate(:page => @page, :per_page => @per_page)
-    else
-      @versions = @versions.page(@page).per(@per_page)
-    end
+      @per_page = params[:per_page].to_i
+      @per_page = nil if @per_page.zero?
 
-    respond_to do |format|
-      format.html # index.html.erb
-      format.atom # index.atom.builder
-      format.json { render :json => @versions }
-    end
-  end
+      @versions = if defined?(WillPaginate)
+                    @versions.paginate(page: @page, per_page: @per_page)
+                  else
+                    @versions.page(@page).per(@per_page)
+                  end
 
-  # Show a change
-  def show
-    begin
-      @version = PaperTrail::Version.find(params[:id])
-    rescue ActiveRecord::RecordNotFound
-      flash[:error] = "No such version."
-      return(redirect_to :action => :index)
+      respond_to do |format|
+        format.html # index.html.erb
+        format.atom # index.atom.builder
+        format.json { render json: @versions }
+      end
     end
 
-    unless change_show_allowed?(@version)
-      flash[:error] = "You do not have permission to show that change."
-      return(redirect_to :action => :index)
-    end
+    # Show a change
+    def show
+      begin
+        @version = PaperTrail::Version.find(params[:id])
+      rescue ActiveRecord::RecordNotFound
+        flash[:error] = 'No such version.'
+        return(redirect_to action: :index)
+      end
 
-    respond_to do |format|
-      format.html # show.html.erb
-      format.json { render :json => @version }
-    end
-  end
+      unless change_show_allowed?(@version)
+        flash[:error] = 'You do not have permission to show that change.'
+        return(redirect_to action: :index)
+      end
 
-  # Rollback a change
-  def update
-    begin
-      @version = PaperTrail::Version.find(params[:id])
-    rescue ActiveRecord::RecordNotFound
-      flash[:error] = "No such version."
-      return(redirect_to(changes_path))
+      respond_to do |format|
+        format.html # show.html.erb
+        format.json { render json: @version }
+      end
     end
 
-    unless change_revert_allowed?(@version)
-      flash[:error] = "You do not have permission to revert this change."
-      return(redirect_to changes_path)
-    end
+    # Rollback a change
+    def update
+      begin
+        @version = PaperTrail::Version.find(params[:id])
+      rescue ActiveRecord::RecordNotFound
+        flash[:error] = 'No such version.'
+        return(redirect_to(changes_path))
+      end
 
-    if @version.event == "create"
-      @record = @version.item_type.constantize.find(@version.item_id)
-      @result = @record.destroy
-    else
-      @record = @version.reify
-      @result = @record.save
-    end
+      unless change_revert_allowed?(@version)
+        flash[:error] = 'You do not have permission to revert this change.'
+        return(redirect_to changes_path)
+      end
 
-    if @result
-      if @version.event == "create"
-        flash[:notice] = "Rolled back newly-created record by destroying it."
-        redirect_to changes_path
+      if @version.event == 'create'
+        @record = @version.item_type.constantize.find(@version.item_id)
+        @result = @record.destroy
       else
-        flash[:notice] = "Rolled back changes to this record."
-        redirect_to change_item_url(@version)
+        @record = @version.reify
+        @result = @record.save
+      end
+
+      if @result
+        if @version.event == 'create'
+          flash[:notice] = 'Rolled back newly-created record by destroying it.'
+          redirect_to changes_path
+        else
+          flash[:notice] = 'Rolled back changes to this record.'
+          redirect_to change_item_url(@version)
+        end
+      else
+        flash[:error] = "Couldn't rollback. Sorry."
+        redirect_to changes_path
       end
-    else
-      flash[:error] = "Couldn't rollback. Sorry."
-      redirect_to changes_path
     end
-  end
 
-protected
+    protected
 
-  # Return the URL for the item represented by the +version+, e.g. a Company record instance referenced by a version.
-  def change_item_url(version)
-    version_type = version.item_type.underscore.split('/').last
-    return send("#{version_type}_url", version.item_id)
-  rescue NoMethodError
-    return nil
-  end
-  helper_method :change_item_url
+    # Return the URL for the item represented by the +version+, e.g. a Company record instance referenced by a version.
+    def change_item_url(version)
+      version_type = version.item_type.underscore.split('/').last
+      send("#{version_type}_url", version.item_id)
+    rescue NoMethodError
+      nil
+    end
+    helper_method :change_item_url
 
-  # Allow index?
-  def change_index_allowed?
-    return PaperTrailManager.allow_index?(self)
-  end
-  helper_method :change_index_allowed?
+    # Allow index?
+    def change_index_allowed?
+      PaperTrailManager.allow_index?(self)
+    end
+    helper_method :change_index_allowed?
 
-  # Allow show?
-  def change_show_allowed?(version)
-    return PaperTrailManager.allow_show?(self, version)
-  end
-  helper_method :change_show_allowed?
+    # Allow show?
+    def change_show_allowed?(version)
+      PaperTrailManager.allow_show?(self, version)
+    end
+    helper_method :change_show_allowed?
 
-  # Allow revert?
-  def change_revert_allowed?(version)
-    return PaperTrailManager.allow_revert?(self, version)
+    # Allow revert?
+    def change_revert_allowed?(version)
+      PaperTrailManager.allow_revert?(self, version)
+    end
+    helper_method :change_revert_allowed?
   end
-  helper_method :change_revert_allowed?
 end

data/app/helpers/paper_trail_manager/changes_helper.rb

@@ -1,11 +1,13 @@
+# frozen_string_literal: true
+
 class PaperTrailManager
   module ChangesHelper
     # Return HTML representing the +object+, which is either its text or a stylized "nil".
     def text_or_nil(object)
       if object.nil?
-        return content_tag("em", "nil")
+        content_tag('em', 'nil')
       else
-        return h(object)
+        h(object)
       end
     end
 
@@ -25,75 +27,56 @@ class PaperTrailManager
     #     ...
     #   }
     def changes_for(version)
-      changes = {}
-      current = version.next.try(:reify)
-      # FIXME #reify randomly throws "ArgumentError Exception: syntax error on line 13, col 30:" -- why?
-      previous = version.reify rescue nil
-      record = \
-        begin
-          version.item_type.constantize.find(version.item_id)
-        rescue ActiveRecord::RecordNotFound
-          previous || current
-        end
+      case version.event
+      when 'create', 'update'
+        return {} unless version.changeset
 
-      # Bail out if no changes are available
-      return changes unless record
+        version.changeset.inject({}) do |changes, (attr, (prev, curr))|
+          changes.store(attr, { previous: prev, current: curr }) && changes
+        end
+      when 'destroy'
+        record = version_reify(version)
+        return {} unless record
 
-      case version.event
-      when "create", "update"
-        current ||= record
-      when "destroy"
-        previous ||= record
+        record.attributes.reject { |_k, v| v.nil? }.inject({}) do |changes, (attr, value)|
+          changes.store(attr, { previous: value, current: nil }) && changes
+        end
       else
         raise ArgumentError, "Unknown event: #{version.event}"
       end
-
-      (current or previous).attribute_names.each do |name|
-        next if name == "updated_at"
-        next if name == "created_at"
-        current_value = current.read_attribute(name) if current
-        previous_value = previous.read_attribute(name) if previous
-        unless current_value == previous_value || (version.event == "create" && current_value.blank?)
-          changes[name] = {
-            :previous => previous_value,
-            :current => current_value,
-          }
-        end
-      end
-
-      return changes
     end
 
     # Returns string title for the versioned record.
     def change_title_for(version)
-      current = version.next.try(:reify)
-      previous = version.reify rescue nil
-      record = version.item_type.constantize.find(version.item_id) rescue nil
-
-      name = nil
-      [:name, :title, :to_s].each do |name_method|
-        [previous, current, record].each do |obj|
-          name = obj.send(name_method) if obj.respond_to?(name_method)
-          break if name
-        end
-        break if name
+      if PaperTrailManager.item_name_method
+        record = version_reify(version) || version.next.try(:reify) || version.item
+        name = record.send(PaperTrailManager.item_name_method)
+      else
+        name = "#{version.item_type} #{version.item_id}"
       end
 
-      return h(name)
+      h(name)
     end
 
-    # Returns sorted array of types of items that there are changes for.
     def change_item_types
-      return ActiveRecord::Base.connection.select_values('SELECT DISTINCT(item_type) FROM versions ORDER BY item_type')
+      ActiveRecord::Base.subclasses.select do |klass|
+        klass.include?(PaperTrail::Model::InstanceMethods)
+      end.map(&:to_s)
     end
 
     # Returns HTML link for the item stored in the version, e.g. a link to a Company record stored in the version.
     def change_item_link(version)
-      if url = change_item_url(version)
-        return link_to(change_title_for(version), url, :class => 'change_item')
+      if (url = change_item_url(version))
+        link_to(change_title_for(version), url, class: 'change_item')
       else
-        return content_tag(:span, change_title_for(version), :class => 'change_item')
+        content_tag(:span, change_title_for(version), class: 'change_item')
       end
     end
+
+    def version_reify(version)
+      version.reify
+    rescue ArgumentError
+      nil
+    end
   end
 end