paper_trail 5.2.1 → 5.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 094660b594e3a7fdd137f0b9a5e586146390223d
-  data.tar.gz: 9b0150f21b8ce6f20b2f9aefb558d03253e0e233
+  metadata.gz: 40131e454009216354dd82f76bfab5ecbc465efb
+  data.tar.gz: b1cbd97963f0ef014c90b2462eceaac5e6df2e77
 SHA512:
-  metadata.gz: f382487c3077476976b91107d3fa4014859d028e45c5ae6d2b7f0dd5d9003ac24d1619029992f2fa4b2ffa5683be19f0142fd1d1f027f1f97182829775e00e14
-  data.tar.gz: 7102dab0875334e462c7ff46b7836de36028fb4ea7e1fabcf55dfcd0ec8545c56fa941ef6833f530353bf32f6aa8d42b86ee9dc64bb731cedbb0f997431a6a43
+  metadata.gz: 42138b9e11f51e210cc11af893b77f1834727c4280dd522ef28465856f3af0072d7065c3a906ccdfcb28ee50d80eefa7535033a6c65a612287ea0d89cd7faf58
+  data.tar.gz: 8a54e81675b6954778ebd715f596886991a47aba63fb0cf3a549be9410947e181a4084b323c64d156c8587306f2c2d6aec557479f3466dada0c34feefc400177

data/CHANGELOG.md

@@ -19,6 +19,24 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/).
 
 ### Fixed
 
+## 5.2.2 (2016-09-08)
+
+### Breaking Changes
+
+- None
+
+### Deprecated
+
+- [#863](https://github.com/airblade/paper_trail/pull/863)
+  PaperTrail.timestamp_field= deprecated without replacement.
+  See [#861](https://github.com/airblade/paper_trail/pull/861) for discussion.
+
+### Added
+
+- None
+
+### Fixed
+
 ## 5.2.1 (2016-09-02)
 
 ### Breaking Changes
@@ -129,8 +147,8 @@ recommendations of [keepachangelog.com](http://keepachangelog.com/).
 - [#556](https://github.com/airblade/paper_trail/pull/556) /
   [#301](https://github.com/airblade/paper_trail/issues/301) -
   If you are tracking who is responsible for changes with `whodunnit`, be aware
-  that PaperTrail no longer adds the `set_paper_trail_whodunnit` before_filter
-  for you. Please add this before_filter to your ApplicationController to
+  that PaperTrail no longer adds the `set_paper_trail_whodunnit` before_action
+  for you. Please add this before_action to your ApplicationController to
   continue recording whodunnit. See the readme for an example.
 - [#683](https://github.com/airblade/paper_trail/pull/683) /
   [#682](https://github.com/airblade/paper_trail/issues/682) -

data/README.md

@@ -11,7 +11,7 @@ has been destroyed.
 | Version        | Documentation |
 | -------------- | ------------- |
 | Unreleased     | https://github.com/airblade/paper_trail/blob/master/README.md |
-| 5.2.1          | https://github.com/airblade/paper_trail/blob/v5.2.1/README.md |
+| 5.2.2          | https://github.com/airblade/paper_trail/blob/v5.2.2/README.md |
 | 4.2.0          | https://github.com/airblade/paper_trail/blob/v4.2.0/README.md |
 | 3.0.9          | https://github.com/airblade/paper_trail/blob/v3.0.9/README.md |
 | 2.7.2          | https://github.com/airblade/paper_trail/blob/v2.7.2/README.md |
@@ -57,7 +57,8 @@ has been destroyed.
 
 | paper_trail    | branch     | tags   | ruby     | activerecord |
 | -------------- | ---------- | ------ | -------- | ------------ |
-| 5              | master     | v5.x   | >= 1.9.3 | >= 3.0, < 6  |
+| 6 (unreleased) | master     |        | >= 1.9.3 | >= 3.0, < 6  |
+| 5              | 5-stable   | v5.x   | >= 1.9.3 | >= 3.0, < 6  |
 | 4              | 4-stable   | v4.x   | >= 1.8.7 | >= 3.0, < 6  |
 | 3              | 3.0-stable | v3.x   | >= 1.8.7 | >= 3.0, < 5  |
 | 2              | 2.7-stable | v2.x   | >= 1.8.7 | >= 3.0, < 4  |
@@ -94,7 +95,7 @@ by adding a controller callback.
 
     ```ruby
     class ApplicationController
-      before_filter :set_paper_trail_whodunnit
+      before_action :set_paper_trail_whodunnit
     end
     ```
 
@@ -691,12 +692,12 @@ widget.versions.last.whodunnit              # Andy Stewart
 ```
 
 If your controller has a `current_user` method, PaperTrail provides a
-`before_filter` that will assign `current_user.id` to `PaperTrail.whodunnit`.
-You can add this `before_filter` to your `ApplicationController`.
+`before_action` that will assign `current_user.id` to `PaperTrail.whodunnit`.
+You can add this `before_action` to your `ApplicationController`.
 
 ```ruby
 class ApplicationController
-  before_filter :set_paper_trail_whodunnit
+  before_action :set_paper_trail_whodunnit
 end
 ```
 

data/doc/warning_about_not_setting_whodunnit.md

@@ -3,12 +3,12 @@
 After upgrading to PaperTrail 5, you see this warning:
 
 > user_for_paper_trail is present, but whodunnit has not been set. PaperTrail no
-> longer adds the set_paper_trail_whodunnit before_filter for you. Please add this
-> before_filter to your ApplicationController to continue recording whodunnit.
+> longer adds the set_paper_trail_whodunnit before_action for you. Please add this
+> before_action to your ApplicationController to continue recording whodunnit.
 
 ## You want to track whodunnit
 
-Add the set_paper_trail_whodunnit before_filter to your ApplicationController.
+Add the set_paper_trail_whodunnit before_action to your ApplicationController.
 See the PaperTrail readme for an example (https://git.io/vrsbt).
 
 ## You don't want to track whodunnit

data/lib/paper_trail.rb

@@ -72,12 +72,19 @@ module PaperTrail
 
     # Set the field which records when a version was created.
     # @api public
+    # @deprecated
     def timestamp_field=(field_name)
+      ::ActiveSupport::Deprecation.warn(
+        "PaperTrail.timestamp_field= is deprecated without replacement." \
+          "See https://github.com/airblade/paper_trail/pull/861 for discussion",
+        caller(1)
+      )
       PaperTrail.config.timestamp_field = field_name
     end
 
     # Returns the field which records when a version was created.
     # @api public
+    # @deprecated
     def timestamp_field
       PaperTrail.config.timestamp_field
     end

data/lib/paper_trail/config.rb

@@ -6,7 +6,8 @@ module PaperTrail
   # configuration can be found in `paper_trail.rb`, others in `controller.rb`.
   class Config
     include Singleton
-    attr_accessor :timestamp_field, :serializer, :version_limit
+    attr_accessor :serializer, :version_limit
+    attr_reader :timestamp_field # deprecated
     attr_writer :track_associations
 
     def initialize
@@ -34,6 +35,18 @@ module PaperTrail
       )
     end
 
+    # Set the field which records when a version was created.
+    # @api public
+    # @deprecated
+    def timestamp_field=(field_name)
+      ::ActiveSupport::Deprecation.warn(
+        "PaperTrail.config.timestamp_field= is deprecated without replacement." \
+          "See https://github.com/airblade/paper_trail/pull/861 for discussion",
+        caller(1)
+      )
+      @timestamp_field = field_name
+    end
+
     # Previously, we checked `PaperTrail::VersionAssociation.table_exists?`
     # here, but that proved to be problematic in situations when the database
     # connection had not been established, or when the database does not exist

data/lib/paper_trail/version_number.rb

@@ -3,7 +3,7 @@ module PaperTrail
   module VERSION
     MAJOR = 5
     MINOR = 2
-    TINY = 1
+    TINY = 2
     PRE = nil
 
     STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".").freeze

data/paper_trail.gemspec

@@ -21,7 +21,6 @@ Gem::Specification.new do |s|
   s.required_ruby_version = ">= 1.9.3"
 
   s.add_dependency "activerecord", [">= 3.0", "< 6.0"]
-  s.add_dependency "activesupport", [">= 3.0", "< 6.0"]
   s.add_dependency "request_store", "~> 1.1"
 
   s.add_development_dependency "appraisal", "~> 2.1"

data/test/dummy/db/migrate/20110208155312_set_up_test_tables.rb

@@ -32,7 +32,6 @@ class SetUpTestTables < ActiveRecord::Migration
       t.time      :a_time
       t.date      :a_date
       t.boolean   :a_boolean
-      t.string    :sacrificial_column
       t.string    :type
       t.timestamps null: true
     end

data/test/dummy/db/schema.rb

@@ -250,12 +250,11 @@ ActiveRecord::Schema.define(version: 20110208155312) do
     t.text     "a_text"
     t.integer  "an_integer"
     t.float    "a_float"
-    t.decimal  "a_decimal",          precision: 6, scale: 4
+    t.decimal  "a_decimal",  precision: 6, scale: 4
     t.datetime "a_datetime"
     t.time     "a_time"
     t.date     "a_date"
     t.boolean  "a_boolean"
-    t.string   "sacrificial_column"
     t.string   "type"
     t.datetime "created_at"
     t.datetime "updated_at"

data/test/test_helper.rb

@@ -95,7 +95,6 @@ end
 def change_schema
   ActiveRecord::Migration.verbose = false
   ActiveRecord::Schema.define do
-    remove_column :widgets, :sacrificial_column
     add_column :versions, :custom_created_at, :datetime
   end
   ActiveRecord::Migration.verbose = true
@@ -121,7 +120,6 @@ end
 def restore_schema
   ActiveRecord::Migration.verbose = false
   ActiveRecord::Schema.define do
-    add_column :widgets, :sacrificial_column, :string
     remove_column :versions, :custom_created_at
   end
   ActiveRecord::Migration.verbose = true

data/test/unit/model_test.rb

@@ -520,7 +520,6 @@ class HasPaperTrailModelTest < ActiveSupport::TestCase
         change_schema
         Widget.connection.schema_cache.clear!
         Widget.reset_column_information
-        assert_raise(NoMethodError) { Widget.new.sacrificial_column }
         @last = @widget.versions.last
       end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: paper_trail
 version: !ruby/object:Gem::Version
-  version: 5.2.1
+  version: 5.2.2
 platform: ruby
 authors:
 - Andy Stewart
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-02 00:00:00.000000000 Z
+date: 2016-09-08 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -31,26 +31,6 @@ dependencies:
     - - "<"
       - !ruby/object:Gem::Version
         version: '6.0'
-- !ruby/object:Gem::Dependency
-  name: activesupport
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6.0'
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '3.0'
-    - - "<"
-      - !ruby/object:Gem::Version
-        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: request_store
   requirement: !ruby/object:Gem::Requirement