pansophy_authenticator 0.4.3 → 0.5.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: 29ebf23c67f25a00a89055ab68ba6915c1e0b856
-  data.tar.gz: 9aff436c473c8330f468b46628b0686509f7ca13
+SHA256:
+  metadata.gz: e14aa82153ef6d5364e11d2eca68c262b556150e045d91d69962c2851b1bbd93
+  data.tar.gz: 417371aabdbeeac10c8179e7afa97e7ac5e5e6e05cbc1bdd31b948f168ba9913
 SHA512:
-  metadata.gz: 4c81c8b7374057a998df770760335dd7f1ae43abbda73aa797160611d385169b63ddba2ca72518acbc50f24aa314b46f74d1d6b869e071bf9eb853338b85d035
-  data.tar.gz: d1945149f67d4f5d1525fe96b614266535c582ce5d014696b6dfe8e6ad90cdfdf85a46aadd70c240526baa55dcd66c02ef77cf5a4e8e22ee8bfdce934052cefb
+  metadata.gz: 736f3d3606bd878cfcccc5679eb5d78ae419bad4ba77519551fa7e2405ab62e01bc64d4aa50bda55bd87e2a2106f944949027e95df00f7d29ab5920782bedb21
+  data.tar.gz: aec2fef36ba7dc3789253715f812860192ff21470d14734bf3890e5a7616f6452f37bb05f1f5b9df4ee883246d8202b0b7db2c0c7a767975d76c79d842dcffc3

data/.ruby-version

@@ -1 +1 @@
-2.3.0
+2.6.3

data/.travis.yml

@@ -1,11 +1,10 @@
 language: ruby
 rvm:
-  - 2.1
-  - 2.2
-  - 2.3.0 # The version of RVM installed on Travis doesn't yet recognise 2.3 as an alias of 2.3.0
-before_install: gem install bundler -v 1.11.2
+  - 2.4
+  - 2.5
+  - 2.6
+before_install:
+  - gem install bundler
 notifications:
   email:
     - support@travellink.com.au
-  flowdock:
-    secure: rn+Y1aDKALwrEUu9JkZCM+DWGMh1X3TKypx05Gh6PPut+DE+DocV1rmRZYgfU/Db0+UtCW27FpdbLETzBa/Z5r58aH0VMdWXpyYbYGXJi8Ff/nWogj0iswrmGoE8a+VEnwt2Z1Gz9LwwP/k7oxA2d+rqalGHNpTZbFf2SOIqq+S8A0ULvg+jTcG1S+mf6iCbAJLbRlRW+CC/dn5YPx9gGt/u9f/dnjGgYmkVuIzS0NvdzmB+lJfMTB4mt5Hbca9QEQSniBQFpI5neWqIBgCgqI9NvbV7s62sztjxnt2+VyjuiJG5IdClwQXIMTlvsgVGifAv99qXBH/Y7mpLUVzJr5uArLpasGe1wJI7xWBDsegYKiIZEYQGNUjFzQaBWwdS/roUWpt+I/FcCHCKYQZvx1OyzmndLN82mMzH7218N5CpCImroVWXZ6MjeOw/45RZPMAaShpdnw5NDHSNPpGF5e+MxqR7okIEoomIDsuGxDgqkCzjAbZETdWTsO8tKu3ZJnAxK9Lu5/iSsQvMLv4mUlL6EYGdjIxLwYtVzbFVVaf8AMdVsr+PMkzbHaqFcoxrE+VC/dFHVVd0szHX8DYs/Nvy5MiEVMVJxRIaUZgzim47I3r7nHKpA9fGh7ipM/pqMBTEnWC64sqQYZTWbFYQ18OyaRtqtdN3Ou3xDY+obPY=

data/CHANGELOG.md

@@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file.
 This project adheres to [Semantic Versioning](http://semver.org/).
 This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).
 
+## [0.5.0]
+### Changed
+- Simplifies verifying validity of configuration
+- Use coverage kit to enforce maximum coverage
+- [TT-5810] Relax runtime dependencies
+
 ## [0.4.3] - 2016-04-07
 ### Fixed
 - Loading of remote YAML application keys file now parses correctly
@@ -20,7 +26,7 @@ This changelog adheres to [Keep a CHANGELOG](http://keepachangelog.com/).
 ## [0.4.0] - 2016-02-16
 ### Added
 - Implements 'application' and 'local?' helper methods
-  
+
 ### Fixed
 - Tests could be influenced by system environment variables
 

data/lib/pansophy_authenticator.rb

@@ -11,6 +11,11 @@ module PansophyAuthenticator
     @configuration ||= configure
   end
 
+  def self.valid_configuration
+    fail Error, configuration.errors unless configuration.valid?
+    configuration
+  end
+
   def self.remote?
     configuration.remote?
   end

data/lib/pansophy_authenticator/configuration.rb

@@ -6,5 +6,7 @@ end
 require 'pansophy_authenticator/configuration/configurator'
 require 'pansophy_authenticator/configuration/from_file'
 require 'pansophy_authenticator/configuration/from_env'
-require 'pansophy_authenticator/configuration/instance'
-require 'pansophy_authenticator/configuration/verification'
+require 'pansophy_authenticator/configuration/base'
+require 'pansophy_authenticator/configuration/result'
+require 'pansophy_authenticator/configuration/local'
+require 'pansophy_authenticator/configuration/remote'

data/lib/pansophy_authenticator/configuration/{instance.rb → base.rb}

@@ -3,30 +3,29 @@ require 'memoizable'
 
 module PansophyAuthenticator
   module Configuration
-    class Instance
-      include Anima.new :local, :bucket_name, :file_path, :application, :cache_store
+    class Base
+      include Anima.new :bucket_name, :file_path, :application, :cache_store
       include Memoizable
 
       def local?
-        @local
+        false
       end
 
       def remote?
         !local?
       end
 
-      def valid?
-        verification.valid?
-      end
-
       def errors
-        verification.errors
+        return ['Application is not defined'] if @application.nil?
+        []
       end
 
-      private
+      def valid?
+        verification.valid?
+      end
 
       def verification
-        Verification::Verify.new(self).call
+        Result.new errors
       end
       memoize :verification
     end

data/lib/pansophy_authenticator/configuration/configurator.rb

@@ -15,31 +15,35 @@ module PansophyAuthenticator
       private
 
       def build_configuration
-        Instance.new(
-          local:       config_values.local,
+        attrs = {
           bucket_name: config_values.bucket_name,
           file_path:   config_values.file_path,
           application: config_values.application,
           cache_store: cache_store
-        )
+        }
+        if config_values.local
+          Local.new(attrs)
+        else
+          Remote.new(attrs)
+        end
       end
 
       def config_values
-        @config_values ||= from_env
+        @config_values ||= from_env_or_base
+      end
+
+      def from_env_or_base
+        FromEnv.new(base_config)
       end
 
       def base_config
         return self if @configuration_path.nil?
-        from_file
+        from_file_or_base
       end
 
-      def from_file
+      def from_file_or_base
         FromFile.new(self)
       end
-
-      def from_env
-        FromEnv.new(base_config)
-      end
     end
   end
 end

data/lib/pansophy_authenticator/configuration/local.rb

@@ -0,0 +1,26 @@
+module PansophyAuthenticator
+  module Configuration
+    class Local < Base
+      def errors
+        errors = super
+        return errors + ['File path is not defined'] unless file_path?
+        return errors + ["#{@file_path} does not exist"] unless file_exist?
+        errors
+      end
+
+      def local?
+        true
+      end
+
+      private
+
+      def file_path?
+        !@file_path.nil?
+      end
+
+      def file_exist?
+        File.exist? @file_path
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/remote.rb

@@ -0,0 +1,12 @@
+module PansophyAuthenticator
+  module Configuration
+    class Remote < Base
+      def errors
+        errors = super
+        return errors + ['Bucket name is not defined'] if @bucket_name.nil?
+        return errors + ['File path is not defined'] if @file_path.nil?
+        errors
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/configuration/result.rb

@@ -0,0 +1,17 @@
+module PansophyAuthenticator
+  module Configuration
+    class Result
+      include Adamantium
+
+      attr_reader :errors
+
+      def initialize(errors = [])
+        @errors = Array(errors)
+      end
+
+      def valid?
+        @errors.empty?
+      end
+    end
+  end
+end

data/lib/pansophy_authenticator/local/build_loader.rb

@@ -26,7 +26,7 @@ module PansophyAuthenticator
       end
 
       def configuration
-        PansophyAuthenticator.configuration
+        PansophyAuthenticator.valid_configuration
       end
     end
   end

data/lib/pansophy_authenticator/remote/fetcher.rb

@@ -29,7 +29,7 @@ module PansophyAuthenticator
       end
 
       def configuration
-        PansophyAuthenticator.configuration
+        PansophyAuthenticator.valid_configuration
       end
 
       def fail_for_invalid_format!

data/lib/pansophy_authenticator/version.rb

@@ -1,4 +1,5 @@
 # frozen_string_literal: true
+
 module PansophyAuthenticator
-  VERSION = '0.4.3'.freeze
+  VERSION = '0.5.0'
 end

data/pansophy_authenticator.gemspec

@@ -24,21 +24,21 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.1'
+  spec.required_ruby_version = '>= 2.4'
 
-  spec.add_dependency 'memoizable', '~> 0.4'
-  spec.add_dependency 'anima', '~> 0.3'
-  spec.add_dependency 'adamantium', '~> 0.2'
-  spec.add_dependency 'pansophy', '~> 0.5', '>= 0.5.2'
-  spec.add_dependency 'yamload', '~> 0.2'
+  spec.add_dependency 'memoizable'
+  spec.add_dependency 'anima'
+  spec.add_dependency 'adamantium'
+  spec.add_dependency 'pansophy'
+  spec.add_dependency 'yamload'
 
-  spec.add_development_dependency 'bundler', '~> 1.11'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.4'
-  spec.add_development_dependency 'timecop', '~> 0.8'
-  spec.add_development_dependency 'simplecov', '~> 0.11'
-  spec.add_development_dependency 'simplecov-rcov', '~> 0.2'
-  spec.add_development_dependency 'coveralls', '~> 0.8'
-  spec.add_development_dependency 'rubocop', '~> 0.39'
-  spec.add_development_dependency 'travis', '~> 1.8'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake'
+  spec.add_development_dependency 'rspec'
+  spec.add_development_dependency 'timecop'
+  spec.add_development_dependency 'coverage-kit'
+  spec.add_development_dependency 'simplecov-rcov'
+  spec.add_development_dependency 'coveralls'
+  spec.add_development_dependency "rubocop", ">= 0.49.0" # CVE-2017-8418
+  spec.add_development_dependency 'travis'
 end

metadata

@@ -1,217 +1,211 @@
 --- !ruby/object:Gem::Specification
 name: pansophy_authenticator
 version: !ruby/object:Gem::Version
-  version: 0.4.3
+  version: 0.5.0
 platform: ruby
 authors:
 - Alessandro Berardi
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2016-04-07 00:00:00.000000000 Z
+date: 2019-08-06 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: memoizable
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.4'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: anima
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.3'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: adamantium
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: pansophy
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '0.5'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 0.5.2
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: yamload
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.11'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.4'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: timecop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: coverage-kit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.11'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: simplecov-rcov
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.2'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: coveralls
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.8'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.39'
+        version: 0.49.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '0.39'
+        version: 0.49.0
 - !ruby/object:Gem::Dependency
   name: travis
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.8'
+        version: '0'
 description: By configuring a set of applications authentication keys in a filestored
   in an S3 bucket, applications can authenticate with each otherby submitting their
   authentication key, which the receiver can matchagainst the key stored in S3.S3
@@ -240,16 +234,13 @@ files:
 - lib/pansophy_authenticator/cache.rb
 - lib/pansophy_authenticator/cache_stores/memory.rb
 - lib/pansophy_authenticator/configuration.rb
+- lib/pansophy_authenticator/configuration/base.rb
 - lib/pansophy_authenticator/configuration/configurator.rb
 - lib/pansophy_authenticator/configuration/from_env.rb
 - lib/pansophy_authenticator/configuration/from_file.rb
-- lib/pansophy_authenticator/configuration/instance.rb
-- lib/pansophy_authenticator/configuration/verification.rb
-- lib/pansophy_authenticator/configuration/verification/common.rb
-- lib/pansophy_authenticator/configuration/verification/local.rb
-- lib/pansophy_authenticator/configuration/verification/remote.rb
-- lib/pansophy_authenticator/configuration/verification/result.rb
-- lib/pansophy_authenticator/configuration/verification/verify.rb
+- lib/pansophy_authenticator/configuration/local.rb
+- lib/pansophy_authenticator/configuration/remote.rb
+- lib/pansophy_authenticator/configuration/result.rb
 - lib/pansophy_authenticator/local.rb
 - lib/pansophy_authenticator/local/build_loader.rb
 - lib/pansophy_authenticator/local/fetcher.rb
@@ -270,15 +261,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.1'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Inter application authentication via central authority

data/lib/pansophy_authenticator/configuration/verification.rb

@@ -1,12 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-    end
-  end
-end
-
-require 'pansophy_authenticator/configuration/verification/result'
-require 'pansophy_authenticator/configuration/verification/common'
-require 'pansophy_authenticator/configuration/verification/local'
-require 'pansophy_authenticator/configuration/verification/remote'
-require 'pansophy_authenticator/configuration/verification/verify'

data/lib/pansophy_authenticator/configuration/verification/common.rb

@@ -1,16 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-      class Common
-        def initialize(configuration)
-          @configuration = configuration
-        end
-
-        def verify
-          return Result.new 'Application is not defined' if @configuration.application.nil?
-          Result.new
-        end
-      end
-    end
-  end
-end

data/lib/pansophy_authenticator/configuration/verification/local.rb

@@ -1,35 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-      class Local
-        def initialize(configuration)
-          @configuration = configuration
-        end
-
-        def verify
-          Result.new errors
-        end
-
-        private
-
-        def errors
-          return ['File path is not defined'] unless file_path?
-          return ["#{file_path} does not exist"] unless file_exist?
-          []
-        end
-
-        def file_path?
-          !file_path.nil?
-        end
-
-        def file_exist?
-          File.exist? file_path
-        end
-
-        def file_path
-          @configuration.file_path
-        end
-      end
-    end
-  end
-end

data/lib/pansophy_authenticator/configuration/verification/remote.rb

@@ -1,19 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-      class Remote
-        def initialize(configuration)
-          @configuration = configuration
-          @result = Result.new
-        end
-
-        def verify
-          errors = []
-          errors << 'Bucket name is not defined' if @configuration.bucket_name.nil?
-          errors << 'File path is not defined' if @configuration.file_path.nil?
-          Result.new errors
-        end
-      end
-    end
-  end
-end

data/lib/pansophy_authenticator/configuration/verification/result.rb

@@ -1,25 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-      class Result
-        include Adamantium
-
-        attr_reader :errors
-
-        def initialize(errors = [])
-          @errors = Array(errors)
-        end
-
-        def valid?
-          @errors.empty?
-        end
-
-        def +(other)
-          transform do
-            @errors += other.errors
-          end
-        end
-      end
-    end
-  end
-end

data/lib/pansophy_authenticator/configuration/verification/verify.rb

@@ -1,29 +0,0 @@
-module PansophyAuthenticator
-  module Configuration
-    module Verification
-      class Verify
-        def initialize(configuration)
-          @configuration = configuration
-        end
-
-        def call
-          verifiers.map { |verifier| verifier.new(@configuration).verify }.reduce(&:+)
-        end
-
-        private
-
-        def verifiers
-          [Common, specific_verifier]
-        end
-
-        def specific_verifier
-          if @configuration.local?
-            Local
-          else
-            Remote
-          end
-        end
-      end
-    end
-  end
-end